Review at https://gerrit.osmocom.org/3573
Print destination address on sendto error
Change-Id: I0f8ad8687acb7f6f0eeeb962f007e87cca0c4c27
---
M gtp/gtp.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/73/3573/1
diff --git a/gtp/
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Increase log verbosity for osmo-bts-trx
..
Increase log verbosity for osmo-bts-trx
The log levels changed are useful to understand clock failures we
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3572
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74af3ccb2f3db3c1793c7ff7b7a60a534e78e81
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3572
Increase log verbosity for osmo-bts-trx
The log levels changed are useful to understand clock failures we see
from time to time in osmo-gsm-tester. See OS-2325.
Change-Id: Id74af3ccb2f3db3c1793c7ff7b7a60a534e78e81
---
M src/osmo_gsm_tester/templates/os
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: bts_osmotrx: Allow LD_LIBRARY_PATH when loading osmo-trx
..
bts_osmotrx: Allow LD_LIBRARY_PATH when loading osmo-trx
When splitting osmo-trx to its o
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3571
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I069ba69f4207665c8c575fed0fc8ff164c571e36
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3571
bts_osmotrx: Allow LD_LIBRARY_PATH when loading osmo-trx
When splitting osmo-trx to its own class the env injection part was
removed because it seemed not needed as it has no dependencies included
by default in the trial.
However, it may still be requi
Patch Set 1:
@Pau: You're not the only one getting confused with it, snprintf() is a mess,
it's hard to deal with it, hence this macro that retains semantics that aims to
simplify things... if you find any better, let me know I'd be happy to reuse it
in my code moving forward :-).
@Holger: Ei
Patch Set 1:
(1 comment)
Hi sorry, it seems I wrote a comment a few days ago but I didn't "submit it".
https://gerrit.osmocom.org/#/c/3537/1/src/osmux.c
File src/osmux.c:
PS1, Line 849:
> I'm still trying to understand this update, not sure what corner case you'r
I first submited this patch
Patch Set 1:
> SOrry, I mean: If you want to retain snprintf semantics, ie. return
> the number of bytes that would have been written, then you need to
> keep 'len' and offset, because offset should not ever go over the
> boundary.
>
> But 'len' may indeed go over the boundary, since it ex
Patch Set 1:
> size is the original buffer size, number of bytes you can fit into
> the buffer you provide.
right. but isn't size + ret then very fishy? (in the nftable macro too). How
does the buffer grow? Shouldn't it be like a "constant"?
--
To view, visit https://gerrit.osmocom.org/3537
Patch Set 1:
SOrry, I mean: If you want to retain snprintf semantics, ie. return the number
of bytes that would have been written, then you need to keep 'len' and offset,
because offset should not ever go over the boundary.
But 'len' may indeed go over the boundary, since it expresses this "n
Patch Set 1:
size is the original buffer size, number of bytes you can fit into the buffer
you provide.
len is the number of byte that has been written into the buffer.
offset is where you should continue to append more bytes.
If you want to retain snprintf semantics, ie. return the number of
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/3570/1/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:
Line 132: #define MAX_A5_KEY_LEN(128/8)
I think it's better to put this next to actual a5 implementation in libosmocore.
Line 235:
Review at https://gerrit.osmocom.org/3570
Revert "factor out & introduce struct gsm_encr, in common_cs.h"
This reverts commit ac1f1436e9d380f632dd850fcd253d3480f0fc2d.
common_cs.h added to gsm_data_shared.h was a mistake, i.e. I added the
dependency by accident. Including common_cs.h in the d
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3558
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d80e7d260f9092f44d4d80471a4dd67b7acc839
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Patch Set 1:
Could you elaborate: what uses this and how?
--
To view, visit https://gerrit.osmocom.org/3559
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If25ce84593bbf6a393928a8f4e1670f320c48ca4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-
17 matches
Mail list logo
