[PATCH] osmo-gsm-manuals[master]: Allow easily disabling GFDL references

2017-08-29 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/3736 Allow easily disabling GFDL references All parts referencing GFDL can be easily disabled by removing the 'gfdl-enabled' attribute from the document. Change-Id: I2489726ad2e90301bceadfada926e31ae0f85986 --- M OsmoBSC/osmobsc-usermanual.adoc M

osmo-sip-connector[master]: sdp.c Send octet-align in fmtp

2017-08-29 Thread Keith Whyte
Patch Set 2: > @keith: Thanks for digging into the RFC. Sure! This was meant more by way of a conversation starter. I'm finding a number of things while interfacing AMR enabled nitb to a SIP endpoint. -- To view, visit https://gerrit.osmocom.org/3735 To unsubscribe, visit

osmo-gsm-tester[master]: Reserve ARFCN dynamically based on BTS band support

2017-08-29 Thread Pau Espin Pedrol
Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/3731/1/src/osmo_gsm_tester/bts_osmotrx.py File src/osmo_gsm_tester/bts_osmotrx.py: Line 137: } > (rather first get the defaults and then overlay this dict on top, otherwise All other confs can be taken from self.conf

osmo-sip-connector[master]: sdp.c Send octet-align in fmtp

2017-08-29 Thread Holger Freyther
Patch Set 2: @keith: Thanks for digging into the RFC. It is clear we need to change it but I would prefer to not use 98 (which is a dynamic payload type and could mean anything) but can you check the result of app_media_name() if it returns "AMR"? -- To view, visit

osmo-sip-connector[master]: sdp.c Send octet-align in fmtp

2017-08-29 Thread Holger Freyther
Patch Set 2: @max; Could you have a look at the build failure? I remember patches from you in regard to to that? -- To view, visit https://gerrit.osmocom.org/3735 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-gsm-tester[master]: Add cipher cfg param for modem and bts

2017-08-29 Thread Pau Espin Pedrol
Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/3723/2/example/resources.conf File example/resources.conf: Line 16: ciphers: ['a5 0', 'a5 1', 'a5 2', 'a5 3'] > 'a5 2' is a weak "export grade" cipher and globally deprecated. I assume ou De HW supports A5/2. If osmocom stack doesn't

[PATCH] osmo-sip-connector[master]: sdp.c Send octet-align in fmtp

2017-08-29 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3735 to look at the new patch set (#2). sdp.c Send octet-align in fmtp rfc4867 8.2: octet-align: Permissible values are 0 and 1. If 1, octet-aligned operation SHALL

[PATCH] osmo-sip-connector[master]: sdp.c Send octet-align in ftmp

2017-08-29 Thread Keith Whyte
Review at https://gerrit.osmocom.org/3735 sdp.c Send octet-align in ftmp rfc4867 8.2: octet-align: Permissible values are 0 and 1. If 1, octet-aligned operation SHALL be used. If 0 or if not present, bandwidth-efficient operation is employed. We

[MERGED] osmo-msc[master]: move to osmo-mgw.git: osmo-bsc_mgcp and libmgcp as libosmo-l...

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: move to osmo-mgw.git: osmo-bsc_mgcp and libmgcp as libosmo-legacy-mgcp .. move to osmo-mgw.git: osmo-bsc_mgcp and libmgcp as libosmo-legacy-mgcp Rewire

[MERGED] osmo-msc[master]: Implement AoIP, port to M3UA SIGTRAN (large addition and ref...

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Implement AoIP, port to M3UA SIGTRAN (large addition and refactoring) .. Implement AoIP, port to M3UA SIGTRAN (large addition and refactoring) This was

[MERGED] osmo-msc[master]: .gitignore: cosmetic: use globs to ignore test binaries

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: .gitignore: cosmetic: use globs to ignore test binaries .. .gitignore: cosmetic: use globs to ignore test binaries Change-Id:

[MERGED] osmo-msc[master]: libmsc: make pitfall in gsm0408_dispatch() more obvious

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc: make pitfall in gsm0408_dispatch() more obvious .. libmsc: make pitfall in gsm0408_dispatch() more obvious The function gsm0408_dispatch()

[MERGED] osmo-msc[master]: rework debian packages support

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: rework debian packages support .. rework debian packages support Remove old leftover from split of osmo-mgw out of openbsc. Change-Id:

[MERGED] osmo-msc[master]: MSC, SGSN: use OSMO_GSUP_PORT == 4222 instead of 2222

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: MSC,SGSN: use OSMO_GSUP_PORT == 4222 instead of .. MSC,SGSN: use OSMO_GSUP_PORT == 4222 instead of In SGSN, actually place the port in the

[MERGED] osmo-msc[master]: cosmetic: msc_vlr_tests: drop unused var

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: msc_vlr_tests: drop unused var .. cosmetic: msc_vlr_tests: drop unused var Change-Id: I584c0dfffe005597563dbd72fad8a087c554ba3d --- M

[MERGED] osmo-msc[master]: gsup client: move not-connected to error loglevel

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsup client: move not-connected to error loglevel .. gsup client: move not-connected to error loglevel Change-Id:

[MERGED] osmo-msc[master]: add msg type to SMS rx logging

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add msg type to SMS rx logging .. add msg type to SMS rx logging Change-Id: I73ea4eebe57b2d1008045a27f174072178b9f077 --- M src/libmsc/gsm_04_11.c 1

[MERGED] osmo-msc[master]: split off osmo-msc: remove files, apply build, rename

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: split off osmo-msc: remove files, apply build, rename .. split off osmo-msc: remove files, apply build, rename Change-Id:

[MERGED] osmo-msc[master]: move libiu to osmo-iuh/libosmo-ranap

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: move libiu to osmo-iuh/libosmo-ranap .. move libiu to osmo-iuh/libosmo-ranap Remove libiu here, use the functions from libosmo-ranap instead, by

[MERGED] osmo-msc[master]: msc_vlr tests: add IMEISV tests

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc_vlr tests: add IMEISV tests .. msc_vlr tests: add IMEISV tests Change-Id: I752afef2ae3ce04e813c7e9fea0e883e607c0e14 --- M

[MERGED] osmo-msc[master]: build: check for -lgsm

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: build: check for -lgsm .. build: check for -lgsm If libosmo-legacy-mgcp is built with --enable-mgcp-transcoding, we need to link -lgsm here as well.

[MERGED] osmo-msc[master]: mgcp: add VTY Option to force-realloc endpoints

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mgcp: add VTY Option to force-realloc endpoints .. mgcp: add VTY Option to force-realloc endpoints Currently the force_realloc feature is turnd on and

osmo-msc[master]: mgcp: add VTY Option to force-realloc endpoints

2017-08-29 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3487 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8740512c5ea0766ff6ceb1c28b9c2b3fe46e75f Gerrit-PatchSet: 4 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: build: check for -lgsm

2017-08-29 Thread Harald Welte
Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3587 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab55a089ae36017b79e7cbc3cac45ef9fd85dd43 Gerrit-PatchSet: 7 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmo-netif[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3707 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01b0aae741b83a3f17f1caf2b6837cf365a1709b Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

[MERGED] libosmo-netif[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

osmo-msc[master]: split off osmo-msc: remove files, apply build, rename

2017-08-29 Thread Harald Welte
Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3497 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf025e5ea8d180613b3114282951c9afa67af9a7 Gerrit-PatchSet: 8 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: move to osmo-mgw.git: osmo-bsc_mgcp and libmgcp as libosmo-l...

2017-08-29 Thread Harald Welte
Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3492 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic99d681759edce11564da62500c2aac5cf5fffe2 Gerrit-PatchSet: 8 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: move libiu to osmo-iuh/libosmo-ranap

2017-08-29 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3489 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8c4fcdb4766c5e575618b95ce16dce51063206b Gerrit-PatchSet: 6 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-iuh[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

[MERGED] openbsc[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

[MERGED] osmo-msc[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

[MERGED] libosmo-sccp[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

[MERGED] libosmocore[master]: umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen .. umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen When doing UMTS AKA with

[MERGED] libosmocore[master]: osmo-auc-gen: umts: print out the IND of the SQN used

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-auc-gen: umts: print out the IND of the SQN used .. osmo-auc-gen: umts: print out the IND of the SQN used Make ind_mask available in the main(){}

[MERGED] openggsn[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

[MERGED] osmo-pcap[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

osmo-gsm-tester[master]: Reserve ARFCN dynamically based on BTS band support

2017-08-29 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (7 comments) https://gerrit.osmocom.org/#/c/3731/1//COMMIT_MSG Commit Message: Line 26: "Related: OS#2230" https://gerrit.osmocom.org/#/c/3731/1/src/osmo_gsm_tester/bts_osmotrx.py File src/osmo_gsm_tester/bts_osmotrx.py: Line 137: } (rather first

[MERGED] libosmocore[master]: osmo-auc-gen: umts: use default of ind_bitlen = 5 instead of 0

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-auc-gen: umts: use default of ind_bitlen = 5 instead of 0 .. osmo-auc-gen: umts: use default of ind_bitlen = 5 instead of 0 Most USIM out there

libsmpp34[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3709 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief2b4d0400b142e84e7ce005a6da5c880c78a8f5 Gerrit-PatchSet: 2 Gerrit-Project: libsmpp34 Gerrit-Branch: master

[MERGED] libsmpp34[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use release helper from libosmocore .. Use release helper from libosmocore See

[MERGED] libosmocore[master]: osmo-auc-gen: umts: add --ind-len arg

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-auc-gen: umts: add --ind-len arg .. osmo-auc-gen: umts: add --ind-len arg osmo-auc-gen so far does not allow indicating the IND bit length of SQN.

[MERGED] libosmocore[master]: osmo-auc-gen: umts: remove erratic SQN.MS printout

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-auc-gen: umts: remove erratic SQN.MS printout .. osmo-auc-gen: umts: remove erratic SQN.MS printout osmo-auc-gen tries to be helpful by deriving

osmo-msc[master]: Implement AoIP, port to M3UA SIGTRAN (large addition and ref...

2017-08-29 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3486 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4e05ee7c57cad341ea5e86af37c1f6b0ffa77 Gerrit-PatchSet: 5 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmocore[master]: cosmetic: test for osmo-auc-gen: print error for missing binary

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3696 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c23ae6378a16cf3b76c90d4ea0dfcf61ff3033 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: cosmetic: umts aka: tweak comments for sqn and ind

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: umts aka: tweak comments for sqn and ind .. cosmetic: umts aka: tweak comments for sqn and ind Clearly indicate that 'sqn' is an in *and*

libosmocore[master]: osmo-auc-gen: umts: remove erratic SQN.MS printout

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3697 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2432c6d6a23818f7b3a29b1295dcbb505e2be53 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: osmo-auc-gen: umts: add --ind arg

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-auc-gen: umts: add --ind arg .. osmo-auc-gen: umts: add --ind arg During UMTS AKA, the caller typically indicates which IND slot the next used SQN

[MERGED] libosmocore[master]: osmo-auc-gen: umts: properly request --sqn

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-auc-gen: umts: properly request --sqn .. osmo-auc-gen: umts: properly request --sqn The user supplied an --sqn to generate a vector for, but

[MERGED] libosmocore[master]: cosmetic: test for osmo-auc-gen: print error for missing binary

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: test for osmo-auc-gen: print error for missing binary .. cosmetic: test for osmo-auc-gen: print error for missing binary Change-Id:

libosmocore[master]: osmo-auc-gen: umts: properly request --sqn

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3698 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51a8f6333fee9c02b4073ca360991d0aa69c74f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: osmo-auc-gen: umts: use default of ind_bitlen = 5 instead of 0

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3699 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fcc11fa2b5816302dcc6b72249b1ee40d5a61f5 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: osmo-auc-gen: umts: add --ind arg

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3700 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60eec80d58ca9a0a01e7fbd2bcbbd4339b1a6d8 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: osmo-auc-gen: umts: print out the IND of the SQN used

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3702 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91eac53c4af66a58b9372d9baf5781fc9f29b1fc Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: osmo-auc-gen: umts: add --ind-len arg

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3701 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1d8b6a823ffc92290b3e39e4e4665aeff80ccc0 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: cosmetic: umts aka: tweak comments for sqn and ind

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3703 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia40cd4ddf35f4fbe895b45b8ea59378f5ce9eb1f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3704 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fc05bbf169d06716f40b995154fd42a3f91bef3 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-trx[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3717 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb843923d8f534654413be695f2b5f0c87b75520 Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master

openggsn[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3718 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcb388ad22b0c009dac7968408d1e2504c838c1 Gerrit-PatchSet: 2 Gerrit-Project: openggsn Gerrit-Branch: master

osmo-sgsn[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3716 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73823c568cfc55ad21a08dec76874724b43f419f Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

openbsc[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3719 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460fd73230facbba3e326214e46c0b98b7491628 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

osmo-iuh[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3712 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ccc8202b650268cc9d1721719ba2f205c351a67 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master

osmo-mgw[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3713 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0905eeb177185da1e2818a01fdb7265694d9903d Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-msc[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3714 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869395d5c9ab5ec1a487aff15418d1517f47e831 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmo-sccp[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3708 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b3bfa8a1ccf376215a3ce220cb3cf7a85471cb Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

openbsc[master]: Remove common_cs.h from .deb

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3705 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22004af84244936ca431f3bf901059f366be8bca Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

osmo-bsc[master]: Use release helper from libosmocore

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3710 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05bf42d638167c779328fa61b01c917da91a88de Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] openbsc[master]: Remove common_cs.h from .deb

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Remove common_cs.h from .deb .. Remove common_cs.h from .deb It's not required by gsm_data_shared.h anymore. Change-Id:

libosmocore[master]: Add define for supported a5 key length limit

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3706 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed0f1dbc31aaff22a685ceb3bd2f8db4d2f34fd Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: Cleanup jenkins build scripts

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/3132/2/contrib/jenkins-arm.sh File contrib/jenkins-arm.sh: PS2, Line 6: - you are introducing cosmetic changes (all arguments on same line vs. separate lines) with a clean-up, making it much harder to read and thus validate

osmo-bts[master]: Use git-version-gen from gnulib

2017-08-29 Thread Harald Welte
Patch Set 3: Code-Review-1 I still don't see why we should introduce yet another build-time ddependency that all of our users need to install. I'm already quite unhappy with the recent new 'bumpversion' dependency. The commit message still doesn't state *why* you are proposing this. What is

openbsc[master]: SI13: drop PBCCH-related bits

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3734 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e71a4b0c682361529e9c21377398a826b934b Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

osmo-gsm-tester[master]: Add cipher cfg param for modem and bts

2017-08-29 Thread Neels Hofmeyr
Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/3723/2/example/resources.conf File example/resources.conf: Line 16: ciphers: ['a5 0', 'a5 1', 'a5 2', 'a5 3'] 'a5 2' is a weak "export grade" cipher and globally deprecated. I assume our osmo-bts code doesn't support it.

osmo-msc[master]: am: msc_vlr_tests: use AM_LDFLAGS instead of COMMON vars

2017-08-29 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6efae6e192b22de2c1d706edd55385135142532b Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-bts[master]: trx: avoid deactivating lchan on LCHAN_REL_ACT_REACT

2017-08-29 Thread Harald Welte
Patch Set 5: Code-Review-1 I still don't like this patch - or don't understand it. If there is a bug, then we fix it instead of introducing a hack and a FIXME. I also don't see why there seems to be an assumption that any LCHAN_REL_ACT_REACT is related to SI3 / number of AGCH. The fact that

[MERGED] libosmo-sccp[master]: cosmetic: aggressively set vty->index to NULL in osmo_ss7_vt...

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: aggressively set vty->index to NULL in osmo_ss7_vty_go_parent() .. cosmetic: aggressively set vty->index to NULL in osmo_ss7_vty_go_parent()

libosmo-sccp[master]: cosmetic: aggressively set vty->index to NULL in osmo_ss7_vt...

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3732 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I579482f679cd43edfbe796a5806ef360335f1c55 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

[MERGED] libosmocore[master]: vty: 'ctrl' node: add missing default commands like list, exi...

2017-08-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: 'ctrl' node: add missing default commands like list,exit,end .. vty: 'ctrl' node: add missing default commands like list,exit,end Change-Id:

libosmocore[master]: vty: 'ctrl' node: add missing default commands like list, exi...

2017-08-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3733 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72569ed767b6a4d792b2867d02caa65520e27cd3 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] openbsc[master]: SI13: drop PBCCH-related bits

2017-08-29 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3734 to look at the new patch set (#2). SI13: drop PBCCH-related bits According to 3GPP TS 44.018 §1.8 the "network shall never enable PBCCH and PCCCH". Change-Id:

[PATCH] openbsc[master]: SI13: check for incorrect configuration

2017-08-29 Thread Max
Review at https://gerrit.osmocom.org/3734 SI13: check for incorrect configuration According to 3GPP TS 44.018 §1.8 the "network shall never enable PBCCH and PCCCH". Change-Id: I319e71a4b0c682361529e9c21377398a826b934b Related: OS#2400 --- M openbsc/src/libbsc/rest_octets.c 1 file changed, 14

[PATCH] osmo-bts[master]: trx: avoid deactivating lchan on LCHAN_REL_ACT_REACT

2017-08-29 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3067 to look at the new patch set (#5). trx: avoid deactivating lchan on LCHAN_REL_ACT_REACT * do not deactivate lchan when called with LCHAN_REL_ACT_REACT * add fixme comment

libosmo-sccp[master]: cosmetic: aggressively set vty->index to NULL in osmo_ss7_vt...

2017-08-29 Thread Max
Patch Set 1: Could you clarify why? Other cases seems to not need this. -- To view, visit https://gerrit.osmocom.org/3732 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I579482f679cd43edfbe796a5806ef360335f1c55 Gerrit-PatchSet: 1

osmo-msc[master]: am: msc_vlr_tests: use AM_LDFLAGS instead of COMMON vars

2017-08-29 Thread Max
Patch Set 2: > since when does gerrit rebuild issues when a commit message was modified? Since the very beginning :) - I don't recall it behaving differently. -- To view, visit https://gerrit.osmocom.org/3720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

osmo-msc[master]: am: msc_vlr_tests: use AM_LDFLAGS instead of COMMON vars

2017-08-29 Thread Max
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6efae6e192b22de2c1d706edd55385135142532b Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master