Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3818
to look at the new patch set (#2).
jenkins: per build, drop programs built "unintentionally"
Each of the jenkins-build-* scripts intends to build a specific set of
pro
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-common.sh
File contrib/jenkins-build-common.sh:
Line 154: if [ -z "$(echo "_ $wanted_binaries _" | grep " $f ")" ]; then
> what are those underscores in there used for? I guess they can be removed.
yes, i
Review at https://gerrit.osmocom.org/3825
osmux: fix buffer management mess in snprintf() calls
SNPRINTF_BUFFER_SIZE() macro seems to be very buggy. Replace it by a
working version:
if (ret < 0)\
ret = 0;
Review at https://gerrit.osmocom.org/3824
rtp: return offset in osmo_rtp_snprintf()
Instead of the result of the last snprintf() call.
Change-Id: I10066d73387be96a4e1f3349d700405beb138076
---
M src/rtp.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/
Review at https://gerrit.osmocom.org/3823
Make use of osmo-build.sh to use dependency artifacts for builds.
Change-Id: I8a2ff700bbe3806bb2c1d561c6f2249fae3d8dd8
Note: this patchset depends on https://gerrit.osmocom.org/#/c/3822/1
---
M contrib/jenkins.sh
1 file changed, 47 insertions(+), 48 del
Review at https://gerrit.osmocom.org/3822
Change used protocoll for 'git ls-remote' call from https to git.
Otherwise script depends on availability of https://git.osmocom.org, which is
currently down.
Change-Id: Icf2a6b425177ef24aef1dba6e270d36fdc05d214
---
M scripts/osmo-build.sh
1 file cha
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 918: SNPRINTF_BUFFER_SIZE(ret, buf_offset, size);
> OK, I'm reviewing this function.
Hm, forget this:
while (msg_len > 0) {
is already always positive, so this can't be the reason f
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 918: SNPRINTF_BUFFER_SIZE(ret, buf_offset, size);
> I have no idea if the code initially fetching the AMR size from RTP is doin
OK, I'm reviewing this function.
It seems this check i
Max has abandoned this change.
Change subject: Migrate from OpenSSL to osmo_get_rand_id()
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/1464
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Message
Review at https://gerrit.osmocom.org/3821
Migrate from OpenSSL to osmo_get_rand_id()
This avoids potential licensing incompatibility and makes integration of
Debian packaging patches easier.
Related: OS#1694
Change-Id: I2b687b7f07ef05bbd861b8479cad5a958a3dde92
---
M configure.ac
M debian/cont
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/3818/1/contrib/jenkins-build-common.sh
File contrib/jenkins-build-common.sh:
Line 154: if [ -z "$(echo "_ $wanted_binaries _" | grep " $f ")" ]; then
what are those underscores in there used for? I guess they can be remo
Review at https://gerrit.osmocom.org/3820
Migrate from OpenSSL to osmo_get_rand_id()
This avoids potential licensing incompatibility and makes integration of
Debian packaging patches easier.
Related: OS#1694
Change-Id: I71cd631704a4dc155c6c752fee2a42cd6e2fa336
---
M configure.ac
M debian/cont
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 918: SNPRINTF_BUFFER_SIZE(ret, buf_offset, size);
> OK, if the problem are truncated packet, then fix _snprintf() function to u
I have no idea if the code initially fetching the AMR s
Review at https://gerrit.osmocom.org/3819
Migrate from OpenSSL to osmo_get_rand_id()
This avoids potential licensing incompatibility and makes integration of
Debian packaging patches easier.
Change-Id: Ia57bf1300525cf3c247284fe966b1c415c2d53e2
Related: OS#1694
---
M configure.ac
M debian/contr
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 918: SNPRINTF_BUFFER_SIZE(ret, buf_offset, size);
> Are you asking about this exact "No room for OSMUX payload" error case?
OK, if the problem are truncated packet, then fix _snprintf
Patch Set 3:
guys, please put this in prespective. If I look at the amount of time all of
you are spending on an osmux-private version of printing strings to a buffer,
this is not worth our time. In case of doubt, consider creating an inefficient
dynamic-allocating version or the like, which
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 918: SNPRINTF_BUFFER_SIZE(ret, buf_offset, size);
> I'm telling this because I suspect this is papering a problem somewhere els
Are you asking about this exact "No room for OSMUX payl
Neels Hofmeyr has submitted this change and it was merged.
Change subject: OsmoGsmTester: Move coredump section and add reference to
kernel.core_pattern sysctl
..
OsmoGsmTester: Move coredump section and add reference to kernel
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3711
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdde0a9960f9806f081e9a876b8b66db9e7f37c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Patch Set 1:
Ok, than add ref. to it so people can follow your train of thought.
--
To view, visit https://gerrit.osmocom.org/3814
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7f54a4cb179eaa9e5eb147b9477633ac618e69e
Gerrit-PatchSet:
Review at https://gerrit.osmocom.org/3818
jenkins: per build, drop programs built "unintentionally"
Each of the jenkins-build-* scripts intends to build a specific set of
programs. While compiling dependencies, other programs may end up in
$prefix/bin. Drop those other binaries to reduce potent
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 851: return ret; \
> I strongly object this coding style. Please no hidden return statements in
Return hidden is macros is not good. I'm with Nee
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 918: SNPRINTF_BUFFER_SIZE(ret, buf_offset, size);
> That's not checking the string output buffer, but the packet input buffer,
How come is the buffer getting full? AMR payload is ver
Patch Set 1:
> Cool. Could you please add spec reference to put this into proper
> context?
Hi,
I am not sure that I can find exact spec reference.
But I used openbsc/doc/handover.txt and it has link to Chapter 8 of
"Performance Enhancements in a Frequency Hopping GSM Network".
It's useful for
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3711
to look at the new patch set (#2).
OsmoGsmTester: Move coredump section and add reference to kernel.core_pattern
sysctl
This section is moved further below in order to h
Review at https://gerrit.osmocom.org/3817
Make release helper more robust
* check for bumpversion and error out if missing
* drop bumpversion dependency from .deb
Change-Id: Ide04d4c1ba20426bdf9531e25b462eda9418858a
Related: OS#1861
---
M debian/control
M osmo-release.mk
2 files changed, 5 ins
Max has abandoned this change.
Change subject: bsc_control.py: convert to python3
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/1358
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: ab
Patch Set 1:
Cool. Could you please add spec reference to put this into proper context?
--
To view, visit https://gerrit.osmocom.org/3814
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7f54a4cb179eaa9e5eb147b9477633ac618e69e
Gerrit-Pat
Patch Set 1:
I'll probably need to locally rebase it as it's based on top of other commits
(some of which contain fixes with arrays which may be needed for it).
--
To view, visit https://gerrit.osmocom.org/3763
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comm
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3150
to look at the new patch set (#9).
Move DL scheduling and RTS handler to trx level
Use TRX object directly instead of BTS singleton and trx_no. This is
necessary to facili
Patch Set 1:
(2 comments)
>From my point of view, we can merge this one.
https://gerrit.osmocom.org/#/c/3763/1/example/resources.conf
File example/resources.conf:
Line 63: features: ['sms']
> again the '- item' list format consideration, if you agree
I'd like to keep this format, it's more c
Patch Set 3: Code-Review-1
As discussed, let's not merge this for now. I still fixed some comments you had
in case we can re-use some of the work done in here.
--
To view, visit https://gerrit.osmocom.org/3731
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comme
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3721
to look at the new patch set (#2).
resource: Fix list comparison in item_matches
In following commits, cipher attribute containing a list of supported
ciphers is introdue
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3724
to look at the new patch set (#4).
resource_test: update to check list features (ciphers)
Change-Id: I532f66585ab6f7be1a71853190791feeecbf263c
---
M selftest/conf/resourc
Review at https://gerrit.osmocom.org/3815
Use own format to specify encryption algorithm
... instead of using the one from from osmo vty directly.
This way we avoid having multiple word attribute value and we can skip
using quotes in the conf files.
Change-Id: I5265cc9990dd5e99dba1f6262b3a8c5
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3722
to look at the new patch set (#2).
config: Fix combination of lists
It can make sense to recursively call combine() for a list containing
complex structures like dictiona
Review at https://gerrit.osmocom.org/3816
resource_test: Fix trailing whitespace
Change-Id: I654484b21ca2e950ff3019ee20133e9cb50296bb
---
M selftest/resource_test.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/16/3816/1
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3731
to look at the new patch set (#3).
Reserve ARFCN dynamically based on BTS band support
Instead of statically specifying a band for a BTS to use, declare a list
of support
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3723
to look at the new patch set (#4).
Add cipher cfg param for modem and bts
This parameter is contains a list of supported encryption ciphers by the
modem or bts setting it
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3760
to look at the new patch set (#4).
Simplify TS alloc: split into digestible pieces
Algorithm B implementation is way too big and complex to maintain or
even to follow the
Review at https://gerrit.osmocom.org/3814
handover_decision: Fix condition for power budget handover attempt
Handover attempt for power budget case should be performed every N SACCH frames,
where N = Power Budget Interval.
First measurement report with mr->nr = 0 was used for the first handover
Review at https://gerrit.osmocom.org/3813
move include/openbsc to include/osmocom/bsc
Change-Id: I39e7b882caa98334636d19ccd104fd83d07d5055
---
M configure.ac
M include/Makefile.am
A include/osmocom/Makefile.am
R include/osmocom/bsc/Makefile.am
R include/osmocom/bsc/a_reset.h
R include/osmocom/b
Review at https://gerrit.osmocom.org/3812
remove contrib/soap.py, seems to apply to osmo-bsc only
Change-Id: I647be0a646bbc3cfee226c55061e0e57fa1211fa
---
D contrib/soap.py
1 file changed, 0 insertions(+), 188 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/12/381
Review at https://gerrit.osmocom.org/3811
rename include/openbsc to include/osmocom/msc
Change-Id: I1f96a1285bbd1b4607614856bca935d5c26e2da9
---
M configure.ac
M include/Makefile.am
A include/osmocom/Makefile.am
R include/osmocom/msc/Makefile.am
R include/osmocom/msc/a_iface.h
R include/osmocom
Review at https://gerrit.osmocom.org/3810
move include/openbsc to include/osmocom/sgsn
Change-Id: I281ef585fffc2644682c8282224fb1c2da5ca795
---
M configure.ac
M debian/copyright
M include/Makefile.am
A include/osmocom/Makefile.am
R include/osmocom/sgsn/Makefile.am
R include/osmocom/sgsn/common.
Review at https://gerrit.osmocom.org/3808
configure.ac: set name to osmo-sgsn, fix ML addr
Change-Id: I47e9f2307b42d171f2ceeda1e129e2311f611883
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/08/3808/1
diff -
Review at https://gerrit.osmocom.org/3809
move openbsc.pc to osmo-sgsn.pc
Change-Id: Iad28d85b2a6d175cbe5d506aa82e7e4d94111eff
---
M Makefile.am
M configure.ac
D openbsc.pc.in
A osmo-sgsn.pc.in
4 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-s
Max has submitted this change and it was merged.
Change subject: cosmetic: convert explicit warnings to fixme/todo
..
cosmetic: convert explicit warnings to fixme/todo
We do not use this style (#warning as an issue tracker repl
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3760
to look at the new patch set (#3).
Simplify TS alloc: split into digestible pieces
Algorithm B implementation is way too big and complex to maintain or
even to follow the
Review at https://gerrit.osmocom.org/3807
Simplify TS alloc: adjust function signatures
* drop unused parameters (from both functions and structs)
* document used parameters and return values
* tighten types used for parameters
* use consistent formatting
Tests are adjusted accordingly but tes
Patch Set 3:
> > (1 comment)
>
> I am still puzzled how we ended up with xor sim cards, I've never
> encountered one before. Using the sysmo-usim-tool and a card reader
> it should be easy to change this, pmaier knows all about it.
> > (1 comment)
>
> I am still puzzled how we ended up
Review at https://gerrit.osmocom.org/3806
git_branch_summary.py: add usage, make py3 compatible
Change-Id: Ia8cc461fd0f1fb43e19ee8846cc48a828d153b2f
---
M src/git_branch_summary.py
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/
Patch Set 3:
(4 comments)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 849: #define SNPRINTF_BUFFER_SIZE(ret, buffer_offset, size)
\
> agreed; yet when first reading it, it helps to have doc for these non-obvio
Agree, I'll add a short description of e
Patch Set 3:
> (1 comment)
I am still puzzled how we ended up with xor sim cards, I've never encountered
one before. Using the sysmo-usim-tool and a card reader it should be easy to
change this, pmaier knows all about it.
--
To view, visit https://gerrit.osmocom.org/3724
To unsubscribe, visi
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3723/3/example/resources.conf
File example/resources.conf:
Line 16: ciphers: ['a5 0', 'a5 1', 'a5 3']
> TBH, I don't care that much.
I think it's only about numbers starting with 0 being interpreted as octal.
my choice would be a5_0. qu
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3711/1//COMMIT_MSG
Commit Message:
Line 7: OsmoGsmTester: Move coredump section and add reference to
kernel.core_pattern sysctl
> So do you want me to split this into 2 commits? Is it really needed? The am
maybe next time.
--
To view,
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/3731/2/src/osmo_gsm_tester/bts_sysmo.py
File src/osmo_gsm_tester/bts_sysmo.py:
Line 120: return self.band_arfcn.get('band')
> It should always be set by suite.py just after creating it in suite.py:bts_
hmm, should be set by suite.
Patch Set 1:
Yes, I'll go through all comments in all commits and push the entire branch
again.
--
To view, visit https://gerrit.osmocom.org/3721
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27b372aa5906feac2843f24f5cdd0d9578d44b4d
G
Patch Set 1: Code-Review+1
ok I understand now, thanks!
(only +1 because you mentioned you wanted to push another commit...?)
--
To view, visit https://gerrit.osmocom.org/3721
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27b372aa5906f
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3761
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72070e2a027e60e8b80c12ccfa23ff075434689f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review-1
(5 comments)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 849: #define SNPRINTF_BUFFER_SIZE(ret, buffer_offset, size)
\
> At least now there's one parameter left storing state, so easier than befor
agreed; yet when first rea
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3721/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 449: return False
> I'll provide a test for this. I think I stumbled onto it when trying to use
After doing some tests, it fixes the followin
Patch Set 3:
(6 comments)
https://gerrit.osmocom.org/#/c/3537/3/src/osmux.c
File src/osmux.c:
Line 849: #define SNPRINTF_BUFFER_SIZE(ret, buffer_offset, size)
\
> phew, can we document the arguments? my head is spinning...
At least now there's one parameter left storing state, s
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3761
to look at the new patch set (#2).
cosmetic: convert explicit warnings to fixme/todo
We do not use this style (#warning as an issue tracker replacement)
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3761/1/src/gprs_bssgp_pcu.cpp
File src/gprs_bssgp_pcu.cpp:
Line 969: talloc_free(the_pcu.bctx);
> what? do we have a missing free here? Why can we just omit it, because we n
Yes to both questions.
--
To view, visit https://gerrit.
Max has abandoned this change.
Change subject: Use release helper from libosmocore
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3716
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: a
Max has abandoned this change.
Change subject: Use release helper from libosmocore
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3713
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: a
Max has abandoned this change.
Change subject: Use release helper from libosmocore
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3710
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: a
Patch Set 1:
(4 comments)
https://gerrit.osmocom.org/#/c/3731/2/src/osmo_gsm_tester/bts_sysmo.py
File src/osmo_gsm_tester/bts_sysmo.py:
Line 117: self.band_arfcn = band_arfcn
> self.band_arfcn should have a default value up in __init__() or above that.
Good point. I didn't do it probabl
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/3711/1//COMMIT_MSG
Commit Message:
Line 7: OsmoGsmTester: Move coredump section and add reference to
kernel.core_pattern sysctl
> Sneaky! Editing while moving. Makes it hard to spot the edits.
So do you want me to split this into 2 commi
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3723/3/example/resources.conf
File example/resources.conf:
Line 16: ciphers: ['a5 0', 'a5 1', 'a5 3']
> re-reading this, I get two thoughts:
TBH, I don't care that much.
I think it's still nice to use the quoting because as far as I reme
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3722/1/src/osmo_gsm_tester/config.py
File src/osmo_gsm_tester/config.py:
Line 253: dest.append(src[i])
> It is potentially dangerous to change this logic and I want to be sure I un
I'll provide a a test for this, but AFAIR
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3721/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 449: return False
> It is potentially dangerous to change this logic and I want to be sure I un
I'll provide a test for this. I think I stumb
Patch Set 11:
> Could you test my version?
Tested. Works.
--
To view, visit https://gerrit.osmocom.org/3735
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa670055
Gerrit-PatchSet: 11
Gerrit-Project: osm
Review at https://gerrit.osmocom.org/3805
cosmetic: clarify language in vty read error
This is very minor but it annoys every time I see it.
The text: "Error occurred during reading below line:"
is not a complete sentence. The default understanding
in english having left out the article implies
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3724/3/selftest/conf/resources.conf
File selftest/conf/resources.conf:
Line 67: auth_algo: 'xor'
> xor is somewhat untypical, comp128 would be more common. Hmm, which one was
? That modem SIM is using a xor algo right now, so it needs th
Patch Set 1:
I'll merge it as it is, I think 3 from uint16_t and uint8_t is clear enough and
no need to clutter with a comment.
--
To view, visit https://gerrit.osmocom.org/3748
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2e6716c3
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: ggsn: Fix DNS not sent in PDP context response
..
ggsn: Fix DNS not sent in PDP context response
During IPv6 support implementation, helper function
Patch Set 11:
>
> don't worry. Let me edit as example.
Ah right.. the caller frees it. of course.
--
To view, visit https://gerrit.osmocom.org/3735
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I938758ac4ec55db9223e3da6c3c277e8fa6700
79 matches
Mail list logo
