Harald Welte has submitted this change and it was merged.
Change subject: doc/examples: tweak osmo-bsc.cfg, add osmo-bsc_custom-sccp.cfg
..
doc/examples: tweak osmo-bsc.cfg, add osmo-bsc_custom-sccp.cfg
Now osmo-bsc.cfg's SCCP
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3832
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb41d5adc24b2ee5613be691a201df8f3566e5dd
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 3:
I would be conservative here, i.e. not merge the patch.
Comments are of severely limited use anyway, as they are all deleted when you
write back the running configuration to the file anyway. And having them on
separate lines has worked so far, nobody has ever raised an issue
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3880
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24cbb3f6de111f2d31110c3c484c066f1153aac9
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3920
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2699ceebf0cbec01652a02fa68ccc9e9419d0293
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3807
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d81ab64ff790b9c4c2d0312a574485cd83e755
Gerrit-PatchSet: 8
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3942
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id968e60d081a6d69de482a908ca3fe5e1044aaa3
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Bump version: 1.0.1 → 1.0.2
..
Bump version: 1.0.1 → 1.0.2
Catch-up with release tagging and .deb changelog: the requirements in
OsmoMSC were updated.
Harald Welte has submitted this change and it was merged.
Change subject: Add TODO-RELEASE file
..
Add TODO-RELEASE file
Let's track the API/ABI changes in libosmo*mgcp the same way we do it in
other libosmo* libraries.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3949
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b8d55ea58bdb3d72b4c131ac983d8895b55ef8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3950
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c37b56e81df13007738f340c3fb48f0996a95f3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3955
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e71a4b0c682361529e9c21377398a826b934b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: SI13: drop PBCCH-related bits
..
SI13: drop PBCCH-related bits
According to 3GPP TS 44.018 §1.8 the "network shall never enable PBCCH
and PCCCH".
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3909
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29270652957f58093be8bf7f2e898b0b4933bd93
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 5:
> >
> > That could work, right?
>
> OK this will give you a random available extension:
>
> SELECT t.extension+1, t2.extension AS ext
> FROM subscriber AS t
> LEFT OUTER JOIN subscriber AS t2 ON
> t.extension+1 = t2.extension
> WHERE t2.extension IS NULL
> ORDER BY
Patch Set 5:
>
> That could work, right?
OK this will give you a random available extension:
SELECT t.extension+1, t2.extension AS ext
FROM subscriber AS t
LEFT OUTER JOIN subscriber AS t2 ON
t.extension+1 = t2.extension
WHERE t2.extension IS NULL
ORDER BY RANDOM() LIMIT 1;
--
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/3907/3/selftest/suite_test/test_suite/suite.conf
File selftest/suite_test/test_suite/suite.conf:
Line 6: - times: 2
> it would serve to see which one of them got duplicated :)
This is left like this in the new version of the patch
Review at https://gerrit.osmocom.org/3955
SI13: drop PBCCH-related bits
According to 3GPP TS 44.018 §1.8 the "network shall never enable PBCCH
and PCCCH".
Change-Id: I319e71a4b0c682361529e9c21377398a826b934b
Related: OS#2400
---
M include/osmocom/bsc/rest_octets.h
M src/libbsc/rest_octets.c
M
Review at https://gerrit.osmocom.org/3951
nominal_power and max_power_red attrs can now be set per resource
Before this commit, only max_power_red was specified and it could only
be used as a defaults and could not be set per object. Together with
nominal_power, it can be useful to be able to
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3907
to look at the new patch set (#4).
Replicate resources based on times attr before combine time
As suite.conf and scenarios need to match 1-to-1 in lists, it's important
Review at https://gerrit.osmocom.org/3954
resource: Allow passing keyword args to NoResourceExn
Same code is already being used by log.Error exception.
This way we can use:
raise resource.NoResourceExn("No free arfcns in any of bands",
bands=supported_bands)
And get:
Review at https://gerrit.osmocom.org/3953
suite_test: Update tests to check new feature fixes
Now that combination and matching of lists works properly, update the
suite test to check a more complex scenario.
Change-Id: Ib0b82dc0c2a7f27cd6b2ffc32eed5f1287692ddc
---
M selftest/suite_test.ok
M
Review at https://gerrit.osmocom.org/3952
resource: Handle lists correctly in item_matches
We want to handle lists in the same way as we handle them in combine().
Without this commit, reserve()->find() failed to match objects
containing dictionaries inside lists correctly (such as trx
Review at https://gerrit.osmocom.org/3950
Bump version: 1.0.1 → 1.0.2
Catch-up with release tagging and .deb changelog: the requirements in
OsmoMSC were updated.
Change-Id: I2c37b56e81df13007738f340c3fb48f0996a95f3
---
M debian/changelog
M src/libosmo-mgcp-client/Makefile.am
2 files changed,
Patch Set 1: Code-Review+1
> Build Successful
>
> http://jenkins.osmocom.org/jenkins/job/osmo-mgw-gerrit/27/ :
> SUCCESS' --verified 1 --code-review 0
--
To view, visit https://gerrit.osmocom.org/3949
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/3949
Add TODO-RELEASE file
Let's track the API/ABI changes in libosmo*mgcp the same way we do it in
other libosmo* libraries.
Change-Id: Id0b8d55ea58bdb3d72b4c131ac983d8895b55ef8
---
A TODO-RELEASE
1 file changed, 9 insertions(+), 0 deletions(-)
git
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#4).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the new printer also
Patch Set 1: Code-Review+2
(4 comments)
https://gerrit.osmocom.org/#/c/3948/1/src/sccp_user.c
File src/sccp_user.c:
Line 418:* the default asp name. */
thinking ... if I've added an ASP for a *different* AS but stupidly enough
chose the same name, we're now stealing the ASP
Patch Set 2:
cosmetic because for all I can tell it does the exact same thing as before, so
it's just removing code dup...
--
To view, visit https://gerrit.osmocom.org/3942
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 4:
and let's add a jobs/README that describes how these yml files are used to
update our jenkins jobs
--
To view, visit https://gerrit.osmocom.org/3911
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/3911/4/jobs/gerrit-verifications.yml
File jobs/gerrit-verifications.yml:
Line 246: - branch-compare-type: 'ANT'
ANT? that's the web UI's 'Path' value?
Line 261: - shell: 'chmod -R +w *; rm -rf *; git checkout .'
Patch Set 4: Code-Review+2
(7 comments)
all of these can be addressed after this is merged.
https://gerrit.osmocom.org/#/c/3911/4/jobs/gerrit-verifications.yml
File jobs/gerrit-verifications.yml:
Line 3:# following default values can be overridden by each repo
by repo you mean the
Patch Set 5:
To avoid loops altogether, I'm thinking of an SQL approach:
One part of the solution is the random picking:
SELECT * FROM table ORDER BY RANDOM() LIMIT 1;
The other part would be to select from a list of *unused* values.
This one looks promising:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3807
to look at the new patch set (#8).
Simplify TS alloc: adjust allocator signatures
* drop unused parameters (from both functions and structs)
* document used parameters
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3914
to look at the new patch set (#4).
Simplify TS alloc: cosmetic, use proper formatting
The find_multi_slots() function has 5 nested for(;;) loops but it's
formatted as one. Before
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3935
to look at the new patch set (#2).
Simplify TS alloc: move slot check into functions
Move timeslot applicability check outside of nested for loop into
separate functions and document
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#3).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the new printer also
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3913
to look at the new patch set (#4).
Simplify TS alloc: split off RX mask computation
Move computation of RX mask into separate function and document it. This
allows to significantly
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3934
to look at the new patch set (#2).
Simplify TS alloc: separate capacity computation
Move TRX capacity computation into separate function and document it.
Change-Id:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3760
to look at the new patch set (#15).
Simplify TS alloc: improve readability
* consistently format log messages to make it possible to grep for test
output in source
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3920
to look at the new patch set (#3).
Simplify TS alloc: use defines for constant
* define and use constant for occupied TFI instead copying the same
magic number all over
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#16).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation
Patch Set 5:
> So if your
> problem goes away from using sqlite directly,
Hmm. the gerrit failure was related to libdbi 0.8.4, but that is not related to
the issue I'm trying to address, although I'm not sure - will this code fail
now on a system with libdbi 0.8.4?
> but it has
> to
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/3910/5/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:
Line 1442: for (i = 0; i < (smax - smin)*2; i++) {
Is there a way to check the entire pool for a free extension, without going
through them all one by one?
Given that we
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3910
to look at the new patch set (#5).
libmsc: db_subscriber_alloc_exten() remove infinite loop
This patch prevents entering an infinite loop in the
case that you actually have exhasuted
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3910
to look at the new patch set (#4).
libmsc: db_subscriber_alloc_exten() remove infinite loop
This patch prevents entering an infinite loop in the
case that you actually have exhasuted
Review at https://gerrit.osmocom.org/3948
simple client: prevent overwriting asp settings
If the user does not create an AS, but creates an ASP with a name
that is equal to the default name, then the simple client detects
that and trys to use this ASP. However, unfortunately it then
overwrites
Gerrit verification jobs as Jenkins Job Builder YAML [1] file.
[1] https://docs.openstack.org/infra/jenkins-job-builder/
Change-Id: I04387367a6e2d737bfb50423c81a8908d3c2a89f
---
A jobs/gerrit-verifications.yml
1 file changed, 268 insertions(+), 0 deletions(-)
git pull
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#2).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the new printer also correctly handle
Patch Set 2: Code-Review+1
I don't think it's cosmetic change (it's more than updating comments,
formatting etc) but seems good anyway.
--
To view, visit https://gerrit.osmocom.org/3942
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: Fix race condition when connect() is called more than
once
..
modem: Fix race condition when connect() is called more than once
An issue was
51 matches
Mail list logo
