osmodumpdoc: fix finding cfg when not calling from source tree
When the binary has not been built in the source tree, it was impossible to
call osmodumpdoc.py despite the -p option. Look for config files
in that config-path.
Make sure a relative config-path is adjusted when changing to the
Neels Hofmeyr has submitted this change and it was merged.
Change subject: VTY: implicit node exit by de-indenting, not parent lookup
..
VTY: implicit node exit by de-indenting, not parent lookup
Note: This will break users'
Patch Set 4:
see https://gerrit.osmocom.org/3987 https://gerrit.osmocom.org/3988 ... those
are all that I found.
Good think I looked, but this patch does not actually affect those. The patch
that made those nodes un-exitable islands has already been merged, i.e. the one
for the interactive
Review at https://gerrit.osmocom.org/3988
vty: install default commands for SIP,MNCC,APP_NODE
Change-Id: Iee51881cc07d56209647fb4f505f8f6be6b885f0
---
M src/vty.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
Patch Set 4:
before merging this, we should make sure that all VTY nodes have the default
commands installed, like in https://gerrit.osmocom.org/3981 -- otherwise we are
creating VTY nodes from which it is impossible to exit. Before this patch, a
node that forgot to have default commands
Neels Hofmeyr has submitted this change and it was merged.
Change subject: ctrl: remove unimplemented cmds subscriber-{modify,delete}
..
ctrl: remove unimplemented cmds subscriber-{modify,delete}
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3981
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53e572194af39a431c54f83cd07e4c41c6fdf7f8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vty: fix: missing default cmds at hlr node
..
vty: fix: missing default cmds at hlr node
Without this, it is impossible to exit the 'hlr' node.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: main: remove cmdline args no longer available for osmo-msc
..
main: remove cmdline args no longer available for osmo-msc
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3980
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3009d2b3dd89eacdf6bc3d9c19744e9fdf4be6c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3986
to look at the new patch set (#2).
OsmoNITB: update vty reference
Change node IDs to use the names derived from the node prompt,
in the process fix the node references to not place the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3985
to look at the new patch set (#2).
fix make deps: don't use the FORCE
With the FORCE dependency in place, every 'make' invocation builds all from
scratch all the time. Remove that to
Review at https://gerrit.osmocom.org/3986
OsmoNITB: update vty reference
Change node IDs to use the names derived from the node prompt.
Related: I8fa70268b231c5e01727c661da92fad265de (libosmocore)
Change-Id: I48edb65be94be56c4b57293d8edc1b30271acc12
---
M
Review at https://gerrit.osmocom.org/3983
INSTALL.txt: add missing dep and vty ref howto
Change-Id: I1068d665b91faf1faa1b295503fcdc33f4ac500a
---
M INSTALL.txt
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/83/3983/1
Review at https://gerrit.osmocom.org/3984
fix make deps: join hint_to_remove_draft_mode to build step
Change-Id: Iecf8e18ce2f1dac61bf55019e1fec601b33abb95
---
M build/Makefile.asciidoc.inc
1 file changed, 1 insertion(+), 4 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3985
fix make deps: don't use the FORCE
With the FORCE dependency in place, every 'make' invocation builds all from
scratch all the time. Remove that to have intelligent re-build on edits.
Change-Id: I9758e04162a480e28c7dc83475b514cf7fd25ec0
---
M
Patch Set 3:
https://gerrit.osmocom.org/#/c/3830/ has been merged, so some changes in this
patch can be re-submitted again on top it:
- documentation for the function.
- Add the "osmuxh->ft == OSMUX_FT_VOICE_AMR &&" check.
--
To view, visit https://gerrit.osmocom.org/3537
To unsubscribe,
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: contrib: Enable -Werror by default
..
contrib: Enable -Werror by default
Change-Id: I2a88cdcbf76ea28a30e82836030f894c2152d5ed
---
M
Review at https://gerrit.osmocom.org/3982
ctrl: remove unimplemented cmds subscriber-{modify,delete}
Change-Id: I754de5d08c053fea5f1ca2673b0ac4d26a85778a
---
M src/libmsc/ctrl_commands.c
1 file changed, 0 insertions(+), 22 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Neels Hofmeyr has abandoned this change.
Change subject: fix deb: drop obsolete mgcp header
..
Abandoned
this is a bit more complex. This may work when the next batch of osmo-mgw
patches are merged, which create an
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: ipa.c: use msgb_dequeue(), drop local var
..
cosmetic: ipa.c: use msgb_dequeue(), drop local var
Make ipa_server_conn_write() a lot simpler
Neels Hofmeyr has submitted this change and it was merged.
Change subject: resource_test: Fix trailing whitespace
..
resource_test: Fix trailing whitespace
Change-Id: I654484b21ca2e950ff3019ee20133e9cb50296bb
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: resource: Allow passing keyword args to NoResourceExn
..
resource: Allow passing keyword args to NoResourceExn
Same code is already being used by
Neels Hofmeyr has submitted this change and it was merged.
Change subject: suite_test: Update tests to check new feature fixes
..
suite_test: Update tests to check new feature fixes
Now that combination and matching of lists
Neels Hofmeyr has submitted this change and it was merged.
Change subject: Add features attribute to modems
..
Add features attribute to modems
The idea behind this attribute is similar to the Features one in ofono:
To provide
Neels Hofmeyr has submitted this change and it was merged.
Change subject: resource_test: update to check list features (ciphers)
..
resource_test: update to check list features (ciphers)
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: Use own format to specify encryption algorithm
..
Use own format to specify encryption algorithm
... instead of using the one from from osmo vty
Neels Hofmeyr has submitted this change and it was merged.
Change subject: Add cipher cfg param for modem and bts
..
Add cipher cfg param for modem and bts
This parameter is contains a list of supported encryption ciphers by
Review at https://gerrit.osmocom.org/3981
vty: fix: missing default cmds at hlr node
Without this, it is impossible to exit the 'hlr' node.
Change-Id: I53e572194af39a431c54f83cd07e4c41c6fdf7f8
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3980
main: remove cmdline args no longer available for osmo-msc
Change-Id: I3009d2b3dd89eacdf6bc3d9c19744e9fdf4be6c3
---
M src/osmo-msc/msc_main.c
1 file changed, 1 insertion(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: src: _snprintf() helper functions nul-terminate buffers, if
possible
..
src: _snprintf() helper functions nul-terminate buffers, if possible
This
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3979
to look at the new patch set (#3).
vty: derive node name from prompt, use as XML ids
The 'show online-help' produces XML output with ids. We
reference those from the
Patch Set 2:
note that this is extended further by https://gerrit.osmocom.org/3979 ...
technically, if we merge that, this one is not necessary. Just adding this one
as a leaner alternative.
--
To view, visit https://gerrit.osmocom.org/3978
To unsubscribe, visit
Patch Set 3:
Looks okay.
--
To view, visit https://gerrit.osmocom.org/3930
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I563dc10827ce68295553f88f3bf2e1fc0ba595c1
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 4: Code-Review-2
Yes it is sad that coding style was violated.. but stuff like this breaks git
blame and such. In other projects such cleanups are not done for having a
working history.
We can do parts of the change.
--
To view, visit https://gerrit.osmocom.org/3914
To
Patch Set 6: Code-Review-1
Depends on "ts_print" which doesn't print.. so I stop review here for now.
--
To view, visit https://gerrit.osmocom.org/3905
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 4: Code-Review-1
Where is the recursion?
* snprintf in call sites is not really an improvement
* Method is called print while it is a format
* newer libosmocore without bumping minimum version in configure.ac
What would it take to just fix the bug?
--
To view, visit
Patch Set 15:
(5 comments)
I have mixed feelings about the change. It seems churn and I don't see the
development path of this branch yet.
https://gerrit.osmocom.org/#/c/3760/15/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:
Line 706
How does this debugging code hurt you? As
Review at https://gerrit.osmocom.org/3979
vty: derive node name from prompt, use as XML ids
The 'show online-help' produces XML output with ids. We
reference those from the osmo-gsm-manuals.
Instead of numeric IDs coming from internal code, rather use a human-readable
node ID. In order to
Review at https://gerrit.osmocom.org/3978
vty: use internal node id for xml ids
The 'show online-help' produces XML output with ids. We
reference those from the osmo-gsm-manuals, but until now, these ids fall out of
sync when the amount of VTY nodes changes.
Change these ids to use the
Patch Set 2:
> Did we remove the 80 chars limit?
For several months already - see
https://lists.osmocom.org/pipermail/openbsc/2017-April/thread.html#10522
--
To view, visit https://gerrit.osmocom.org/3912
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 2:
(1 comment)
What tests are adjusted?
https://gerrit.osmocom.org/#/c/3912/2/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:
Line 305: static void assign_uplink_tbf_usf(struct gprs_rlcmac_pdch *pdch,
struct gprs_rlcmac_ul_tbf *tbf, uint8_t tfi, int8_t usf)
Did we
Patch Set 9: Code-Review-1
Looks like a lot of churn in this iteration. Especially as we have trx->bts in
many places. For moving UL/DL TBF into the trx. What corner cases do you
expect? How do you solve them? Is there a high level approach for this branch?
E.g. how to make sure that UL and
Review at https://gerrit.osmocom.org/3977
gbproxy: check peer allocation result
gbproxy_peer_alloc() could return NULL which wasn't checked. Fix it and
add corresponding error log. While at it, also format log messages
consistently.
Change-Id: Ib10c954e17a479baef31ded54370b35938e00018
---
M
Review at https://gerrit.osmocom.org/3975
osmodumpdoc: print called commands and OSError messages
Change-Id: Ib044cbb8a1b8e02cbe6852f785c75b5c7aae6174
---
M osmopy/osmodumpdoc.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests
Review at https://gerrit.osmocom.org/3974
osmodumpdoc: fix finding cfg when not calling from source tree
When the binary has not been built in the source tree, it was impossible to
call osmodumpdoc.py despite the -p option. Look for config files
in that config-path.
Change-Id:
Max has submitted this change and it was merged.
Change subject: Expand bit pretty-printer
..
Expand bit pretty-printer
Add OSMO_BIT_PRINT_EX() which is like OSMO_BIT_PRINT() but allows to
specify character to be printed for
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3973
to look at the new patch set (#2).
Remove bogus error message
* mark 'release' target as virtual (not tied to a presence of a certain
file)
* silence bumpversion test
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3971
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9454698976bdba3b1e0498a81bad9855eee45e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3972
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a88cdcbf76ea28a30e82836030f894c2152d5ed
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3973/1//COMMIT_MSG
Commit Message:
Line 9: * mark 'release' target as virtual (not tight to a presence of a certain
tied
--
To view, visit https://gerrit.osmocom.org/3973
To unsubscribe, visit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3915
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72528bc1e376134c5a7b6e7a50c48e38c3f48b0a
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3973
Remove bogus error message
* mark 'release' target as virtual (not tight to a presence of a certain
file)
* silence bumpversion test warning outside of release target
Change-Id: Ia6ab79fe2f6b502ea223aa72e929dd3c75f34b5c
Related: OS#1861
---
M
53 matches
Mail list logo
