Patch Set 2:
I'm sure the FORCE was added intentionally at the time, as some rebuilds didn't
catch all changes. are we sure that we track all dependencies properly now?
--
To view, visit https://gerrit.osmocom.org/3985
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageTy
Patch Set 2:
we should only merge this after the libosmocore patch is merged to master.
--
To view, visit https://gerrit.osmocom.org/3986
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48edb65be94be56c4b57293d8edc1b30271acc12
Gerrit-Pat
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3984
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf8e18ce2f1dac61bf55019e1fec601b33abb95
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3983
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1068d665b91faf1faa1b295503fcdc33f4ac500a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3974
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5427d354c289ec4602411c7059c8d80e2b451f7c
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Gerrit-Branc
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib044cbb8a1b8e02cbe6852f785c75b5c7aae6174
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Gerrit-Branc
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3976
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie39316f0b51ee518b9dce8d5f98b53f748db573b
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Gerrit-Branc
Harald Welte has submitted this change and it was merged.
Change subject: Introduce contrib/jenkins.sh to align with other projects
..
Introduce contrib/jenkins.sh to align with other projects
This change will make jenkins' inl
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/3989
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I517e1be8b5680c3cc274fd5ad13ac7c920154e7f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-tetra
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3995
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9bcf58b655fbd85e196f363fb7d8305d7dfc997
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3993
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia58c16d995f6751bdd69defe8a46665aee163f3d
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3978
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib07fb9d9106e19f5be6539493e82b5d5991f8bc2
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 5: Code-Review+1
I like the idea, but why not simply add the "name" attribute in addtion to the
existing "node-id" attribute? This way the old 'vty-additions.xml' would still
work, while we could write new ones referring to the names? In any case, if
that adds extra work for some r
Patch Set 4: Code-Review+2
just to be clear: This just moves code between files and adjust
whitepsace/formatting, but there are no API/implementation changes? if yes, +2.
"refactoring" can mean many things, that's why I'm asking.
--
To view, visit https://gerrit.osmocom.org/4006
To unsubscri
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4007
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc80f06b2811cc32fe38518b11efd6764b347ee
Gerrit-PatchSet: 4
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Patch Set 4:
(20 comments)
https://gerrit.osmocom.org/#/c/4003/4/include/osmocom/mgcp/mgcp.h
File include/osmocom/mgcp/mgcp.h:
Line 37: #define RTP_PORT_DEFAULT_RANGE_END RTP_PORT_DEFAULT_RANGE_START + 10
why do we have a default range end of only 10 ports higher than the start port?
given th
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4002
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf54481754a1765bdb2d0d7033bc0d7dc2018024
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/4001/1//COMMIT_MSG
Commit Message:
Line 7: debian: tweak .install: less wildcards
I can see that you're removin wildcards. what I cannot see from the code is
why. So that "why" should be stated in the commit log. thanks!
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3999
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d81853f811f412b186621c3657bab6af397a980
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4000
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4edf786fde085f612f8a04972c55175a080ac65f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4003
to look at the new patch set (#4).
Initially implement the new osmo-mgw and libosmo-mgcp
Leave the old osmo-bsc_mgcp and libosmo-legacy-mgcp as it is; on a copy thereof
(added by a prev
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4003
to look at the new patch set (#3).
Initially implement the new osmo-mgw and libosmo-mgcp
Leave the old osmo-bsc_mgcp and libosmo-legacy-mgcp as it is; on a copy thereof
(added by a prev
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3997
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I266b129788b2caaec0f345f80a2c5eab0172bf97
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix osmo-stp.cfg: accept-asp-connections must be a child of
listen m3ua
..
fix osmo-stp.cfg: accept-asp-connections must be a child of listen m3ua
Chan
Neels Hofmeyr has abandoned this change.
Change subject: libosmo-mgcp-client: move dep from legacy to libosmo-mgcp
..
Abandoned
squashed with G#4005 to avoid intermediate build problems
--
To view, visit https://gerrit.osmoco
libosmo-mgcp-client: make independent of other mgcp libs
Remove the shared mgcp_common.c file and hence erase all conflicts in case both
libosmo-mgcp-client and libosmo-mgcp were linked.
Move the few remaining common definitions to new header
. The content of this header is now the only bit
shar
Initially implement the new osmo-mgw and libosmo-mgcp
Leave the old osmo-bsc_mgcp and libosmo-legacy-mgcp as it is; on a copy thereof
(added by a previous commit), apply changes to initially implement the new
osmo-mgw.
Adjust build system and debian packaging to accomodate the new libosmo-mgcp a
Review at https://gerrit.osmocom.org/4007
mgcp_test: tweak test failure output
Change-Id: Ibfc80f06b2811cc32fe38518b11efd6764b347ee
---
M tests/legacy_mgcp/mgcp_test.c
M tests/mgcp/mgcp_test.c
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw
Review at https://gerrit.osmocom.org/4006
sdp: refactoring sdp parser/generator
fix sourcecode formatting
move SDP generator to mgcp_sdp.c
add doxygen comments
Change-Id: I9f88c93872ff913bc211f560b26901267f577324
---
M include/osmocom/mgcp/Makefile.am
M include/osmocom/mgcp/mgcp_internal.h
A
Review at https://gerrit.osmocom.org/4003
Initially implement the new osmo-mgw and libosmo-mgcp
Leave the old osmo-bsc_mgcp and libosmo-legacy-mgcp as it is; on a copy thereof
(added by a previous commit), apply changes to initially implement the new
osmo-mgw.
Adjust build system and debian pa
Review at https://gerrit.osmocom.org/4004
libosmo-mgcp-client: move dep from legacy to libosmo-mgcp
A subsequent patch will drop the interdependency, but first completely forget
about libosmo-legacy-mgcp and depend on libosmo-mgcp instead.
Change-Id: Ie1f05948f36bf5148b58256312214de262bdf762
-
Review at https://gerrit.osmocom.org/4005
drop all cross-builts between libosmo-mgcp-client and libosmo-mgcp
Remove the shared mgcp_common.c file and hence erase all conflicts in case both
libosmo-mgcp-client and libosmo-mgcp were linked.
Move the few remaining common definitions to new header
Review at https://gerrit.osmocom.org/4000
tweak API version comments
Clarify LIBVERSION comments in TODO-RELEASE and reference Makefile.am comments
to look there.
Change-Id: I4edf786fde085f612f8a04972c55175a080ac65f
---
M TODO-RELEASE
M src/libosmo-legacy-mgcp/Makefile.am
M src/libosmo-mgcp-cl
Review at https://gerrit.osmocom.org/4002
create libosmo-mgcp and osmo-mgw by copying legacy code
This a cosmetic commit, copying libosmo-legacy-mgcp to libosmo-mgcp and
osmo-bsc_mgcp to osmo-mgw 1:1 at first, to provide a basis for next patches
that highlight the changes from legacy to new cod
Review at https://gerrit.osmocom.org/3999
set API versions back to 0
Roll back the LIBVERSIONs to 0:0:0 -- the bumps so far have been confused and
wrong. Let's start over from scratch with API-current of 0 while we still can.
Rename the mgcp_client debian .install files back to 0 to match the
Review at https://gerrit.osmocom.org/4001
debian: tweak .install: less wildcards
Change-Id: I6a3f3b9efa08eb9c5cdca3e02f8fab4a96c28ad5
---
M debian/libosmo-legacy-mgcp-dev.install
M debian/libosmo-legacy-mgcp0.install
M debian/libosmo-mgcp-client0.install
3 files changed, 5 insertions(+), 5 dele
Patch Set 5:
> Where is the recursion?
For example: set_flag_chars(set_flag_chars(set_flag_chars(slot_info,
> snprintf in call sites is not really an improvement
Why? What's bad about it?
> Method is called print while it is a format
Just like sprintf(). Anyway, renamed it. Too bad we can't
Max has abandoned this change.
Change subject: Simplify TS alloc: cosmetic, use proper formatting
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3914
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3913
to look at the new patch set (#5).
Simplify TS alloc: split off RX mask computation
Move computation of RX mask into separate function and document it. This
allows to significantly shri
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3934
to look at the new patch set (#3).
Simplify TS alloc: separate capacity computation
Move TRX capacity computation into separate function and document it.
Change-Id: Ifd88
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3920
to look at the new patch set (#4).
Simplify TS alloc: use defines for constant
* define and use constant for occupied TFI instead copying the same
magic
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3905
to look at the new patch set (#7).
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL timeslot as
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#5).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3935
to look at the new patch set (#3).
Simplify TS alloc: move slot check into functions
Move timeslot applicability check outside of nested for loop into
separate functions and document th
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3912
to look at the new patch set (#4).
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify functi
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3979
to look at the new patch set (#5).
vty: derive node name from prompt, use as XML ids
The 'show online-help' produces XML output with ids. We
reference those from the
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3979
to look at the new patch set (#4).
vty: derive node name from prompt, use as XML ids
The 'show online-help' produces XML output with ids. We
reference those from the
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3979/3/src/vty/command.c
File src/vty/command.c:
Line 158: if (!*node->name)
> node->name is a char[], and if it is unset, it starts with 0 as from struct
(Note that if the user set a name during struct composition, we don't do the
Patch Set 3:
(2 comments)
re "you don't mention duplicate avoidance" -- is that asking to improve the
commit log? agreed.
https://gerrit.osmocom.org/#/c/3979/3/src/vty/command.c
File src/vty/command.c:
Line 158: if (!*node->name)
> use node->name[0]? But why derive it from the prompt? I
Patch Set 2:
> Anyway I would favor using the node name as in the other patch,
> because it makes writing osmo-gsm-manuals vty references much
> easier for humans: instead of we can do id='config-smpp'>
agreed and hence the +2
--
To view, visit https://gerrit.osmocom.org/3978
To unsubscrib
Patch Set 2:
> Okay makes sense. But is cnode->node unique it seems to be solely
> external defined but then it might be more stable?
The node ID is what we use to enter VTY nodes, and it is required to be unique
within a given main() program. We do this:
enum bsc_vty_node {
G
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3912
to look at the new patch set (#3).
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify functi
Review at https://gerrit.osmocom.org/3998
vty: install 'exit', 'end',... commands on *all* nodes
In many callers of the VTY API, we are lacking the vty_install_default() step
at certain node levels. This creates nodes that lack the 'exit' command, and
hence the only way to exit such a node is t
Review at https://gerrit.osmocom.org/3997
fix osmo-stp.cfg: accept-asp-connections must be a child of listen m3ua
Change-Id: I266b129788b2caaec0f345f80a2c5eab0172bf97
---
M src/osmo_gsm_tester/templates/osmo-stp.cfg.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.os
54 matches
Mail list logo
