Patch Set 2:
Of course I did: I've built libosmocore's .deb with the patch included,
installed it, used "make release" in osmo-bts and libosmo-abis, verified that
the commit/tag are generated properly.
--
To view, visit https://gerrit.osmocom.org/4127
To unsubscribe, visit https://gerrit.osmo
Patch Set 2: Code-Review+2 Verified+1
> Of course I did
great. I just wanted to make sure as I didn't give it a lot of testing before.
--
To view, visit https://gerrit.osmocom.org/4127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98
Harald Welte has submitted this change and it was merged.
Change subject: Fixup severe build performance issues
..
Fixup severe build performance issues
Make variable substitution calling bumpversion and other commands
introduc
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/4140
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c362cde7afd6de025e8fe2c1e9abe3d3a1e04a6
Gerrit-PatchSet: 1
Gerrit-Project: openpcd
Gerrit-Branch: mas
Harald Welte has submitted this change and it was merged.
Change subject: firmware: Makefiles: enable changing toolchain
..
firmware: Makefiles: enable changing toolchain
Without that the user was expected to either patch
the M
Patch Set 2: Code-Review-2
> I've tried to implement this comparison and got really weird
> results:
> I might be missing smth but home come lsb in a byte can be more
> than 8? Could it be that using negation on unsigned type somehow
> confused gcc? Or some sort of template optimization magi
Patch Set 1:
(6 comments)
Assuming these tables are correctly copy and pasted. What is the minimal
dependency to get this in? Which patch removes the <= 32 assumption?
tests/alloc/AllocTest.cpp requires updates to use/test the new classes as well.
The commit message needs some work. You are n
Review at https://gerrit.osmocom.org/4141
Add osmo-iuh to nightly .deb builds
It produces libosmo-ranap-dev which is required by osmo-sgsn.
Change-Id: Ief40137cc94e2c54da8c12e2a00953834a578171
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pul
Patch Set 5:
(4 comments)
https://gerrit.osmocom.org/#/c/3920/5//COMMIT_MSG
Commit Message:
Line 10: magic number all over the place
Okay. What I would have liked to have in the commit message is the discussion
of int vs. unsigned long in used types. Why is this change correct?
Line 11: *
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4091
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id82a12bbfb72b421c75140072048a963fb50f684
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4087
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If36b86a6a542af7381d9a07da51a330f2e44a96f
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4092
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6018ef78ff18f2e6809fee957c9d645e35c7c9a
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4096
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c2d6b5dd8dfd8a0b462d87e93e0733e57f7b0a
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4088
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80eea9ac888ab4b13614ff475bebacb94b72b0f2
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4089
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib45238e95156f215412d51d975b1acb33633a3e1
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4094
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d6dccad2336b83f4b4e89769b0796d1c87ed94
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4090
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f27661d9e5241efe7725b7d1efcf4aef55e2efe
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4095
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e35660598bfd87917728c521c1fba827e98d68
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4099
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06c529c01a72e16aa20a2c7a20e8b043718edab3
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4093
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50d990b06c56c3bfa71e7268694702300c0c9a26
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4101
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4098
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68715d1970fde83fd6647344b82c6a859404ef9e
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libosmo-sccp: Install cfg and service file for osmo-stp
..
libosmo-sccp: Install cfg and service file for osmo-stp
Patch with systemd service file is
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libosmo-sccp: Attempt to fix link issue on 201705-nightly builds
..
libosmo-sccp: Attempt to fix link issue on 201705-nightly builds
This project wil
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-iuh: Introduce recipe
..
osmo-iuh: Introduce recipe
Change-Id: I33d6dccad2336b83f4b4e89769b0796d1c87ed94
---
A recipes-osmocom/osmo-iuh/osmo-iuh
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-mgw: Introduce recipe
..
osmo-mgw: Introduce recipe
Change-Id: If9c2d6b5dd8dfd8a0b462d87e93e0733e57f7b0a
---
A recipes-osmocom/osmo-mgw/osmo-mgw
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-sgsn: Introduce recipe
..
osmo-sgsn: Introduce recipe
Change-Id: Ia7e35660598bfd87917728c521c1fba827e98d68
---
A recipes-osmocom/osmo-sgsn/osmo-
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-hlr: Introduce recipe
..
osmo-hlr: Introduce recipe
Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
---
A recipes-osmocom/osmo-hlr/osmo-hlr
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
..
osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Those two binaries are current
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libasn1c: Introduce recipe
..
libasn1c: Introduce recipe
Change-Id: I50d990b06c56c3bfa71e7268694702300c0c9a26
---
A recipes-osmocom/libasn1c/libasn1c
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-bsc: Introduce recipe
..
osmo-bsc: Introduce recipe
This recipe provides osmo-bsc package from new osmo-bsc.git repository,
and replaces old osm
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: update PV versions for libosmocore, libosmo-sccp and openggsn
..
update PV versions for libosmocore, libosmo-sccp and openggsn
As we're building git
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Update osmocom versions to point to current master
..
Update osmocom versions to point to current master
New versions are required in order to build
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-msc: Introduce recipe
..
osmo-msc: Introduce recipe
Change-Id: I68715d1970fde83fd6647344b82c6a859404ef9e
---
A recipes-osmocom/osmo-msc/osmo-msc
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Fix typo with DESCRIPTION var in several recipes
..
Fix typo with DESCRIPTION var in several recipes
Change-Id: I2637afdb1c868a1f9b54dcbbe55b1a1ee751
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4100
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd029cbd36417ee980bff51b4112705be16175d3
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/4109
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2637afdb1c868a1f9b54dcbbe55b1a1ee7519d14
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: openbsc: Drop packages present in other recipes after split
..
openbsc: Drop packages present in other recipes after split
The osmo-bsc one is rename
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libosmo-abis: modify PV to match recent release
..
libosmo-abis: modify PV to match recent release
The upstream release commit is 7f17b8c45d094941292
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/4097
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Drop openggsn and introduce osmo-ggsn
..
Drop openggsn and introduce osmo-ggsn
Take the opportunity to enable systemd service instead of sysvint like
Review at https://gerrit.osmocom.org/4142
add ';' after OSMO_ASSERT()
Currently, OSMO_ASSERT() is defined such that it ends in a semicolon, hence an
added ';' is redundant. However, the usual way this kind of macro should be
defined is
#define OSMO_ASSERT(x) do { ... } while(0)
so that the
Review at https://gerrit.osmocom.org/4143
add ';' after OSMO_ASSERT()
Currently, OSMO_ASSERT() is defined such that it ends in a semicolon, hence an
added ';' is redundant. However, the usual way this kind of macro should be
defined is
#define OSMO_ASSERT(x) do { ... } while(0)
so that the
Review at https://gerrit.osmocom.org/4144
add osmo_imsi_str_valid() and osmo_msisdn_str_valid()
Add GSM23003_IMSI_MIN_DIGITS definition.
Add regression test gsm23003_test.c to test the two new functions.
Will be used by OsmoHLR to validate VTY and CTRL input.
Change-Id: I1e94f5b0717b947d2a7a7
Review at https://gerrit.osmocom.org/4145
modem: reset cancellable after cancelling dbus methods
I first wanted to use "reset" method, but according to [1]:
"The recommended practice is to drop the reference to a
cancellable after cancelling it, and let it die with the outstanding
async operati
Review at https://gerrit.osmocom.org/4146
client: add unified function to generate MGCP messages
currently the only way to generate MGCP messages is to use
mgcp_msg_crcx(), mgcp_msg_mdcx() and mgcp_msg_dlcx(). All
three function take a fixed set of parameters via their
parameter list. There is
Review at https://gerrit.osmocom.org/4147
client: add ip address parsing to the client
Some MGCP messages (CRCX, MDCX) return IP-Addresses. Make use of
this information.
Change-Id: I44b338b09de45e1675cedf9737fa72dde72e979a
---
M include/osmocom/mgcp_client/mgcp_client.h
M src/libosmo-mgcp-clie
Patch Set 3:
> > I got an error about missing QEMU when running make check without
> > our LC15 toolchain built from Yocto framework.
>
> I suspect you're still doing a cross-compile, i.e. the
> './configure' was executed with the environment for your
> cross-toolchain?
>
> > Any suggest
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4144
to look at the new patch set (#2).
add osmo_imsi_str_valid() and osmo_msisdn_str_valid()
Add GSM23003_IMSI_MIN_DIGITS definition.
Add regression test gsm23003_test.c to test the two new
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4055
to look at the new patch set (#2).
drop code dup between libosmo-mgcp-client and libosmo-mgcp
Remove mgcp_common.c and replace with mgcp_common.h.
Move mgcp_common.h from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4144
to look at the new patch set (#3).
add osmo_imsi_str_valid() and osmo_msisdn_str_valid()
Add GSM23003_IMSI_MIN_DIGITS definition.
Add regression test gsm23003_test.c to test the two new
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4144
to look at the new patch set (#4).
add osmo_imsi_str_valid() and osmo_msisdn_str_valid()
Add GSM23003_IMSI_MIN_DIGITS definition.
Add regression test gsm23003_test.c to test the two new
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4144
to look at the new patch set (#5).
add osmo_imsi_str_valid() and osmo_msisdn_str_valid()
Add GSM23003_IMSI_MIN_DIGITS definition.
Add regression test gsm23003_test.c to test the two new
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/1526
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0241b814ea4c4ce1458f7ad76e31d390383c2048
Gerrit-PatchSet: 8
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4143
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic79c8b8f98a7f3bef761751d55a7e6125cf2c46d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4144
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e94f5b0717b947d2a7a7d36bacdf04a75cb3522
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6dce81faee9177737a6e1b572a871aaf7e37138
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4147/1/include/osmocom/mgcp_client/mgcp_client.h
File include/osmocom/mgcp_client/mgcp_client.h:
Line 39:uint32_t audio_ip;
I think for years in most places in osmocom code, we started to represent IP
addresses as "char *host" ins
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/4146/1/include/osmocom/mgcp_client/mgcp_client.h
File include/osmocom/mgcp_client/mgcp_client.h:
PS1, Line 49: MSG_T
msg_t typically referst to "message type", which it isn't. What about
MGCP_MSG_PRES_... ? or MGCP_MGS_PAR_... ?
https
Patch Set 1:
this will not work and will acutally break the build (further) unless you
create the respective osmo-iuh package in OBS.
https://build.opensuse.org/project/show/network:osmocom:nightly doesn't list
it. You need to "copypac" it.
--
To view, visit https://gerrit.osmocom.org/4141
Patch Set 1: Code-Review+2
> this will not work and will acutally break the build (further)
> unless you create the respective osmo-iuh package in OBS.
> https://build.opensuse.org/project/show/network:osmocom:nightly
> doesn't list it. You need to "copypac" it.
> this will not work and wi
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/4141
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief40137cc94e2c54da8c12e2a00953834a578171
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Own
Harald Welte has submitted this change and it was merged.
Change subject: Add osmo-iuh to nightly .deb builds
..
Add osmo-iuh to nightly .deb builds
It produces libosmo-ranap-dev which is required by osmo-sgsn.
Change-Id: Ief4
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of buil
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Review at https://gerrit.osmocom.org/4148
osmocom-nightly-packages.sh: Add libasn1c required by osmo-iuh
Change-Id: Ia455655eaf53faeab6c3049a54c153cb9ddd3d37
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osm
Review at https://gerrit.osmocom.org/4149
osmocom:nitb-split:nightly Re-introduce osmo-sgsn + osmo-ggsn
For some strange reason, in commit
8e9fe0808072d3f5eca8b4c6fac9865a52c9beb3, the osmocom:nitb-split:nightly
package feed was rendered to use old packages for sgsn+ggsn, rather than
current on
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/4149
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c091127d92a4b4beb7355e16abd9788fa3b9fe5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: mas
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/4148
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia455655eaf53faeab6c3049a54c153cb9ddd3d37
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: mas
Harald Welte has submitted this change and it was merged.
Change subject: osmocom:nitb-split:nightly Re-introduce osmo-sgsn + osmo-ggsn
..
osmocom:nitb-split:nightly Re-introduce osmo-sgsn + osmo-ggsn
For some strange reason, i
Harald Welte has submitted this change and it was merged.
Change subject: osmocom-nightly-packages.sh: Add libasn1c required by osmo-iuh
..
osmocom-nightly-packages.sh: Add libasn1c required by osmo-iuh
Change-Id: Ia455655eaf53
71 matches
Mail list logo
