Harald Welte has submitted this change and it was merged.
Change subject: create_context_ind(): Fix crash on apn not found
..
create_context_ind(): Fix crash on apn not found
Program terminated with signal SIGSEGV,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4228
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4ec74e87aaf1d067dd1717d986673be56c4d6ed
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 6: Code-Review-1
(4 comments)
-1 for space-indent, the rest is for you to reflect on.
https://gerrit.osmocom.org/#/c/4147/6/include/osmocom/mgcp_client/mgcp_client.h
File include/osmocom/mgcp_client/mgcp_client.h:
Line 39: char audio_ip[INET_ADDRSTRLEN];
indent by tab,
Patch Set 5: Code-Review-1
(12 comments)
-1 for mem leaks and missing rc eval. The rest is up to you to reflect on.
https://gerrit.osmocom.org/#/c/4146/5//COMMIT_MSG
Commit Message:
Line 22: Change-Id I15e1af68616309555d0ed9ac5da027c9833d42e3
(I usually do it as
Depends: libosmocore
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4228
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4ec74e87aaf1d067dd1717d986673be56c4d6ed
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/4227/1//COMMIT_MSG
Commit Message:
Line 14: id is supplied with the DLCX command.
is a missing call id compliant with MGCP?
https://gerrit.osmocom.org/#/c/4227/1/src/libosmo-mgcp/mgcp_protocol.c
File
Neels Hofmeyr has submitted this change and it was merged.
Change subject: refactor db_subscr_lu()
..
refactor db_subscr_lu()
Use named parameters in the SQL statement.
Use db_bind_* functions to drop some code dup.
Use
Neels Hofmeyr has submitted this change and it was merged.
Change subject: code undup: use db_bind_text() in db_get_auth_data()
..
code undup: use db_bind_text() in db_get_auth_data()
To make the db_bind_text() error reporting
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: don't log about missing SQLite log cb
..
cosmetic: don't log about missing SQLite log cb
SQLite3 seems to be commonly compiled without log
Neels Hofmeyr has submitted this change and it was merged.
Change subject: db: use int64_t as subscriber id
..
db: use int64_t as subscriber id
The SQLite db does not support uint64_t, and we are always binding the uint64_t
id
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add db_subscr_update_aud_by_id(), complete
db_subscr_delete_by_id()
..
add db_subscr_update_aud_by_id(), complete db_subscr_delete_by_id()
Add ability
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add db_subscr_get_by_msisdn() and db_subscr_get_by_id()
..
add db_subscr_get_by_msisdn() and db_subscr_get_by_id()
Factor out the selected SQL columns
Neels Hofmeyr has submitted this change and it was merged.
Change subject: refactor db_subscr_ps() to db_subscr_nam()
..
refactor db_subscr_ps() to db_subscr_nam()
Allow to set nam_ps and nam_cs from this same function, by
Neels Hofmeyr has submitted this change and it was merged.
Change subject: code undup: use db_remove_reset() in db_auc.c
..
code undup: use db_remove_reset() in db_auc.c
Change-Id: I32d728e2b8a9771421c097647aa0e060e29a601f
---
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add initial db_test: creating and deleting subscribers
..
add initial db_test: creating and deleting subscribers
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: less noise: simplify db_remove_reset()
..
less noise: simplify db_remove_reset()
db_remove_reset() needs to be called after each stmt run, whether it
Neels Hofmeyr has submitted this change and it was merged.
Change subject: refactor db_subscr_purge
..
refactor db_subscr_purge
Use named parameters in the SQL statements.
Use db_bind_* functions to drop some code dup.
Adopt
Neels Hofmeyr has submitted this change and it was merged.
Change subject: refactor db_get_auth_data return val
..
refactor db_get_auth_data return val
Adopt the error handling of the other db functions: return -ENOENT on
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add db_bind_int() and db_bind_int64()
..
add db_bind_int() and db_bind_int64()
Will be used in upcoming patches, e.g. change-IDs
-
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix db_update_sqn(): reset stmt in all error cases
..
fix db_update_sqn(): reset stmt in all error cases
Use the common db_bind_int64() so that the
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add db_subscr_create(), db_subscr_delete(),
db_subscr_update_msisdn_by_imsi()
..
add db_subscr_create(), db_subscr_delete(),
Patch Set 3: Code-Review+2
re-add previous +2, lost from trivial fix (drop duplicate print of sgsn_address)
--
To view, visit https://gerrit.osmocom.org/4178
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Neels Hofmeyr has abandoned this change.
Change subject: db_test: fix typo: drop double-print of sgsn_address
..
Abandoned
squashed into initial db_test patch
--
To view, visit https://gerrit.osmocom.org/4229
To unsubscribe,
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4180
to look at the new patch set (#3).
db: use int64_t as subscriber id
The SQLite db does not support uint64_t, and we are always binding the uint64_t
id actually as signed
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4186
to look at the new patch set (#3).
refactor db_get_auth_data return val
Adopt the error handling of the other db functions: return -ENOENT on unknown
subscriber and -EIO
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4182
to look at the new patch set (#3).
refactor db_subscr_ps() to db_subscr_nam()
Allow to set nam_ps and nam_cs from this same function, by adding the is_ps
arg.
Combine
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4178
to look at the new patch set (#3).
add initial db_test: creating and deleting subscribers
Change-Id: I2a0d277f55162bf5ceb0fc7d50390f2994daed71
---
M configure.ac
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4184
to look at the new patch set (#3).
refactor db_subscr_purge
Use named parameters in the SQL statements.
Use db_bind_* functions to drop some code dup.
Adopt error
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4183
to look at the new patch set (#3).
refactor db_subscr_lu()
Use named parameters in the SQL statement.
Use db_bind_* functions to drop some code dup.
Use explicit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4189
to look at the new patch set (#4).
code undup: use db_bind_text() in db_get_auth_data()
To make the db_bind_text() error reporting mention "imsi", change the
fix db_subscr_get_by_*(): clear output data; test in db_test.c
db_subscr_get_by_*() failed to clear the out-param struct, meaning that data
could remain in a struct even though it is not present in the database. Always
zero out the struct before writing to it.
Adjust the db_test to catch this
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4185
to look at the new patch set (#4).
add db_subscr_update_aud_by_id(), complete db_subscr_delete_by_id()
Add ability to add and remove auc_2g and auc_3g table rows with
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4181
to look at the new patch set (#3).
add db_subscr_get_by_msisdn() and db_subscr_get_by_id()
Factor out the selected SQL columns as SEL_COLUMNS macro, so that each of the
Patch Set 6: Code-Review+2
re-add +2, lost due to rebase cosmetics
--
To view, visit https://gerrit.osmocom.org/4175
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78d75dc351eb587b0a022f82f147e9a31c0324c5
Gerrit-PatchSet: 6
Review at https://gerrit.osmocom.org/4229
db_test: fix typo: drop double-print of sgsn_address
Change-Id: Ia85a3a3b10ceed4bbcd10867d147355c99ccb715
---
M tests/db/db_test.c
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4175
to look at the new patch set (#6).
cosmetic: don't log about missing SQLite log cb
SQLite3 seems to be commonly compiled without log callback support. It is then
Review at https://gerrit.osmocom.org/4230
fix db_subscr_get_by_*(): clear output data; test in db_test.c
db_subscr_get_by_*() failed to clear the out-param struct, meaning that data
could remain in a struct even though it is not present in the database. Always
zero out the struct before
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: log: "SQLite" with capital L
..
cosmetic: log: "SQLite" with capital L
Change-Id: I43a6ea646f14cfea3a7cd4eb88237ada6d47f5f1
---
M src/db.c
1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: ctrl_test_runner.py: use proper constant as test db path
..
ctrl_test_runner.py: use proper constant as test db path
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: gitignore: tests/package.m4
..
gitignore: tests/package.m4
Change-Id: Ida4a61d4786d7db63dc59a641f44afb2ec2edd97
---
M .gitignore
1 file changed, 1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: db_hlr: SL3_TXT: clarify indenting
..
cosmetic: db_hlr: SL3_TXT: clarify indenting
Before, it looked like the nul term was within the if ()
Patch Set 1: Code-Review+2
(9 comments)
some more nitpicks...
https://gerrit.osmocom.org/#/c/4151/1/suites/aoip_debug/interactive.py
File suites/aoip_debug/interactive.py:
Line 26: cmd = prompt('Enter command: (q)uit (s)ms (g)et-registered
(w)ait-registered, call-list [], call-dial
,
Patch Set 1: Code-Review+2
(12 comments)
yay, I'm really glad that we finally feature a voice test!
And I didn't even raise a finger for it :)
I have a few questions and some hints to tighten, but I'll leave it up to you,
it's already good enough to be merged.
Review at https://gerrit.osmocom.org/4228
create_context_ind(): Fix crash on apn not found
Program terminated with signal SIGSEGV, Segmentation fault.
0 create_context_ind (pdp=0xb6b391b0 )
at
/usr/src/debug/osmo-ggsn/1.0.0+gitrAUTOINC+ab5e160937-r0/git/ggsn/ggsn.c:453
453
Review at https://gerrit.osmocom.org/4227
protocol: allow wildcarded DLCX
In many cases it is simpler to instruct the mgcp-gw to drop all
connections at once instead of removing each connection
individually.
drop all connections and release the endpoint in when no connection
id is supplied
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4146
to look at the new patch set (#5).
client: add unified function to generate MGCP messages
currently the only way to generate MGCP messages is to use
mgcp_msg_crcx(),
Max has submitted this change and it was merged.
Change subject: sysmo: don't override clock source with defaults
..
sysmo: don't override clock source with defaults
Previously clock source configured via vty was ignored.
Patch Set 2:
(1 comment)
The .gitignore entry was added automatically via Emacs' magit. I can adjust it
manually if necessary although it works as it is.
https://gerrit.osmocom.org/#/c/4222/2/.gitignore
File .gitignore:
Line 75: /tests/power/power_test
> leading '/'? really? it's highly
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4223
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5e65e23e62442ef8758ecbcf8e7820b4f15d7b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/4222/2/.gitignore
File .gitignore:
Line 75: /tests/power/power_test
leading '/'? really? it's highly uncommon. does it work?
--
To view, visit https://gerrit.osmocom.org/4222
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4224
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c809d48f29ef8e8c50641f882d7a954dfcf88f9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8de74a12d2096971a8a83946dc6c7cdb9889acd7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4226
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcfbf36746cf988afb2e55741b4a3e1eda70194b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/4226
cosmetic: avoid direct state assignment
Use oml_mo_state_init() for Abis reset instead of explicit state
assignment.
Change-Id: Idcfbf36746cf988afb2e55741b4a3e1eda70194b
---
M src/common/gsm_data_shared.c
1 file changed, 2 insertions(+), 2
Review at https://gerrit.osmocom.org/4225
sysmo: don't override clock source with defaults
Previously clock source configured via vty was ignored. Check that it
wasn't configured and only apply default value in that case.
Change-Id: I8de74a12d2096971a8a83946dc6c7cdb9889acd7
Fixes: OS#1944
---
Review at https://gerrit.osmocom.org/4224
sysmo: use clock calibration source wrapper
Make get_clk_cal() public and use it for ctrl commands handling. This
ensures that the calibration is properly selected depending on the clock
source.
Change-Id: I1c809d48f29ef8e8c50641f882d7a954dfcf88f9
Move power loop to generic tests
There's nothing sysmobts specific in this test so let's move it into
separate directory and run unconditionally. The test itself is unaltered
except for intro text.
Change-Id: I0d1957cd9cf5497826be095c7a42b7bb4fa10397
Related: OS#2223
---
M .gitignore
M
Review at https://gerrit.osmocom.org/4223
Make power test more verbose
Power control loop test outputs next to nothing which is not very
helpful. Make it more verbose. While at it, also move duplicated code
into static function to make test cases less cluttered.
Change-Id:
Review at https://gerrit.osmocom.org/4222
Move power loop to generic tests
There's nothing sysmobts specific in this test so let's move them into
separate directory and run unconditionally. The test itself is unaltered
except for intro text.
Change-Id:
Patch Set 2: Code-Review-1
(2 comments)
Please clarify further.
https://gerrit.osmocom.org/#/c/4200/2/tests/msgb/msgb_test.c
File tests/msgb/msgb_test.c:
Line 296:
Please add more test-cases: for example "msgb_printf(msg, "", 23, 0xfee,
"text");" and "msgb_printf(msg, "%d %s %c", "lol",
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4200
to look at the new patch set (#2).
add function msgb_printf() to print formatted text into msg buf
In ASCII string based protocols it a printf() version that prints
directly to
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4146
to look at the new patch set (#4).
client: add unified function to generate MGCP messages
currently the only way to generate MGCP messages is to use
mgcp_msg_crcx(),
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4006
to look at the new patch set (#6).
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to mgcp_sdp.c
move
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4211
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0684bc04b82ad57a1513bbd4627144d6c254b965
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4072
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef2eb99c517f25e7d1e71b985a3e0eb3879eb2c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4201
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I786df6b154c0668d2cefa0ea84d7dea336b0da1d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4198
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a56f83289e32a09643047f0e779c9de3e4b39a6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: build: make sure copied mgcp_common.h is removed on 'make clean'
..
build: make sure copied mgcp_common.h is removed on 'make clean'
I thought the
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4212
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11aca905350b2e3464fb526ec4d3ae6ffcf55114
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4215
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3af7b50e3d3e0ba3eddace0e6d4e58c6cb98b9aa
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log files when tests are failing
..
debian/rules: show testsuite.log files when tests are failing
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4216
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2d8576c5b15fe86419d1c21741f82d4d705bd60
Gerrit-PatchSet: 1
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4219
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice1c9f51225cef335626d5689ffb306395d7e2b6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4218
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0b10c02f87ed81878593198e21da1fc9f8d4bbc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4217
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I373b26c9d5eb32b1155e6405c6305ac870061887
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4221
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc6589d4ce95538baf3f30079a3af53cc218268
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4220
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I588ed7c7766a2e71284c9c7a3f3ce5a48561fe7f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4213/1/src/input/unixsocket.c
File src/input/unixsocket.c:
Line 235: strncpy(sock_path, line->sock_path, PATH_MAX - 1);
strncpy is not zero-terminating the buffer if it truncates. Pleaes consider
osmo_strlcpy
Patch Set 1:
we typically state the coverity CID that a patch fixes
--
To view, visit https://gerrit.osmocom.org/4213
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3ec741247d728232f8c07c94eb63f068597d80
Gerrit-PatchSet: 1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4214
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3322e3931612f2153797331b02f2789490e5e2b
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
88 matches
Mail list logo
