[PATCH] osmo-gsm-manuals[master]: refactor Makefile build rules, don't use the FORCE

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3985 to look at the new patch set (#5). refactor Makefile build rules, don't use the FORCE The initial goal was to make sure we don't have overall FORCE rules causing unnecessary rebuilds

[PATCH] osmo-gsm-manuals[master]: add OsmoHLR manual, OsmoHLR VTY reference

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4348 to look at the new patch set (#2). add OsmoHLR manual, OsmoHLR VTY reference Change-Id: Ieb6a362a26a7e65199f68f5cd32d9b6b0e5d0fbf --- M Makefile A OsmoHLR/Makefile A

[PATCH] osmo-gsm-manuals[master]: refactor Makefile build rules, don't use the FORCE

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3985 to look at the new patch set (#4). refactor Makefile build rules, don't use the FORCE The initial goal was to make sure we don't have overall FORCE rules causing unnecessary rebuilds

[PATCH] osmo-gsm-manuals[master]: refactor Makefile build rules, don't use the FORCE

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3985 to look at the new patch set (#3). refactor Makefile build rules, don't use the FORCE The initial goal was to make sure we don't have overall FORCE rules causing unnecessary rebuilds

[PATCH] osmo-gsm-manuals[master]: add OsmoHLR manual, OsmoHLR VTY reference

Review at https://gerrit.osmocom.org/4348 add OsmoHLR manual, OsmoHLR VTY reference Change-Id: Ieb6a362a26a7e65199f68f5cd32d9b6b0e5d0fbf --- M Makefile A OsmoHLR/Makefile A OsmoHLR/chapters/control.adoc A OsmoHLR/chapters/overview.adoc A OsmoHLR/chapters/running.adoc A

[PATCH] osmo-gsm-manuals[master]: common/vty: minor wording tweaks and typo fixes

Review at https://gerrit.osmocom.org/4347 common/vty: minor wording tweaks and typo fixes Change-Id: I5eb1ea0d3de883ff5e9742f77e7ef4be0482852d --- M common/chapters/vty.adoc 1 file changed, 40 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals

[PATCH] osmo-gsm-manuals[master]: common/vty: fix: CONFIG entered from ENABLE, not VIEW node

Review at https://gerrit.osmocom.org/4344 common/vty: fix: CONFIG entered from ENABLE, not VIEW node Change-Id: I892081f9452f8923441913f978a3be542a3c53d0 --- M common/chapters/vty.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals

[PATCH] osmo-gsm-manuals[master]: common/vty: explain difference between telnet and config file

Review at https://gerrit.osmocom.org/4346 common/vty: explain difference between telnet and config file - Mention that the CONFIG node is used to parse config files. - Mention that it is not well defined whether CONFIG node items have immediate effect. - Add a 'telnet' here and there to

[PATCH] osmo-gsm-manuals[master]: common/vty: "programs should not use the telnet VTY"

Review at https://gerrit.osmocom.org/4345 common/vty: "programs should not use the telnet VTY" Change-Id: Ic7e8c3663a2bfaf8dcb5752bf55ccb822b111c31 --- M common/chapters/vty.adoc 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals

osmo-hlr[master]: implement subscriber vty interface, tests

Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/4273/2/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: Line 34: #define hexdump_buf(buf) osmo_hexdump_nospc((void*)buf, sizeof(buf)) > what's tricky here is that it can only be used on a static buf[]. Having t I have instead renamed to

[PATCH] osmo-hlr[master]: ctrl: completely replace all CTRL commands

Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4311 to look at the new patch set (#3). ctrl: completely replace all CTRL commands The previous commands are not conforming to how the CTRL interface is intended to work: SET

[PATCH] osmo-hlr[master]: test_subscriber.ctrl: test against octal/hex interpretation ...

Review at https://gerrit.osmocom.org/4343 test_subscriber.ctrl: test against octal/hex interpretation of id Add a large enough subscriber id and add a test that ensures a leading zero is not interpreted as octal, and that a leading 0x is invalid and not interpreted as hexadecimal. Change-Id:

osmo-hlr[master]: ctrl: completely replace all CTRL commands

Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/4311/2/src/ctrl.c File src/ctrl.c: Line 156: /* not used yet */ > Erm, could you clarify? Who's using the other part of the same function? This is one large printf (to avoid reallocating string memory), in the first #if 0 are the format

[PATCH] libosmocore[master]: add osmo_talloc_asprintf() and ctrl_cmd_reply_printf()

Review at https://gerrit.osmocom.org/4340 add osmo_talloc_asprintf() and ctrl_cmd_reply_printf() Add macro to append to a CTRL commands' reply string, ctrl_cmd_reply_printf(). The talloc_asprintf() part of it is generic enough to qualify for a separate macro, osmo_talloc_asprintf(). The idea

osmo-sgsn[master]: deb: install .service files

Patch Set 2: > Why do you want to have both installed automatically? Because we have to support Debian 8 which does not have systemd. If both .init and .service are installed automatically than it works everywhere: debian 8 will ignore .service and systemd will automatically prefer .service

osmo-sgsn[master]: deb: install .service files

Patch Set 2: > That seems to be unnecessary complex. Placing symlinks into debian/ > means that both are installed automatically. This also means that > the same package will work on all .deb with and without systemd. > Adding ./configure options wouldn't mean we'll get read of manual >

osmo-sgsn[master]: deb: install .service files

Patch Set 2: That seems to be unnecessary complex. Placing symlinks into debian/ means that both are installed automatically. This also means that the same package will work on all .deb with and without systemd. Adding ./configure options wouldn't mean we'll get read of manual install in OE -

[PATCH] osmo-bsc[master]: mgcp: use osmo-mgw to switch RTP streams

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4334 to look at the new patch set (#3). mgcp: use osmo-mgw to switch RTP streams osmo-bsc currently negotiates the RTP stream directly with the BTS and reports back the RTP IP/Port on the

meta-telephony[201705]: osmo-sgsn: Add missing DEPENDS libosmo-sccp

Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4330 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f533bc18cab7883b076b532ef9656fb3f084f2 Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

osmo-bts[master]: osmo-bts-trx: vty: various fixes of 'write file' and doc

Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4314 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I018eaef40345bfa26e12eb7d09e83a52596c1000 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: osmo-bts-trx: vty: various fixes of 'write file' and doc

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4314 to look at the new patch set (#2). osmo-bts-trx: vty: various fixes of 'write file' and doc On 'write file': - Write 'osmotrx' before 'maxdly' and 'maxdlynb' (broken since "Introduce

[PATCH] osmo-bsc[master]: mgcp: use osmo-mgw to switch RTP streams

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4334 to look at the new patch set (#2). mgcp: use osmo-mgw to switch RTP streams osmo-bsc currently negotiates the RTP stream directly with the BTS and reports back the RTP IP/Port on the

[PATCH] libosmocore[master]: Expand bitvec_write_field()

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4292 to look at the new patch set (#4). Expand bitvec_write_field() Previously only boolean values were allowed while in practice it's sometimes necessary to use L/H. Allow user to specify

[PATCH] libosmocore[master]: Expand bitvec_write_field() function

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4292 to look at the new patch set (#3). Expand bitvec_write_field() function Previously only boolean values were allowed while in practice it's sometimes necessary to use L/H. Allow user to

[PATCH] libosmocore[master]: Add tests for bitvec_write_field()

Review at https://gerrit.osmocom.org/4336 Add tests for bitvec_write_field() This function is actively used by OsmoPCU but have not been covered by tests so far. The test code is based on Minh-Quang Nguyen submission with some modifications. Change-Id:

[PATCH] libosmocore[master]: Simplify bitvec_write_field()

Review at https://gerrit.osmocom.org/4339 Simplify bitvec_write_field() Use existing function instead of copy-pasted loop. Change-Id: I9fe27c06125ac52e02e63dcded056a5f1cf68f41 Related: OS#1526 --- M src/bitvec.c 1 file changed, 7 insertions(+), 9 deletions(-) git pull

[PATCH] libosmocore[master]: Deprecated bitvec_set_uint()

Review at https://gerrit.osmocom.org/4338 Deprecated bitvec_set_uint() Use bitvec_set_u64() directly. Change-Id: I2fd8d17f9fa6c51ef51f4294882cca5944d71df2 --- M include/osmocom/core/bitvec.h M src/bitcomp.c M src/bitvec.c M src/gsm/gsm_utils.c M tests/bits/bitcomp_test.c M

[PATCH] libosmocore[master]: Replace bitvec_set_uint() with bitvec_set_u64()

Review at https://gerrit.osmocom.org/4337 Replace bitvec_set_uint() with bitvec_set_u64() Old bitvec_set_uint() uses "unsigned int" as input parameter which length is not guaranteed. It does not allow to specify which bit_value to set and does not check for incorrect length. Overall this makes

[PATCH] libosmocore[master]: Expand bitvec_write_field() function

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4292 to look at the new patch set (#2). Expand bitvec_write_field() function Previously only boolean values were allowed while in practice it's sometimes necessary to use L/H. Allow user to

[PATCH] meta-telephony[201705]: osmo-sgsn: Enable iu support based on DISTRO_FEATURES

Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4332 to look at the new patch set (#2). osmo-sgsn: Enable iu support based on DISTRO_FEATURES Change-Id: Ifd8068d61aeea228dd24c54df6e1ce87bfcafff5 --- M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc

[PATCH] meta-telephony[201705]: osmo-iuh: Split into packages libosmo-ranap and osmo-hnbgw

osmo-iuh: Split into packages libosmo-ranap and osmo-hnbgw Change-Id: Ib924a5a05c378c59dd44aed5b5b5fe897604e86b --- M recipes-osmocom/osmo-iuh/osmo-iuh.inc 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/31/4331/2 diff

[PATCH] meta-telephony[201705]: osmo-ggsn: Update SRCREV to get ippool related fixes

Review at https://gerrit.osmocom.org/4335 osmo-ggsn: Update SRCREV to get ippool related fixes Change-Id: I631bb31b10657a8d3aa0fa40a37efdc693e98be0 --- M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 1 file changed, 1 insertion(+), 1 deletion(-) git pull

[PATCH] meta-telephony[201705]: osmo-sgsn: Add missing DEPENDS libosmo-sccp

Hello Max, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4330 to look at the new patch set (#2). osmo-sgsn: Add missing DEPENDS libosmo-sccp Needed as it uses libosmo-sigtran. Change-Id: I70f533bc18cab7883b076b532ef9656fb3f084f2 --- M

[PATCH] osmo-bsc[master]: mgcp: use osmo-mgw to switch RTP streams

Review at https://gerrit.osmocom.org/4334 mgcp: use osmo-mgw to switch RTP streams osmo-bsc currently negotiates the RTP stream directly with the BTS and reports back the RTP IP/Port on the BTS. This works fine for a single BTS, but for Handover the port/ip pointing to the MSC side must not

[MERGED] osmo-ggsn[master]: lib/ippool: Fix listsize calculated 1 elem too small

Pau Espin Pedrol has submitted this change and it was merged. Change subject: lib/ippool: Fix listsize calculated 1 elem too small .. lib/ippool: Fix listsize calculated 1 elem too small Take the chance this commit is changing

[MERGED] osmo-ggsn[master]: lib/in46a: Introduce in46a_netmasklen API

Pau Espin Pedrol has submitted this change and it was merged. Change subject: lib/in46a: Introduce in46a_netmasklen API .. lib/in46a: Introduce in46a_netmasklen API Change-Id: I06e3e038afd8f7afaec2a3fa67b1616500c8db80 --- M

[MERGED] osmo-ggsn[master]: tun: Convert tun_ipv6_linklocal_get to be more generic

Pau Espin Pedrol has submitted this change and it was merged. Change subject: tun: Convert tun_ipv6_linklocal_get to be more generic .. tun: Convert tun_ipv6_linklocal_get to be more generic Add support for IPv4 and IPv6

[MERGED] osmo-ggsn[master]: ippool: Implement and use blacklist instead of blindly using...

Pau Espin Pedrol has submitted this change and it was merged. Change subject: ippool: Implement and use blacklist instead of blindly using IPPOOL_NOGATEWAY .. ippool: Implement and use blacklist instead of blindly using

meta-telephony[201705]: osmo-sgsn: Add missing DEPENDS libosmo-sccp

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/4330/1/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc File recipes-osmocom/osmo-sgsn/osmo-sgsn.inc: Line 6: DEPENDS = "c-ares libpcap libosmocore libosmo-netif libosmo-sccp osmo-ggsn" > You not only add, you also remove. Thanks for pointing

[MERGED] libosmo-sccp[master]: Add doxygen docs

Max has submitted this change and it was merged. Change subject: Add doxygen docs .. Add doxygen docs Make sure doxygen generates library documentation by default (can be disabled at compile time). Change-Id:

osmo-ggsn[master]: ippool: Implement and use blacklist instead of blindly using...

Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4256 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e91f7280d60490c858a769dd578c1c8e54e9243 Gerrit-PatchSet: 6 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

libosmo-sccp[master]: Add doxygen docs

Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4234 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bf7438bcdde19dc88b9bc14c8ad9c8f49099f8a Gerrit-PatchSet: 5 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

osmo-mgw[master]: cosmetic: correct whitespaces

Patch Set 1: Code-Review+2 I would prefer us not to spend paid working time on this, but well. -- To view, visit https://gerrit.osmocom.org/4329 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22302ae8a48a2c776025a60267f5ef5af706e576

osmo-mgw[master]: cosmetic: fix commenting style

Patch Set 1: Code-Review+2 I would prefer us not to spend paid working time on this, but well. -- To view, visit https://gerrit.osmocom.org/4328 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib717d9dd3b17250ef4d6c67be0463a407cb83fbe

osmo-mgw[master]: cosmetic: fix coding style for mgcp_parse_sdp_data()

Patch Set 1: Code-Review+2 I would prefer us not to spend paid working time on this, but well. -- To view, visit https://gerrit.osmocom.org/4327 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dcf53ef8d3af5885b8b1f258d963949fa3ee93a

osmo-mgw[master]: sdp: refactoring sdp parser/generator

Patch Set 13: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/4006/13/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: Line 335: int mgcp_write_response_sdp(struct mgcp_endpoint *endp, not sure if endp and/or conn could be 'const' (read-only), but this is not really

osmo-mgw[master]: cosmetic: rename bts_codec to codec_str

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4326 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d4d5af8925d032155ca1ef8c7d7d2e496a60fb6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

meta-telephony[201705]: osmo-msc: Enable iu support based on DISTRO_FEATURES

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4333 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef50e96e80ef685748ddffa733ade84f5543eff Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: osmo-sgsn: Add missing DEPENDS libosmo-sccp

Patch Set 1: Code-Review-1 (1 comment) Please provide justification for both in commit message. https://gerrit.osmocom.org/#/c/4330/1/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc File recipes-osmocom/osmo-sgsn/osmo-sgsn.inc: Line 6: DEPENDS = "c-ares libpcap libosmocore libosmo-netif libosmo-sccp

meta-telephony[201705]: osmo-sgsn: Enable iu support based on DISTRO_FEATURES

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4332 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd8068d61aeea228dd24c54df6e1ce87bfcafff5 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

meta-telephony[201705]: osmo-iuh: Split into packages libosmo-ranap and osmo-hnbgw

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/4331/1/recipes-osmocom/osmo-iuh/osmo-iuh.inc File recipes-osmocom/osmo-iuh/osmo-iuh.inc: Line 22: SYSTEMD_SERVICE_osmo-stp = "osmo-hnbgw.service" this seems odd. why is osmo-stp getting an osmo-hnbgw.service? copy+paste error? -- To

meta-telephony[201705]: osmo-sgsn: Add missing DEPENDS libosmo-sccp

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4330 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f533bc18cab7883b076b532ef9656fb3f084f2 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705

[PATCH] meta-telephony[201705]: osmo-msc: Enable iu support based on DISTRO_FEATURES

Review at https://gerrit.osmocom.org/4333 osmo-msc: Enable iu support based on DISTRO_FEATURES Change-Id: Iaef50e96e80ef685748ddffa733ade84f5543eff --- M recipes-osmocom/osmo-msc/osmo-msc.inc 1 file changed, 5 insertions(+), 3 deletions(-) git pull

[PATCH] meta-telephony[201705]: osmo-iuh: Split into packages libosmo-ranap and osmo-hnbgw

Review at https://gerrit.osmocom.org/4331 osmo-iuh: Split into packages libosmo-ranap and osmo-hnbgw Change-Id: Ib924a5a05c378c59dd44aed5b5b5fe897604e86b --- M recipes-osmocom/osmo-iuh/osmo-iuh.inc 1 file changed, 16 insertions(+), 2 deletions(-) git pull

[PATCH] meta-telephony[201705]: osmo-sgsn: Add missing DEPENDS libosmo-sccp

Review at https://gerrit.osmocom.org/4330 osmo-sgsn: Add missing DEPENDS libosmo-sccp Needed as it uses libosmo-sigtran. Change-Id: I70f533bc18cab7883b076b532ef9656fb3f084f2 --- M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc 1 file changed, 2 insertions(+), 2 deletions(-) git pull

[PATCH] meta-telephony[201705]: osmo-sgsn: Enable iu support based on DISTRO_FEATURES

Review at https://gerrit.osmocom.org/4332 osmo-sgsn: Enable iu support based on DISTRO_FEATURES Change-Id: Ifd8068d61aeea228dd24c54df6e1ce87bfcafff5 --- M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc 1 file changed, 3 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-mgw[master]: cosmetic: correct whitespaces

Review at https://gerrit.osmocom.org/4329 cosmetic: correct whitespaces Change-Id: I22302ae8a48a2c776025a60267f5ef5af706e576 --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 21 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/29/4329/1 diff

[PATCH] osmo-mgw[master]: cosmetic: fix commenting style

Review at https://gerrit.osmocom.org/4328 cosmetic: fix commenting style Change-Id: Ib717d9dd3b17250ef4d6c67be0463a407cb83fbe --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/28/4328/1 diff

[PATCH] osmo-mgw[master]: sdp: refactoring sdp parser/generator

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4006 to look at the new patch set (#13). sdp: refactoring sdp parser/generator move SDP generator function write_response_sdp() from mgcp_protocol.c to mgcp_sdp.c move

[PATCH] osmo-mgw[master]: client: add ip address parsing to the client

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4147 to look at the new patch set (#12). client: add ip address parsing to the client Some MGCP messages (CRCX, MDCX) return IP-Addresses. Make use of this

[PATCH] osmo-mgw[master]: cosmetic: rename bts_codec to codec_str

Review at https://gerrit.osmocom.org/4326 cosmetic: rename bts_codec to codec_str make variable name more meaningful e enter the commit message for your changes. Lines starting Change-Id: I4d4d5af8925d032155ca1ef8c7d7d2e496a60fb6 --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 3

[PATCH] osmo-mgw[master]: client: add unified function to generate MGCP messages

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4146 to look at the new patch set (#11). client: add unified function to generate MGCP messages currently the only way to generate MGCP messages is to use

[PATCH] osmo-mgw[master]: protocol: allow wildcarded DLCX

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4227 to look at the new patch set (#7). protocol: allow wildcarded DLCX In many cases it is simpler to instruct the mgcp-gw to drop all connections at once

[PATCH] osmo-mgw[master]: cosmetic: fix coding style for mgcp_parse_sdp_data()

Review at https://gerrit.osmocom.org/4327 cosmetic: fix coding style for mgcp_parse_sdp_data() move variable declaration to the top remove brackets in case statement correct whitespaces Change-Id: I6dcf53ef8d3af5885b8b1f258d963949fa3ee93a --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 38

[PATCH] libosmocore[master]: gb: optionally allow nsip packets only from a specific host

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4317 to look at the new patch set (#2). gb: optionally allow nsip packets only from a specific host When listening for nsip connections is enabled, then every remote host may

[PATCH] libosmo-sccp[master]: Add doxygen docs

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4234 to look at the new patch set (#5). Add doxygen docs Make sure doxygen generates library documentation by default (can be disabled at compile time).

[PATCH] libosmo-sccp[master]: Add doxygen docs

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4234 to look at the new patch set (#4). Add doxygen docs Make sure doxygen generates library documentation by default (can be disabled at compile time).