Review at https://gerrit.osmocom.org/4750
bsc filter: don't ignore imsi-allow on "global" filter level
First off, there are "global" and "local" IMSI black/whitelist levels:
"global" "local"
VTY 'bsc' 'msc' for osmo-bsc
VTY 'nat' 'bsc' for osmo-bsc_nat
Both in osmo-bsc
Patch Set 1:
Right. All LUA related work should be merged at once or not at all. I will
rebase so that general fixes are coming first. It is to catch feedback early
and often.
The expected next patch will build some primitives to get a feeling for lua
callbacks and if it does make sense.
--
Harald Welte has submitted this change and it was merged.
Change subject: mobile/gsm322.c: prevent buffer over-/under-run
..
mobile/gsm322.c: prevent buffer over-/under-run
Change-Id: Ic12587a6c6456b8663e5357cf68a22c6d1927a07
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Make VTY logging commands available to the mobile app
..
mobile: Make VTY logging commands available to the mobile app
So far
Harald Welte has submitted this change and it was merged.
Change subject: mobile/gsm322.c: prevent calling memset() with zero length
..
mobile/gsm322.c: prevent calling memset() with zero length
This change prevents a
Patch Set 2:
Will remove this line in the next round..
--
To view, visit https://gerrit.osmocom.org/4733
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia874b7ed127026b8395072a3bac2aed9944b1cce
Gerrit-PatchSet: 2
Gerrit-Project:
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Do not exclude DGPS from the list of default categories
..
mobile: Do not exclude DGPS from the list of default categories
I don't remember
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4729
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12587a6c6456b8663e5357cf68a22c6d1927a07
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1:
seems I forgot to push this one for some reason
--
To view, visit https://gerrit.osmocom.org/4749
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee1b582a62921cb3205de01ff87d94881e8d411b
Gerrit-PatchSet: 1
Gerrit-Project:
Review at https://gerrit.osmocom.org/4749
vty: skip installing cmds now always installed by default
vty_install_default() and install_default() will soon be deprecated.
Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: Iee1b582a62921cb3205de01ff87d94881e8d411b
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: osmo-bsc: SCCP addrs: default only if unset, reject invalid
..
osmo-bsc: SCCP addrs: default only if unset, reject invalid
So far, if the user entered
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vty: skip installing cmds now always installed by default
..
vty: skip installing cmds now always installed by default
vty_install_default() and
Neels Hofmeyr has submitted this change and it was merged.
Change subject: examples: apply mgcp_client vty rename from 'mgcpgw' to 'mgw'
..
examples: apply mgcp_client vty rename from 'mgcpgw' to 'mgw'
osmo-mgw.git is changing
Neels Hofmeyr has submitted this change and it was merged.
Change subject: osmo-bsc RESET FSM: use distinct struct names
..
osmo-bsc RESET FSM: use distinct struct names
Use distinctive struct names: s/fsm_/fsm_bsc_reset/.
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_8.0/x86_64
Package network:osmocom:latest/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libosmocore
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/xUbuntu_17.04/x86_64
Package network:osmocom:latest/libosmocore failed to build in
xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libosmocore
Last lines of
Harald Welte has submitted this change and it was merged.
Change subject: debian: Add dependency to libosmo-mgcp-client-dev
..
debian: Add dependency to libosmo-mgcp-client-dev
Since Change-Id
Harald Welte has submitted this change and it was merged.
Change subject: debian: Increase required libosmo-legacy-mgcp-dev version
..
debian: Increase required libosmo-legacy-mgcp-dev version
Use the same version requirement
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4748
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc21e89bd676a754bc24a6995c4f9c0c4727d57
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
+2,but please read the comment in the change log. We will probably discuss
about this next week, too. We have to make sure we clean up our development
process to avoid creating such situations. Now you can install
libosmo-mgcp.git 1.1.0 and autoconf will succeed,
Review at https://gerrit.osmocom.org/4748
debian: Increase required libosmo-legacy-mgcp-dev version
Use the same version requirement as in configure.ac.
Change-Id: I2dc21e89bd676a754bc24a6995c4f9c0c4727d57
---
M debian/control
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/4747
debian: Add dependency to libosmo-mgcp-client-dev
Since Change-Id Ia2882b7ca31a3219c676986e85045fa08a425d7a, osmo-bsc
uses osmo-mgw and utilizes libosmo-mgcp-client to talk to it, so
let's make sure the Debian control file states that dependency.
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/armv7l
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/aarch64
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: l1sap: Fix abort on big RTP packet received
..
l1sap: Fix abort on big RTP packet received
Recently while testing new osmo-mgw, big RTP packets
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: host/mobile: use osmocom_ms as talloc context
..
host/mobile: use osmocom_ms as talloc context
As we use talloc, it's absurdly not to use the main
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4729
to look at the new patch set (#2).
mobile/gsm322.c: prevent buffer over-/under-run
Change-Id: Ic12587a6c6456b8663e5357cf68a22c6d1927a07
---
M src/host/layer23/src/mobile/gsm322.c
1
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4729/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:
Line 326: OSMO_ASSERT(value > 0 && value < 128);
> if you assert > 0 here, the "== 0" below will never be used. Sure you didn
Ah, sure, my
Harald Welte has submitted this change and it was merged.
Change subject: network: remove unused return code
..
network: remove unused return code
The function that forwards the tapped (voice ebug) traffic returns
its status
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4739
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2034ce4c68bb8b70cb72d3978d2a0f685bbe19
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 2: Code-Review-1
what about existing config files? We need compatibility alieses to be able to
still parse old config files, right? Think of osmo-gsm-testers or users of the
debian packages.
--
To view, visit https://gerrit.osmocom.org/4738
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4741
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47a15701f9a7e7a492df183b67ec971f5be61069
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: network: fix rtp packet length
..
network: fix rtp packet length
When sending rtp packets sizeof(buf) is used as length. This causes
all RTP packets to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4740
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfde1dacc3dc3d3d5e239cf1f7e39ade7fc25975
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4729/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:
Line 326: OSMO_ASSERT(value > 0 && value < 128);
if you assert > 0 here, the "== 0" below will never be used. Sure you didn't
mean >= 0?
--
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4645
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8d78474614939659a7f24d5007b1c890776b1a
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4746
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09851c957395d1ddb2f9471b99ffc091bc250404
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4745
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic67aa7c67a4e98a38bff156be3ebf612012eb842
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4743
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I360842fe899b95972c44da3cb74a3dc51b379fdc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4744
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibccda7e95c42267ce5f44e9fc4256a0083b6f68f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4742
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedc883b0f5760f004c51d7cf15328eb8c4d472db
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4731
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e3467ff739f3e6dc8dd60cc6d1fcd3f8e490ce9
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+1
no issues from my side, but I think it might make sense to keep this out of
master until we see some users to validate that the current approach really can
be useful this way?
--
To view, visit https://gerrit.osmocom.org/4737
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4736
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d266c48d30c06dfdc3b8c84d875038b43f2ad8
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4735
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic649e49a22c878585a6c20b5b80108909f2374eb
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4734
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db9cf288bce12f51e36caad44e9bc34094638f4
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
I think this is complete legacy and results from a time when there was no VTY
interface to configure log levels yet. So all of this could probably disappear.
--
To view, visit https://gerrit.osmocom.org/4733
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/4743
cosmetic: reorder case list
the switch statement in fsm_send_assignment_complete() has the
default case at the beginning.
Move the default case to the end to match common coding style
rules
Change-Id: I360842fe899b95972c44da3cb74a3dc51b379fdc
---
M
Review at https://gerrit.osmocom.org/4745
mgcp: add missing out state
Even in the very early ST_CRCX_BTS phase, the error handler may
decide to go to ST_CALL in order to initate the termination of
a possibly half open connection.
Add ST_CALL to the out state list in ST_CRCX_BTS
Change-Id:
Review at https://gerrit.osmocom.org/4746
mgcp: remove unused variable
The function handle_error asserts mgcp_ctx->conn to be non null,
but it does not access it otherwise.
remove unused variable conn
Change-Id: I09851c957395d1ddb2f9471b99ffc091bc250404
---
M src/osmo-bsc/osmo_bsc_mgcp.c
1
Review at https://gerrit.osmocom.org/4744
cosmetic: replace term MGCP-GW with MGW
The term MGCP-GW is deprecated, use now MGW
Change-Id: Ibccda7e95c42267ce5f44e9fc4256a0083b6f68f
---
M src/osmo-bsc/osmo_bsc_mgcp.c
1 file changed, 7 insertions(+), 7 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4742
cosmetic: remove distracting newline
Change-Id: Iedc883b0f5760f004c51d7cf15328eb8c4d472db
---
M include/osmocom/bsc/osmo_bsc_mgcp.h
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Patch Set 1:
I tested this patch in my setup which showed the issue, and after applying the
patch the issue is gone -> it works.
--
To view, visit https://gerrit.osmocom.org/4741
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/4741/1//COMMIT_MSG
Commit Message:
Line 11: rtp payload and random excess data from previoes memory usage
previoes->previous
--
To view, visit https://gerrit.osmocom.org/4741
To unsubscribe, visit
Review at https://gerrit.osmocom.org/4741
network: fix rtp packet length
When sending rtp packets sizeof(buf) is used as length. This causes
all RTP packets to be the size of the buffer (4096) containing the
rtp payload and random excess data from previoes memory usage
Use the actual length
Review at https://gerrit.osmocom.org/4740
l1sap: Fix abort on big RTP packet received
Recently while testing new osmo-mgw, big RTP packets (around 4K bytes,
see OS#2625 for more info), were being received on the BTS, which was
aborting with the following message:
"msgb(0xff208): Not enough
Review at https://gerrit.osmocom.org/4739
doc: update sample config file
The current example configuration is out of date.
Add a recent configuration file
Change-Id: Iad2034ce4c68bb8b70cb72d3978d2a0f685bbe19
---
M doc/examples/osmo-mgw/osmo-mgw.cfg
1 file changed, 14 insertions(+), 9
Review at https://gerrit.osmocom.org/4738
cosmetic: remove prefix "net" from rtp related vty commands
There the prefix "net" is a leftover from the time when
there was a bts and a net side. Now we do not distinguish
anymore between the two.
remove prefix "net"
Change-Id:
Review at https://gerrit.osmocom.org/4737
mobile: Add initial support for scripting support
Right now the script will be executed once it is loaded. Make sure
to write it into the config file last. Expose various log commands
for logging. Jump through some hoops and get the filename and line
Review at https://gerrit.osmocom.org/4736
mobile: Add LUA as debug category to the applications
Change-Id: Id2d266c48d30c06dfdc3b8c84d875038b43f2ad8
---
M src/host/layer23/include/osmocom/bb/common/logging.h
M src/host/layer23/src/common/logging.c
M src/host/layer23/src/mobile/main.c
3 files
Review at https://gerrit.osmocom.org/4734
mobile: Make VTY logging commands available to the mobile app
So far logging_vty_add_cmds wasn't called. The main.c might be
shared with other apps so place it into the routine that is
setting up the VTY.
Change-Id:
Review at https://gerrit.osmocom.org/4733
mobile: Do not exclude DGPS from the list of default categories
I don't remember why we parse the categories like this. First if
the mobile doesn't use a subsystem there is no harm to have it
enabled, second the default levels can be adjusted for all
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4732/1/doc/examples/osmo-bsc/osmo-bsc.cfg
File doc/examples/osmo-bsc/osmo-bsc.cfg:
Line 105: mgcpgw remote-ip 127.0.0.1
Deprecated, better use "mgw".
--
To view, visit https://gerrit.osmocom.org/4732
To unsubscribe,
Review at https://gerrit.osmocom.org/4732
doc: add example configuration for osmo-mgw
osmo-bsc now uses osmo-mgw to switch the RTP streams, but there
is no example configuration yet.
Add the missing example configuration.
Change-Id: I4d4ed401bee6c3dfdec2b584bf7248ffb02bddbf
---
M
Review at https://gerrit.osmocom.org/4731
host/mobile: use osmocom_ms as talloc context
As we use talloc, it's absurdly not to use the main feature of
the library - hierarchical memory management. This change sets
talloc context of all sub-allocated objects to related osmocom_ms
instance. So,
Vadim Yanitskiy has abandoned this change.
Change subject: host/mobile: use osmocom_ms as talloc context
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/4730
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/4729
mobile/gsm322.c: prevent buffer over-/under-run
Change-Id: Ic12587a6c6456b8663e5357cf68a22c6d1927a07
---
M src/host/layer23/src/mobile/gsm322.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4645
to look at the new patch set (#3).
mobile/gsm322.c: prevent calling memset() with zero length
This change prevents a possibility of calling memset()
with constant zero
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4645/2/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:
Line 326: for (i = 0; i < value && i < sizeof(bar) - 1; i++)
> you could just as well simply compute the length of the interval as
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-msc: Use mgw instead of mgcpgw in cfg
..
osmo-msc: Use mgw instead of mgcpgw in cfg
As of osmo-mgw 87203f2a3746d708f85ee75d978e2821bda58e6d,
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Use unique incrementing value for BTS CellId
..
Use unique incrementing value for BTS CellId
Change-Id: If4559b945a3e71f3a36fd7ac760cb094278f6b39
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: resource: Refactor next_msisdn to be more generic
..
resource: Refactor next_msisdn to be more generic
The logic in next_msisdn can be later re-used
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-deps.sh: Force fetching git tags
..
osmo-deps.sh: Force fetching git tags
It was recently spotted, in a osmo-msc jenkins build, that an updated
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/4718
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfe4846959c70e435d6792a755a6f2a6f0a932c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4672/1/src/vty/command.c
File src/vty/command.c:
Line 1952: the end of the line. */
> (does anyone understand what the comment is trying to say about '?' -- it's
I find it really confusing too.
--
To view, visit
Patch Set 1:
> As we already screwed up with the first attempt to merge a fix, I
> would rather not want to touch this code again unless we have a
> test case.
Do you imply you don't want to merge this patch unless there's a test case?
This new patch is not changing logic, as '\0' = 0x0 =
87 matches
Mail list logo
