Build failure of network:osmocom:latest/osmo-bsc in Debian_9.0/armv7l

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_9.0/armv7l Package network:osmocom:latest/osmo-bsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [

[PATCH] osmo-sgsn[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4891 add --enable-sanitize config option Change-Id: I3be01e0682b479a71c545f718b68c441a1011b0f --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/91/4891/1 diff --git

[PATCH] osmo-msc[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4890 add --enable-sanitize config option Change-Id: I6c0c91abc0d3fa737dbe3db1e6473358da64c2a5 --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/4890/1 diff --git

[PATCH] osmo-mgw[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4889 add --enable-sanitize config option Change-Id: I2693238c5c8d914cf3ff7721511e7b4b56e413d2 --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/89/4889/1 diff --git

[PATCH] osmo-iuh[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4888 add --enable-sanitize config option Change-Id: Id9bb6cc982cd30b86f772207184398af6b899f66 --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/88/4888/1 diff --git

[PATCH] osmo-hlr[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4887 add --enable-sanitize config option Change-Id: I12b7b0e751f274a05e88c79299fd8388667cc542 --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/87/4887/1 diff --git

[PATCH] osmo-ggsn[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4886 add --enable-sanitize config option Change-Id: I439ff2b2cb36a5c29347a914c0f2e21bed598b06 --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/86/4886/1 diff --git

[PATCH] osmo-bsc[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4885 add --enable-sanitize config option Change-Id: Ie6888cc29b9815d3dc7aa6673599a0d6cb010e6b --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/4885/1 diff --git

[PATCH] libsmpp34[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4884 add --enable-sanitize config option Change-Id: I83c7b16baeffd3b7ae86edf87a9bb4cbb7346609 --- M configure.ac 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/84/4884/1 diff --git

[PATCH] libosmo-abis[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4883 add --enable-sanitize config option Change-Id: I59fea4a7199ca6aa71710d3aca0b25425df7d346 --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/83/4883/1 diff --git

[PATCH] libasn1c[master]: add --enable-sanitize config option

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4876 to look at the new patch set (#2). add --enable-sanitize config option Change-Id: I8f641c4bce361dcef5d8c149b8b81b21f12cbadf --- M configure.ac 1 file changed, 12 insertions(+), 0

[PATCH] libosmo-sccp[master]: sccp_test: sanitize: don't memcmp NULL pointers

Review at https://gerrit.osmocom.org/4881 sccp_test: sanitize: don't memcmp NULL pointers Change-Id: I0159a875c1e11f4f9728d9e09f5c365b8174673a --- M tests/sccp/sccp_test.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp

[PATCH] libosmo-sccp[master]: xua_test: sanitize: fix msgb leak

Review at https://gerrit.osmocom.org/4882 xua_test: sanitize: fix msgb leak Change-Id: Ie57e803bb6361f39042084a21cada754a6506606 --- M tests/xua/xua_test.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/82/4882/1 diff

[PATCH] libosmo-sccp[master]: sccp_test: sanitize: fix msgb mem leaks

Review at https://gerrit.osmocom.org/4880 sccp_test: sanitize: fix msgb mem leaks Change-Id: I6d5ff3e4c053db5a2af9d548250f0307e00317bb --- M tests/sccp/sccp_test.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/80/4880/1

[PATCH] libosmo-sccp[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4879 add --enable-sanitize config option Change-Id: Ie9bf734cb6cdee24e776cd64f9f1b800a7a9277c --- M configure.ac 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/79/4879/1 diff --git

[PATCH] libosmo-netif[master]: osmo_stream_{cli, srv}_destroy: fix mem leak: empty msgb queue

Review at https://gerrit.osmocom.org/4878 osmo_stream_{cli,srv}_destroy: fix mem leak: empty msgb queue On destroying a client or server stream, deallocate any msgbs that are still pending in the queue. In libosmo-sccp, the ss7_test.c in test_as(), messages are queued and were, before this,

[PATCH] libosmocore[master]: jenkins: add 'make V=1' for more verbose build logs

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4860 to look at the new patch set (#3). jenkins: add 'make V=1' for more verbose build logs Change-Id: Ie89b1c39489ba80fb47716f4c747f2c85960e32e --- M contrib/jenkins.sh 1 file changed, 1

[ABANDON] libosmocore[master]: build, jenkins: use only CFLAGS, not CPPFLAGS as well

Neels Hofmeyr has abandoned this change. Change subject: build, jenkins: use only CFLAGS, not CPPFLAGS as well .. Abandoned not really worth the bother -- To view, visit https://gerrit.osmocom.org/4859 To unsubscribe, visit

[PATCH] libosmocore[master]: jenkins: add 'make V=1' for more verbose build logs

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4860 to look at the new patch set (#2). jenkins: add 'make V=1' for more verbose build logs Change-Id: Ie89b1c39489ba80fb47716f4c747f2c85960e32e --- M contrib/jenkins.sh 1 file changed, 1

Build failure of network:osmocom:latest/libosmocore in xUbuntu_17.04/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/xUbuntu_17.04/i586 Package network:osmocom:latest/libosmocore failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of

[PATCH] libosmocore[master]: build, jenkins: use only CFLAGS, not CPPFLAGS as well

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4859 to look at the new patch set (#2). build, jenkins: use only CFLAGS, not CPPFLAGS as well Looking at jenkins 'make V=1' output shows that we pass various flags twice. Apparently only

[PATCH] libasn1c[master]: add --enable-sanitize config option

Review at https://gerrit.osmocom.org/4876 add --enable-sanitize config option Change-Id: I8f641c4bce361dcef5d8c149b8b81b21f12cbadf --- M configure.ac 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/76/4876/1 diff --git

[MERGED] osmo-iuh[master]: src/Makefile.am: drop unused COMMON_LDADD

Neels Hofmeyr has submitted this change and it was merged. Change subject: src/Makefile.am: drop unused COMMON_LDADD .. src/Makefile.am: drop unused COMMON_LDADD unused since change-id Ic6a645a93406670d58eb5edf5f2f2e1266168c92

[PATCH] libosmocore[master]: sercomm_test: sanitize: fix msgb mem leak

Review at https://gerrit.osmocom.org/4875 sercomm_test: sanitize: fix msgb mem leak This should fix the last current remaining sanitizer build failure in libosmocore regression tests. Helps fix sanitizer build on debian 9. Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043 --- M

[PATCH] libosmocore[master]: abis_test: sanitize: fix msgb memleak

Review at https://gerrit.osmocom.org/4862 abis_test: sanitize: fix msgb memleak Helps fix sanitizer build on debian 9. Change-Id: I69750d9cd2b8f30bfc6d2dfd9e62576e46989fab --- M tests/abis/abis_test.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull

[PATCH] libosmocore[master]: rate_ctr_group_alloc: use ctx; adjust stats_test

Review at https://gerrit.osmocom.org/4868 rate_ctr_group_alloc: use ctx; adjust stats_test Using the NULL context creates mem leaks that bother sanitizer builds. Allocating from the rate counter context allows cleaning up at the end of stats_test. Remove the comment concerning osmo-msc: one

[PATCH] libosmocore[master]: bssgp_fc_test: sanitize: free fc struct when done

Review at https://gerrit.osmocom.org/4873 bssgp_fc_test: sanitize: free fc struct when done Helps fix sanitizer build on debian 9. Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181 --- M tests/gb/bssgp_fc_test.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull

[PATCH] libosmocore[master]: bssgp_fc_test: sanitizer: free msgb context when done

Review at https://gerrit.osmocom.org/4871 bssgp_fc_test: sanitizer: free msgb context when done Print remaining msgbs when done, then free the entire tall_msgb_context. To be able to do that, call msgb_talloc_ctx_init() and use its return value. A subsequent patch will fix a known mem leak

[PATCH] libosmocore[master]: gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow

Review at https://gerrit.osmocom.org/4872 gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate).

[PATCH] libosmocore[master]: stats_test: clarify talloc contexts

Review at https://gerrit.osmocom.org/4867 stats_test: clarify talloc contexts Change-Id: I0eda27cd3e322fb43a825382b37185048ebcd509 --- M tests/stats/stats_test.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/4867/1

[PATCH] libosmocore[master]: bssgp_fc_test: remove rounding to deciseconds

Review at https://gerrit.osmocom.org/4869 bssgp_fc_test: remove rounding to deciseconds Ever since this test was changed to use osmo_gettimeofday_override, the times it sees are exact every time and don't need rounding to pass the expected output. Change-Id:

[PATCH] libosmocore[master]: tlv_put: guard against NULL val and 0 len

Review at https://gerrit.osmocom.org/4874 tlv_put: guard against NULL val and 0 len For example encode_auth_info() from gsup.c calls msgb_tlv_put(msg, iei, 0, NULL) to put a tag and len with content data following later. However, this would cause a memcpy() from a NULL pointer, in

[PATCH] libosmocore[master]: lapd_test: sanitize: fix msgb memleaks

Review at https://gerrit.osmocom.org/4863 lapd_test: sanitize: fix msgb memleaks Helps fix sanitizer build on debian 9. Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25 --- M tests/lapd/lapd_test.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull

[PATCH] libosmocore[master]: rate_ctr: doc: explain intentional "mem leak" for mangled gr...

Review at https://gerrit.osmocom.org/4866 rate_ctr: doc: explain intentional "mem leak" for mangled group names Change-Id: I35363c4c1fa0d62fd7fed40fe689487244248a3f --- M src/rate_ctr.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[PATCH] libosmocore[master]: gsm0808_test: sanitize: fix msgb memleak

Review at https://gerrit.osmocom.org/4865 gsm0808_test: sanitize: fix msgb memleak Helps fix sanitizer build on debian 9. Change-Id: I0097d63bbb4e7ee20eb4a8474f4fef32d39e625f --- M tests/gsm0808/gsm0808_test.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull

[PATCH] libosmocore[master]: memleak: osmo_config_list_parse: getline() needs free also o...

Review at https://gerrit.osmocom.org/4861 memleak: osmo_config_list_parse: getline() needs free also on error Helps fix sanitizer build on debian 9. Change-Id: Iddf0a6cc733cd81d5f6c1eb62fc079ad319db119 --- M src/msgfile.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull

[PATCH] libosmocore[master]: bssgp_fc_test: clarify by outputting ok / failure messages

Review at https://gerrit.osmocom.org/4870 bssgp_fc_test: clarify by outputting ok / failure messages The test fills up the queue / sends too large PDUs on purpose. Make that obvious by outputting returned errors in the expected output. Cosmetic: - fc_in()'s return value is ignored, hence

[PATCH] libosmocore[master]: gsm0408_test: sanitize: cleanup msgb

Review at https://gerrit.osmocom.org/4864 gsm0408_test: sanitize: cleanup msgb Remove initial msgb talloc context creation: if we create a root ctx for msgb that all msgb are allocated in, we would in a final cleanup discard all msgbs, i.e. we would not verify that all msgb are cleaned up

[PATCH] libosmocore[master]: build, jenkins: use only CPPFLAGS, not CFLAGS as well

Review at https://gerrit.osmocom.org/4859 build, jenkins: use only CPPFLAGS, not CFLAGS as well According to https://stackoverflow.com/questions/2754966/cflags-vs-cppflags?answertab=votes#tab-top using CPPFLAGS is sufficient and we don't need to set CFLAGS as well. Looking at jenkins 'make

[PATCH] libosmocore[master]: jenkins: add 'make V=1' for more verbose build logs

Review at https://gerrit.osmocom.org/4860 jenkins: add 'make V=1' for more verbose build logs Change-Id: Ie89b1c39489ba80fb47716f4c747f2c85960e32e --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[PATCH] libosmocore[master]: NOT FOR MERGE: test gerrit sanitizer build

Review at https://gerrit.osmocom.org/4858 NOT FOR MERGE: test gerrit sanitizer build Change-Id: I67ae5d253e227002f2c252bd4c5818617bef5fbb --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/4858/1 diff

Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/armv7l

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcap in Debian_9.0/armv7l

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-pcap failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build

Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of

[PATCH] osmo-gsm-tester[master]: stp: Set local-ip cfg parameter to use correct ip

Review at https://gerrit.osmocom.org/4857 stp: Set local-ip cfg parameter to use correct ip Change-Id: I89deaa71956131766fec8fcc3bc7381ebb0e187f --- M src/osmo_gsm_tester/osmo_stp.py M src/osmo_gsm_tester/templates/osmo-stp.cfg.tmpl 2 files changed, 4 insertions(+), 4 deletions(-) git pull

libosmocore[master]: Print /proc/cpuinfo before executing testsuite

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4856 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib23e5bfb3c894206fad62d6cc6151583b1bb75a6 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: Print /proc/cpuinfo before executing testsuite

Harald Welte has submitted this change and it was merged. Change subject: Print /proc/cpuinfo before executing testsuite .. Print /proc/cpuinfo before executing testsuite The testsuite fails on some specific build machines in

[PATCH] libosmocore[master]: Print /proc/cpuinfo before executing testsuite

Review at https://gerrit.osmocom.org/4856 Print /proc/cpuinfo before executing testsuite The testsuite fails on some specific build machines in the OBS build cluster. Let's try to figure out which CPU flags they have to narrow down the cause of this. Change-Id:

[MERGED] osmo-sgsn[master]: tests/ctrl_test_runner.py: remove BSC/NAT TestRunner

Harald Welte has submitted this change and it was merged. Change subject: tests/ctrl_test_runner.py: remove BSC/NAT TestRunner .. tests/ctrl_test_runner.py: remove BSC/NAT TestRunner SGSN was splitted out of OpenBSC.

osmo-sgsn[master]: debian: remove doublicated project name in example files

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4843 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f9665e78e3e55910efb30cb50cefdb138e19f7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

osmo-sgsn[master]: .gitignore: remove unneeded ignores of bsc/msc/nitb files

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4841 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66905432c411291630f66579fa4177936c8f2bcf Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

[MERGED] osmo-sgsn[master]: .gitignore: remove unneeded ignores of bsc/msc/nitb files

Harald Welte has submitted this change and it was merged. Change subject: .gitignore: remove unneeded ignores of bsc/msc/nitb files .. .gitignore: remove unneeded ignores of bsc/msc/nitb files sgsn was splitted out of the

osmo-sgsn[master]: tests/ctrl_test_runner.py: remove BSC/NAT TestRunner

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4842 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4e44e49e5c904929869b47fc4d608aab1aab75e Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

osmo-msc[master]: debian/rules: remove doublicated project name in example files

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4846 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I702cd963d5c3a2f4085ebce5e0dfa1a8a27ea89f Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] libosmocore[master]: utils: Fix false positive in compiler warning

Pau Espin Pedrol has submitted this change and it was merged. Change subject: utils: Fix false positive in compiler warning .. utils: Fix false positive in compiler warning Fixes the warning below: warning: ‘sqn’ may be used

[MERGED] libosmocore[master]: gsm: Use correct include for getrandom

Pau Espin Pedrol has submitted this change and it was merged. Change subject: gsm: Use correct include for getrandom .. gsm: Use correct include for getrandom "man getrandom" states sys/random.h is required. Fixes warning

[PATCH] osmo-ggsn[master]: contrib/jenkins.sh: Enable Werror in C(PP)FLAGS

Review at https://gerrit.osmocom.org/4855 contrib/jenkins.sh: Enable Werror in C(PP)FLAGS Change-Id: Id4724fe07f6641e82c3bd9cde2d8d759aa492288 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/55/4855/1

[PATCH] osmo-ggsn[master]: ggsn_vty: Stop using deprecated API vty_install_default

Review at https://gerrit.osmocom.org/4854 ggsn_vty: Stop using deprecated API vty_install_default Changes made as requested by the deprecation text. Fixes warning below: warning: ‘vty_install_default’ is deprecated: Now happens implicitly with install_node() [-Wdeprecat ed-declarations]

osmo-hlr[master]: debian: include systemd service osmo-hlr.service

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4847 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d9fd34aa42b911f074557b526adde05e03d58b9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master

osmo-hlr[master]: doc: install example .cfg files to $(docdir)/examples/

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4848 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8671ce33b9bf28c89f767dd1b4a1463aeb275158 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master

osmo-hlr[master]: debian: install osmo-hlr.cfg to /etc/osmocom

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4849 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa1094da9b286a17a5c9a1ee300ec13a4a10a9a7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master

[MERGED] osmo-mgw[master]: debian: include systemd service osmo-mgw.service

Harald Welte has submitted this change and it was merged. Change subject: debian: include systemd service osmo-mgw.service .. debian: include systemd service osmo-mgw.service Change-Id:

osmo-mgw[master]: debian: include systemd service osmo-mgw.service

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4850 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic298b836620b3497734aed89b92c4f22a9071f0d Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-iuh[master]: src/Makefile.am: drop unused COMMON_LDADD

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4851 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4241a1d84b54a77a6a6dad809f8ec921f45ba4bc Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master

libosmocore[master]: utils: Fix false positive in compiler warning

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4853 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5903db01ea6765bd6bb688e63f70925c5012f98 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm: Use correct include for getrandom

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4852 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e73fd018e887893dc5527d6d73644d627eb963a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: utils: Fix false positive in compiler warning

Review at https://gerrit.osmocom.org/4853 utils: Fix false positive in compiler warning Fixes the warning below: warning: ‘sqn’ may be used uninitialized in this function [-Wmaybe-uninitialized] fprintf(stderr, "Requesting --sqn %"PRIu64" implies IND=%u,"

[PATCH] libosmocore[master]: gsm: Use correct include for getrandom

Review at https://gerrit.osmocom.org/4852 gsm: Use correct include for getrandom "man getrandom" states sys/random.h is required. Fixes warning below: warning: implicit declaration of function ‘getrandom’; did you mean ‘srandom’? [-Wimplicit-function-declaration] rc = getrandom(out, len,

[PATCH] osmo-pcu[master]: PCU: Fix TA adjustment

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4678 to look at the new patch set (#3). PCU: Fix TA adjustment Promblem: TA provided from L1 PH-DATA-IND is a relative amount of TA adjustment to actual TA being used for

osmo-mgw[master]: MGCP endpoints: parse as decimal, not hex

Patch Set 2: So libosmo-mgcp is not meant to be used with real MSCs/MGWs? I am a bit puzzled why compat with the real world is so easily broken (and then no test case is added). -- To view, visit https://gerrit.osmocom.org/4780 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-gsm-manuals[master]: OsmoGGSN: more info on non-root operation / tun creation

Patch Set 1: I have no clue about systemd masquerading, sorry. -- To view, visit https://gerrit.osmocom.org/4824 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02bd9cfa35c7f2fb338d5d92c2e968fe80574a78 Gerrit-PatchSet: 1 Gerrit-Project:

osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp

Patch Set 2: > It appears that osmo-hnbgw *does* need -lsctp. Which particular libsctp API is used directly by osmo-hnbgw? Can you please point this out? I would have expected that all use of libsctp API is done through libosmo-netif and/or libosmo-sigtran, and those libraries than bring in

[PATCH] osmo-iuh[master]: src/Makefile.am: drop unused COMMON_LDADD

Review at https://gerrit.osmocom.org/4851 src/Makefile.am: drop unused COMMON_LDADD unused since change-id Ic6a645a93406670d58eb5edf5f2f2e1266168c92 "osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp" Change-Id: I4241a1d84b54a77a6a6dad809f8ec921f45ba4bc --- M src/Makefile.am 1 file

osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp

Patch Set 2: It appears that osmo-hnbgw *does* need -lsctp. -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 2 Gerrit-Project: