[PATCH] osmo-msc[master]: fix vty write: add missing 'authentication optional/required...

2017-12-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5333 fix vty write: add missing 'authentication optional/required' output Change-Id: I4918b8a8a6f4cbe783f588ebe68a2cf1e7e50ae2 --- M src/libmsc/msc_vty.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc ref

[PATCH] osmo-ttcn3-hacks[master]: BSC_Tests: Add more tests about invalid channel activations

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5332 BSC_Tests: Add more tests about invalid channel activations Change-Id: I8a44b5eab6c6e09330305547d145820983f90140 --- M bsc/BSC_Tests.ttcn 1 file changed, 107 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks ref

[PATCH] osmo-ttcn3-hacks[master]: BSC_Tests: Make as_Tguard() more robust (don't abort after R...

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5330 BSC_Tests: Make as_Tguard() more robust (don't abort after RESET) Change-Id: Ia5a39d372c1b7ec8267446f2762aabc600667775 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: BSC_Tests: remove copy+paste CHAN RQD -> CHAN ACT -> CHAN ACK

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5331 BSC_Tests: remove copy+paste CHAN RQD -> CHAN ACT -> CHAN ACK ... and replace it with a function Change-Id: Id75cc92ddf1c1833c892a7bfa77d6561fd0f3679 --- M bsc/BSC_Tests.ttcn 1 file changed, 15 insertions(+), 20 deletions(-) git pull ssh://gerrit.o

[MERGED] osmo-bsc[master]: cosmetic: osmo_bsc_mgcp: improve comments

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: osmo_bsc_mgcp: improve comments .. cosmetic: osmo_bsc_mgcp: improve comments Make the comments for struct mgcp_ctx more expressive Change-Id:

osmo-bts[master]: osmo-bts-trx: add error concealment unit for GSM-FR

2017-12-13 Thread Harald Welte
Patch Set 3: > @dexter, just let me know if I can help you with that. if you have time and want to split it to a library function and propose an API+patch, feel free to go ahead. dexter has many other things on his hand, so I'm not sure when he can get back to it. -- To view, visit https://

osmo-bsc[master]: abisip-find: add getopts and option to prevent endless loop

2017-12-13 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/5239/2/src/ipaccess/abisip-find.c File src/ipaccess/abisip-find.c: Line 210: strncpy(program_name, basename(argv[0]), sizeof(program_name)); you don't need to copy the string here, as the argc array is pushed on the stack before ma

[MERGED] osmo-ttcn3-hacks[master]: Ignore build byproducts

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Ignore build byproducts .. Ignore build byproducts Change-Id: I3a677a809f372a147cd4855abe3f0db14f738450 --- M .gitignore 1 file changed, 2 insertions(+),

osmo-ttcn3-hacks[master]: Ignore build byproducts

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5317 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a677a809f372a147cd4855abe3f0db14f738450 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-bsc[master]: mgcp: cancel transactions on timeout

2017-12-13 Thread Harald Welte
Patch Set 1: waiting for answers to Neels' question before moving this ahead -- To view, visit https://gerrit.osmocom.org/5157 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40794dff7d10e2b6a96863a2da7e9fbd5662a1bf Gerrit-PatchSet: 1 Ge

osmo-bsc[master]: cosmetic: osmo_bsc_mgcp: improve comments

2017-12-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5319 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie80b4915055e3f944ff1870c38e3609197ab72b2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: paging: paging_flush_bts: be sure pending_requests is inital...

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5321 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42ddbfdec6f9d74d858ad13cc38b5b64061d08dc Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

[MERGED] osmo-bsc[master]: paging: paging_flush_bts: be sure pending_requests is inital...

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: paging: paging_flush_bts: be sure pending_requests is initalized .. paging: paging_flush_bts: be sure pending_requests is initalized The BSSMAP reset cau

osmo-bsc[master]: mgcp: validate rtp connection data in MGW response (ip/port)

2017-12-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5320 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d0aa7e9b8480e1bef57269e3904399cb99815bb Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: fix segfault upon release paging on BSSMAP Reset: init llist

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5327 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfafac4e2c0e0a241a62aecbbdc22be71febf840 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmocom-bb[master]: mobile/vty_interface.c: fix 'channel-capability' description

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5323 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c08e071ffaac9b8e7c4af6a7be2bd8125145842 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerr

[MERGED] osmocom-bb[master]: mobile/vty_interface.c: fix 'channel-capability' description

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/vty_interface.c: fix 'channel-capability' description .. mobile/vty_interface.c: fix 'channel-capability' description Change-Id: I0c08e071ffaac9b8

[MERGED] osmo-bsc[master]: fix segfault upon release paging on BSSMAP Reset: init llist

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix segfault upon release paging on BSSMAP Reset: init llist .. fix segfault upon release paging on BSSMAP Reset: init llist Initialize the llist head gs

[MERGED] osmo-gsm-tester[master]: gprs: ping.py: Disable ipv6 ctx activate test

2017-12-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: gprs: ping.py: Disable ipv6 ctx activate test .. gprs: ping.py: Disable ipv6 ctx activate test osmo-ggsn is failing to create tun ipv6 device in Prod

osmo-gsm-tester[master]: gprs: ping.py: Disable ipv6 ctx activate test

2017-12-13 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5329 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I018c525a8a3d108233740ee1376b2671fefbbb59 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Bra

[PATCH] osmo-gsm-tester[master]: gprs: ping.py: Disable ipv6 ctx activate test

2017-12-13 Thread Pau Espin Pedrol
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5329 to look at the new patch set (#2). gprs: ping.py: Disable ipv6 ctx activate test osmo-ggsn is failing to create tun ipv6 device in Prod main unit. Afterwards, as the iface is not created,

[MERGED] osmo-ttcn3-hacks[master]: Avoid gcc version check

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Avoid gcc version check .. Avoid gcc version check By default the build fails on Debian due to gcc version check in /usr/include/titan/cversion.h - inste

osmo-ttcn3-hacks[master]: Avoid gcc version check

2017-12-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5313 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71c765d5d8e182a198e2c5d2886ebce3b86e6328 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-gsm-tester[master]: gprs: ping.py: Disable ipv6 ctx activate test

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 reason belongs in changelog, IMHO. -- To view, visit https://gerrit.osmocom.org/5329 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I018c525a8a3d108233740ee1376b2671fefbbb59 Gerrit-PatchSet: 1 Gerrit-Project: o

[MERGED] osmo-ttcn3-hacks[master]: Add RTP_Emulation (stream source/sink) on top of RTP_CodecPort

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add RTP_Emulation (stream source/sink) on top of RTP_CodecPort .. Add RTP_Emulation (stream source/sink) on top of RTP_CodecPort Change-Id: Ic0750bdc025c

[MERGED] osmo-ttcn3-hacks[master]: Add missing RTP_CodecPort_CtrlFunct TTCN and C++ files

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add missing RTP_CodecPort_CtrlFunct TTCN and C++ files .. Add missing RTP_CodecPort_CtrlFunct TTCN and C++ files Change-Id: Ic5499a0b5f635a93214cbb5e641d

[MERGED] osmo-ttcn3-hacks[master]: move RTP_CodecPort.ttcn to library

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: move RTP_CodecPort.ttcn to library .. move RTP_CodecPort.ttcn to library Change-Id: I67343f016757c23a85db6b526b6f60476e91ffc3 --- R library/RTP_CodecPort

[MERGED] osmo-ttcn3-hacks[master]: bsc: Run three virtual BTSs (2 in one lac, 1 in another)

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc: Run three virtual BTSs (2 in one lac, 1 in another) .. bsc: Run three virtual BTSs (2 in one lac, 1 in another) This allows us to verify if the BSC

osmo-ttcn3-hacks[master]: bsc: Run three virtual BTSs (2 in one lac, 1 in another)

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5328 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53ffe44279a7b83e045b3fdb25da64529955d457 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: move RTP_CodecPort.ttcn to library

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5324 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67343f016757c23a85db6b526b6f60476e91ffc3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: Add RTP_Emulation (stream source/sink) on top of RTP_CodecPort

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5326 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0750bdc025cd6f16094843550429d976fb44f4f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[PATCH] osmo-gsm-tester[master]: gprs: ping.py: Disable ipv6 ctx activate test

2017-12-13 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5329 gprs: ping.py: Disable ipv6 ctx activate test Change-Id: I018c525a8a3d108233740ee1376b2671fefbbb59 --- M suites/gprs/ping.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/29/5329

osmo-ttcn3-hacks[master]: Add missing RTP_CodecPort_CtrlFunct TTCN and C++ files

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5325 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5499a0b5f635a93214cbb5e641d2fd8d37f38d6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[PATCH] osmo-ttcn3-hacks[master]: bsc: Run three virtual BTSs (2 in one lac, 1 in another)

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5328 bsc: Run three virtual BTSs (2 in one lac, 1 in another) This allows us to verify if the BSC pages *only* where it is supposed to page based on the cell identity list in the 08.08 PAGING. Change-Id: I53ffe44279a7b83e045b3fdb25da64529955d457 --- M bsc/B

[PATCH] osmo-bsc[master]: fix segfault upon release paging on BSSMAP Reset: init llist

2017-12-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5327 fix segfault upon release paging on BSSMAP Reset: init llist Initialize the llist head gsm_bts->paging.pending_requests at the time gsm_bts is allocated, not only at paging_init_if_needed(). The gsm_bts->paging sub-struct is invalid as long as gsm_bts-

[PATCH] osmo-ttcn3-hacks[master]: Avoid gcc version check

2017-12-13 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5313 to look at the new patch set (#2). Avoid gcc version check By default the build fails on Debian due to gcc version check in /usr/include/titan/cversion.h - instead of aski

python/osmo-python-tests[master]: Use setuptools for packaging

2017-12-13 Thread Max
Patch Set 1: README describes only basic installation which remains exactly the same. We do not have any dependencies described anywhere yet (because distutils does not have this concept) and anyway it would have stayed the same: both distutils and setuptools are part of the standard library.

python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-13 Thread Max
Patch Set 1: > We do not have comprehensive automatic testing of these scripts anywhere We don't have any testing, that's why I've added basic tests in https://gerrit.osmocom.org/#/c/5277/ > why does this *need* py3 in the first place? "necessary for proper py3 tests" > doesn't explain it to

[MERGED] osmo-ttcn3-hacks[master]: Fix rmlink.sh

2017-12-13 Thread Max
Max has submitted this change and it was merged. Change subject: Fix rmlink.sh .. Fix rmlink.sh Exclude directories with symlinks which are under version control from link cleanup script. Change-Id: I9b93b3918f6d277a21cd30e7dc

[PATCH] osmo-ttcn3-hacks[master]: Add RTP_Emulation (stream source/sink) on top of RTP_CodecPort

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5326 Add RTP_Emulation (stream source/sink) on top of RTP_CodecPort Change-Id: Ic0750bdc025cd6f16094843550429d976fb44f4f --- A library/RTP_Emulation.ttcn 1 file changed, 209 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3

[PATCH] osmo-ttcn3-hacks[master]: move RTP_CodecPort.ttcn to library

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5324 move RTP_CodecPort.ttcn to library Change-Id: I67343f016757c23a85db6b526b6f60476e91ffc3 --- R library/RTP_CodecPort.ttcn M mgw/gen_links.sh 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs

[PATCH] osmo-ttcn3-hacks[master]: Add missing RTP_CodecPort_CtrlFunct TTCN and C++ files

2017-12-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/5325 Add missing RTP_CodecPort_CtrlFunct TTCN and C++ files Change-Id: Ic5499a0b5f635a93214cbb5e641d2fd8d37f38d6 --- A library/RTP_CodecPort_CtrlFunct.ttcn A library/RTP_CodecPort_CtrlFunctDef.cc 2 files changed, 100 insertions(+), 0 deletions(-) git pul

[PATCH] osmocom-bb[master]: mobile/vty_interface.c: fix 'channel-capability' description

2017-12-13 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/5323 mobile/vty_interface.c: fix 'channel-capability' description Change-Id: I0c08e071ffaac9b8e7c4af6a7be2bd8125145842 --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:294

osmo-gsm-tester[master]: osmo-ggsn: set cap CAP_NET_ADMIN to be able to set up tun de...

2017-12-13 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5322 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a3ce16218f0274e0be09bbf2881bc21636acdf9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: osmo-ggsn: set cap CAP_NET_ADMIN to be able to set up tun de...

2017-12-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: osmo-ggsn: set cap CAP_NET_ADMIN to be able to set up tun devices .. osmo-ggsn: set cap CAP_NET_ADMIN to be able to set up tun devices This is a tem

[PATCH] osmo-gsm-tester[master]: osmo-ggsn: set cap CAP_NET_ADMIN to be able to set up tun de...

2017-12-13 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5322 osmo-ggsn: set cap CAP_NET_ADMIN to be able to set up tun devices This is a temporary workaround to be able to test gprs signalling until we set up all required bits to run osmo-ggsn in its own namespace. Change-Id: I0a3ce16218f0274e0be09bbf2881bc21636

[PATCH] osmo-bsc[master]: paging: paging_flush_bts: be sure pending_requests is inital...

2017-12-13 Thread dexter
Review at https://gerrit.osmocom.org/5321 paging: paging_flush_bts: be sure pending_requests is initalized The BSSMAP reset causes the paging requests to be flushed. When this happens right after startup then calling paging_flush_bts() may be called when the list bts->paging.pending_requests is

osmo-ttcn3-hacks[master]: Avoid gcc version check

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+1 might make sense to refer to the fact that this is a debian-specific bug report and also refer to Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879816 -- To view, visit https://gerrit.osmocom.org/5313 To unsubscribe, visit https://gerrit.osmocom.org/setti

osmo-ttcn3-hacks[master]: Add generic link functions

2017-12-13 Thread Harald Welte
Patch Set 3: I'm not quite sure if it's worth optimizing this, given that there is a proper solution in TITAN that avoids working with symlinks. I haven't used it yet, but it relates to the .grp XML files that ship with their libraries. ttcn3_makefilegen can work with those, but I haven't st

osmo-ttcn3-hacks[master]: Fix rmlink.sh

2017-12-13 Thread Harald Welte
Patch Set 3: Code-Review+2 the script is to be run from within one of the test cases, i.e. from within osmo-ttcn3-hacks/bsc, then the issue you are fixing won't occur. But it seems your patch won't hurt. -- To view, visit https://gerrit.osmocom.org/5314 To unsubscribe, visit https://gerrit.o

[MERGED] osmo-gsm-tester[master]: OsmoNitb: Introduce bts_is_connected API

2017-12-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: OsmoNitb: Introduce bts_is_connected API .. OsmoNitb: Introduce bts_is_connected API This can be used by tests to wait until bts is successfully conn

[MERGED] osmo-gsm-tester[master]: OsmoBsc: Introduce bts_is_connected API

2017-12-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: OsmoBsc: Introduce bts_is_connected API .. OsmoBsc: Introduce bts_is_connected API This can be used by tests to wait until bts is successfully connec

[MERGED] osmo-gsm-tester[master]: suites: Wait for BTS to connect to BSC before continuing

2017-12-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: suites: Wait for BTS to connect to BSC before continuing .. suites: Wait for BTS to connect to BSC before continuing Change-Id: I027e3bfb8f470a811e65

osmo-gsm-tester[master]: suites: Wait for BTS to connect to BSC before continuing

2017-12-13 Thread Pau Espin Pedrol
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/5276/2/suites/voice/mo_mt_call.py File suites/voice/mo_mt_call.py: Line 26: hlr.subscriber_add(ms_mo) > (true, but will not make a noticeable difference in execution time) I agree that it would be better in terms of dependencies and timing

osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

2017-12-13 Thread dexter
Patch Set 11: (70 comments) Actually we should not merge this patch until we did not solve the problems with 3G (rab assignment response not parsed). For the other topic, please see my email. https://gerrit.osmocom.org/#/c/4980/2//COMMIT_MSG Commit Message: Line 15: Depends: osmo-mgw Iab6a60

python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-13 Thread Neels Hofmeyr
Patch Set 1: > > have you verified that these tools work as expected in both py2 > and py3? > > py2 is verified in gerrit 5277, py3 verification is added in > follow-up patch. We do not have comprehensive automatic testing of these scripts anywhere, so it would involve manual testing. Hen

osmo-gsm-tester[master]: suites: Wait for BTS to connect to BSC before continuing

2017-12-13 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/5276/2/suites/voice/mo_mt_call.py File suites/voice/mo_mt_call.py: Line 26: hlr.subscriber_add(ms_mo) > you can probably add the subscribers to the HLR before/while waiting for th (true, but will not make a noticeable differe

osmo-gsm-tester[master]: OsmoBsc: Introduce bts_is_connected API

2017-12-13 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5275 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dc2be7fd802e0e77a5e6bf23c9ca03d4c4b28f2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

osmo-gsm-tester[master]: OsmoNitb: Introduce bts_is_connected API

2017-12-13 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5274 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9b7087e38f638d8b8acbad6dd8ab4218746832 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-bsc[master]: mgcp: validate rtp connection data in MGW response (ip/port)

2017-12-13 Thread dexter
Review at https://gerrit.osmocom.org/5320 mgcp: validate rtp connection data in MGW response (ip/port) Currently the pasing results from the RTP ip/port are fed into inet_addr without checking the results. Check the return code of inet_addr to be sure that the IP-Address got properly decoded.

[PATCH] osmo-mgw[master]: client: mgcp_response_parse_params: check rtp port

2017-12-13 Thread dexter
Review at https://gerrit.osmocom.org/5318 client: mgcp_response_parse_params: check rtp port Also check the port number for plausibility like we do it already for the IP-Address Change-Id: I594a06fc9dd1bf0522f6e72a8943df52448d2ce4 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 3 i

[PATCH] osmo-bsc[master]: cosmetic: osmo_bsc_mgcp: improve comments

2017-12-13 Thread dexter
Review at https://gerrit.osmocom.org/5319 cosmetic: osmo_bsc_mgcp: improve comments Make the comments for struct mgcp_ctx more expressive Change-Id: Ie80b4915055e3f944ff1870c38e3609197ab72b2 --- M include/osmocom/bsc/osmo_bsc_mgcp.h 1 file changed, 7 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

2017-12-13 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4980 to look at the new patch set (#12). mgcp: use osmo-mgw to switch rtp streams in the current implementation we still use osmo-bsc_mgcp, which has many problems and is also

[PATCH] osmo-ttcn3-hacks[master]: Ignore build byproducts

2017-12-13 Thread Max
Review at https://gerrit.osmocom.org/5317 Ignore build byproducts Change-Id: I3a677a809f372a147cd4855abe3f0db14f738450 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/5317/1 diff --git a/.gitignore b

[PATCH] osmo-ttcn3-hacks[master]: Fix rmlink.sh

2017-12-13 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5314 to look at the new patch set (#3). Fix rmlink.sh Exclude directories with symlinks which are under version control from link cleanup script. Change-Id: I9b93b3918f6d277a21cd30e7dcf91cf

[PATCH] osmo-ttcn3-hacks[master]: GPRS/Gb: use generic linker

2017-12-13 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5316 to look at the new patch set (#2). GPRS/Gb: use generic linker Make symlinks using generic.sh functions. Change-Id: I713b8dffe298e3e878a4760a82f1ad0d42e0aacf --- A gprs_gb/.gitignore M

[PATCH] osmo-ttcn3-hacks[master]: Fix rmlink.sh

2017-12-13 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5314 to look at the new patch set (#2). Fix rmlink.sh Exclude directories with symlinks which are under version control from link cleanup script. Change-Id: I9b93b3918f6d277a21cd30e7dcf91cf

[PATCH] osmo-ttcn3-hacks[master]: GPRS/Gb: use generic linker

2017-12-13 Thread Max
Review at https://gerrit.osmocom.org/5316 GPRS/Gb: use generic linker Make symlinks using generic.sh functions. Change-Id: I713b8dffe298e3e878a4760a82f1ad0d42e0aacf --- A gprs_gb/.gitignore M gprs_gb/gen_links.sh 2 files changed, 107 insertions(+), 31 deletions(-) git pull ssh://gerrit.osm

[PATCH] osmo-ttcn3-hacks[master]: Add generic link functions

2017-12-13 Thread Max
Review at https://gerrit.osmocom.org/5315 Add generic link functions * add function for link generation * add functions to symlink specific libraries The main differences with existing gen_links() routines: * properly shift arguments to avoid making directory symlink alongside with files sym

[PATCH] osmo-ttcn3-hacks[master]: Fix rmlink.sh

2017-12-13 Thread Max
Review at https://gerrit.osmocom.org/5314 Fix rmlink.sh Exclude directories with symlinks which are under version control from link cleanup script. Change-Id: I9b93b3918f6d277a21cd30e7dcf91cf4adcc69f2 --- M rmlinks.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmo

[PATCH] osmo-ttcn3-hacks[master]: Avoid gcc version check

2017-12-13 Thread Max
Review at https://gerrit.osmocom.org/5313 Avoid gcc version check By default the build fails due to gcc version check in /usr/include/titan/cversion.h - instead of asking users to manually change this file let's add workaround to our makefile fixer which disables this check automatically. Chan

[MERGED] osmocom-bb[master]: mobile/gsm48_rr.c: cosmetic: drop wrong comment

2017-12-13 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: mobile/gsm48_rr.c: cosmetic: drop wrong comment .. mobile/gsm48_rr.c: cosmetic: drop wrong comment Nothing is actually being skipped in this function.

osmocom-bb[master]: mobile/gsm48_rr.c: fix ACCH System Information parsing

2017-12-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5204 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9166996f146af7973bf02a8a1c965581dc58a4a5 Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerr

[MERGED] osmocom-bb[master]: mobile/gsm48_rr.c: fix ACCH System Information parsing

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile/gsm48_rr.c: fix ACCH System Information parsing .. mobile/gsm48_rr.c: fix ACCH System Information parsing According to GSM 04.08, the System Infor

osmo-gsm-tester[master]: suites: Wait for BTS to connect to BSC before continuing

2017-12-13 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/5276/2/suites/voice/mo_mt_call.py File suites/voice/mo_mt_call.py: Line 26: hlr.subscriber_add(ms_mo) you can probably add the subscribers to the HLR before/while waiting for the BTS to be connected. There's no dependency between those.

osmo-gsm-tester[master]: OsmoBsc: Introduce bts_is_connected API

2017-12-13 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5275 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dc2be7fd802e0e77a5e6bf23c9ca03d4c4b28f2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

osmo-gsm-tester[master]: OsmoNitb: Introduce bts_is_connected API

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5274 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb9b7087e38f638d8b8acbad6dd8ab4218746832 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[MERGED] osmo-ci[master]: rewrite osmocom-nightly-package based on the old osmocom-nig...

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: rewrite osmocom-nightly-package based on the old osmocom-nightly-split.sh .. rewrite osmocom-nightly-package based on the old osmocom-nightly-split.sh T

osmo-ci[master]: rewrite osmocom-nightly-package based on the old osmocom-nig...

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5295 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b55e14b5b4915a3aae23ee382d65bce4ef82774 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: mas

osmo-ttcn3-hacks[master]: Add git-review config

2017-12-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5312 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8ea609827ae4da6659b64c25f0c743770e0cc07 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-ttcn3-hacks[master]: Add git-review config

2017-12-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add git-review config .. Add git-review config Change-Id: Ie8ea609827ae4da6659b64c25f0c743770e0cc07 --- A .gitreview 1 file changed, 3 insertions(+), 0 d

[PATCH] osmo-ttcn3-hacks[master]: Add git-review config

2017-12-13 Thread Max
Review at https://gerrit.osmocom.org/5312 Add git-review config Change-Id: Ie8ea609827ae4da6659b64c25f0c743770e0cc07 --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/5312/1 diff --git a/.gitreview b/.