osmo-tetra[laforge/sq5bpf-rebase-20161218]: adding dmo support:

2018-01-23 Thread allesklar2
Patch Set 3: > Patch Set 3: Published edit on patch set 2. I found out that a file (tetra_burst.h) was uploaded without changes in my first commit and there was also a type in tetra-rx.c -- To view, visit https://gerrit.osmocom.org/2817 To unsubscribe, visit

[PATCH] osmo-tetra[laforge/sq5bpf-rebase-20161218]: adding dmo support:

2018-01-23 Thread allesklar2
Hello Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2817 to look at the new patch set (#3). adding dmo support: physical layer: If DMO preamble bits are present, burst are send to DMO SAPs lower mac layer: Decoding DMO Bursts and adding a new

[PATCH] osmo-pcu[master]: Remove ASAN preprocessor warning

2018-01-23 Thread Max
Review at https://gerrit.osmocom.org/6001 Remove ASAN preprocessor warning We have ASAN integrated into CI tests directly so there's no need in additional manual warnings at compile time. Change-Id: Idaabb4203a282be6779d7ab29de3f827b0ca6462 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 2

[PATCH] osmo-pcu[master]: AllocTest: remove assumption on max MS class

2018-01-23 Thread Max
Hello Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4958 to look at the new patch set (#5). AllocTest: remove assumption on max MS class So far the allocation was only tested up to hardcoded MS class 29. Drop that assumption

[PATCH] osmo-pcu[master]: Add multislot classes from latest spec

2018-01-23 Thread Max
Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4072 to look at the new patch set (#8). Add multislot classes from latest spec The table B.1 is copy-pasted from 3GPP TS 45.002 and reformatted via Emacs

[PATCH] osmo-pcu[master]: TBF: make poll state internal

2018-01-23 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5864 to look at the new patch set (#2). TBF: make poll state internal * add functions/macros for setting TBF's poll state * add function for checking TBF's poll state * update TBF test

[PATCH] osmo-pcu[master]: TBF: make UL ack state internal

2018-01-23 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5863 to look at the new patch set (#2). TBF: make UL ack state internal * add functions/macros for setting TBF's UL ack state * add functions for checking TBF's UL ack state * update TBF

[PATCH] osmo-pcu[master]: TBF: adjust test log levels

2018-01-23 Thread Max
Review at https://gerrit.osmocom.org/6000 TBF: adjust test log levels * enable debugging for DTBF* * disable excessive DRLCMAC* Change-Id: I122620941e7939d513742c8589a75e0ab76f79ab --- M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err 2 files changed, 4,665 insertions(+), 1,175 deletions(-)

[PATCH] osmo-pcu[master]: TBF: make UL/DL state internal

2018-01-23 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5862 to look at the new patch set (#2). TBF: make UL/DL state internal * add functions/macros for setting TBF's UL/DL state * add functions for checking TBF's UL/DL state * move pre-free

[MERGED] osmo-trx[master]: Remove unneeded libdl dependency

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Remove unneeded libdl dependency .. Remove unneeded libdl dependency Closes: OS#1929 Change-Id: I0caea2a2a8e6bd07432fd73bae72b42b1ce022cd --- M

[MERGED] libosmo-sccp[master]: sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER .. sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER It seems we have been sending the

libosmo-sccp[master]: sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER

2018-01-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5860 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113645bd6df1ec9ae5137977028df38560fc4789 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

[ABANDON] osmo-ci[master]: gerrit: remove obsolete openggsn job

2018-01-23 Thread Max
Max has abandoned this change. Change subject: gerrit: remove obsolete openggsn job .. Abandoned -- To view, visit https://gerrit.osmocom.org/5986 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

[MERGED] osmo-ci[master]: jenkins: fix jobs template

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: fix jobs template .. jenkins: fix jobs template The sequential parameter was silently skipped because it was absent from the project template.

osmo-ci[master]: jenkins: fix jobs template

2018-01-23 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5985 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bc28695f4f270bc7b1cc4bcd5d4d43ede6172f3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch:

osmo-ci[master]: gerrit: remove obsolete openggsn job

2018-01-23 Thread Harald Welte
Patch Set 1: Code-Review-1 We might still need to apply some bug fixes or the like, I don't want to remove the job -- To view, visit https://gerrit.osmocom.org/5986 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-mgw[master]: client: eliminate destructive head parsing

2018-01-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5936 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib273c13d6fe7ee042fb4e3b8ed46ac02602226f6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[MERGED] osmo-msc[master]: MNCC: Add input validation

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: MNCC: Add input validation .. MNCC: Add input validation There appears to have been no input validation whatsoever on MNCC messages. Hence it was very

osmo-pcu[master]: Simplify TS alloc: use defines for constants

2018-01-23 Thread Harald Welte
Patch Set 7: Code-Review-1 Not all of holgers comments adrresed -- To view, visit https://gerrit.osmocom.org/3920 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2699ceebf0cbec01652a02fa68ccc9e9419d0293 Gerrit-PatchSet: 7

osmo-msc[master]: Fix value of stored SMS validity time.

2018-01-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5995 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf786f9b1efabfe7407fb6414ec0d326d8f7244a Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: Fix value of stored SMS validity time.

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix value of stored SMS validity time. .. Fix value of stored SMS validity time. Quote the argument to sqlite's datetime(). Otherwise, the timestamp

[MERGED] osmo-pcu[master]: TBF: add dedicated log categories

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: TBF: add dedicated log categories .. TBF: add dedicated log categories Previously all TBF-related events were logged as part of DRLCMAC which is too

osmo-pcu[master]: TBF: add dedicated log categories

2018-01-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5933 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660e5971263d5c63d2ba95d50625c16a594aa Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS

2018-01-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5673 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

[MERGED] osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: configure.ac: Enable Wall in CFLAGS .. configure.ac: Enable Wall in CFLAGS Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 --- M configure.ac 1

[ABANDON] osmo-ci[master]: jobs: Add IPv6 build option to osmo-ggsn job

2018-01-23 Thread Pau Espin Pedrol
Pau Espin Pedrol has abandoned this change. Change subject: jobs: Add IPv6 build option to osmo-ggsn job .. Abandoned -- To view, visit https://gerrit.osmocom.org/5165 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmo-ggsn[master]: Add configure flag to disable ipv6 support

2018-01-23 Thread Pau Espin Pedrol
Pau Espin Pedrol has abandoned this change. Change subject: Add configure flag to disable ipv6 support .. Abandoned -- To view, visit https://gerrit.osmocom.org/5121 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-sgsn[master]: configure.ac: Enable Wall in CFLAGS

2018-01-23 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5673 to look at the new patch set (#2). configure.ac: Enable Wall in CFLAGS Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1 --- M configure.ac 1 file changed, 3

osmo-iuh[master]: configure.ac: Enable -Wall flag

2018-01-23 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5998 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib05f7862081708d578d8f0302d926aab42897dc2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master

[MERGED] pysim[master]: Revert "pySim-prog: ADM code can be longer 8 digits, it's im...

2018-01-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Revert "pySim-prog: ADM code can be longer 8 digits, it's implementation specific." .. Revert "pySim-prog: ADM code can be longer 8 digits, it's

pysim[master]: Revert "pySim-prog: ADM code can be longer 8 digits, it's im...

2018-01-23 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5999 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d68b7e09938a2fcb7a9a6a31048388cc3141f79 Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch:

[PATCH] pysim[master]: Revert "pySim-prog: ADM code can be longer 8 digits, it's im...

2018-01-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/5999 Revert "pySim-prog: ADM code can be longer 8 digits, it's implementation specific." This reverts commit a51592e1807c1d13f88b32275aa4a8a77d7d3b40, which broke the use of ADM pins on sysmoUSIM-SJS1 (and possibly others?) The ADM pins have so far always

[PATCH] osmo-iuh[master]: configure.ac: Enable -Wall flag

2018-01-23 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5998 configure.ac: Enable -Wall flag Change-Id: Ib05f7862081708d578d8f0302d926aab42897dc2 --- M configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/98/5998/1 diff --git

osmo-msc[master]: Accept SMS for any receiver

2018-01-23 Thread Pau Espin Pedrol
Patch Set 1: Shouldn't we be checking if we can find the subscriber in the VLR/HLR instead of blindly accepting? -- To view, visit https://gerrit.osmocom.org/5997 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: