Review at https://gerrit.osmocom.org/6252
layer23/cell_log: set default logfile to /dev/null
When '/var/log/osmocom.log' does not exist the cell_log
app cannot start normally, because it has no permissions
to create a new file. Furthermore, logfile is optional now.
Change-Id:
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6237
to look at the new patch set (#3).
l1ctl_proto.h: define burst indication messages
One burst indication message carries a single raw burst, forwarded
to the higher layers from DSP. The
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6237/2//COMMIT_MSG
Commit Message:
Line 10: to the higher layers from DSP. The burst bits are soft-bits (127..
They are hard-bits ... 116 bits = 14.5 bytes.
--
To view, visit https://gerrit.osmocom.org/6237
To unsubscribe, visit
Review at https://gerrit.osmocom.org/6251
firmware/l23_api.c: increase the L3_MSG_SIZE
This one defines the fixed amount of memory we will allocate for
each new l23 message in the firmware. Since the BURST INDICATION
message was defined, data_ind is no longer the biggest message.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6237
to look at the new patch set (#2).
l1ctl_proto.h: define burst indication messages
One burst indication message carries a single raw burst, forwarded
to the higher layers from DSP. The
Patch Set 1:
Regarding to the ws fixes, they are definitely great.
But unrelated to the commit at all. I would prefer
to see them in a separate change...
--
To view, visit https://gerrit.osmocom.org/6238
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review-1
I think, it would be better to ask the commit author - @Max.
Probably, the mentioned commit was incomplete, and may be
finished / improved. Max?
--
To view, visit https://gerrit.osmocom.org/6250
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6247
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21298fcd0d1c1aafdd3dc1e8c8dae37b271b1d3d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6236
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I736c1e4d625f647d3bb794fa717256e9dbf36e87
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6235
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18018adec05ce1c2ddbca38653311d74c7454ce8
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6250
l1sap.c: l1sap_tch_rts_ind: Remove unused variables
Commit a1fa955212e18ddca286a2c7d30333116406f56b added them without
really making use of them.
Change-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
---
M src/common/l1sap.c
1 file changed, 1
Review at https://gerrit.osmocom.org/6249
bts-trx: scheduler_trx.c: Fix missing header
It is required for bts_shutdown used in trx_fn_timer_cb, and compiler
warns about implicit declaration.
Change-Id: I274662cd657ce8c36ed1d262d138590808bfafea
---
M src/osmo-bts-trx/scheduler_trx.c
1 file
Review at https://gerrit.osmocom.org/6248
Remove unused variables
Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb
---
M src/common/l1sap.c
M src/common/rsl.c
M src/osmo-bts-trx/l1_if.c
3 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts
Review at https://gerrit.osmocom.org/6247
gsm_pchan2chan_nr: move warning to pragma message and track issue
Take the chance to move the default option to the end as it's the
usually expected syntax.
Change-Id: I21298fcd0d1c1aafdd3dc1e8c8dae37b271b1d3d
---
M src/common/gsm_data_shared.c
1 file
Review at https://gerrit.osmocom.org/6245
cosmetic: rename mgcp_release_endp to mgcp_endp_release
In order to allow clean prefixes for future endpoint related
functions the "rlease" should be moved to the end of the
function name.
- rename mgcp_release_endp to mgcp_endp_release
Change-Id:
Review at https://gerrit.osmocom.org/6243
msg: fix response code on exhausted endp resources
When all endpoints are seized and a call agent tries to allocate
another one, then 500 is returned as response code, which means
that the endpoint was not found. This does not match.
- Return 403
Review at https://gerrit.osmocom.org/6246
cosmetic: rename mgcp_ep.c/h to mgcp_endp.c/h
The short term of endpoint has always been "endp" througout the whole
project and not "ep".
- rename mcgp_ep.c to mgcp_endp.c
- rename mgcp_ep.h to mgcp_endp.h
Change-Id:
Review at https://gerrit.osmocom.org/6242
protocol: on wildcarded CRCX return endpoint number as hex
When a wildcarded CRCX is done, then the endpoint number is
returned as unsigned integer (%u). This results into problems
with endpoint numbers higher than 9.
- Return endpoint identifier with
Review at https://gerrit.osmocom.org/6244
ep: move endpoint struct and define to mgcp_ep.h
The endpoint and the define that computes the endpoint number is
defined in mgcp_internal.h. Since we have a dedicated module for
endpoint related code it makes sense to move the endpoint related
parts
Review at https://gerrit.osmocom.org/6240
TBF: move common test code into functions
* move common code into functions
* print error instead of failing test right away
This allows the tests to continue till completion even in case of
intermediate error which simplifies troubleshooting by
Review at https://gerrit.osmocom.org/6239
vty: add commands to show TBF of a certain kind
Add vty commands to show only TBFs allocated via PACCH or CCCH.
Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312
Related: OS#1759
---
M src/pcu_vty.c
M src/pcu_vty_functions.cpp
M
Patch Set 1: Code-Review-1
Not tested yet, WIP. I'll do some tests next week, I push it here meanwhile in
case someone wants to comment on it.
--
To view, visit https://gerrit.osmocom.org/6238
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/6238
Add support to set Rx/TxAntenna
Change-Id: I1735e6ab05a05b0312d6d679b16ebd4a2260fa23
---
M Transceiver52M/UHDDevice.cpp
M Transceiver52M/USRPDevice.cpp
M Transceiver52M/USRPDevice.h
M Transceiver52M/osmo-trx.cpp
M Transceiver52M/radioDevice.h
5 files
Patch Set 1:
(5 comments)
Thank you for detailed review, I've tried to address most of it, don't hesitate
to remind if I've missed something.
https://gerrit.osmocom.org/#/c/5992/1/src/host/gprsdecode/README
File src/host/gprsdecode/README:
Line 3: Based on the version from
Review at https://gerrit.osmocom.org/6237
Add burst_ind struct
It's used by both burst_ind branch and gprsdecode tool (will be added in
follow-up patch).
Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Related: OS#1672
---
M include/l1ctl_proto.h
1 file changed, 13 insertions(+), 0
Review at https://gerrit.osmocom.org/6236
tests: utils_test: Fix test failure when compiling with -O0
It seems with default flags in_buf was being memzeroed by the compiler.
When compiling with -O0, that's not the case anymore and printf prints
after first 16 bytes, printing extra garbage
Review at https://gerrit.osmocom.org/6235
tests: coding_test: Fix compilation with -O0
inline keyword is a hint for the compiler to inline the function, but
it's not mandatory. If no static or extern is specified, the definition
is only visible in the current unit but the identifier still has
Patch Set 1: Code-Review-1
-1 for whitespace
--
To view, visit https://gerrit.osmocom.org/6230
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Patch Set 1:
(4 comments)
Multiple ws...
https://gerrit.osmocom.org/#/c/6232/1/src/osmo_ms_driver/lua/json.lua
File src/osmo_ms_driver/lua/json.lua:
Line 41: end
ws
Line 130: local function create_set(...)
ws
Line 247:
ws
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/6230/1/src/osmo_ms_driver/cdf.py
File src/osmo_ms_driver/cdf.py:
Line 50:
ws
Line 128:
ws
Line 134:
ws
--
To view, visit https://gerrit.osmocom.org/6230
To unsubscribe, visit https://gerrit.osmocom.org/settings
31 matches
Mail list logo
