Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6317
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib539a8739d53ab60d8fadffcef38152b82a28498
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 2:
As Vadim indicated: how was this tested?
--
To view, visit https://gerrit.osmocom.org/6315
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Harald Welte has submitted this change and it was merged.
Change subject: Add helper to get BCC from BSIC
..
Add helper to get BCC from BSIC
Change-Id: Ib539a8739d53ab60d8fadffcef38152b82a28498
Related: OS#1854
---
M include/os
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6238
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1735e6ab05a05b0312d6d679b16ebd4a2260fa23
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Add support to set Rx/TxAntenna
..
Add support to set Rx/TxAntenna
Some devices have different Rx or Tx ports with different RF characteristics.
For inst
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/6316/1/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:
Line 90:char *id;
hm. We cannot change a "const char *" pointer? I always thought it states that
the destination buffer is 'const' and not that the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6313
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78b839f0bcb7e2da61bff0add3abc452bfea40a2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: bsc: fix f_establish_fully() for expected assignment failures
..
bsc: fix f_establish_fully() for expected assignment failures
The altstep guard statemen
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/6314/1//COMMIT_MSG
Commit Message:
Line 11: A51 the values match up by coincidence, from A53 on they differ.
from A5/2 onwards.
https://gerrit.osmocom.org/#/c/6314/1/bsc/MSC_ConnectionHandler.ttcn
File bsc/MSC_ConnectionHa
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6288
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74d46fdb7e87dc04c6b82a0b6f3ce6bef60bde58
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6295
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6312
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9180478152f9341f11bb3dffe61671da683f24d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6297
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3
Gerrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6294
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eac4c24257fd38068ba629d3c21848181703220
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6304
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2607cb1ac60941dbc22fca532ed2b3738bfbcc63
Gerrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6305
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f571ec319ff3231fd9acd4066e470476c3b1f78
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6311
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68a2e94cf79fcb83286eef981a8d88bdbe10ef69
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Move IMSI into test parameters
..
Move IMSI into test parameters
This makes test routines more flexible and allows to easier re-use them
for tests with d
Harald Welte has submitted this change and it was merged.
Change subject: VLR tests: always print test parameters
..
VLR tests: always print test parameters
For each test print:
* the test number
* IMSI
Unfortunately tests are
Harald Welte has submitted this change and it was merged.
Change subject: Constify msc_subscr_conn_is_accepted() parameter
..
Constify msc_subscr_conn_is_accepted() parameter
Related: OS#2864
Change-Id: I8af50a8847a5b438cf2ef66
Harald Welte has submitted this change and it was merged.
Change subject: VLR tests: move network init into function
..
VLR tests: move network init into function
That's a preparation step for properly splitting main function o
Harald Welte has submitted this change and it was merged.
Change subject: VLR tests: don't fail via assert
..
VLR tests: don't fail via assert
Don't fail tests using thwart_rx_non_initial_requests() via
OSMO_ASSERT. Instead log
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6307
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e1d7701f5322d2311f32b796148a8b414f53b8e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: VLR tests: mark static test functions as such
..
VLR tests: mark static test functions as such
Related: OS#2864
Change-Id: I5eac4c24257fd38068ba629d3c218
Harald Welte has submitted this change and it was merged.
Change subject: VLR tests: remove weird code
..
VLR tests: remove weird code
Having while(0) as a body for for() cycle generate too much WTF while
looking at the code wh
Harald Welte has submitted this change and it was merged.
Change subject: Expand VLR tests
..
Expand VLR tests
Print the IMSI used for each test. This enables expansion to tests with
several IMSIs in follow-up patches.
Change-
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6010
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4551212011fb0bd898c020a183756ed7a9afb9e5
Gerrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: GSUP: check osmo_gsup_encode() result
..
GSUP: check osmo_gsup_encode() result
Check and handle gracefully any error which might appear in
osmo_gsup_enco
Harald Welte has submitted this change and it was merged.
Change subject: Use python 3 for utilities
..
Use python 3 for utilities
There're no python2-specific code in there so we can switch right away
without waiting till 2020
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5657
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d34aed124b00c5dd2ab1bcc84bbfa8c620282cc
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
I agree, we shouldn't write a log unless requested to do so. Just like in all
the libosmovty-using programs on the network side: Log files must be explicitly
enabled/configured
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit https://gerrit.o
Patch Set 2: Code-Review-2
How would this work? Where are your negation rules to ensure we actually don't
ignore those .cc / .hh files that we have in this repository? See my example,
or otherwise explain why it's not needed.
--
To view, visit https://gerrit.osmocom.org/6285
To unsubscribe,
Max has submitted this change and it was merged.
Change subject: RACH: improve single block detection
..
RACH: improve single block detection
Replace unreadable if-else ladder in is_single_block() with regular
switch-case. This
Patch Set 9:
(1 comment)
https://gerrit.osmocom.org/#/c/5881/9/src/libosmo-mgcp-client/mgcp_client_fsm.c
File src/libosmo-mgcp-client/mgcp_client_fsm.c:
Line 443: static void fsm_cleanup_cb(struct osmo_fsm_inst *fi, enum
osmo_fsm_term_cause cause)
> It exits always through the cleanup_cb, I th
Patch Set 2:
The "git ls-files msc" does not show any .cc or .hh files so no negation needed
in this subdirectory yet. Am I missing something?
--
To view, visit https://gerrit.osmocom.org/6285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-
Patch Set 11:
aside from the "DLCX from the cleanup function in case of erroneous shutdown"
it is fine.
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887ce0c15a831dffeb6251a975337b8394
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6240
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c4ad1dc94542835f15bd666f0821e0ccfcc78c1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: TBF: move common test code into functions
..
TBF: move common test code into functions
* move common code into functions
* print error instead of failing
Harald Welte has submitted this change and it was merged.
Change subject: tests: coding_test: Fix compilation with -O0
..
tests: coding_test: Fix compilation with -O0
inline keyword is a hint for the compiler to inline the func
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6235
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18018adec05ce1c2ddbca38653311d74c7454ce8
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: tests: utils_test: Fix test failure when compiling with -O0
..
tests: utils_test: Fix test failure when compiling with -O0
It seems with default flags in
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6236
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I736c1e4d625f647d3bb794fa717256e9dbf36e87
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6149
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48b93adc280c1b0521e7f5acc1f66ce5db462915
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Add missing build products in .gitignore
..
Add missing build products in .gitignore
Change-Id: I48b93adc280c1b0521e7f5acc1f66ce5db462915
---
M .gitignor
Harald Welte has submitted this change and it was merged.
Change subject: mandatory depend on libc-ares and libgtp
..
mandatory depend on libc-ares and libgtp
Both library are required to build osmo-sgsn.
The optional dependenc
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6209
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id608165ae490cb6c84aac1fe70412b2cb2b2587b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerri
Patch Set 1:
I agree with the logic change as such, but I'm surprised that the gengetopt
code doesn't already have some kind of support for mutual exclusion. Did you
check if it has any support for it?
--
To view, visit https://gerrit.osmocom.org/6196
To unsubscribe, visit https://gerrit.osm
Patch Set 1:
At least from a quick glance at
https://www.gnu.org/software/gengetopt/gengetopt.html#Mode-options it seems
that gengetopt has support for mutually exclusive options. Did you investigate
that? If we cannot use it for some reason, please include the reason in the
changelog.
--
Patch Set 1:
Sorry, my reply was too quick. It seems you are using it. But then why do we
need those strange manual function counting how often a certain option has been
specified?
--
To view, visit https://gerrit.osmocom.org/6196
To unsubscribe, visit https://gerrit.osmocom.org/settings
Ge
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerr
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: layer23/cell_log: set default logfile to /dev/null
..
layer23/cell_log: set default logfile to /dev/null
When '/var/log/osmocom.log' does not exist th
Review at https://gerrit.osmocom.org/6318
fsm: do not terminate child FSMs to early
The function _osmo_fsm_inst_term() terminates all child FSMs befor
it calls fi->fsm_cleanup(). This prevnts the cleanup callback to
perform last actions on the child FSMs (e.g.
osmo_fsm_inst_unlink_parent()).
m
fsm: do not terminate child FSMs early
The function _osmo_fsm_inst_term() terminates all child FSMs befor
it calls fi->fsm_cleanup(). This prevnts the cleanup callback to
perform last actions on the child FSMs (e.g.
osmo_fsm_inst_unlink_parent()).
move the function call to _osmo_fsm_inst_term_c
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6314
to look at the new patch set (#2).
msc: convert bssmap chipher to rsl chiper representation
The representation of the chiphering algorithm is different bssmap
and RSL. BSS
Patch Set 2:
Hasm this been tested with omso-stp,MSC and hlr(heavy FSM users)?
--
To view, visit https://gerrit.osmocom.org/6318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89d435417306c6bf897274eabc3ed0a46485c26
Gerrit-PatchSet: 2
Harald Welte has submitted this change and it was merged.
Change subject: msc: convert bssmap chipher to rsl chiper representation
..
msc: convert bssmap chipher to rsl chiper representation
The representation of the chiphering
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6314
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I274c1ff0b5636c48411f994f918e783b468cb3be
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#12).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osm
Review at https://gerrit.osmocom.org/6320
increase RAN timeout in MGCP FSM
The MGCP FSM implements a timeout when waiting for the RAN to complete
the call (assignment complete, alerting, connect...). This timeout
is currently set to 10sec. This means if the other end did not pick
up after 10sec
Review at https://gerrit.osmocom.org/6319
mcgp: let the MGW allocate the MGCP endpoint
osmo-msc still uses endpoints that are allocated locally by the
MGCP-Client. Since osmo-mgw now supports the more comfortable,
dynamic variant we should make use of it.
- Replace the endpoint numer allocatio
Review at https://gerrit.osmocom.org/6322
osmo-bts-trx: ignore frame offset error on startup
Previously we always printed error on startup:
l1sap.c:461 Invalid condition detected: Frame difference is 627202-0=627202 > 1!
This is expected and of little practical use. Let's suppress it
by checki
Review at https://gerrit.osmocom.org/6321
osmo-bts-trx: init nbits to know value
It seems like some of the functions invoked by _sched_dl_burst()
do not sent nbits properly. This leads to a number of errors on
startup:
trx_if.c:593 Tx burst length 65535 invalid
It happens in conjunction with:
Review at https://gerrit.osmocom.org/6323
MGCP: remove hack to fake SDP
A problem with the parameter ordering inside the mgcp-client
(osmo-mgw) prevented TTCN3 from accepting the SDP data that
was generated by the IUT. The problem is now fixed and the
hack can be removed.
- remove hack
Change
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6316
to look at the new patch set (#2).
fsm: Add a function to change the FSM instance ID later
Sometimes we want to create an FSM instance before we know its name. In
that cas
Patch Set 1:
(2 comments)
Patch Set 2 has also restored the ability for an fsm instance to have NULL
passed as an id. I'm not sure if that was used before, but this way the
behaviour is unchanged.
https://gerrit.osmocom.org/#/c/6316/1/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h
Patch Set 2:
> Hasm this been tested with omso-stp,MSC and hlr(heavy FSM users)?
I did a manual test with my test-network and the TTCN3 MSC tests. It does not
look any different to me.
(The reason for this patch is that I need to be able to unlink a child FSM from
the cleanup_cb. This is impo
Patch Set 1:
do we have a TTCN-3 test case for this in OsmoMSC yet, so we can make sure the
feature works as expected? If not, please provide one (or indicate what is
missing in terms of infrastructure to write one).
--
To view, visit https://gerrit.osmocom.org/6319
To unsubscribe, visit htt
Harald Welte has submitted this change and it was merged.
Change subject: client: add an optional FSM interface
..
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887ce0c15a831dffeb6251a975337b83942af566
Gerrit-PatchSet: 12
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerr
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89d435417306c6bf897274eabc3ed0a46485c26
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6316
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic216e5b11d4440f8e106a297714f4f06c1152945
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6323
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: MGCP: remove hack to fake SDP
..
MGCP: remove hack to fake SDP
A problem with the parameter ordering inside the mgcp-client
(osmo-mgw) prevented TTCN3 fr
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6322
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7cf285e437db0e980e1a2a3ab48a7255945448
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: ignore frame offset error on startup
..
osmo-bts-trx: ignore frame offset error on startup
Previously we always printed error on startup:
l
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: init nbits to know value
..
osmo-bts-trx: init nbits to know value
It seems like some of the functions invoked by _sched_dl_burst()
do not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6321
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6320
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a11d53f9701d9b11b18d7026ff2241c7c0b57f5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: increase RAN timeout in MGCP FSM
..
increase RAN timeout in MGCP FSM
The MGCP FSM implements a timeout when waiting for the RAN to complete
the call (ass
Patch Set 2:
I thought you're adding this to the global .gitignore. Let's please do that,
not a msc-specific one. The names of the symlinked files are the same in all
directories anyway. We must of course then excempt any library/*.ttcn and the
cc files that we have all over the repo, too.
Harald Welte has submitted this change and it was merged.
Change subject: main.c: bts_main: fix typo in error message
..
main.c: bts_main: fix typo in error message
Change-Id: Ib44fce36a945042e92ea3f4173e72c1ce5f66fb8
---
M src
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6309
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44fce36a945042e92ea3f4173e72c1ce5f66fb8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/6324
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increasing number of MS. This avoids overload at
startup time in cases where a lot of MS would discover the new
cell and try
Patch Set 1:
The above build failure seems dubious.
The build is complaining about a missing header file (osmocom/bsd/acc_ramp.h)
which is a file added by my commit. Have I done something wrong or is this a
bug in the jenkins build?
--
To view, visit https://gerrit.osmocom.org/6324
To unsubsc
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6050
to look at the new patch set (#3).
WIP: VTY: Add 'show connections' and 'show transactions' commands
It is quite important to have some way of runtime state introspection
about the majo
Don't answer to BSC-originated RESET with another RESET
If the BSC is contacting us for the first time and sending a BSSMAP
RESET, then we should simply ACK that and transition into the
"connected" state, where connection-oriented and connectionless
procedures are permitted.
This patch is a bit
Review at https://gerrit.osmocom.org/6325
a_reset: Add additional "a_reset_alloc" argument
Using this argument we can create the state machine in the
"already connected" state, i.e. without starting an outbound
RESET procedure.
Change-Id: Ibf569d57300965cd47084fa0bff54aa67679e2a1
---
M include
Review at https://gerrit.osmocom.org/6326
Don't answer to BSC-originated RESET with another RESET
If the BSC is contacting us for the first time and sending a BSSMAP
RESET, then we should simply ACK that and transition into the
"connected" state, where connection-oriented and connectionless
pro
Review at https://gerrit.osmocom.org/6327
tlv_parser: Report *first* occurrence of repeated IEs
Most GSM related specifications require the receiver to use the
*first* occurrence of repeated IEs. The Osmocom TLV parser so
far did the opposite: It reported only the *last* occurrence in
case of
Review at https://gerrit.osmocom.org/6328
msgb: Add msgb_hexdump_{l2,l3}() to dump l2 or l3 part of message buffer
Change-Id: I98e85397fb541ee0fd711f2e1852f63f3bb87359
---
M include/osmocom/core/msgb.h
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6325
to look at the new patch set (#2).
a_reset: Add additional "a_reset_alloc" argument
Using this argument we can create the state machine in the
"already connected" state, i.e. without st
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6326
to look at the new patch set (#3).
Don't answer to BSC-originated RESET with another RESET
If the BSC is contacting us for the first time and sending a BSSMAP
RESET, then we should simp
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6050
to look at the new patch set (#4).
VTY: Add 'show connections' and 'show transactions' commands
It is quite important to have some way of runtime state introspection
about the major obj
Review at https://gerrit.osmocom.org/6334
cosmetic: No need for 'break' after 'return'
This just makes the code longer with no added benefit.
Change-Id: If689b8284a669021219eff0397c6e90570e2aaa4
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 0 insertions(+), 20 deleti
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6328
to look at the new patch set (#2).
msgb: Add msgb_hexdump_{l2,l3}() to dump l2 or l3 part of message buffer
Change-Id: I98e85397fb541ee0fd711f2e1852f63f3bb87359
---
M include/osmocom/co
Review at https://gerrit.osmocom.org/6337
a_iface: Add copyright statement (after recent contributions)
Change-Id: I3f5dedb045a9ae9b93b00a8388a73ed77e67f19f
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom
Review at https://gerrit.osmocom.org/6330
a_iface: Reduce log levels
During normal operation, regular messages occurring during processing
of a call / transaction should not be higher than LOGL_INFO.
Change-Id: Ibd04ade47b249406696c7d0b660474afc4f4adee
---
M src/libmsc/a_iface.c
M src/libmsc/a
Review at https://gerrit.osmocom.org/6336
cosmetic: a_iface: More logging harmonization
Change-Id: I66139862c4d821fcce0334207ce84fffbd08b4e3
---
M src/libmsc/a_iface_bssap.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/6336
Review at https://gerrit.osmocom.org/6338
Introduce new BSSAP logging category/subsystem
Having all BSSAP related logs in the "DMSC" category is overly
generic, and dosn't provide useful granularity.
Change-Id: Id1e52dad03840dfd026fb23f3845a8771c8cc308
---
M include/osmocom/msc/a_iface.h
M inc
Review at https://gerrit.osmocom.org/6329
cosmetic: Use msgb_hexdump*() rather than manual osmo_hexdump() on msg
Change-Id: Ieeb97a9f1eba2fdef84294b8c8c7ac0984ae5c70
---
M src/libcommon/gsup_test_client.c
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
M src/libmsc/gsm_04_11.c
M src/libmsc/
1 - 100 of 150 matches
Mail list logo
