Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/6324/1/include/osmocom/bsc/acc_ramp.h
File include/osmocom/bsc/acc_ramp.h:
Line 20: #ifndef _ACC_RAMP_H_
Do we still use this way of the include guard?
Why now '#pragma once'?
Patch Set 1:
> The above build failure seems dubious.
> The build is complaining about a missing header file
> (osmocom/bsd/acc_ramp.h) which is a file added by my commit. Have I
> done something wrong or is this a bug in the jenkins build?
The problem appears only during the 'make
Harald Welte has submitted this change and it was merged.
Change subject: fsm: do not terminate child FSMs early
..
fsm: do not terminate child FSMs early
The function _osmo_fsm_inst_term() terminates all child FSMs befor
it
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/6318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89d435417306c6bf897274eabc3ed0a46485c26
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: a_iface: More logging harmonization
..
cosmetic: a_iface: More logging harmonization
Change-Id: I66139862c4d821fcce0334207ce84fffbd08b4e3
---
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6338
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e52dad03840dfd026fb23f3845a8771c8cc308
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6326
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67e7ed20a6c42afe99bafef96d85a4e083dd057
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: a_iface: Reduce log levels
..
a_iface: Reduce log levels
During normal operation, regular messages occurring during processing
of a call / transaction
Harald Welte has submitted this change and it was merged.
Change subject: a_sccp_rx_dt(): Don't print hexdump of message multiple times
..
a_sccp_rx_dt(): Don't print hexdump of message multiple times
We don't need to hexdump
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: a_iface: Harmonize log statements
..
cosmetic: a_iface: Harmonize log statements
Clean up the log statements in a_iface*.c, which was very
Harald Welte has submitted this change and it was merged.
Change subject: a_reset: Add additional "a_reset_alloc" argument
..
a_reset: Add additional "a_reset_alloc" argument
Using this argument we can create the state machine
Harald Welte has submitted this change and it was merged.
Change subject: a_iface: centralize lookup of subscriber_conn
..
a_iface: centralize lookup of subscriber_conn
There's little point in resolving the
Harald Welte has submitted this change and it was merged.
Change subject: Introduce new BSSAP logging category/subsystem
..
Introduce new BSSAP logging category/subsystem
Having all BSSAP related logs in the "DMSC" category is
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: No need for 'break' after 'return'
..
cosmetic: No need for 'break' after 'return'
This just makes the code longer with no added benefit.
Harald Welte has submitted this change and it was merged.
Change subject: a_iface_bssap.c: Use LOGPCONN() whenever possible
..
a_iface_bssap.c: Use LOGPCONN() whenever possible
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: Use msgb_hexdump*() rather than manual osmo_hexdump()
on msg
..
cosmetic: Use msgb_hexdump*() rather than manual osmo_hexdump() on msg
This
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6337
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5dedb045a9ae9b93b00a8388a73ed77e67f19f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6336
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66139862c4d821fcce0334207ce84fffbd08b4e3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6335
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea85527ea4d4cde7b36cc28a8027362c1570518f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6334
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If689b8284a669021219eff0397c6e90570e2aaa4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6332
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2caa8e0af236983430155f9c808de913377d5780
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6331
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c9d14b892154d51165598338d23a924a772265
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6333
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id50e964d86713ae506d4e7657159797e09501d99
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6330
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd04ade47b249406696c7d0b660474afc4f4adee
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6329
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb97a9f1eba2fdef84294b8c8c7ac0984ae5c70
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/6329
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb97a9f1eba2fdef84294b8c8c7ac0984ae5c70
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/6328
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98e85397fb541ee0fd711f2e1852f63f3bb87359
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: tlv_parser: Report *first* occurrence of repeated IEs
..
tlv_parser: Report *first* occurrence of repeated IEs
Most GSM related specifications require
Harald Welte has submitted this change and it was merged.
Change subject: msgb: Add msgb_hexdump_{l2,l3}() to dump l2 or l3 part of
message buffer
..
msgb: Add msgb_hexdump_{l2,l3}() to dump l2 or l3 part of message buffer
Harald Welte has submitted this change and it was merged.
Change subject: VTY: Add 'show connections' and 'show transactions' commands
..
VTY: Add 'show connections' and 'show transactions' commands
It is quite important to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6327
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icde09e075f68c842a7a96cf7160c8e44b77cf82d
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6050
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c457c1eac20188f67b8379a36cfda3a085fcef4
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6328
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98e85397fb541ee0fd711f2e1852f63f3bb87359
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
cosmetic: a_iface: Harmonize log statements
Clean up the log statements in a_iface*.c, which was very inconsistent.
For example "BSC sending" is very confusing. We are receiving from the BSC,
and it did already send the message, it is no longer in the process of
sending it if we have already
a_sccp_rx_dt(): Don't print hexdump of message multiple times
We don't need to hexdump it in a_sccp_rx_dt() and then again in
rx_bssmap() or rx_dtap().
Change-Id: I2caa8e0af236983430155f9c808de913377d5780
---
M src/libmsc/a_iface_bssap.c
1 file changed, 0 insertions(+), 2 deletions(-)
git
cosmetic: Use msgb_hexdump*() rather than manual osmo_hexdump() on msg
This requires libosmocore Change-Id I98e85397fb541ee0fd711f2e1852f63f3bb87359
Change-Id: Ieeb97a9f1eba2fdef84294b8c8c7ac0984ae5c70
---
M src/libcommon/gsup_test_client.c
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
M
a_iface: centralize lookup of subscriber_conn
There's little point in resolving the gsm_subscriber_connection in each
and every function handling connection-oriented messages. We can
resolve it once and dispatch the already-resolved conn into the
function, instead of passing the raw sccp_user
a_iface: Add copyright statement (after recent contributions)
Change-Id: I3f5dedb045a9ae9b93b00a8388a73ed77e67f19f
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/6337/2
a_iface_bssap.c: Use LOGPCONN() whenever possible
Change-Id: Ic1c9d14b892154d51165598338d23a924a772265
---
M include/osmocom/msc/a_iface.h
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
3 files changed, 27 insertions(+), 26 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
a_iface: Reduce log levels
During normal operation, regular messages occurring during processing
of a call / transaction should not be higher than LOGL_INFO.
Change-Id: Ibd04ade47b249406696c7d0b660474afc4f4adee
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 18
cosmetic: No need for 'break' after 'return'
This just makes the code longer with no added benefit.
Change-Id: If689b8284a669021219eff0397c6e90570e2aaa4
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 0 insertions(+), 20 deletions(-)
git pull
cosmetic: a_iface: More logging harmonization
Change-Id: I66139862c4d821fcce0334207ce84fffbd08b4e3
---
M src/libmsc/a_iface_bssap.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/6336/2
diff --git a/src/libmsc/a_iface_bssap.c
Introduce new BSSAP logging category/subsystem
Having all BSSAP related logs in the "DMSC" category is overly
generic, and dosn't provide useful granularity.
Change-Id: Id1e52dad03840dfd026fb23f3845a8771c8cc308
---
M include/osmocom/msc/a_iface.h
M include/osmocom/msc/debug.h
M
Review at https://gerrit.osmocom.org/6332
a_sccp_rx_dt(): Don't print hexdump of message multiple times
We don't need to hexdump it in a_sccp_rx_dt() and then again in
rx_bssmap() or rx_dtap().
Change-Id: I2caa8e0af236983430155f9c808de913377d5780
---
M src/libmsc/a_iface_bssap.c
1 file
Review at https://gerrit.osmocom.org/6333
cosmetic: a_iface: Harmonize log statements
Clean up the log statements in a_iface*.c, which was very inconsistent.
For example "BSC sending" is very confusing. We are receiving from the BSC,
and it did already send the message, it is no longer in the
Review at https://gerrit.osmocom.org/6331
a_iface_bssap.c: Use LOGPCONN() whenever possible
Change-Id: Ic1c9d14b892154d51165598338d23a924a772265
---
M include/osmocom/msc/a_iface.h
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
3 files changed, 27 insertions(+), 26 deletions(-)
git
Review at https://gerrit.osmocom.org/6338
Introduce new BSSAP logging category/subsystem
Having all BSSAP related logs in the "DMSC" category is overly
generic, and dosn't provide useful granularity.
Change-Id: Id1e52dad03840dfd026fb23f3845a8771c8cc308
---
M include/osmocom/msc/a_iface.h
M
Review at https://gerrit.osmocom.org/6329
cosmetic: Use msgb_hexdump*() rather than manual osmo_hexdump() on msg
Change-Id: Ieeb97a9f1eba2fdef84294b8c8c7ac0984ae5c70
---
M src/libcommon/gsup_test_client.c
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
M src/libmsc/gsm_04_11.c
M
Review at https://gerrit.osmocom.org/6336
cosmetic: a_iface: More logging harmonization
Change-Id: I66139862c4d821fcce0334207ce84fffbd08b4e3
---
M src/libmsc/a_iface_bssap.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/6337
a_iface: Add copyright statement (after recent contributions)
Change-Id: I3f5dedb045a9ae9b93b00a8388a73ed77e67f19f
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6328
to look at the new patch set (#2).
msgb: Add msgb_hexdump_{l2,l3}() to dump l2 or l3 part of message buffer
Change-Id: I98e85397fb541ee0fd711f2e1852f63f3bb87359
---
M
Review at https://gerrit.osmocom.org/6334
cosmetic: No need for 'break' after 'return'
This just makes the code longer with no added benefit.
Change-Id: If689b8284a669021219eff0397c6e90570e2aaa4
---
M src/libmsc/a_iface.c
M src/libmsc/a_iface_bssap.c
2 files changed, 0 insertions(+), 20
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6325
to look at the new patch set (#2).
a_reset: Add additional "a_reset_alloc" argument
Using this argument we can create the state machine in the
"already connected" state, i.e. without
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6326
to look at the new patch set (#3).
Don't answer to BSC-originated RESET with another RESET
If the BSC is contacting us for the first time and sending a BSSMAP
RESET, then we should
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6050
to look at the new patch set (#4).
VTY: Add 'show connections' and 'show transactions' commands
It is quite important to have some way of runtime state introspection
about the major
Review at https://gerrit.osmocom.org/6327
tlv_parser: Report *first* occurrence of repeated IEs
Most GSM related specifications require the receiver to use the
*first* occurrence of repeated IEs. The Osmocom TLV parser so
far did the opposite: It reported only the *last* occurrence in
case of
Review at https://gerrit.osmocom.org/6328
msgb: Add msgb_hexdump_{l2,l3}() to dump l2 or l3 part of message buffer
Change-Id: I98e85397fb541ee0fd711f2e1852f63f3bb87359
---
M include/osmocom/core/msgb.h
1 file changed, 10 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6325
a_reset: Add additional "a_reset_alloc" argument
Using this argument we can create the state machine in the
"already connected" state, i.e. without starting an outbound
RESET procedure.
Change-Id: Ibf569d57300965cd47084fa0bff54aa67679e2a1
---
M
Review at https://gerrit.osmocom.org/6326
Don't answer to BSC-originated RESET with another RESET
If the BSC is contacting us for the first time and sending a BSSMAP
RESET, then we should simply ACK that and transition into the
"connected" state, where connection-oriented and connectionless
Don't answer to BSC-originated RESET with another RESET
If the BSC is contacting us for the first time and sending a BSSMAP
RESET, then we should simply ACK that and transition into the
"connected" state, where connection-oriented and connectionless
procedures are permitted.
This patch is a bit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6050
to look at the new patch set (#3).
WIP: VTY: Add 'show connections' and 'show transactions' commands
It is quite important to have some way of runtime state introspection
about the
Patch Set 1:
The above build failure seems dubious.
The build is complaining about a missing header file (osmocom/bsd/acc_ramp.h)
which is a file added by my commit. Have I done something wrong or is this a
bug in the jenkins build?
--
To view, visit https://gerrit.osmocom.org/6324
To
Review at https://gerrit.osmocom.org/6324
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increasing number of MS. This avoids overload at
startup time in cases where a lot of MS would discover the new
cell and
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6309
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44fce36a945042e92ea3f4173e72c1ce5f66fb8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: main.c: bts_main: fix typo in error message
..
main.c: bts_main: fix typo in error message
Change-Id: Ib44fce36a945042e92ea3f4173e72c1ce5f66fb8
---
M
Patch Set 2:
I thought you're adding this to the global .gitignore. Let's please do that,
not a msc-specific one. The names of the symlinked files are the same in all
directories anyway. We must of course then excempt any library/*.ttcn and the
cc files that we have all over the repo, too.
Harald Welte has submitted this change and it was merged.
Change subject: increase RAN timeout in MGCP FSM
..
increase RAN timeout in MGCP FSM
The MGCP FSM implements a timeout when waiting for the RAN to complete
the call
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6320
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a11d53f9701d9b11b18d7026ff2241c7c0b57f5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: init nbits to know value
..
osmo-bts-trx: init nbits to know value
It seems like some of the functions invoked by _sched_dl_burst()
do not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6321
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: ignore frame offset error on startup
..
osmo-bts-trx: ignore frame offset error on startup
Previously we always printed error on startup:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6322
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7cf285e437db0e980e1a2a3ab48a7255945448
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: MGCP: remove hack to fake SDP
..
MGCP: remove hack to fake SDP
A problem with the parameter ordering inside the mgcp-client
(osmo-mgw) prevented TTCN3
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6323
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6316
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic216e5b11d4440f8e106a297714f4f06c1152945
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887ce0c15a831dffeb6251a975337b83942af566
Gerrit-PatchSet: 12
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89d435417306c6bf897274eabc3ed0a46485c26
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: client: add an optional FSM interface
..
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care
Patch Set 1:
do we have a TTCN-3 test case for this in OsmoMSC yet, so we can make sure the
feature works as expected? If not, please provide one (or indicate what is
missing in terms of infrastructure to write one).
--
To view, visit https://gerrit.osmocom.org/6319
To unsubscribe, visit
Patch Set 2:
> Hasm this been tested with omso-stp,MSC and hlr(heavy FSM users)?
I did a manual test with my test-network and the TTCN3 MSC tests. It does not
look any different to me.
(The reason for this patch is that I need to be able to unlink a child FSM from
the cleanup_cb. This is
Patch Set 1:
(2 comments)
Patch Set 2 has also restored the ability for an fsm instance to have NULL
passed as an id. I'm not sure if that was used before, but this way the
behaviour is unchanged.
https://gerrit.osmocom.org/#/c/6316/1/include/osmocom/core/fsm.h
File
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6316
to look at the new patch set (#2).
fsm: Add a function to change the FSM instance ID later
Sometimes we want to create an FSM instance before we know its name. In
that
Review at https://gerrit.osmocom.org/6323
MGCP: remove hack to fake SDP
A problem with the parameter ordering inside the mgcp-client
(osmo-mgw) prevented TTCN3 from accepting the SDP data that
was generated by the IUT. The problem is now fixed and the
hack can be removed.
- remove hack
Review at https://gerrit.osmocom.org/6321
osmo-bts-trx: init nbits to know value
It seems like some of the functions invoked by _sched_dl_burst()
do not sent nbits properly. This leads to a number of errors on
startup:
trx_if.c:593 Tx burst length 65535 invalid
It happens in conjunction
Review at https://gerrit.osmocom.org/6322
osmo-bts-trx: ignore frame offset error on startup
Previously we always printed error on startup:
l1sap.c:461 Invalid condition detected: Frame difference is 627202-0=627202 > 1!
This is expected and of little practical use. Let's suppress it
by
Review at https://gerrit.osmocom.org/6319
mcgp: let the MGW allocate the MGCP endpoint
osmo-msc still uses endpoints that are allocated locally by the
MGCP-Client. Since osmo-mgw now supports the more comfortable,
dynamic variant we should make use of it.
- Replace the endpoint numer
Review at https://gerrit.osmocom.org/6320
increase RAN timeout in MGCP FSM
The MGCP FSM implements a timeout when waiting for the RAN to complete
the call (assignment complete, alerting, connect...). This timeout
is currently set to 10sec. This means if the other end did not pick
up after
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#12).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an
Harald Welte has submitted this change and it was merged.
Change subject: msc: convert bssmap chipher to rsl chiper representation
..
msc: convert bssmap chipher to rsl chiper representation
The representation of the
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6314
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I274c1ff0b5636c48411f994f918e783b468cb3be
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2:
Hasm this been tested with omso-stp,MSC and hlr(heavy FSM users)?
--
To view, visit https://gerrit.osmocom.org/6318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89d435417306c6bf897274eabc3ed0a46485c26
Gerrit-PatchSet: 2
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6314
to look at the new patch set (#2).
msc: convert bssmap chipher to rsl chiper representation
The representation of the chiphering algorithm is different bssmap
and RSL.
Review at https://gerrit.osmocom.org/6318
fsm: do not terminate child FSMs to early
The function _osmo_fsm_inst_term() terminates all child FSMs befor
it calls fi->fsm_cleanup(). This prevnts the cleanup callback to
perform last actions on the child FSMs (e.g.
osmo_fsm_inst_unlink_parent()).
fsm: do not terminate child FSMs early
The function _osmo_fsm_inst_term() terminates all child FSMs befor
it calls fi->fsm_cleanup(). This prevnts the cleanup callback to
perform last actions on the child FSMs (e.g.
osmo_fsm_inst_unlink_parent()).
move the function call to
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: layer23/cell_log: set default logfile to /dev/null
..
layer23/cell_log: set default logfile to /dev/null
When '/var/log/osmocom.log' does not exist
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1:
At least from a quick glance at
https://www.gnu.org/software/gengetopt/gengetopt.html#Mode-options it seems
that gengetopt has support for mutually exclusive options. Did you investigate
that? If we cannot use it for some reason, please include the reason in the
changelog.
--
Patch Set 1:
I agree with the logic change as such, but I'm surprised that the gengetopt
code doesn't already have some kind of support for mutual exclusion. Did you
check if it has any support for it?
--
To view, visit https://gerrit.osmocom.org/6196
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6209
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id608165ae490cb6c84aac1fe70412b2cb2b2587b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: mandatory depend on libc-ares and libgtp
..
mandatory depend on libc-ares and libgtp
Both library are required to build osmo-sgsn.
The optional
1 - 100 of 142 matches
Mail list logo
