osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-02-25 Thread Pau Espin Pedrol
Patch Set 1: > > Why? are you planning to install the qemu-img in there? Easier > than > > /opt for permission-related reasons? > > IMHO: A jenkins job shouldn't do anything outside it's own working > directory. I know this is sometimes hard. Using $HOME/qemu-img is > still not optimal, bu

osmo-gsm-tester[master]: ms: Add a main function to start all of it

2018-02-25 Thread Pau Espin Pedrol
Patch Set 3: Overall it looks fine as a first working step, but I'd like seeing all this a lot better integrated with current osmo-gsm-tester, so that you can re-use more stuff which might be useful (testsuites, test, junit output, configuration of resources, etc.) and we can also re-use later

libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-25 Thread Neels Hofmeyr
Patch Set 4: This is breaking ABI, but not API. In the commit log, I wrote: - I decided against packing the mnc with the mnc_3_digits field into a sub-struct because it would enlarge this patch; plus, with a separate flag, current code can decide when to start heeding leading zeros. Maybe

osmo-gsm-tester[master]: ms: Create template for the osmocom-bb mobile application

2018-02-25 Thread Pau Espin Pedrol
Patch Set 3: I don't know the details, but afaik there's several different apps in osmocom-bb. It may make more sense to name this file "osmo-mobile.cfg.tml". Also, as far as I see, this tmpl is not going to be used by any code in osmo_gsm_tester dir but only on the dir you are adding, so it m

osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-02-25 Thread Pau Espin Pedrol
Patch Set 3: Code-Review-1 I think it makes a lot of sense separating these already in this commit. Better have a OsmoMobile and OsmoVirtPhy classes (put them in the same file if it is easier for you). Have a look for instance at osmo_bsc.py or bts_osmo_trx.py. -- To view, visit https://gerri

osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-02-25 Thread Holger Freyther
Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/6915/3/src/osmo_ms_driver/lua/json.lua File src/osmo_ms_driver/lua/json.lua: Line 41: end > ws, lots of them We are not upstream of this code. Any modification will create unnecessary diff to the upstream version. I should put the curl f

osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

2018-02-25 Thread lynxis lazus
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh File contrib/jenkins.sh: Line 86: if [ -z "${INSIDE_CHROOT}" ]; then > I think this should always be executed, with no condition. Otherwise in the oh yes. you're right. I just looked at the warning (shellcheck).

osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-02-25 Thread lynxis lazus
Patch Set 1: > Why? are you planning to install the qemu-img in there? Easier than > /opt for permission-related reasons? IMHO: A jenkins job shouldn't do anything outside it's own working directory. I know this is sometimes hard. Using $HOME/qemu-img is still not optimal, but at least it doe

osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-02-25 Thread Pau Espin Pedrol
Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/6915/3/src/osmo_ms_driver/lua/json.lua File src/osmo_ms_driver/lua/json.lua: Line 41: end ws, lots of them -- To view, visit https://gerrit.osmocom.org/6915 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerri

osmo-gsm-tester[master]: ms: Create an event server to handle Unix datagram messages

2018-02-25 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6914 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida97c570e8e741410f2dba4a231a8058ca96da25 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

2018-02-25 Thread Pau Espin Pedrol
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/6913/2/src/osmo_ms_driver/simple_loop.py File src/osmo_ms_driver/simple_loop.py: Line 41: You could add extra checking for the maximum len of 107 chars, in case it is truncated at somedirectory level it will fail to be crea

osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-25 Thread Pau Espin Pedrol
Patch Set 3: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/__init__.py File src/osmo_ms_driver/__init__.py: Line 5: # Authors: D. Lazlo Sitzer Better use your name here as this subdir is all from you? https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_dri

[PATCH] osmo-trx[master]: debian: Depend on libtalloc and libosmocore

2018-02-25 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6920 debian: Depend on libtalloc and libosmocore Change-Id: If4bf03d164e9d19a8a21399a2c74b2984c48cc70 --- M debian/control 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/20/6920/1 diff --git

osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-02-25 Thread Holger Freyther
Patch Set 3: > (4 comments) > > Multiple ws... I don't want to fix the json.lua as it is an import from upstream (we don't want a diff here). But I have fixed the ms_support.lua -- To view, visit https://gerrit.osmocom.org/6232 To unsubscribe, visit https://gerrit.osmocom.org/settings Ger

[PATCH] osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-02-25 Thread Holger Freyther
ms: Add lua script support utilities Add a JSON encoder and a small module to sent registration and other events per unix datagram socket. Change-Id: I43ae84a944c7f33e41d5de0880d4aaab3378809b --- A src/osmo_ms_driver/lua/json.lua A src/osmo_ms_driver/lua/ms_support.lua 2 files changed, 411 inser

[PATCH] osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-25 Thread Holger Freyther
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6230 to look at the new patch set (#3). ms: Create a cumulative distribution function class We are using the CDF to decide which percentage of the jobs should

[PATCH] osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-25 Thread Holger Freyther
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6230 to look at the new patch set (#2). ms: Create a cumulative distribution function class We are using the CDF to decide which percentage of the jobs should

[PATCH] osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6917 ms: Create a starter for virtphy and mobile application In the long run we might not want to start the virtphy but for now virtphy+mobile belong together. Start virtphy first as mobile will not handle a missing socket gracefully. Change-Id: I5c6d742842

[PATCH] osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6915 ms: Add lua script support utilities Add a JSON encoder and a small module to sent registration and other events per unix datagram socket. Change-Id: I43ae84a944c7f33e41d5de0880d4aaab3378809b --- A src/osmo_ms_driver/lua/json.lua A src/osmo_ms_driver/l

[PATCH] osmo-gsm-tester[master]: ms: Create template for the osmocom-bb mobile application

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6916 ms: Create template for the osmocom-bb mobile application Change-Id: I9296f42edfab57762f8dd317d63231298cda5430 --- A src/osmo_gsm_tester/templates/osmocom-bb.cfg.tmpl 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org

[PATCH] osmo-gsm-tester[master]: ms: Add a main function to start all of it

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6919 ms: Add a main function to start all of it Add a main file to start everything. All parameters need to be made configurable. Composition of testcase and IMSI ranges need to be configurable as well. This is left for future commits. Right now it can execu

[PATCH] osmo-gsm-tester[master]: ms: Add a first test to use all parts of the system

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6918 ms: Add a first test to use all parts of the system This is an interim solution but is bringing all parts together. We will need to: * Abstract this into a base class * Be able to mix different tests without interfering with each other (e.g. 10k L

[PATCH] osmo-gsm-tester[master]: ms: Create an event server to handle Unix datagram messages

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6914 ms: Create an event server to handle Unix datagram messages Create an EventServer that will create a unix domain socket and dispatch incoming datagram messages. The lua remotes are not passing credentials so this is a one way communication channel for n

[PATCH] osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

2018-02-25 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6913 ms: Create a simple epoll (or kqueue) based event loop Create a C-like single process event loop. It could be powered by select/epoll or kqueue. It should scale to many open fds but we will not have that many. Change-Id: Iea06f33870cab9f21e9a1a1feb9758

[PATCH] osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-02-25 Thread Holger Freyther
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6232 to look at the new patch set (#2). ms: Lua part of location update testing The lua part to start the MS and then signal the first successful Location Update. Change-Id: Ica5aa0c2f86d0e

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

[MERGED] osmo-ci[master]: jenkins: master-builds: replace the label linux_amd64_debian...

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: master-builds: replace the label linux_amd64_debian8/9 -> osmocom-master-debian8/9 .. jenkins: master-builds: replace the label linux_amd64_debi

[MERGED] osmo-ci[master]: jenkins: gerrit-builds: replace the label linux_amd64_debian...

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: gerrit-builds: replace the label linux_amd64_debian8/9 -> osmocom-gerrit-debian8/9 .. jenkins: gerrit-builds: replace the label linux_amd64_debi

[MERGED] osmo-ci[master]: jenkins: add node admin2-deb8build to the update jobs

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: add node admin2-deb8build to the update jobs .. jenkins: add node admin2-deb8build to the update jobs Change-Id: I6b703b9f27865b146f20bea953fe3d

osmo-ci[master]: jenkins: master-builds: replace the label linux_amd64_debian...

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6908 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa3d3f81ab01e2488fe07601740f42eb54b6d9c Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: mas

[MERGED] osmo-ci[master]: jenkins: add node admin2-deb9build to the update jobs

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins: add node admin2-deb9build to the update jobs .. jenkins: add node admin2-deb9build to the update jobs Change-Id: Ie3803a46ee192dc72823291004ee20

osmo-ci[master]: jenkins: gerrit-builds: replace the label linux_amd64_debian...

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6912 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I900b7b50b33cc95e127ca78d2a47f59d32a6dfee Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: mas

osmo-ci[master]: jenkins: add node admin2-deb8build to the update jobs

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6907 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b703b9f27865b146f20bea953fe3d6500a88166 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: mas

osmo-ci[master]: jenkins: add node admin2-deb9build to the update jobs

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3803a46ee192dc72823291004ee20f4bdbe0126 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: mas

osmo-trx[master]: jenkins.sh: fix the download url if the qemu image wasn't setup

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6910 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit

osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-02-25 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 Why? are you planning to install the qemu-img in there? Easier than /opt for permission-related reasons? -- To view, visit https://gerrit.osmocom.org/6909 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56f314

osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

2018-02-25 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/6911/1/contrib/jenkins.sh File contrib/jenkins.sh: Line 86: if [ -z "${INSIDE_CHROOT}" ]; then I think this should always be executed, with no condition. Otherwise in the case in which we call us recursively, the workspace w

osmo-trx[master]: jenkins.sh: fix the download url if the qemu image wasn't setup

2018-02-25 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6910 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/x86_64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build l

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/x86_64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build l

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/x86_64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build l

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/i586

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/i586

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 251

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/aarch64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build l

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/x86_64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/i586

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 132

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/x86_64

2018-02-25 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

[PATCH] osmo-ci[master]: jenkins: gerrit-builds: replace the label linux_amd64_debian...

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6912 jenkins: gerrit-builds: replace the label linux_amd64_debian8/9 -> osmocom-gerrit-debian8/9 Introduce more precise labels to allow more flexibility when extending the jenkins setup. The linux_amd64_debian8 or linux_amd64_debian9 is used across all bui

[PATCH] osmo-trx[master]: jenkins.sh: enable the cleanup workspace after building

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6911 jenkins.sh: enable the cleanup workspace after building Emptyness with a literal string will never be zero. Change-Id: Ib228ff247a72b21b12e8dd4cbe3afe3e858c89d3 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://g

[PATCH] osmo-trx[master]: jenkins.sh: fix the download url if the qemu image wasn't setup

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6910 jenkins.sh: fix the download url if the qemu image wasn't setup Download the image from yesterday because linuxcontainers only contains the images of the last 3 days. Change-Id: I75e270b7255c1cd7fca1674111b0f19fc7bba74f --- M contrib/jenkins.sh 1 file

[PATCH] osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6909 jenkins.sh: change qemu-img default location to $HOME/qemu-img instead of /opt/qemu-img Change-Id: I56f314d78c0ca968b1fef9a91ecd540a7cc8fa86 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29

[PATCH] osmo-ci[master]: jenkins: master-builds: replace the label linux_amd64_debian...

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6908 jenkins: master-builds: replace the label linux_amd64_debian8/9 -> osmocom-master-debian8/9 Introduce more precise labels to allow more flexibility when extending the jenkins setup. The linux_amd64_debian8 or linux_amd64_debian9 is used across all bui

[PATCH] osmo-ci[master]: jenkins: add node admin2-deb8build to the update jobs

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6907 jenkins: add node admin2-deb8build to the update jobs Change-Id: I6b703b9f27865b146f20bea953fe3d6500a88166 --- M jobs/update-osmo-ci-on-slaves.yml M jobs/update-osmo-python-on-slaves.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh:

[PATCH] osmo-ci[master]: jenkins: add node admin2-deb9build to the update jobs

2018-02-25 Thread lynxis lazus
Review at https://gerrit.osmocom.org/6906 jenkins: add node admin2-deb9build to the update jobs Change-Id: Ie3803a46ee192dc72823291004ee20f4bdbe0126 --- M jobs/update-osmo-ci-on-slaves.yml M jobs/update-osmo-python-on-slaves.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh:

[MERGED] osmo-ttcn3-hacks[master]: Merge duplicate SI3 in GSM_RR_Types and GSM_SystemInformation

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Merge duplicate SI3 in GSM_RR_Types and GSM_SystemInformation .. Merge duplicate SI3 in GSM_RR_Types and GSM_SystemInformation Let's have one SI3 definit

[MERGED] osmo-ttcn3-hacks[master]: Helper functions in GSM_Tyes and Osmocom_Types

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Helper functions in GSM_Tyes and Osmocom_Types .. Helper functions in GSM_Tyes and Osmocom_Types Change-Id: Ibd8f215a7cd4564126503c3552bbcceb6d31c779 ---

osmo-ttcn3-hacks[master]: bts: Add some more comments for better code grouping

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6905 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe68067f20d72318716c6a27f02d7bc9b56f1b01 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-ttcn3-hacks[master]: bts: Add TC_ipa_crcx_mdcx_mdcx_dlcx_not_active (2x MDCX on l...

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add TC_ipa_crcx_mdcx_mdcx_dlcx_not_active (2x MDCX on lchan) .. bts: Add TC_ipa_crcx_mdcx_mdcx_dlcx_not_active (2x MDCX on lchan) Change-Id: I58475

[MERGED] osmo-ttcn3-hacks[master]: bts: Set not only SI3 but also SI2+SI4 during initialization

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Set not only SI3 but also SI2+SI4 during initialization .. bts: Set not only SI3 but also SI2+SI4 during initialization Change-Id: I9146792285cdb722

[MERGED] osmo-ttcn3-hacks[master]: bts: Add some more comments for better code grouping

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add some more comments for better code grouping .. bts: Add some more comments for better code grouping Change-Id: Ibe68067f20d72318716c6a27f02d7bc9

osmo-ttcn3-hacks[master]: bts: Set not only SI3 but also SI2+SI4 during initialization

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6904 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9146792285cdb7225150320d1949aaec28290abf Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: Helper functions in GSM_Tyes and Osmocom_Types

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6903 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd8f215a7cd4564126503c3552bbcceb6d31c779 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: Merge duplicate SI3 in GSM_RR_Types and GSM_SystemInformation

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6902 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c4754c9a69cb2fa51d88ef6358d5399dbb29860 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: bts: Add TC_ipa_crcx_mdcx_mdcx_dlcx_not_active (2x MDCX on l...

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6901 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58475e15958002e18cbe9d471bb5c8959bbf7bed Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[PATCH] osmo-ttcn3-hacks[master]: bts: Add some more comments for better code grouping

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6905 bts: Add some more comments for better code grouping Change-Id: Ibe68067f20d72318716c6a27f02d7bc9b56f1b01 --- M bts/BTS_Tests.ttcn 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/change

[PATCH] osmo-ttcn3-hacks[master]: Merge duplicate SI3 in GSM_RR_Types and GSM_SystemInformation

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6902 Merge duplicate SI3 in GSM_RR_Types and GSM_SystemInformation Let's have one SI3 definition rather than multiple... Change-Id: I3c4754c9a69cb2fa51d88ef6358d5399dbb29860 --- M bts/BTS_Tests.ttcn M bts/gen_links.sh M library/GSM_RR_Types.ttcn M library/G

[PATCH] osmo-ttcn3-hacks[master]: bts: Set not only SI3 but also SI2+SI4 during initialization

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6904 bts: Set not only SI3 but also SI2+SI4 during initialization Change-Id: I9146792285cdb7225150320d1949aaec28290abf --- M bts/BTS_Tests.ttcn 1 file changed, 57 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks re

[PATCH] osmo-ttcn3-hacks[master]: bts: Add TC_ipa_crcx_mdcx_mdcx_dlcx_not_active (2x MDCX on l...

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6901 bts: Add TC_ipa_crcx_mdcx_mdcx_dlcx_not_active (2x MDCX on lchan) Change-Id: I58475e15958002e18cbe9d471bb5c8959bbf7bed --- M bts/BTS_Tests.ttcn 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: Helper functions in GSM_Tyes and Osmocom_Types

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6903 Helper functions in GSM_Tyes and Osmocom_Types Change-Id: Ibd8f215a7cd4564126503c3552bbcceb6d31c779 --- M library/GSM_Types.ttcn M library/Osmocom_Types.ttcn 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/o

libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-25 Thread Harald Welte
Patch Set 4: I think it would make sense to introuce a new 'struct gsm_mcc' or the like to encapsulate the uint16_t + bool flag and then use that as function argument rather than always having a mnc _and_ a 'bool thre_digits' argument. Or even start to treat the MNC as a string in the libosmo*

osmo-trx[master]: osmo-trx: Drop cmd lines and use VTY cfg

2018-02-25 Thread Harald Welte
Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/6651/5//COMMIT_MSG Commit Message: Line 7: osmo-trx: Drop cmd lines and use VTY cfg command line (options|arguments) -- To view, visit https://gerrit.osmocom.org/6651 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-Mes

osmo-ttcn3-hacks[master]: bts: Add TC_ipa_crcx_sdcch_not_active (CRCX on SDDCH)

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6900 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8286cc5c36f4abff301f54f831adb672a1661a79 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-ttcn3-hacks[master]: bts: Sleep for some time after RSL is up before using it

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Sleep for some time after RSL is up before using it .. bts: Sleep for some time after RSL is up before using it This is a work-around for an OsmoBSC

[MERGED] osmo-ttcn3-hacks[master]: bts: Add TC_ipa_crcx_sdcch_not_active (CRCX on SDDCH)

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add TC_ipa_crcx_sdcch_not_active (CRCX on SDDCH) .. bts: Add TC_ipa_crcx_sdcch_not_active (CRCX on SDDCH) Change-Id: I8286cc5c36f4abff301f54f831adb6

osmo-ttcn3-hacks[master]: bts: Sleep for some time after RSL is up before using it

2018-02-25 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6899 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a552984a895b08d3f517bdc5844b810eb57700f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[PATCH] osmo-ttcn3-hacks[master]: bts: Sleep for some time after RSL is up before using it

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6899 bts: Sleep for some time after RSL is up before using it This is a work-around for an OsmoBSC bug, see OS#3000 Change-Id: I9a552984a895b08d3f517bdc5844b810eb57700f Related: OS#3000 --- M bts/BTS_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-)

[PATCH] osmo-ttcn3-hacks[master]: bts: Add TC_ipa_crcx_sdcch_not_active (CRCX on SDDCH)

2018-02-25 Thread Harald Welte
Review at https://gerrit.osmocom.org/6900 bts: Add TC_ipa_crcx_sdcch_not_active (CRCX on SDDCH) Change-Id: I8286cc5c36f4abff301f54f831adb672a1661a79 --- M bts/BTS_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/os

[MERGED] osmo-ttcn3-hacks[master]: RSL: Add more IPA related templates

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL: Add more IPA related templates .. RSL: Add more IPA related templates Change-Id: I432c75c25e20dd211c8a429bfd9d407999f6e99a --- M library/RSL_Types.t

[MERGED] osmo-ttcn3-hacks[master]: RSL: ts_RSL_IPA_MDCX_ACK contains *local* IP+Port, not remote

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL: ts_RSL_IPA_MDCX_ACK contains *local* IP+Port, not remote .. RSL: ts_RSL_IPA_MDCX_ACK contains *local* IP+Port, not remote the IPA_MDCX_ACK contains

[MERGED] osmo-ttcn3-hacks[master]: bts: Add TC_ipa_dlcx_not_active()

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add TC_ipa_dlcx_not_active() .. bts: Add TC_ipa_dlcx_not_active() Change-Id: I5c8eec8ba56b35aa8d7df87649389392ffd1a78c --- M bts/BTS_Tests.ttcn M li

[MERGED] osmo-ttcn3-hacks[master]: RSL_Types: Remove RT_PT2 from tr_RSL_IPA_CRCX_ACK

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Types: Remove RT_PT2 from tr_RSL_IPA_CRCX_ACK .. RSL_Types: Remove RT_PT2 from tr_RSL_IPA_CRCX_ACK The way how TTCN-3 templates work we cannot use a

[MERGED] osmo-ttcn3-hacks[master]: bts: TC_ipa_crcx_twice_not_active + TC_ipa_crcx_mdcx_dlcx_no...

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: TC_ipa_crcx_twice_not_active + TC_ipa_crcx_mdcx_dlcx_not_active .. bts: TC_ipa_crcx_twice_not_active + TC_ipa_crcx_mdcx_dlcx_not_active Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: RSL: Make ts_RSL_IPA_DLCX require a conn_id value

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL: Make ts_RSL_IPA_DLCX require a conn_id value .. RSL: Make ts_RSL_IPA_DLCX require a conn_id value The way how TTCN-3 templates work it's not possibl

[MERGED] osmo-ttcn3-hacks[master]: bts: Introduce f_rsl_transceive() and reduce code duplication

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Introduce f_rsl_transceive() and reduce code duplication .. bts: Introduce f_rsl_transceive() and reduce code duplication Change-Id: I56de61e08bd150

osmo-ttcn3-hacks[master]: bts: Introduce f_rsl_transceive() and reduce code duplication

2018-02-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6895 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56de61e08bd1508a0531f720561ead84d1075de3 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-ttcn3-hacks[master]: Osmocom_Types: Add c_UINT16_MAX / c_UINT32_MAX

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Osmocom_Types: Add c_UINT16_MAX / c_UINT32_MAX .. Osmocom_Types: Add c_UINT16_MAX / c_UINT32_MAX Change-Id: I99f3b08b07a46042a8c1e13a420743c58e94603b ---

osmo-ttcn3-hacks[master]: bts: TC_ipa_crcx_twice_not_active + TC_ipa_crcx_mdcx_dlcx_no...

2018-02-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6896 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie643203c4fa4ba0baf5c640d9fd8eaf9fd85cd5b Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: RSL: Make ts_RSL_IPA_DLCX require a conn_id value

2018-02-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6894 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb772ca5b9661ab39b1c161fa4ebc70544275d8f Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-bts[master]: RSL IPA DLCX: Avoid another null-pointer dereference

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL IPA DLCX: Avoid another null-pointer dereference .. RSL IPA DLCX: Avoid another null-pointer dereference In case a DLCX _with conn-id_ is issued with

[MERGED] osmo-ttcn3-hacks[master]: RSL_Types: Add ts_RSL_BCCH_INFO() for sending BCCH_INFO

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Types: Add ts_RSL_BCCH_INFO() for sending BCCH_INFO .. RSL_Types: Add ts_RSL_BCCH_INFO() for sending BCCH_INFO Change-Id: Id9ad914f67137e38c7ad259c7a

[MERGED] osmo-ttcn3-hacks[master]: bts: Type Definition + Template for SI3; Send SI3 at start o...

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Type Definition + Template for SI3; Send SI3 at start of test .. bts: Type Definition + Template for SI3; Send SI3 at start of test The BTS needs s

[MERGED] osmo-ttcn3-hacks[master]: RSL_Emulation: Make CCHAN_PT bi-directional

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Emulation: Make CCHAN_PT bi-directional .. RSL_Emulation: Make CCHAN_PT bi-directional So far we only dispatched received Common Channel messages fro

osmo-ttcn3-hacks[master]: bts: low-level RSL ERROR REPORT Testing

2018-02-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6887 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc6c672d5a0cf8eb8ef23b96eb1e80ceef30f1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-ttcn3-hacks[master]: bts: low-level RSL ERROR REPORT Testing

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: low-level RSL ERROR REPORT Testing .. bts: low-level RSL ERROR REPORT Testing Change-Id: If1cc6c672d5a0cf8eb8ef23b96eb1e80ceef30f1 --- M bts/BTS_Tes

[MERGED] osmo-ttcn3-hacks[master]: bts: Add paging related tests

2018-02-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add paging related tests .. bts: Add paging related tests We're testing at 80% and 200% of PCH capacity, both for either IMSI-only or TMSI-only pagi

osmo-ttcn3-hacks[master]: bts: Add paging related tests

2018-02-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6886 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b80b72bdab3d80d915296d70e1174623fbd8610 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: bts: Type Definition + Template for SI3; Send SI3 at start o...

2018-02-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6885 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dc3724f79e669f52593cd776806d84b4dd4bf5c Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

  1   2   >