[MERGED] osmo-bsc[master]: paging: fix paging attemt rate counter

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: paging: fix paging attemt rate counter .. paging: fix paging attemt rate counter The rate counter BSC_CTR_PAGING_ATTEMPTED does not increment when a

[MERGED] osmo-trx[master]: Logger: Use libosmocore logging system

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Logger: Use libosmocore logging system .. Logger: Use libosmocore logging system We still need an intermediate class Logger due to osmo-trx being

[MERGED] osmo-trx[master]: Add initial support for logging, vty, ctrl

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add initial support for logging, vty, ctrl .. Add initial support for logging, vty, ctrl Up to this point, the logging system, vty and ctrl are

osmo-trx[master]: osmo-trx.cpp: Move trx start and stop to helper functions

2018-02-26 Thread Harald Welte
Patch Set 5: Code-Review+1 Are the new global variables really needed non-static? -- To view, visit https://gerrit.osmocom.org/6648 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10eaaafe38ace2b7bb095a0ad1db70d6c06ee03b

osmo-trx[master]: Logger: Use libosmocore logging system

2018-02-26 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6620 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30baac89f53e927f8699d0586b43cccf88ecd493 Gerrit-PatchSet: 9 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-trx[master]: Add initial support for logging, vty, ctrl

2018-02-26 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6619 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad Gerrit-PatchSet: 9 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] osmo-trx[master]: debian: Depend on libtalloc and libosmocore

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: debian: Depend on libtalloc and libosmocore .. debian: Depend on libtalloc and libosmocore Change-Id: If4bf03d164e9d19a8a21399a2c74b2984c48cc70 --- M

osmo-trx[master]: debian: Depend on libtalloc and libosmocore

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6920 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4bf03d164e9d19a8a21399a2c74b2984c48cc70 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] osmo-bsc[master]: paging: page all bts when no cell is associated

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: paging: page all bts when no cell is associated .. paging: page all bts when no cell is associated When the cell identifier list of the BSSMAP paging

osmo-bsc[master]: paging: fix paging attemt rate counter

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6860 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3eb6724bc655806c3ce3c28448069590d99f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: paging: page all bts when no cell is associated

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6848 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85e3a7540bdc13cd0e780e7870f16c35c6a6a50 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ttcn3-hacks[master]: L1CTL: Add message segmentation helper via getMsgLen()

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review-1 Logging can be removed; got source repo of UD_PT needs change -- To view, visit https://gerrit.osmocom.org/6922 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab33f57cb4311180e521a76307a552d16287b062

osmo-ttcn3-hacks[master]: bts: TC_rach_max_ta

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6924 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd7335f753f8b1a7d91274dc2c99d51d882309d3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Instruct trxcon for TA=2 at every testcase start

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6957 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f07768346e0d68a4dbe36780e36b799d27a7f06 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: Add new f_timer_safe_restart() function for warning-safe res...

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6956 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee83b4905cce3a84eb007ffd189b55f4b54f7cb6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: WIP: bts: SI scheduling tests

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: WIP: bts: SI scheduling tests .. WIP: bts: SI scheduling tests This imports those tests from ../sysinfo/Tests.ttcn which deal with the scheduling of SI,

osmo-ttcn3-hacks[master]: WIP: bts: SI scheduling tests

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6921 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65f4b91e81174717a0c484ba5c22bede68683ae1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-26 Thread Harald Welte
Patch Set 6: 48.008 is the renamed successor of 08.08 so naming is correct. osmo_ prefix is *added* for need api, but not for functions that align with existing API and it is an addition and not a replacement! -- To view, visit https://gerrit.osmocom.org/6509 To unsubscribe, visit

osmo-bsc[master]: bsc_api.c: fix log string format

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6958 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab11ec6c44eb235d327b3776d5f1d82267ddadaa Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: bsc_api.c: fix log string format

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_api.c: fix log string format .. bsc_api.c: fix log string format Fix string format error introduced by recent commit: "bsc_api: drop unknown RR

osmo-bsc[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Harald Welte
Patch Set 2: Are there any ttcn3 tests for this? Seems like an ideal opportunity -- To view, visit https://gerrit.osmocom.org/6668 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa Gerrit-PatchSet:

osmo-pcu[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Harald Welte
Patch Set 1: Weren't there any changes in 0x08 which you must import? -- To view, visit https://gerrit.osmocom.org/ To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I787fed84a7b613158a5618dd5cffafe4e4927234 Gerrit-PatchSet: 1

osmo-sgsn[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Harald Welte
Patch Set 1: How was this tested, particularly the gbproxy changes? -- To view, visit https://gerrit.osmocom.org/6672 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7437dfaa586689e2bef0d4be6537e5577a8f6c26 Gerrit-PatchSet: 1

osmo-bts[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6665 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49cd762c3c9d7ee6a82451bdf3ffa2a060767947 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-msc[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6671 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82f0016d9512ee8722a3489a3cb4b6c704a271fc Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmocore[master]: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp(...

2018-02-26 Thread Harald Welte
Patch Set 5: mncc_from_str: we always have the output argument first, thee input arguments last (think of memcpy) -- To view, visit https://gerrit.osmocom.org/6663 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmocore[master]: gsm0408_test: test new gsm48_{decode, generate}_lai2() functions

2018-02-26 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6661 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Harald Welte
Patch Set 5: I think all (new) functions not dealing with a ts 04.08 encoding should go to the 23.003 source file -- To view, visit https://gerrit.osmocom.org/6659 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-msc[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6671 to look at the new patch set (#2). implement support for 3-digit MNC with leading zeros Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout the code base to

[PATCH] osmo-iuh[master]: hnb-test: log accurate three-digit MNC with leading zeros

2018-02-26 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6670 to look at the new patch set (#2). hnb-test: log accurate three-digit MNC with leading zeros Depends: Id2240f7f518494c9df6c8bda52c0d5092f90f221 (libosmocore) Change-Id:

[ABANDON] libosmocore[master]: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp(...

2018-02-26 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC .. Abandoned change-id mixup -- To view, visit https://gerrit.osmocom.org/6959 To

[PATCH] libosmocore[master]: introduce GSM_MCC_MNC_INVALID

2018-02-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6664 to look at the new patch set (#6). introduce GSM_MCC_MNC_INVALID In some cases, we want to mark an unset MCC-MNC. Define uint16-max for this purpose. osmo-bsc code is

[PATCH] libosmocore[master]: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp(...

2018-02-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6663 to look at the new patch set (#5). gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC osmo_mnc_from_str() preserves leading zeros in the string

[PATCH] libosmocore[master]: gsm0408_test: test new gsm48_{decode, generate}_lai2() functions

2018-02-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6661 to look at the new patch set (#5). gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b --- M

[PATCH] libosmocore[master]: gsm0408_test: add test cases for MNC with leading zeros

2018-02-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6662 to look at the new patch set (#5). gsm0408_test: add test cases for MNC with leading zeros Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c --- M

[PATCH] libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6659 to look at the new patch set (#5). implement support for 3-digit MNC with leading zeros Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are actually

[PATCH] libosmocore[master]: gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp(...

2018-02-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6959 gsm: add osmo_mnc_from_str(), osmo_mnc_cmp(), osmo_plmn_cmp() for 3-digit MNC osmo_mnc_from_str() preserves leading zeros in the string and is useful for VTY config parsing (osmo-bsc, osmo-msc, osmo-sgsn, osmo-pcu). osmo_{plmn,mnc}_cmp() takes care of

[PATCH] osmo-bsc[master]: bsc_api.c: fix log string format

2018-02-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6958 bsc_api.c: fix log string format Fix string format error introduced by recent commit: "bsc_api: drop unknown RR messages." I0a4d311f6939a4fcee59129daa18da4a2ab510ae e4b0ebb25b68d667b9281573638c49358f71007f Change-Id:

libosmocore[master]: implement support for 3-digit MNC with leading zeros

2018-02-26 Thread Neels Hofmeyr
Patch Set 4: > Ok, agreed. However, for new API functions introduced, like > gsm0808_create_layer3_aoip2 in your patch, I would like to see them > take an aggregate structure as input, rather than an endless list > of function arguments. If we create a new function/symbol, we > don't have

libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-26 Thread Neels Hofmeyr
Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h File include/osmocom/gsm/gsm0808_utils.h: Line 64: #define CELL_ID_LIST_GLOBAL_MAXLEN (CELL_ID_LIST_MAXLEN / sizeof(struct osmo_cell_global_id)) > gosh, I'd just define like 128 items for

libosmocore[master]: support for more cell ID list types in libosmocore

2018-02-26 Thread Neels Hofmeyr
Patch Set 6: Code-Review-1 (8 comments) I'd go more towards API stability (deprecate old and add new API naming); and I'd go for less definitions. My opinions are of course not imperative, let's see what others think of my remarks...

osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

2018-02-26 Thread Holger Freyther
Patch Set 3: > (1 comment) https://elixir.bootlin.com/linux/v4.16-rc3/source/include/uapi/linux/un.h#L11 I wasn't aware of that limit.. thanks. -- To view, visit https://gerrit.osmocom.org/6913 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-ttcn3-hacks[master]: bts: Instruct trxcon for TA=2 at every testcase start

2018-02-26 Thread Harald Welte
Review at https://gerrit.osmocom.org/6957 bts: Instruct trxcon for TA=2 at every testcase start as fake_trx keeps running during the entire test suite run, and the protocol being UDP based, it doesn't know when BTS_Test will re-start and hence the old TA/FAKE_TIMING value will remain until it

osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-26 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3 Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-bts[master]: scheduler: Add missing \n at end of LOG statement

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6954 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55419dfa884b4170dfed696a7e1334940a46ba82 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: Add new f_timer_safe_restart() function for warning-safe res...

2018-02-26 Thread Harald Welte
Review at https://gerrit.osmocom.org/6956 Add new f_timer_safe_restart() function for warning-safe restart TITAN will print warnings if a still-running timer is res-started. It will also warn if a not-started timer is stopped, so we need a conditional stop + start if we want to avoid any

[PATCH] osmo-bts[master]: scheduler: Add missing \n at end of LOG statement

2018-02-26 Thread Harald Welte
Review at https://gerrit.osmocom.org/6954 scheduler: Add missing \n at end of LOG statement Change-Id: I55419dfa884b4170dfed696a7e1334940a46ba82 --- M src/common/scheduler.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

[PATCH] osmo-bts[master]: trx/scheduler: Use integer math for TOA (Timing of Arrival)

2018-02-26 Thread Harald Welte
Review at https://gerrit.osmocom.org/6955 trx/scheduler: Use integer math for TOA (Timing of Arrival) There's no need to express TOA as a float: * We receive it as signed 16bit integer in units 1/256 symbol periods * We pass it to L1SAP as signed integer in 1/4 symbol periods So turn it into

[PATCH] osmo-bsc[master]: paging: fix paging attemt rate counter

2018-02-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6860 to look at the new patch set (#2). paging: fix paging attemt rate counter The rate counter BSC_CTR_PAGING_ATTEMPTED does not increment when a paging request is sent to the BSC. The

osmo-bsc[master]: paging: page all bts when no cell is associated

2018-02-26 Thread dexter
Patch Set 1: > would be great to include a spec reference in the commit log and > possibly even in the code/comment. thanks! I have looked for more details (also in the books we have) but I could not find any description how exactly should be paged if a certain cell identifier is present.

[PATCH] osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-02-26 Thread Holger Freyther
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6915 to look at the new patch set (#4). ms: Add lua script support utilities Add a JSON encoder and a small module to sent registration and other events per

[PATCH] osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-02-26 Thread Holger Freyther
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6232 to look at the new patch set (#5). ms: Lua part of location update testing The lua part to start the MS and then signal the first successful Location Update. Change-Id:

[PATCH] osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-26 Thread Holger Freyther
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6230 to look at the new patch set (#4). ms: Create a cumulative distribution function class We are using the CDF to decide which percentage of the jobs

osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-26 Thread Pau Espin Pedrol
Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/cdf.py File src/osmo_ms_driver/cdf.py: Line 89: Linear progression that reaches 100% after duration.total_seconds() > As a follow-up please. What is the reasoning for it? What is the concern ag I'm not

osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-02-26 Thread Holger Freyther
Patch Set 4: > (1 comment) It is but that wasn't the intent. $ lua > function foo(one) >> if one==1then >> print("IS ONE") >> end >> end > foo(1) IS ONE > foo(2) ... -- To view, visit https://gerrit.osmocom.org/6232 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-02-26 Thread Holger Freyther
Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/6230/3/src/osmo_ms_driver/__init__.py File src/osmo_ms_driver/__init__.py: Line 5: # Authors: D. Lazlo Sitzer > Better use your name here as this subdir is all from you? That's not how copyright works but you have

[PATCH] osmo-bsc[master]: bsc_api: fix formatstring in log message

2018-02-26 Thread dexter
Review at https://gerrit.osmocom.org/6953 bsc_api: fix formatstring in log message The log message that is displayed when an unknown RR message is detected contains an excess placeholder in its format string. - correct format string. This is a follow-up to the following change: Change-Id

[ABANDON] osmo-gsm-tester[master]: cdf: Add API to scale percent to target value

2018-02-26 Thread Holger Freyther
Holger Freyther has abandoned this change. Change subject: cdf: Add API to scale percent to target value .. Abandoned -- To view, visit https://gerrit.osmocom.org/6231 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmo-gsm-tester[master]: WIP.. use gerrit as backup

2018-02-26 Thread Holger Freyther
Holger Freyther has abandoned this change. Change subject: WIP.. use gerrit as backup .. Abandoned -- To view, visit https://gerrit.osmocom.org/6233 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmo-gsm-tester[master]: WIP.. figure out asyncio..

2018-02-26 Thread Holger Freyther
Holger Freyther has abandoned this change. Change subject: WIP.. figure out asyncio.. .. Abandoned -- To view, visit https://gerrit.osmocom.org/6234 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-bsc[master]: a_reset: Add FSM event names

2018-02-26 Thread dexter
Review at https://gerrit.osmocom.org/6952 a_reset: Add FSM event names The FSM lacks a proper definition of the FSM event names. This causes problems when inspecting the FSM using the VTY. - Add proper FSM Event names Change-Id: Ief1eff45a896d6191bdc64c232be69e85bfc63dc Related: OS#2924 ---

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/aarch64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/x86_64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/x86_64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/i586

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/i586

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/x86_64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/x86_64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/i586

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/x86_64

2018-02-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-26 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6861 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

libosmo-netif[master]: test: osmo-pcap-test: Fix clock drift while replaying pcap file

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6949 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11cb9a63e16e829ccd4af1096b9f473c802d822f Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

[MERGED] libosmocore[master]: ensure VTY commands don't segfault if an FSM has no event names

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ensure VTY commands don't segfault if an FSM has no event names .. ensure VTY commands don't segfault if an FSM has no event names If no event names are

libosmocore[master]: ensure VTY commands don't segfault if an FSM has no event names

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6950 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87457945a7b76aa052305c9c531722be1ea0c1d1 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: print BIG FAT ERROR message if osmo_fsm lacks event names

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: print BIG FAT ERROR message if osmo_fsm lacks event names .. print BIG FAT ERROR message if osmo_fsm lacks event names Event names are displayed in VTY

libosmocore[master]: print BIG FAT ERROR message if osmo_fsm lacks event names

2018-02-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6951 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b100d62b5c50bf025ef87d31ea39072539cf37 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: print BIG FAT ERROR message if osmo_fsm lacks event names

2018-02-26 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6951 print BIG FAT ERROR message if osmo_fsm lacks event names Event names are displayed in VTY commands so all FSM should have them. Print an error message if an FSM is registered without event names. We could also return an error code, however at present

[PATCH] libosmocore[master]: ensure VTY commands don't segfault if an FSM has no event names

2018-02-26 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6950 ensure VTY commands don't segfault if an FSM has no event names If no event names are defined for an FSM, show a placeholder message which points out the problem instead of segfaulting. Change-Id: I87457945a7b76aa052305c9c531722be1ea0c1d1 Related:

[PATCH] libosmo-netif[master]: test: osmo-pcap-test: Fix clock drift while replaying pcap file

2018-02-26 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6949 test: osmo-pcap-test: Fix clock drift while replaying pcap file In the previous implementation, the processing time was not being taken into account, which was implicitly added for each new packet to be sent, which caused a steady incremental drift in

[PATCH] libosmocore[master]: core: Add timespec helper macros and make timer_compat.h public

2018-02-26 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6948 core: Add timespec helper macros and make timer_compat.h public If a monotonic clock must be used, then the clock_gettime API is used which uses timespec structures. Linux systems by default don't provide helpers to calculate time using timespecs, so

[PATCH] osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-26 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6861 to look at the new patch set (#3). bsc_api: drop unknown RR messages. Radio Resource (RR) handling is entirely done inside the BSC. However, the current implementation

[MERGED] osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc_mgcp: Add FSM event names .. msc_mgcp: Add FSM event names The FSM (fsm_msc_mgcp) lacks a proper definition of the FSM event names. This causes

osmo-msc[master]: a_reset: Add FSM event names

2018-02-26 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6930 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d7d9e0accffd433a3f3b5e5f8ab17ecd4a348c Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6947 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6823756a63b08a71e5518130e49751aa073dbcd2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: a_reset: Add FSM event names

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: a_reset: Add FSM event names .. a_reset: Add FSM event names The FSM lacks a proper definition of the FSM event names. This causes problems when

[MERGED] osmo-mgw[master]: mgcp_client_fsm: Add FSM event names

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mgcp_client_fsm: Add FSM event names .. mgcp_client_fsm: Add FSM event names The FSM lacks a proper definition of the FSM event names. This causes

osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-26 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/6861/2/src/libbsc/bsc_api.c File src/libbsc/bsc_api.c: Line 778:"BSC: Dropping %s 04.08 RR message from %s\n", sorry, but where do we normally put context information? Always at the beginning of the log

osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/6861 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-mgw[master]: cosmetic: mgcp_client_fsm: rename enums

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: mgcp_client_fsm: rename enums .. cosmetic: mgcp_client_fsm: rename enums The enum defining the event and state identifiers is prefixed with

osmo-mgw[master]: mgcp_client_fsm: Add FSM event names

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6937 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0990abea2e9fd92546e7b337b5ff3d6f0866321 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[PATCH] osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6861 to look at the new patch set (#2). bsc_api: drop unknown RR messages. Radio Resource (RR) handling is entirely done inside the BSC. However, the current implementation forwards unknown

[PATCH] osmo-mgw[master]: mgcp_client_fsm: Add FSM event names

2018-02-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6937 to look at the new patch set (#2). mgcp_client_fsm: Add FSM event names The FSM lacks a proper definition of the FSM event names. This causes problems when inspecting the FSM using the

osmo-msc[master]: a_reset: Add FSM event names

2018-02-26 Thread dexter
Patch Set 2: (2 comments) > Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/380/ https://gerrit.osmocom.org/#/c/6930/1/src/libcommon-cs/a_reset.c File src/libcommon-cs/a_reset.c: Line 46: static const struct value_string fsm_event_names[] = { > why is it called gscon if

[PATCH] osmo-msc[master]: a_reset: Add FSM event names

2018-02-26 Thread dexter
Hello Stefan Sperling, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6930 to look at the new patch set (#3). a_reset: Add FSM event names The FSM lacks a proper definition of the FSM event names. This causes problems when inspecting the FSM

[PATCH] osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6947 to look at the new patch set (#2). msc_mgcp: Add FSM event names The FSM (fsm_msc_mgcp) lacks a proper definition of the FSM event names. This causes problems when inspecting the FSM

osmo-msc[master]: a_reset: Add FSM event names

2018-02-26 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/6930/2/src/libcommon-cs/a_reset.c File src/libcommon-cs/a_reset.c: Line 47:{EV_RESET_ACK, "EV_RESET_ACK"}, OSMO_VALUE_STRING -- To view, visit https://gerrit.osmocom.org/6930 To unsubscribe, visit

  1   2   >