Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#10).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell identi
Patch Set 9:
(11 comments)
https://gerrit.osmocom.org/#/c/6509/9/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 32: #define GSM0808_CELL_ID_LIST2_MAXLEN 128
> from (255-1)/2 the theoretical max is 127, would be nice to explain that in
Yes, comment i
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6594
to look at the new patch set (#6).
bsc_vty: Merge more VTY documentation string #defines
Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
---
M src/libbsc/bsc_vty.c
1
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6594
to look at the new patch set (#5).
bsc_vty: Merge more VTY documentation string #defines
Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
---
M src/libbsc/bsc_vty.c
1
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6594
to look at the new patch set (#4).
bsc_vty: Merge more VTY documentation string #defines
Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
---
M src/libbsc/bsc_vty.c
1
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6594
to look at the new patch set (#3).
bsc_vty: Merge more VTY documentation string #defines
Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
---
M src/libbsc/bsc_vty.c
1
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: fake_trx/data_msg.py: use a single unified constructor
..
fake_trx/data_msg.py: use a single unified constructor
There are no message specific initial
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: fake_trx/data_msg.py: fix python3 compatibility in tests
..
fake_trx/data_msg.py: fix python3 compatibility in tests
In Python3 a range has it's own t
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: fake_trx/data_dump.py: fix python3 compatibility
..
fake_trx/data_dump.py: fix python3 compatibility
There is no 'file' type in Python3 anymore, so le
dexter has submitted this change and it was merged.
Change subject: Align syntax of "handover" + "assignment" command with that of
lchan act/deact
..
Align syntax of "handover" + "assignment" command with that of lchan act/de
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fc83a1a07db9c569b93f29835bf3a0fd8ef4ef5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6992/1/src/osmo-bts-octphy/l1_tch.c
File src/osmo-bts-octphy/l1_tch.c:
Line 122: #pragma message ("We don't support EFR with L1 that doesn't support
RTP mode!")
> Yes I think this warning is legitimate. Octbts does not support E1, so RTP
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6593
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f31e9adf9c75348809ebf9f40f6c69fab248e43
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6994
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I650133563436349d4ce55f292ea683dbb2ae68d7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review-1
I think the proper location for this feature list is in libosmcoore. So rather
than adding more entries, I think it should be renamed to osmo_bts_features and
merged to libosmcoore, followed by both osmo-bts and osmo-bsc being converted
to using the libosmcoroe defin
Patch Set 1:
> @neels (or others): Do you think we should install an alias for
> backwards compatibility? I think it's not worth it. It's not a
> config node (i.e. no old config files relevant) and only a
> debugging command anyway...
I also think that an alias is not necessary as long as co
Review at https://gerrit.osmocom.org/6993
gsm_data: update feature list
The feature list of the BTS features has been extended with voice
codec capabilities but osmo-bsc does not yet know the meaning of
those bits.
- update feature list
Change-Id: I3e80517539cc5d0e5d8189d434a5e3cc0fdea1a0
---
Review at https://gerrit.osmocom.org/6994
bsc_vty: display bts features in show bts
The command show bts displays all kind of BTS related info, but it
does not display the bts features yet.
- display bts specific features in vty-command show bts
Change-Id: I650133563436349d4ce55f292ea683dbb2a
Patch Set 1: Code-Review-1
There is a missing part.
--
To view, visit https://gerrit.osmocom.org/6990
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b88740f4d782ac7591fc096d1969514784a4e1
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Patch Set 3:
> Good idea. I would prefer to have the following:
>
> CMD FAKE_TOA
>
> where both values define a range of ToA randomization:
>
> min: TOA_BASE - TOA_TRESHOLD
> max: TOA_BASE + TOA_TRESHOLD
In tests, you normally don't want randomization, but you want reproducible
resu
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fc83a1a07db9c569b93f29835bf3a0fd8ef4ef5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
> (1 comment)
https://gerrit.osmocom.org/#/c/6992/1/src/osmo-bts-octphy/l1_tch.c
File src/osmo-bts-octphy/l1_tch.c:
Line 122: #pragma message ("We don't support EFR with L1 that doesn't support
RTP mode!")
> No associated ticket for this one?
Yes I think this warning
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6992/1/src/osmo-bts-octphy/l1_tch.c
File src/osmo-bts-octphy/l1_tch.c:
Line 122: #pragma message ("We don't support EFR with L1 that doesn't support
RTP mode!")
No associated ticket for this one?
--
To view, visit https://gerrit.osmoco
Review at https://gerrit.osmocom.org/6992
octphy: replace #warning with #pragma message
warning causes the compiler to throw an actual warning. Lets
change those intentional warnings to messages.
Change-Id: I2fc83a1a07db9c569b93f29835bf3a0fd8ef4ef5
---
M src/osmo-bts-octphy/l1_if.c
M src/osmo-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6968
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3bc840c0428d08dfbeedacc408b3dd1cd0fa7ec
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: BSC_Tests: try to avoid race condition
..
BSC_Tests: try to avoid race condition
When the test component ends and the underlaying
components are shut dow
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6983
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic676bb046a8ee254b9ee8d0d126ce79e6057cfb3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: pcuif_proto.h: fix whitespaces and indention
..
pcuif_proto.h: fix whitespaces and indention
Change-Id: Ic676bb046a8ee254b9ee8d0d126ce79e6057cfb3
---
M i
Harald Welte has submitted this change and it was merged.
Change subject: pcuif_proto.h: add features of version 7 (txt indication)
..
pcuif_proto.h: add features of version 7 (txt indication)
The txt indication has been introd
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6981
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67f8ec036e219994cc296d0ed5409da7f3ec681e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6984
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafef7dae8b84f659a1aca1677b30a38a2e5558dc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6982/1/include/osmo-bts/pcuif_proto.h
File include/osmo-bts/pcuif_proto.h:
Line 65:uint32_tfn;
it might be useful to state which fiels are expected to be populted in which
case. By simply adding those definitions to bsc/b
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6980
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39f3bc1f0a1e238f8f00cb00e2d1e5193f118c16
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: pcuif_proto: correct indention of gsm_pcu_if_data
..
pcuif_proto: correct indention of gsm_pcu_if_data
Change-Id: I39f3bc1f0a1e238f8f00cb00e2d1e5193f118c
Review at https://gerrit.osmocom.org/3332
Edit Project Config
Change-Id: Iad6fc9e6f3995a2f6c06c3f5cecea748d2b4a83d
---
0 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/32/3332/1
--
To view, visit https://gerrit.osmocom.org/33
Holger Freyther has abandoned this change.
Change subject: Edit Project Config
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3332
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: aband
Patch Set 3: Code-Review-1
Hi Harald,
finally, the TRX Toolkit also migrated to the integer math now ;)
> actually, I think setting an absolute value is not a good idea. We
> should be able to set/configure a _delta_ value.
Good idea. I would prefer to have the following:
CMD FAKE_TOA
Harald Welte has submitted this change and it was merged.
Change subject: pcuif_proto: add version 8 features
..
pcuif_proto: add version 8 features
Add PCU_IF_MSG_DATA_CNF_DT and PCU_IF_SAPI_AGCH_DT to bring the
pccif_proto in
Harald Welte has submitted this change and it was merged.
Change subject: pcuif_proto.h: fix whitespaces and indention
..
pcuif_proto.h: fix whitespaces and indention
Change-Id: I290967346af4e2707cfdfb62dccaccd43d195443
---
M i
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6985
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290967346af4e2707cfdfb62dccaccd43d195443
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6986
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaf151447e5556b911be7e2483b7c154fc5ec42e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review-1
ad indicated, I think the much better option is to have a delta/relative value,
like setting the "path loss" for RSSI as well as the "propagation dlay" for
TOA. This way the full timing advance and/or power control loops can be
tested in virtual setups.
--
To vie
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6991
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib11482c06b977c4cf01b0644f5845a2e49d059fb
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6990
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b88740f4d782ac7591fc096d1969514784a4e1
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6989
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13a3e4b2f6a1f443ebe7d809df62736e3c43f56f
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6987
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c40d3d63cbcdc3e5dc840ebf8d7310c5c08e56
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6988
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00c7f0bd5871fcfce931a4bfa501ae5bf797c45
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Review at https://gerrit.osmocom.org/6990
fake_trx/data_msg.py: use integer math for ToA
In order to avoid both float arithmetic as well as loosing any
precision, let's use integer math fot ToA (Timing of Arrival),
i.e. let's express ToA values in units 1/256 symbol periods.
Change-Id: I56b887
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6846
to look at the new patch set (#3).
fake_trx/ctrl_if_bb.py: add FAKE_RSSI and FAKE_TOA commands
At the moment, the BurstForwarder performs simple randomization
of both RSSI
Review at https://gerrit.osmocom.org/6989
fake_trx/data_msg.py: use a single unified constructor
There are no message specific initialization parts, excepting
the header specific fields setting. Let's us a common constructor,
dropping custom fields from its arguments.
Change-Id: I13a3e4b2f6a1f
Review at https://gerrit.osmocom.org/6991
fake_trx/data_msg.py: implement ToA parsing support
This change implements ToA (Timing of Arrival) parsing, which
was missing in the DATAMSG_TRX2L1. Since we use integer math,
a ToA value is represented in units 1/256 symbol periods.
Change-Id: Ib11482
Review at https://gerrit.osmocom.org/6987
fake_trx/data_msg.py: fix python3 compatibility in tests
In Python3 a range has it's own type, so its comparasion with
a list is incorrect. Let's explicitly convert both bit ranges
to lists in the bit conversation tests.
Change-Id: I98c40d3d63cbcdc3e5d
Review at https://gerrit.osmocom.org/6988
fake_trx/data_dump.py: fix python3 compatibility
There is no 'file' type in Python3 anymore, so let's reverse the
condition in DATADumpFile constructor. Also, the tag definition
was incorrect: both '\x01' and b'\x01' aren't the same.
Change-Id: Ib00c7f
101 - 153 of 153 matches
Mail list logo
