Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7148
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7172
Transceiver.cpp: use pointer arithmetics for CMD parsing
It looks like the author of control command parsing code was not
familar with simple pointer arithmetics, so excessive amount of
memory and useless memcopying was used to parse a single command.
Review at https://gerrit.osmocom.org/7173
Transceiver.cpp: fix incorrect format string for SETTSC
Change-Id: If69a478121a31aa7df945548cc17271c476d6a6b
---
M Transceiver52M/Transceiver.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Review at https://gerrit.osmocom.org/7171
Transceiver.cpp: properly zero-terminate received commands
Previously it was assumed that a sender should zero-terminate
each command being sent. Otherwise, this could cause to printing
garbage. Let's do this manually, using the length of received
data
Review at https://gerrit.osmocom.org/7174
Transceiver.cpp: prevent out-of-range array access
There was no a simple range check for both (NO)HANDOVER commands,
so an out-of-range access was possible. For example, a command:
CMD HANDOVER 0 -3
might enable EDGE at run-time, because:
a[i]
Review at https://gerrit.osmocom.org/7170
Transceiver.cpp: use a define for the MAX_PACKET_LENGTH
No need to keep this value on stack.
Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7
---
M Transceiver52M/Transceiver.cpp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
Vadim Yanitskiy has abandoned this change.
Change subject: src/msgb.c: mark *tall_msgb_ctx as static
..
Abandoned
Didn't know about that.
Ok, let's keep the compatibility.
--
To view, visit https://gerrit.osmocom.org/7163
To
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7165
to look at the new patch set (#2).
src/msgb.c: avoid using internal talloc API
An internal symbol '_talloc_zero' of talloc library was used
during a msgb allocation. This is not
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7165/1/src/msgb.c
File src/msgb.c:
Line 90:talloc_set_name_const(msg, name);
> does this mean that talloc internally first generates a different name (pos
You're right, I just looked at the source code
of talloc, and yes, this
Harald Welte has submitted this change and it was merged.
Change subject: Fix no-return-in-nonvoid-function ipaccess-auth.c:80
..
Fix no-return-in-nonvoid-function ipaccess-auth.c:80
OBS post-build check complained:
Harald Welte has submitted this change and it was merged.
Change subject: build: check for libcrypto and libssl
..
build: check for libcrypto and libssl
Use PKG_CHECK_MODULES to check for libcrypto and libssl
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/7156
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I442603f9fa3f648cb552f5e9daf6e0fd49776eff
Gerrit-PatchSet: 1
Gerrit-Project: libtelnet
Gerrit-Branch:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/7157
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1368f308f0af6ac88334002a8aa1e90737e563b
Gerrit-PatchSet: 1
Gerrit-Project: libtelnet
Gerrit-Branch:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7165/1/src/msgb.c
File src/msgb.c:
Line 90:talloc_set_name_const(msg, name);
does this mean that talloc internally first generates a different name
(possibly using sprintf, ...) before we set it to something else? Then this
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7161
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b473aadaa22d95f2a8cc87580c638ccd7e531a4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7164
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2d1beabd6936fc28a1ad664c083ff1698bb644
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7162
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief562a6e5b220a84902f95862d67279f953ee726
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review-1
In GSM, "power control" refers to adjusting the transmit power of either the MS
or BTS. Pleaes let's not use such general terms with pre-existing meaning to
avoid confusion.
PowerOnOff? PowerCycle? PowerSupplyCtrl?
--
To view, visit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7166
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ba38f7d81134e5f0ca28fa684fdb09c753bb04
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7159
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7158/1/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:
Line 3: # Copyright (C) 2016-2017 by sysmocom - s.f.m.c. GmbH
2018 only? the file didn't exist in 2016/2017, I presume? or is this code moved?
--
To view,
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7160/1/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:
Line 3: # Copyright (C) 2016-2017 by sysmocom - s.f.m.c. GmbH
2018?
--
To view, visit https://gerrit.osmocom.org/7160
To unsubscribe, visit
Patch Set 2:
just noting that in general we could also consider to either
a) not re-cycle the msgb with msgb_trim() but allocate a new one
b) have the L1SAP primitive on the stack and pass that up (not sure if L1SAP
currently supports this for all primitives, but I know at least in one case
Patch Set 1:
NOTE: I HAVE ONLY TESTED ON SYSMOBTS. We should still test on octphy and
litecell15. litecell15 probably is fine because of practically identical code,
but octphy might not be.
--
To view, visit https://gerrit.osmocom.org/7169
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7169
to look at the new patch set (#2).
fix handover: handle_ph_ra_ind(): evaluate ra_ind before msgb_trim()
Commit c2b4c668f3510b7b0baace749c5a310959010e90
Patch Set 1:
yes, I understand. Well, it was new to me anyhow.
--
To view, visit https://gerrit.osmocom.org/7121
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ce33a4e42bc82b9ce5060e2f811033f5a1f8d8
Gerrit-PatchSet: 1
Gerrit-Project:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: handover_test: explicitly wrap abis_rsl_sendmsg()
..
handover_test: explicitly wrap abis_rsl_sendmsg()
Until now, handover_test simply defines an
Review at https://gerrit.osmocom.org/7169
fix handover: handle_ph_ra_ind(): evaluate ra_ind before msgb_trim()
Commit c2b4c668f3510b7b0baace749c5a310959010e90
I3b989580cb38082e3fd8fc50a11fedda13991092 introduces evaluation of ra_ind
members below the msgb_trim() call that actually invalidates
Review at https://gerrit.osmocom.org/7168
WIP: Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M example/resources.conf
A example/scenarios/nanobts.conf
A src/osmo_gsm_tester/bts_nanobts.py
M src/osmo_gsm_tester/resource.py
4 files changed, 129
Review at https://gerrit.osmocom.org/7166
pcu.py: Introduce PcuDummy class
It will be used in later commits by BTS without proper PCU control such
as NanoBts.
Change-Id: I37ba38f7d81134e5f0ca28fa684fdb09c753bb04
---
M src/osmo_gsm_tester/pcu.py
1 file changed, 13 insertions(+), 0 deletions(-)
Review at https://gerrit.osmocom.org/7167
Introduce PowerCtrl interface and PowerCtrlSispm
File powerctrl.py defines the interface to be used by child classes
implementing it. It also provides helpers to allocate a child class
based on configuration provided ('type' field).
File
Review at https://gerrit.osmocom.org/7162
src/msgb.c: remove dead includes from OpenBSC
The MSGB API is not a part of OpenBSC anymore, so let's remove
dead includes, which were probably left here during the
migration process.
Change-Id: Ief562a6e5b220a84902f95862d67279f953ee726
---
M
Review at https://gerrit.osmocom.org/7163
src/msgb.c: mark *tall_msgb_ctx as static
There is no need to expose the internal root talloc context.
A pointer to it can be obtained by calling msgb_talloc_ctx_init().
Change-Id: I45b25e1bb762e7d4a271f76c6e7c8616fe98efe4
---
M src/msgb.c
1 file
Review at https://gerrit.osmocom.org/7161
src/msgb.c: cosmetic: fix spelling mistakes
Change-Id: I6b473aadaa22d95f2a8cc87580c638ccd7e531a4
---
M src/msgb.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/7161/1
diff --git
Review at https://gerrit.osmocom.org/7164
src/msgb.c: print an error if msgb allocation failed
Printing an error message when msgb allocation failed was initially
intended, but have been commented out for years. This would
facilitate the bug hunting process, especially on embedded
platforms
Review at https://gerrit.osmocom.org/7165
src/msgb.c: avoid using internal talloc API
An internal symbol '_talloc_zero' of talloc library was used
during a msgb allocation. This is not actually good because:
- it may be removed or modified by talloc developers;
- the behaviour may be
Review at https://gerrit.osmocom.org/7159
bts_osmo.py: ready_for_pcu is of public access from tests, move it accordingly
Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1
---
M src/osmo_gsm_tester/bts_osmo.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7158
Create Pcu abstract class and make OsmoPcu inherit from it
This base class will be used to describe the required accessors for all
PCU objects.
It is introduced in this commit and will be further used in the future
when adding a Dummy PCU object which
Review at https://gerrit.osmocom.org/7160
Create Bts abstract class and make OsmoBts inherit from it
This base class will be used to describe the required accessors for all
BTS objects, be it an osmocom BTS or not.
It is introduced in this commit and will be further used in the future
when
Review at https://gerrit.osmocom.org/7157
Fix no-return-in-nonvoid-function ipaccess-auth.c:80
OBS post-build check complained:
Change-Id: Id1368f308f0af6ac88334002a8aa1e90737e563b
I: Program returns random data in a function
E: libtelnet no-return-in-nonvoid-function ipaccess-auth.c:80
---
M
Review at https://gerrit.osmocom.org/7156
build: check for libcrypto and libssl
Use PKG_CHECK_MODULES to check for libcrypto and libssl
Change-Id: I442603f9fa3f648cb552f5e9daf6e0fd49776eff
---
M configure.ac
1 file changed, 4 insertions(+), 0 deletions(-)
git pull
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7148
to look at the new patch set (#2).
Build Transceiver52M/common as an .la lib
Stop picking files from that directory on different places as it causes
dependency issues during make
Patch Set 2: Code-Review-1
better description required
--
To view, visit https://gerrit.osmocom.org/7154
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee66d4a2eab520dfc115ffeb16ab6413e4057973
Gerrit-PatchSet: 2
Gerrit-Project:
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7153/2/library/LAPDm_RAW_PT.ttcn
File library/LAPDm_RAW_PT.ttcn:
Line 30://uint8_t tfi,
this shouldn't be added
--
To view, visit https://gerrit.osmocom.org/7153
To unsubscribe, visit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7155
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3350e7e1a9d6715ab81f4a5f413b7e4d728ff60
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7152/2/library/NS_Emulation.ttcn
File library/NS_Emulation.ttcn:
Line 87://f_sendReset();
this cannot be in an upstream commit.
--
To view, visit https://gerrit.osmocom.org/7152
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7153
to look at the new patch set (#2).
WIP: working UL TBF with segmentation
Change-Id: I0f93246f02e1bee2e1e9db62af5e1e3559c415e9
---
A gprs_gb/GPRS_Context.ttcn
A gprs_gb/GPRS_TBF.ttcn
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7155
to look at the new patch set (#2).
pcu: Rename 'gprs_gb/Test' tp 'pcu/PCU_Tests' to align with other suites
Change-Id: Ia3350e7e1a9d6715ab81f4a5f413b7e4d728ff60
---
M Makefile
R
Review at https://gerrit.osmocom.org/7154
WIP: pcu testing
Change-Id: Iee66d4a2eab520dfc115ffeb16ab6413e4057973
---
M gprs_gb/Test.ttcn
1 file changed, 47 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/54/7154/1
diff --git
Review at https://gerrit.osmocom.org/7155
pcu: Rename 'gprs_gb/Test' tp 'pcu/PCU_Tests' to align with other suites
Change-Id: Ia3350e7e1a9d6715ab81f4a5f413b7e4d728ff60
---
M Makefile
A pcu/GPRS_Context.ttcn
A pcu/GPRS_TBF.ttcn
R pcu/PCU_Tests.cfg
R pcu/PCU_Tests.ttcn
R pcu/gen_links.sh
R
Review at https://gerrit.osmocom.org/7153
WIP: working UL TBF with segmentation
Change-Id: I0f93246f02e1bee2e1e9db62af5e1e3559c415e9
---
M gprs_gb/Test.ttcn
M library/GSM_Types.ttcn
M library/LAPDm_RAW_PT.ttcn
M library/Osmocom_Types.ttcn
M library/RLCMAC_EncDec.cc
M library/RLCMAC_Types.ttcn
Review at https://gerrit.osmocom.org/7152
WIP: working Uplink PACKET_CONTROL_ACK
Change-Id: I2c7d0eb9371911e28f328caeaed63cb8ec311ac1
---
M Common.cfg
M gprs_gb/Test.ttcn
M library/L1CTL_Types.ttcn
M library/LAPDm_RAW_PT.ttcn
M library/NS_Emulation.ttcn
M library/Osmocom_Gb_Types.ttcn
M
Patch Set 1:
> > Why do you need each of this?
> > -Wno-error=deprecated -Wno-error=deprecated-declarations
> > -Wno-error=cpp
>
> it's all explained in the commit log as well as the ./configure
> --help
Regarding deprecated, I think it's good that it fails when using a deprecated
53 matches
Mail list logo
