Patch Set 7:
Hmm.. So even with _prep missing the test should have been executed... I am
retriggering the build and check if the workspace is updated..
https://jenkins.osmocom.org/jenkins/job/osmo-gsm-tester_gerrit/ws/osmo-gsm-tester/selftest/
doesn't contain a cdf_test.py... that's strange..
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/armv7l
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7333
to look at the new patch set (#2).
pcu_sock.c: Avoid breaking strict-aliasing on ptr derreference
Fixes following warning:
pcu_sock.c: In function 'pcu_rx_data_req':
pcu_sock.c:406:3:
Patch Set 1:
Still cannot be merged due to warnings in lc15 specific parts:
osmo-bts-litecell15/lc15_l1_if.c: In function ‘prim_init’:
osmo-bts-litecell15/lc15_l1_if.c:79:33: error: cast to pointer from integer of
different size [-Werror=int-to-pointer-cast]
prim->u.mphCloseReq.hLayer1 =
Pau Espin Pedrol has abandoned this change.
Change subject: contrib/jenkins.sh: Enable Werror
..
Abandoned
Abandoning since it seems we will use --enable-werror configure flag anyway.
--
To view, visit
Review at https://gerrit.osmocom.org/7333
pcu_sock.c: Avoid breaking strict-aliasing on ptr derreference
Fixes following warning:
pcu_sock.c: In function 'pcu_rx_data_req':
pcu_sock.c:406:3: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
Patch Set 1:
This one cannot still be merged due to this warning still appearing:
pcu_sock.c: In function 'pcu_rx_data_req':
pcu_sock.c:406:3: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
tlli = *((uint32_t *)data_req->data);
^
--
Review at https://gerrit.osmocom.org/7332
msc_mgcp.c: Fix several wrong ptr printf fmt
Fixes several of these type of warnings:
include/osmocom/core/fsm.h:123:38: warning: format ‘%x’ expects argument of
type ‘unsigned int’, but argument 9 has type ‘char *’ [-Wformat=]
Review at https://gerrit.osmocom.org/7330
gprs_bssgp_pcu.cpp: Comment unused function parse_ra_cap
Commit 741d25cb6f8c0c1522cf6d1be2fea49356ecd4bd commented the only user
of the function but forgot to comment too the function itself.
Change-Id: I8b291b45aaedfb0421cd28c0d9e24cefa5547b09
---
M
Review at https://gerrit.osmocom.org/7331
contrib: jenkins.sh: Use flag --enable-werror
Change-Id: I7023f3637df12d2483b745db9881d37c5b0aa91d
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/31/7331/1
diff
Patch Set 5:
> interestingly, I don't get any such compiler warnings on debian
> unstable, using gcc-7.3.
I'm running archlinux with gcc-8.1.
It seems the warnings were introduced by an earlier commit, not this one. I
sent fixes for all warnings + a patch to enable werror in here:
Review at https://gerrit.osmocom.org/7328
tests: handover_test.c: Add missing header
Fixes following compilation warning:
osmo-bsc/tests/handover/handover_test.c:48:83: warning:
‘struct mgcp_conn_peer’ declared inside parameter list will not be visible
outside of this definition or
Review at https://gerrit.osmocom.org/7327
bsc_subscr_conn_fsm.c: Fix wrong param list passed to LOGPFSML
Fixes: 3561bd48976dbee8dbd4659dad15be85a3e79ace
Change-Id: Ifbf84bd3b64eea5bf315b83c95561e4534acc3b7
---
M src/libbsc/bsc_subscr_conn_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)
Review at https://gerrit.osmocom.org/7329
contrib: jenkins.sh: Add --enable-werror flag
Change-Id: Ife9ca2a5b835dfd6d03c981dcf0e48265eb861eb
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/7329/1
Review at https://gerrit.osmocom.org/7326
bsc_api.c: bsc_handle_lchan_signal: Remove unused variable
Variable is unused since 3561bd48976dbee8dbd4659dad15be85a3e79ace.
Change-Id: I8ecff940ae848b965b26b7dc07153dd88b365fe4
---
M src/libbsc/bsc_api.c
1 file changed, 1 insertion(+), 4
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/aarch64
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586
Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
[
Patch Set 5:
mh. I thought we didn't expect any regressions in the tests according to
pmaier?
https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/test_results_analyzer/
says something else: 8 testcases fail which passed before the merge :(
--
To view, visit
Harald Welte has submitted this change and it was merged.
Change subject: msc_mgcp: to not access higher layers after release
..
msc_mgcp: to not access higher layers after release
The higher layers (gsm_04_08.c) are informed
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7322
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I041f38548c5e4236920991d6c681c1c1e04de9ca
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: add a regression test for TLV parsing with repeated IEs
..
add a regression test for TLV parsing with repeated IEs
Since commit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7324
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70906939b3320473c56a87929c4886aac9d7d064
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/7323/1//COMMIT_MSG
Commit Message:
Line 10: requires root permissions. However, the same target can be accomplished
THe rationale is probably simple: SO_BINDTODEVICE bypasses the system-wide (by
root) configured routing
Harald Welte has submitted this change and it was merged.
Change subject: abisip-find: Improve use information output
..
abisip-find: Improve use information output
Interestingly, SO_BINDTODEVICE used to bind to a specific
Harald Welte has submitted this change and it was merged.
Change subject: ipaccess-config: Check cmdlie arg unit-id format
..
ipaccess-config: Check cmdlie arg unit-id format
Print a clear error when the format in not correct.
Harald Welte has submitted this change and it was merged.
Change subject: gitignore Makefiles produced by 'make compile'
..
gitignore Makefiles produced by 'make compile'
Change-Id: Ia71e76f0dce2ba2f9f5837f4d3d099dff92e8787
Harald Welte has submitted this change and it was merged.
Change subject: ignore results of .ttcnpp files
..
ignore results of .ttcnpp files
Add another macro ignore_pp_results to gen_links.sh.inc and call from all
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7316
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8901ec0b090e342ebb04a04f9d759fc46c7d9cab
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: gitignore *.{cc,hh}, whitelist library/*.{cc,hh}
..
gitignore *.{cc,hh}, whitelist library/*.{cc,hh}
ttcn3 creates these files, and they clutter 'git
Harald Welte has submitted this change and it was merged.
Change subject: sgsn: test GMM Attach with 3-digit leading-zero MNC
..
sgsn: test GMM Attach with 3-digit leading-zero MNC
Add general infrastructure to
- pass an
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7325
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f1b6a9149488a4ad3f120c1e190a83c07d4b89
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7325
to look at the new patch set (#2).
msc_mgcp: to not access higher layers after release
The higher layers (gsm_04_08.c) are informed errors occur. But it
is not checked if the call was
Patch Set 4:
interestingly, I don't get any such compiler warnings on debian unstable, using
gcc-7.3.
Let's merge this now, it has been pending for a lng time due to missing
TTCN-3 tests, and now that we have the tests, merge it. We can always fix some
warnings in a follow-up.
--
To
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68286d26e2014048b054f39ef29c35fef420cc97
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7325
msc_mgcp: to not access higher layers after release
The higher layers (gsm_04_08.c) are informed errors occur. But it
is not checked if the call was already released. If an error occurs
after the call control stack calls msc_mgcp_call_release() then
dexter has abandoned this change.
Change subject: gsm_04_08: clear SCCP connection when release is not
acknowledged
..
Abandoned
Analyzed it further. trans_free() should indeed be enough so this patch is not
the right
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7316
to look at the new patch set (#2).
sgsn: test GMM Attach with 3-digit leading-zero MNC
Add general infrastructure to
- pass an MCC-MNC for BSSGP to use into f_init();
-
Patch Set 2: Code-Review+2
re-add earlier +2, lost from trivial merge conflict resolution
--
To view, visit https://gerrit.osmocom.org/7314
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia71e76f0dce2ba2f9f5837f4d3d099dff92e8787
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7314
to look at the new patch set (#2).
gitignore Makefiles produced by 'make compile'
Change-Id: Ia71e76f0dce2ba2f9f5837f4d3d099dff92e8787
---
M .gitignore
1 file changed, 6
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7313
to look at the new patch set (#2).
gitignore *.{cc,hh}, whitelist library/*.{cc,hh}
ttcn3 creates these files, and they clutter 'git status' output.
Change-Id:
Patch Set 1:
> I think I explicitly suggested to white-list the *.cc and *.hh
> files in "library/" where most (if not all) of the user-developed
> C++ code is located. AFAIK you can have negated entries in
> gitignore, see the examples at the end of the "man gitignore" page.
understood it
Review at https://gerrit.osmocom.org/7323
abisip-find: Improve use information output
Interestingly, SO_BINDTODEVICE used to bind to a specific iface
requires root permissions. However, the same target can be accomplished
by binding to a local IP addr set on the target interface, which doesn't
Review at https://gerrit.osmocom.org/7324
ipaccess-config: Check cmdlie arg unit-id format
Print a clear error when the format in not correct. I was in the
situation several times in which I was passing "123" instead of
"123/0/0", and spent a while seeing what was wrong.
Change-Id:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/Debian_9.0/armv7l
Package network:osmocom:latest/eclipse-titan failed to build in
Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:latest eclipse-titan
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/Debian_9.0/aarch64
Package network:osmocom:latest/eclipse-titan failed to build in
Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:latest eclipse-titan
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/xUbuntu_17.04/i586
Package network:osmocom:latest/eclipse-titan failed to build in
xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:latest eclipse-titan
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/xUbuntu_17.04/x86_64
Package network:osmocom:latest/eclipse-titan failed to build in
xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest eclipse-titan
Last
Patch Set 4:
I confirm after applying this patch I can run one single osmo-mgw shared
between osmo-bsc and osmo-msc and place a call between to MS connected to the
network with voice working fine.
But let's fix the compile warnings first.
--
To view, visit https://gerrit.osmocom.org/7142
To
Patch Set 4:
I think this patch is introducing several compiler warnings, in my PC I can see:
/home/pespin/dev/sysmocom/build/new/out/include/osmocom/core/fsm.h:123:38:
warning: too many arguments for format [-Wformat-extra-args]
LOGP((fi)->fsm->log_subsys, level, "%s{%s}: " fmt, \
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7322
to look at the new patch set (#2).
add a regression test for TLV parsing with repeated IEs
Since commit bf383a1d83661af26ccd6521c49b655fb22531d4 tlv_parse()
will return the first
Patch Set 1:
Thanks! Just let me know.
--
To view, visit https://gerrit.osmocom.org/7310
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1afaf0a9e2dce43aec87964bacefb21ed4d3d565
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Review at https://gerrit.osmocom.org/7322
add a regression test for TLV parsing with repeated IEs
Since commit bf383a1d83661af26ccd6521c49b655fb22531d4 tlv_parse()
will return the first occurrence of a repeated IE. Add a test to
verify this behaviour. This test passes with the current code and
Patch Set 6:
> I think your new cdf_test is not yet being executed. I had to add
> the import _prep to successfully run them locally. Did you try
> yourself?
I had a PYTHONPATH changed and emulated a "testsuite -k testname" behavior by
setting the array of tests. I thought _prep is a python
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6230
to look at the new patch set (#7).
ms: Create a cumulative distribution function class
We are using the CDF to decide which percentage of the jobs
Patch Set 1:
I'd normally simply send you a batch of cards. Given how difficult it is for
mail to reach you, I would suggest that we simply connect a card to a reader
and attach it to a machine with SSH access for you. Then you could use it as
needed to generate as much test data in whatever
Harald Welte has submitted this change and it was merged.
Change subject: fix bug in parse_cell_id_ci_list()
..
fix bug in parse_cell_id_ci_list()
Cell ID lists with CI were misparsed because parse_cell_id_ci_list()
failed to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7320
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie633d9e55c6a30555c0153d35aaf9f982d6e0088
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7317
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4e485e2b86c6f3321c9700611700115ad247b2
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Test SCCP clearing on release timeout
..
MSC_Tests: Test SCCP clearing on release timeout
Provoke a timeout error in the MGCP FSM which then
Harald Welte has submitted this change and it was merged.
Change subject: add a test for CELL_IDENT_WHOLE_GLOBAL cell identifier lists
..
add a test for CELL_IDENT_WHOLE_GLOBAL cell identifier lists
Add a regression test which
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0fafbc7171da2a3044bfa9a167208a1afa1c07b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: MGCP_Test: fix config file include path
..
MGCP_Test: fix config file include path
The config file mistakenly references the defaults for the MSC.
-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7319
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e0bee11763f1c6b2cfae91f2a818ff7d0df9e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7321
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12c6907717dfba1c31790a2b71f42e37743351af
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7321
MGCP_Test: fix config file include path
The config file mistakenly references the defaults for the MSC.
- correct include path to use MGCP_Test.default
Change-Id: I12c6907717dfba1c31790a2b71f42e37743351af
---
M mgw/MGCP_Test.cfg
1 file changed, 1
Patch Set 2:
another thought... The main reason why the FSM allocation was separate from the
subscr_conn struct allocation was that in the osmo-nitb, libbsc allocated the
subscr_conn and handed it over to libmsc, and only then were we "allowed" to
start an FSM. That limitation has gone away
Review at https://gerrit.osmocom.org/7320
add a test for CELL_IDENT_WHOLE_GLOBAL cell identifier lists
Add a regression test which encodes and decodes a cell identifier
list of type CELL_IDENT_WHOLE_GLOBAL.
Change-Id: Ie633d9e55c6a30555c0153d35aaf9f982d6e0088
Depends:
Patch Set 1:
And BTW, I am also working on Milenage-2G support for both
OsmoNiTB and OsmoHLR. Is Milenage supported by Sysmocom SIM?
If yes, additional sample data would also make me happy ;)
--
To view, visit https://gerrit.osmocom.org/7310
To unsubscribe, visit
Patch Set 1:
Hi Harald,
> do you have any sysmoUSIM-SJS1 card?
Yes, I do have one from 34c3. I've contacted lynxis, and he
provided me all data, including ADM1. But, as it turns out,
a SIM was brute-forced / blocked by its previous owner as
I am always getting 6983. And as I understand, it
Patch Set 3:
(1 comment)
want to get BSC_Tests.ttcn running on jenkins first, then run it one more time
before merging this, merge the patch and re-trigger it.
https://gerrit.osmocom.org/#/c/7142/3/tests/handover/handover_test.c
File tests/handover/handover_test.c:
Line 63: *
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7022
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677
Gerrit-PatchSet: 6
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 5: Code-Review-1
Waiting for this patch to be updated to fullfill new resources.conf changes.
See my last comment in this patch regarding this topic.
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7020
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7019
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7319
MSC_Tests: Test SCCP clearing on release timeout
Provoke a timeout error in the MGCP FSM which then triggers a
release on the CC layer. Ignore this release and let the CC leyer
timeout. The MSC is expected to clear the SCCP connection.
Change-Id:
Review at https://gerrit.osmocom.org/7318
fix parse_cell_id_lac_and_ci_list()
The implementation was entirely broken, reading data from wrong offsets
and always writing to the first element of the decoded list.
Also, add a new test for this function which found the problems.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7317
to look at the new patch set (#2).
fix bug in parse_cell_id_ci_list()
Cell ID lists with CI were misparsed because parse_cell_id_ci_list()
failed to report the amount of consumed bytes
Review at https://gerrit.osmocom.org/7317
fix bug in parse_cell_id_ci_list()
Cell ID lists with CI were misparsed because parse_cell_id_ci_list()
failed to report the amount of consumed bytes to its caller.
Also add a regression test which uncovered the bug.
Change-Id:
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7020
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dcf2a6fa2991cb73b4807f8a10d251f3dca77dd
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 5
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7022
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If661675528059bc8a95d39a6489a5a9381f52677
Gerrit-PatchSet: 6
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: add ansible playbooks
..
add ansible playbooks
Introduce playbooks to do:
- setup-jenkins-slave - setup a usualy or special jenkins-slave
-
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/7127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7007a4e6c38f73843390ec2b3b91133aff21e36a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+2
approving now, after 4 days without feedback from neels.
--
To view, visit https://gerrit.osmocom.org/7127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7007a4e6c38f73843390ec2b3b91133aff21e36a
Harald Welte has submitted this change and it was merged.
Change subject: compiler warnings: use enum ranap_nsap_addr_enc, constify local
var
..
compiler warnings: use enum ranap_nsap_addr_enc, constify local var
Use the
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7019
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7305
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16cb2582b9d1764d7cb7e4b787368a4dd5ddf69c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Support wildcarded endpoints (follow up)
..
MSC_Tests: Support wildcarded endpoints (follow up)
The following tests still lack support for
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7297
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1168ce6425c31db3f6c3bf1f3682ae96b028c59b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: use gsm48_decode_lai2() in gsm0808_dec_cell_id_list()
..
use gsm48_decode_lai2() in gsm0808_dec_cell_id_list()
This makes gsm0808_dec_cell_id_list()
1 - 100 of 114 matches
Mail list logo
