Change in libosmocore[master]: stats_statsd: sanitize statsd name

2018-07-24 Thread lynxis lazus
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10133 to look at the new patch set (#2). Change subject: stats_statsd: sanitize statsd name .. stats_statsd:

Change in osmo-iuh[master]: hnbgw: remove close_cb() to fix a crash when releasing a hnbgw

2018-07-24 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/10151 ) Change subject: hnbgw: remove close_cb() to fix a crash when releasing a hnbgw .. Patch Set 1: The close_cb is only called within

Change in osmo-gsm-tester[master]: ms: Make the total test duration configurable

2018-07-24 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/9720 ) Change subject: ms: Make the total test duration configurable .. ms: Make the total test duration configurable Change-Id:

Change in osmo-gsm-tester[master]: ms: Remove unused imports

2018-07-24 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/9719 ) Change subject: ms: Remove unused imports .. ms: Remove unused imports Change-Id: Idd428d1bbd937a26a320eb69b1031856e49d3e4b --- M

Change in osmo-gsm-tester[master]: ms: Only use completed tests for min/max handling

2018-07-24 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/9718 ) Change subject: ms: Only use completed tests for min/max handling .. ms: Only use completed tests for min/max handling Remove non

Change in osmo-gsm-tester[master]: ms: Quit early when all tests concluded..

2018-07-24 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/9716 ) Change subject: ms: Quit early when all tests concluded.. .. ms: Quit early when all tests concluded.. And fix the the detection

Change in simtrace2[master]: cardem: fix typo

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10121 ) Change subject: cardem: fix typo .. cardem: fix typo Change-Id: Ibeeb01b21a3ccfa74642f13694a20054e920837e --- M

Change in simtrace2[master]: cardem: fix USB message parsing

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10122 ) Change subject: cardem: fix USB message parsing .. cardem: fix USB message parsing the msg->l2h pointer was not set but used later

Change in simtrace2[master]: USB: print decoded USB error

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10125 ) Change subject: USB: print decoded USB error .. USB: print decoded USB error In case of error it also ensures the returned value is

Change in simtrace2[master]: I2C: return error after failed write

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10124 ) Change subject: I2C: return error after failed write .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10124 To

Change in simtrace2[master]: USB: print decoded USB error

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10125 ) Change subject: USB: print decoded USB error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10125 To

Change in simtrace2[master]: I2C: add wait time after write to let EEPROM write

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10123 ) Change subject: I2C: add wait time after write to let EEPROM write .. I2C: add wait time after write to let EEPROM write The Atmel

Change in simtrace2[master]: I2C: return error after failed write

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10124 ) Change subject: I2C: return error after failed write .. I2C: return error after failed write The previous mechanism of retrying a

Change in simtrace2[master]: I2C: add wait time after write to let EEPROM write

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10123 ) Change subject: I2C: add wait time after write to let EEPROM write .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: cardem: fix USB message parsing

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10122 ) Change subject: cardem: fix USB message parsing .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10122 To

Change in simtrace2[master]: cardem: fix typo

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10121 ) Change subject: cardem: fix typo .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10121 To unsubscribe, or for

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9653 ) Change subject: introduce a TTCN3 test suite for SCCP .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9653 To

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9653 ) Change subject: introduce a TTCN3 test suite for SCCP .. introduce a TTCN3 test suite for SCCP This test suite acts as an SCCP

Change in osmo-sgsn[master]: gbproxy: Replace '.' in counter names with ':'

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10127 ) Change subject: gbproxy: Replace '.' in counter names with ':' .. gbproxy: Replace '.' in counter names with ':' The '.' is illegal

Change in libosmo-abis[master]: e1_input.c: Replace '.' in counter names with ':'

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10130 ) Change subject: e1_input.c: Replace '.' in counter names with ':' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-abis[master]: e1_input.c: Replace '.' in counter names with ':'

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10130 ) Change subject: e1_input.c: Replace '.' in counter names with ':' .. e1_input.c: Replace '.' in counter names with ':' The '.' is

Change in osmo-sgsn[master]: sgsn: gtp: Use new API to send PDP DEL CTX REQ without freeing ctx lo...

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10019 ) Change subject: sgsn: gtp: Use new API to send PDP DEL CTX REQ without freeing ctx locally .. sgsn: gtp: Use new API to send PDP

Change in osmo-sgsn[master]: gbproxy: Replace '.' in counter names with ':'

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10127 ) Change subject: gbproxy: Replace '.' in counter names with ':' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: sgsn: Fix crash using new libgtp cb_recovery2 API

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10025 ) Change subject: sgsn: Fix crash using new libgtp cb_recovery2 API .. sgsn: Fix crash using new libgtp cb_recovery2 API When PDP CTX

Change in osmo-sgsn[master]: sgsn: gtp: Use new API to send PDP DEL CTX REQ without freeing ctx lo...

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10019 ) Change subject: sgsn: gtp: Use new API to send PDP DEL CTX REQ without freeing ctx locally .. Patch Set 3: Code-Review+2 -- To view,

Change in libosmocore[master]: stats_statsd: sanitize statsd name

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10133 ) Change subject: stats_statsd: sanitize statsd name .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-bsc[master]: rename gsm_04_08_utils.[hc] to gsm_04_08_rr

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10145 ) Change subject: rename gsm_04_08_utils.[hc] to gsm_04_08_rr .. Patch Set 1: Code-Review+2 (1 comment)

Change in osmocom-bb[master]: trxcon/scheduler: fix: check primitive len before encoding

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10137 ) Change subject: trxcon/scheduler: fix: check primitive len before encoding .. trxcon/scheduler: fix: check primitive len before

Change in osmocom-bb[master]: trxcon/scheduler: fix: check primitive len before encoding

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10137 ) Change subject: trxcon/scheduler: fix: check primitive len before encoding .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10143 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10141 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10143 ) Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is

Change in osmo-bsc[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10140 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10142 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10139 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: check payload type of received RTP packets

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10150 ) Change subject: MGCP_Test: check payload type of received RTP packets .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: check payload type of received RTP packets

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10150 ) Change subject: MGCP_Test: check payload type of received RTP packets .. MGCP_Test: check payload type of received RTP packets When

Change in osmo-iuh[master]: hnbgw: remove close_cb() to fix a crash when releasing a hnbgw

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10151 ) Change subject: hnbgw: remove close_cb() to fix a crash when releasing a hnbgw .. Patch Set 1: Code-Review+1 it somehow feels odd that we

Change in libosmocore[master]: logging: log_vty_command_string: Fix undercount of buf alloc size

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10134 ) Change subject: logging: log_vty_command_string: Fix undercount of buf alloc size .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: stats_vty: Add asciidoc sections between the different counters

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10152 ) Change subject: stats_vty: Add asciidoc sections between the different counters .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: stats_vty: Add asciidoc sections between the different counters

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10152 ) Change subject: stats_vty: Add asciidoc sections between the different counters .. stats_vty: Add asciidoc sections between the

Change in osmo-bts[master]: update sysinfo copies in all lchans upon SACCH FILL

2018-07-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10153 ) Change subject: update sysinfo copies in all lchans upon SACCH FILL .. update sysinfo copies in all lchans upon SACCH FILL When a

Change in osmo-bts[master]: update sysinfo copies in all lchans upon SACCH FILL

2018-07-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10153 ) Change subject: update sysinfo copies in all lchans upon SACCH FILL .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: logging: Fix logging level all

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10116 ) Change subject: logging: Fix logging level all .. Patch Set 2: What I would like to have, for a long time already, is a small program that

Change in osmo-bts[master]: update sysinfo copies in all lchans upon SACCH FILL

2018-07-24 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/10153 Change subject: update sysinfo copies in all lchans upon SACCH FILL .. update sysinfo copies in all lchans upon SACCH FILL When a SACCH

Change in libosmocore[master]: stats_vty: Add asciidoc sections between the different counters

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10152 Change subject: stats_vty: Add asciidoc sections between the different counters .. stats_vty: Add asciidoc sections between the different counters

Change in libosmocore[master]: logging: Add VTY cmd: logging level unset

2018-07-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10136 ) Change subject: logging: Add VTY cmd: logging level unset .. Patch Set 1: (1 comment)

Change in libosmocore[master]: logging: Fix logging level all

2018-07-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10116 ) Change subject: logging: Fix logging level all .. Patch Set 2: Code-Review-1 (1 comment)

Change in libosmocore[master]: logging: log_vty_command_string: Fix undercount of buf alloc size

2018-07-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10134 ) Change subject: logging: log_vty_command_string: Fix undercount of buf alloc size .. Patch Set 1: Code-Review+1 (5 comments) Looks

Change in libosmocore[master]: logging_vty: Simplify code in config_write_log_single

2018-07-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10135 ) Change subject: logging_vty: Simplify code in config_write_log_single .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-sysmon[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/10138 ) Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in

Change in osmo-iuh[master]: hnbgw: remove close_cb() to fix a crash when releasing a hnbgw

2018-07-24 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/10151 Change subject: hnbgw: remove close_cb() to fix a crash when releasing a hnbgw .. hnbgw: remove close_cb() to fix a crash when releasing a

Change in osmo-ttcn3-hacks[master]: MGCP_Test: check payload type of received RTP packets

2018-07-24 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10150 Change subject: MGCP_Test: check payload type of received RTP packets .. MGCP_Test: check payload type of received RTP packets When an RTP packet

Change in osmo-bsc[master]: lchan_fsm: add in_release_handler flag

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10104 to look at the new patch set (#5). Change subject: lchan_fsm: add in_release_handler flag ..

Change in osmo-bsc[master]: allocate larger lchans if no SDCCH are available

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10105 to look at the new patch set (#5). Change subject: allocate larger lchans if no SDCCH are available ..

Change in osmo-bsc[master]: cosmetic: constify gsm_bts_num() net arg

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10107 to look at the new patch set (#5). Change subject: cosmetic: constify gsm_bts_num() net arg ..

Change in osmo-bsc[master]: create separate logging categories for lchan, ts, as FSMs

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10106 to look at the new patch set (#5). Change subject: create separate logging categories for lchan,ts,as FSMs

Change in osmo-bsc[master]: lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10103 to look at the new patch set (#5). Change subject: lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier

Change in osmo-bsc[master]: cosmetic: reduce bsc_api.h

2018-07-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10147 to look at the new patch set (#2). Change subject: cosmetic: reduce bsc_api.h .. cosmetic: reduce bsc_api.h Remove

Change in osmo-bsc[master]: cosmetic: dissolve bsc_api.c

2018-07-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10146 to look at the new patch set (#2). Change subject: cosmetic: dissolve bsc_api.c .. cosmetic: dissolve bsc_api.c

Change in osmo-bsc[master]: fix BSC_CTR_ASSIGNMENT doc strings

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10102 to look at the new patch set (#5). Change subject: fix BSC_CTR_ASSIGNMENT doc strings .. fix

Change in osmo-bsc[master]: vty: 'handover any': pick more random chans, use lchan_select_by_type()

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10108 to look at the new patch set (#5). Change subject: vty: 'handover any': pick more random chans, use lchan_select_by_type()

Change in osmo-bsc[master]: cosmetic: move RR functions from bsc_api.c to gsm_04_08_rr.c

2018-07-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9669 to look at the new patch set (#14). Change subject: cosmetic: move RR functions from bsc_api.c to gsm_04_08_rr.c ..

Change in osmo-bsc[master]: cosmetic: rename osmo_bsc_api.c to gsm_08_08.c

2018-07-24 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10149 to look at the new patch set (#2). Change subject: cosmetic: rename osmo_bsc_api.c to gsm_08_08.c .. cosmetic:

Change in osmo-bsc[master]: cosmetic: FSMs: allow ignorable events

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10101 to look at the new patch set (#5). Change subject: cosmetic: FSMs: allow ignorable events .. cosmetic:

Change in osmo-bsc[master]: large refactoring: use FSMs for lchans; add inter-BSC HO

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9671 to look at the new patch set (#37). Change subject: large refactoring: use FSMs for lchans; add inter-BSC HO

Change in osmo-sysmon[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10138 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: resources.conf.prod: add calypso SIM data (commented)

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10132 ) Change subject: resources.conf.prod: add calypso SIM data (commented) .. Patch Set 1: Code-Review-1 As I said in iRC, I don't really

Change in libosmo-sccp[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10139 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: Is .git a symlink in your case? It probably makes sense

Change in osmo-sysmon[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10138 ) Change subject: git-version-gen: Don't check for .git directory .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: cosmetic: dissolve bsc_api.c

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10146 Change subject: cosmetic: dissolve bsc_api.c .. cosmetic: dissolve bsc_api.c gsm0808_page() is just a thin wrapper for rsl_paging_cmd(),

Change in osmo-bsc[master]: cosmetic: reduce bsc_api.h

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10147 Change subject: cosmetic: reduce bsc_api.h .. cosmetic: reduce bsc_api.h Remove as much as possible from bsc_api.h. Use '#pragma once'.

Change in osmo-bsc[master]: cosmetic: rename osmo_bsc_api.c to gsm_08_08.c

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10149 Change subject: cosmetic: rename osmo_bsc_api.c to gsm_08_08.c .. cosmetic: rename osmo_bsc_api.c to gsm_08_08.c Change-Id:

Change in osmo-bsc[master]: cosmetic: rename bsc_api.h to gsm_08_08.h

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10148 Change subject: cosmetic: rename bsc_api.h to gsm_08_08.h .. cosmetic: rename bsc_api.h to gsm_08_08.h See also

Change in osmo-bsc[master]: rename gsm_04_08_utils.[hc] to gsm_04_08_rr

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10145 Change subject: rename gsm_04_08_utils.[hc] to gsm_04_08_rr .. rename gsm_04_08_utils.[hc] to gsm_04_08_rr "utils" suggests thin helpers to

Change in osmo-bsc[master]: lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10103 to look at the new patch set (#4). Change subject: lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier

Change in osmo-bsc[master]: add gsm_timers, for Tnnn definitions usable by FSMs

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9670 to look at the new patch set (#13). Change subject: add gsm_timers, for Tnnn definitions usable by FSMs

Change in osmo-bsc[master]: large refactoring: use FSMs for lchans; add inter-BSC HO

2018-07-24 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9671 to look at the new patch set (#36). Change subject: large refactoring: use FSMs for lchans; add inter-BSC HO

Change in openbsc[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10144 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in osmo-mgw[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10143 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in osmo-sgsn[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10142 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in osmo-msc[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10141 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in osmo-bsc[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10140 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in libosmo-sccp[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10139 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in osmo-sysmon[master]: git-version-gen: Don't check for .git directory

2018-07-24 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/10138 Change subject: git-version-gen: Don't check for .git directory .. git-version-gen: Don't check for .git directory This check is not in all our

Change in osmocom-bb[master]: trxcon/scheduler: fix: check primitive len before encoding

2018-07-24 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10137 ) Change subject: trxcon/scheduler: fix: check primitive len before encoding .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: prevent heap overflow in tch_fr_disassemble()

2018-07-24 Thread Stefan Sperling
Stefan Sperling has abandoned this change. ( https://gerrit.osmocom.org/10131 ) Change subject: prevent heap overflow in tch_fr_disassemble() .. Abandoned see https://gerrit.osmocom.org/c/osmocom-bb/+/10137/ -- To view, visit

Change in osmocom-bb[master]: trxcon/scheduler: fix: check primitive len before encoding

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10137 ) Change subject: trxcon/scheduler: fix: check primitive len before encoding .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: trxcon/scheduler: fix: check primitive len before encoding

2018-07-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10137 Change subject: trxcon/scheduler: fix: check primitive len before encoding .. trxcon/scheduler: fix: check primitive len before encoding

Change in libosmocore[master]: logging: Add VTY cmd: logging level unset

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10136 Change subject: logging: Add VTY cmd: logging level unset .. logging: Add VTY cmd: logging level unset This command is useful while

Change in libosmocore[master]: logging: Fix logging level all

2018-07-24 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10116 to look at the new patch set (#2). Change subject: logging: Fix logging level all

Change in libosmocore[master]: logging: log_vty_command_string: Fix undercount of buf alloc size

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10134 Change subject: logging: log_vty_command_string: Fix undercount of buf alloc size .. logging: log_vty_command_string: Fix undercount of

Change in libosmocore[master]: logging_vty: Simplify code in config_write_log_single

2018-07-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10135 Change subject: logging_vty: Simplify code in config_write_log_single .. logging_vty: Simplify code in config_write_log_single Since we

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #194

2018-07-24 Thread jenkins
See -- [...truncated 3.74 KB...] checking build system type... x86_64-unknown-linux-gnu checking host system type...

Change in libosmocore[master]: stats_statsd: sanitize statsd name

2018-07-24 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/10133 Change subject: stats_statsd: sanitize statsd name .. stats_statsd: sanitize statsd name The statsd protocol use ':' as seperator between

Change in osmo-gsm-tester[master]: resources.conf.prod: add calypso SIM data (commented)

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10132 Change subject: resources.conf.prod: add calypso SIM data (commented) .. resources.conf.prod: add calypso SIM data (commented) We've

Change in osmocom-bb[master]: prevent heap overflow in tch_fr_disassemble()

2018-07-24 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10131 ) Change subject: prevent heap overflow in tch_fr_disassemble() .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-bsc[master]: lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10103 ) Change subject: lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier .. Patch Set 3: Code-Review+2 only cosmetic changes due to

Change in osmo-bsc[master]: lchan_fsm: add in_release_handler flag

2018-07-24 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10104 ) Change subject: lchan_fsm: add in_release_handler flag .. Patch Set 3: Code-Review+2 commit log adjusted, marking +2 -- To view, visit

Change in osmocom-bb[master]: prevent heap overflow in tch_fr_disassemble()

2018-07-24 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/10131 Change subject: prevent heap overflow in tch_fr_disassemble() .. prevent heap overflow in tch_fr_disassemble() Ensure that

  1   2   >