Change in osmo-mgw[master]: generate shorter 'I:' conn IDs

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10676 ) Change subject: generate shorter 'I:' conn IDs .. Patch Set 3: The previous patch indeed affected the maximum length that even

Change in osmo-mgw[master]: mgcp_verify_ci(): return meaningful error codes

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10753 Change subject: mgcp_verify_ci(): return meaningful error codes .. mgcp_verify_ci(): return meaningful error codes Instead of just -1,

Change in osmo-mgw[master]: mgcp_client_test: cosmetically re-arrange reply_to() args

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10746 Change subject: mgcp_client_test: cosmetically re-arrange reply_to() args .. mgcp_client_test: cosmetically re-arrange reply_to() args I

Change in osmo-mgw[master]: mgcp_conn_get(): compare conn Id ('I:') case insensitively

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10677 to look at the new patch set (#3). Change subject: mgcp_conn_get(): compare conn Id ('I:') case insensitively

Change in osmo-mgw[master]: mgcp_client: error on too long conn id

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10750 Change subject: mgcp_client: error on too long conn id .. mgcp_client: error on too long conn id Instead of just silently truncating the

Change in osmo-mgw[master]: fix mgcp_verify_ci(): off-by-one in max len check

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10754 Change subject: fix mgcp_verify_ci(): off-by-one in max len check .. fix mgcp_verify_ci(): off-by-one in max len check MGCP_CONN_ID_MAXLEN

Change in osmo-mgw[master]: generate shorter 'I:' conn IDs

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10676 ) Change subject: generate shorter 'I:' conn IDs .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/10676 To unsubscribe,

Change in osmo-mgw[master]: doc: fix mgcp_verify_ci() return val doc

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10752 Change subject: doc: fix mgcp_verify_ci() return val doc .. doc: fix mgcp_verify_ci() return val doc Match the '\returns' doc to the actual

Change in osmo-mgw[master]: mgcp_client_test: use "\r\n\r\n" instead of "\n\n"

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10747 Change subject: mgcp_client_test: use "\r\n\r\n" instead of "\n\n" .. mgcp_client_test: use "\r\n\r\n" instead of "\n\n" The separator

Change in osmo-mgw[master]: mgcp_conn_get(): match conn Id ('I:') despite leading zeros

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10678 to look at the new patch set (#3). Change subject: mgcp_conn_get(): match conn Id ('I:') despite leading zeros

Change in osmo-mgw[master]: mgcp_client_test: also verify received conn_id

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10748 Change subject: mgcp_client_test: also verify received conn_id .. mgcp_client_test: also verify received conn_id Include the parsed conn_id

Change in osmo-mgw[master]: mgcp_common: rename to MGCP_CONN_ID_MAXLEN

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10751 Change subject: mgcp_common: rename to MGCP_CONN_ID_MAXLEN .. mgcp_common: rename to MGCP_CONN_ID_MAXLEN So far, MGCP_CONN_ID_LENGTH was

Change in osmo-mgw[master]: mgcp_client_test: test long conn_id

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10749 Change subject: mgcp_client_test: test long conn_id .. mgcp_client_test: test long conn_id Add a full length (32 characters according to

Change in simtrace2[master]: stdio: fix detection of malformated format strings

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10671 to look at the new patch set (#2). Change subject: stdio: fix detection of malformated format strings .. stdio: fix

Change in simtrace2[master]: stdio: fix detection of malformated format strings

Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/10671 ) Change subject: stdio: fix detection of malformated format strings .. Patch Set 1: you are right. I misunderstood how the va_ macros work.

Change in osmo-bsc[master]: cosmetic: lchan activ: no need to clear mr again

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10699 ) Change subject: cosmetic: lchan activ: no need to clear mr again .. Patch Set 1: actually, I don't understand why this tiny patch is any

Change in osmo-bsc[master]: cosmetic: lchan activ: no need to clear mr again

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10699 ) Change subject: cosmetic: lchan activ: no need to clear mr again .. Patch Set 1: what? :) Ok, to put it differently, if you see code like

Change in osmo-trx[master]: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly o...

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10743 ) Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error .. Patch Set 2: (2 comments)

Change in osmo-trx[master]: configure.ac: Specify default language as C++

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10745 Change subject: configure.ac: Specify default language as C++ .. configure.ac: Specify default language as C++ This is useful if we add

Change in osmo-trx[master]: cosmetic: Fix trailing whitespace

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10740 to look at the new patch set (#2). Change subject: cosmetic: Fix trailing whitespace .. cosmetic: Fix trailing

Change in osmo-trx[master]: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly o...

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10743 to look at the new patch set (#2). Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error

Change in osmo-trx[master]: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly o...

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10743 ) Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error .. Patch Set 1: (1 comment)

Change in osmo-trx[master]: radioInterface: Fix variable storing integer return value

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10744 ) Change subject: radioInterface: Fix variable storing integer return value .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly o...

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10743 ) Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-trx[master]: cosmetic: Fix trailing whitespace

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10740 ) Change subject: cosmetic: Fix trailing whitespace .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10740/1//COMMIT_MSG

Change in osmo-trx[master]: lms: Return error on device read timeout

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10742 ) Change subject: lms: Return error on device read timeout .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10742

Change in osmo-trx[master]: radioInterface: forward errors from RadioDevice to Transceiver in rec...

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10741 ) Change subject: radioInterface: forward errors from RadioDevice to Transceiver in recv path .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-trx[master]: Vector: Copy arrays in a sane wayfor non-trivially copyable types

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10721 ) Change subject: Vector: Copy arrays in a sane wayfor non-trivially copyable types .. Patch Set 1: Tested with osmo-trx-lms and a

Change in osmo-trx[master]: Vector: Copy arrays in a sane wayfor non-trivially copyable types

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10721 ) Change subject: Vector: Copy arrays in a sane wayfor non-trivially copyable types .. Set Ready For Review -- To view, visit

Change in osmo-trx[master]: cosmetic: Fix trailing whitespace

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10740 ) Change subject: cosmetic: Fix trailing whitespace .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10740/1//COMMIT_MSG Commit

Change in osmo-trx[master]: radioInterfaceMulti:pullBuffer: Sanely convert float array to complex...

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10720 ) Change subject: radioInterfaceMulti:pullBuffer: Sanely convert float array to complex array .. Patch Set 1: Tested with osmo-trx-lms

Change in osmo-trx[master]: radioInterfaceMulti:pullBuffer: Sanely convert float array to complex...

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10720 ) Change subject: radioInterfaceMulti:pullBuffer: Sanely convert float array to complex array .. Set Ready For Review -- To view, visit

Change in osmo-trx[master]: Logger: Disable pthread cancel point inside Logger destructor

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10739 ) Change subject: Logger: Disable pthread cancel point inside Logger destructor .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-trx[master]: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly o...

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10743 Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error .. osmo-trx: Add osmo_signal to stop whole

Change in osmo-trx[master]: Logger: Disable pthread cancel point inside Logger destructor

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10739 Change subject: Logger: Disable pthread cancel point inside Logger destructor .. Logger: Disable pthread cancel point inside Logger

Change in osmo-trx[master]: radioInterface: Fix variable storing integer return value

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10744 Change subject: radioInterface: Fix variable storing integer return value .. radioInterface: Fix variable storing integer return value

Change in osmo-trx[master]: cosmetic: Fix trailing whitespace

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10740 Change subject: cosmetic: Fix trailing whitespace .. cosmetic: Fix trailing whitespace Change-Id:

Change in osmo-trx[master]: radioInterface: forward errors from RadioDevice to Transceiver in rec...

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10741 Change subject: radioInterface: forward errors from RadioDevice to Transceiver in recv path .. radioInterface: forward errors from

Change in osmo-trx[master]: lms: Return error on device read timeout

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10742 Change subject: lms: Return error on device read timeout .. lms: Return error on device read timeout If LImeSDR device is unplugged or

Change in osmo-hlr[master]: libosmo-gsup-client: License is GPLv2-or-later

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10738 ) Change subject: libosmo-gsup-client: License is GPLv2-or-later .. libosmo-gsup-client: License is GPLv2-or-later Fix the

Change in osmo-hlr[master]: libosmo-gsup-client: License is GPLv2-or-later

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10738 ) Change subject: libosmo-gsup-client: License is GPLv2-or-later .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: libosmo-gsup-client: License is GPLv2-or-later

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10738 Change subject: libosmo-gsup-client: License is GPLv2-or-later .. libosmo-gsup-client: License is GPLv2-or-later Fix the unintentional

Change in osmo-mgw[master]: debian/rules: Don't overwrite .tarball-version

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10351 ) Change subject: debian/rules: Don't overwrite .tarball-version .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: Add RSPRO support to IPA and logging definitions

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10737 ) Change subject: Add RSPRO support to IPA and logging definitions .. Add RSPRO support to IPA and logging definitions Change-Id:

Change in osmo-mgw[master]: debian/rules: Don't overwrite .tarball-version

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10351 ) Change subject: debian/rules: Don't overwrite .tarball-version .. debian/rules: Don't overwrite .tarball-version The

Change in libosmocore[master]: Add RSPRO support to IPA and logging definitions

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10737 ) Change subject: Add RSPRO support to IPA and logging definitions .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: Add RSPRO support to IPA and logging definitions

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10737 Change subject: Add RSPRO support to IPA and logging definitions .. Add RSPRO support to IPA and logging definitions Change-Id:

Change in libosmocore[master]: Add CC_CAUSE value_string array

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10732 ) Change subject: Add CC_CAUSE value_string array .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10732 To

Change in osmo-sip-connector[master]: jenkins.sh: Use --enable-werror option

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10736 ) Change subject: jenkins.sh: Use --enable-werror option .. jenkins.sh: Use --enable-werror option Change-Id:

Change in libosmocore[master]: Add CC_CAUSE value_string array

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10732 ) Change subject: Add CC_CAUSE value_string array .. Add CC_CAUSE value_string array Adds a value_string array for GSM 04.08 Call

Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10734 ) Change subject: mncc: Fix missing conditional clause .. mncc: Fix missing conditional clause Fixes following compilation warning:

Change in osmo-sip-connector[master]: configure.ac: Introduce --enable-werror option

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10735 ) Change subject: configure.ac: Introduce --enable-werror option .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10734 ) Change subject: mncc: Fix missing conditional clause .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10734 To

Change in osmo-sip-connector[master]: jenkins.sh: Use --enable-werror option

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10736 ) Change subject: jenkins.sh: Use --enable-werror option .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10736 To

Change in osmo-bsc[master]: gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7149 ) Change subject: gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported .. Patch Set 1: > Please, could you merge this fix

Change in osmo-sip-connector[master]: jenkins.sh: Use --enable-werror option

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10736 ) Change subject: jenkins.sh: Use --enable-werror option .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/10736

Change in osmo-sip-connector[master]: configure.ac: Introduce --enable-werror option

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10735 ) Change subject: configure.ac: Introduce --enable-werror option .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-sip-connector[master]: jenkins.sh: Use --enable-werror option

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10736 Change subject: jenkins.sh: Use --enable-werror option .. jenkins.sh: Use --enable-werror option Change-Id:

Change in osmo-sip-connector[master]: configure.ac: Introduce --enable-werror option

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10735 Change subject: configure.ac: Introduce --enable-werror option .. configure.ac: Introduce --enable-werror option Change-Id:

Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10734 ) Change subject: mncc: Fix missing conditional clause .. Patch Set 1: Indeed, we are lacking --enable-werror in configure.ac and

Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10734 ) Change subject: mncc: Fix missing conditional clause .. Patch Set 1: This also shows that there is no testing coverage of the recently

Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10734 ) Change subject: mncc: Fix missing conditional clause .. Patch Set 1: Code-Review+1 Yep, C is not Python :) -- To view, visit

Change in osmo-bsc[master]: gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported

Ivan Kluchnikov has posted comments on this change. ( https://gerrit.osmocom.org/7149 ) Change subject: gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported .. Patch Set 1: Hi Neels, We have faced with

Change in osmo-sip-connector[master]: Implement Cause Mapping

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10728 ) Change subject: Implement Cause Mapping .. Patch Set 3: Have a look at https://gerrit.osmocom.org/#/c/osmo-sip-connector/+/10734, I

Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10734 Change subject: mncc: Fix missing conditional clause .. mncc: Fix missing conditional clause Fixes following compilation warning: