Change in osmo-bts[master]: osmo-bts-trx: add extended (11-bit) RACH support

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/6315 ) Change subject: osmo-bts-trx: add extended (11-bit) RACH support .. Patch Set 3: @fixeria: What's the statsu now? Before your re-upload, max

Change in osmo-bts[master]: common/pcu_sock.c: cosmetic: explicitly address lchan

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11258 ) Change subject: common/pcu_sock.c: cosmetic: explicitly address lchan .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in osmo-bts[master]: common/pcu_sock.c: cosmetic: explicitly address lchan

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11258 ) Change subject: common/pcu_sock.c: cosmetic: explicitly address lchan .. common/pcu_sock.c: cosmetic: explicitly address lchan In th

Change in osmo-bsc[master]: nanoBTS: Allow BCCH with CBCH on TS0

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11257 ) Change subject: nanoBTS: Allow BCCH with CBCH on TS0 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11257 To un

Change in osmo-bsc[master]: nanoBTS: Allow BCCH with CBCH on TS0

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11257 ) Change subject: nanoBTS: Allow BCCH with CBCH on TS0 .. Patch Set 1: works according to roox. -- To view, visit https://gerrit.osmocom.org

Change in osmo-bsc[master]: nanoBTS: Allow BCCH with CBCH on TS0

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11257 ) Change subject: nanoBTS: Allow BCCH with CBCH on TS0 .. nanoBTS: Allow BCCH with CBCH on TS0 Change-Id: I111c7f14e5f70ecbf6c660c1de2

Change in osmo-bsc[master]: nanoBTS: Allow BCCH with CBCH on TS0

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11257 ) Change subject: nanoBTS: Allow BCCH with CBCH on TS0 .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11257 To unsubscr

Change in docker-playground[master]: redmine: Fix openid

2018-10-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11259 Change subject: redmine: Fix openid .. redmine: Fix openid For some reason, redmine:3.4 ships with ancient (2014) ruby-openid, which is no lo

Change in docker-playground[master]: redmine: Fix openid

2018-10-07 Thread Harald Welte
Harald Welte has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11259 ) Change subject: redmine: Fix openid .. redmine: Fix openid For some reason, redmine:3.4 ships with ancient (2014) ruby-openid, which is no lon

Change in docker-playground[master]: redmine: Fix openid

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11259 ) Change subject: redmine: Fix openid .. redmine: Fix openid For some reason, redmine:3.4 ships with ancient (2014) ruby-openid, which

Change in docker-playground[master]: redmine: Fix openid

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11259 ) Change subject: redmine: Fix openid .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11259 To unsubscr

Change in osmo-sgsn[master]: fix build: remove unused variable

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11256 ) Change subject: fix build: remove unused variable .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11256 To unsub

Change in osmo-sgsn[master]: fix build: remove unused variable

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11256 ) Change subject: fix build: remove unused variable .. fix build: remove unused variable fix: "src/gprs/gprs_gmm_attach.c:240:6: error

Change in osmocom-bb[master]: layer23/common: introduce L23SAP API for L1CTL

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11246 ) Change subject: layer23/common: introduce L23SAP API for L1CTL .. Patch Set 1: I'm not sure I'm following you here. The existing "Layer2/3"

Change in osmocom-bb[master]: layer23/l23sap.c: use the CHAN_IS_SACCH() macro

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11253 ) Change subject: layer23/l23sap.c: use the CHAN_IS_SACCH() macro .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

Change in osmocom-bb[master]: layer23/l23sap.c: fix: use host byte order for dl->frame_nr

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11252 ) Change subject: layer23/l23sap.c: fix: use host byte order for dl->frame_nr .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.

Change in osmocom-bb[master]: layer23/l23sap.c: use safe wrapper around rsl_dec_chan_nr()

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11254 ) Change subject: layer23/l23sap.c: use safe wrapper around rsl_dec_chan_nr() .. Patch Set 1: one coudl simply put an OSMO_ASSERT() in the cod

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #269

2018-10-07 Thread jenkins
See -- [...truncated 3.92 KB...] checking whether build environment is sane... yes checking for gawk... gawk checking w

Change in osmocom-bb[master]: layer23/common: introduce L23SAP API for L1CTL

2018-10-07 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11246 ) Change subject: layer23/common: introduce L23SAP API for L1CTL .. Patch Set 1: > I'm not sure I'm following you here. The existing "Laye

Change in osmocom-bb[master]: layer23/l23sap.c: use safe wrapper around rsl_dec_chan_nr()

2018-10-07 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11254 ) Change subject: layer23/l23sap.c: use safe wrapper around rsl_dec_chan_nr() .. Patch Set 1: > one coudl simply put an OSMO_ASSERT() in th

Change in docker-playground[master]: add "public-inbox" Dockerfile + Makefiel

2018-10-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11260 Change subject: add "public-inbox" Dockerfile + Makefiel .. add "public-inbox" Dockerfile + Makefiel this is just for playing around with it.

Change in docker-playground[master]: add "public-inbox" Dockerfile + Makefiel

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11260 ) Change subject: add "public-inbox" Dockerfile + Makefiel .. add "public-inbox" Dockerfile + Makefiel this is just for playing around

Change in docker-playground[master]: add "public-inbox" Dockerfile + Makefiel

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11260 ) Change subject: add "public-inbox" Dockerfile + Makefiel .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.

Change in libosmocore[master]: GSMTAP: add definitions for new LTE RRC channels

2018-10-07 Thread Shinjo Park
Shinjo Park has uploaded this change for review. ( https://gerrit.osmocom.org/11261 Change subject: GSMTAP: add definitions for new LTE RRC channels .. GSMTAP: add definitions for new LTE RRC channels Later release of 3GPP TS

Change in libosmocore[master]: GSMTAP: add definitions for LTE NAS subtypes

2018-10-07 Thread Shinjo Park
Shinjo Park has uploaded this change for review. ( https://gerrit.osmocom.org/11262 Change subject: GSMTAP: add definitions for LTE NAS subtypes .. GSMTAP: add definitions for LTE NAS subtypes Wireshark GSMTAP dissector has LT

Change in libosmocore[master]: GSMTAP: fix typos in comments

2018-10-07 Thread Shinjo Park
Shinjo Park has uploaded this change for review. ( https://gerrit.osmocom.org/11263 Change subject: GSMTAP: fix typos in comments .. GSMTAP: fix typos in comments Change-Id: I2e710141ee90ddc8b5336d5f81e99bd918d10106 --- M incl

Change in libosmocore[master]: GSMTAP: add definitions for new LTE RRC channels

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11261 ) Change subject: GSMTAP: add definitions for new LTE RRC channels .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in libosmocore[master]: GSMTAP: add definitions for new LTE RRC channels

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11261 ) Change subject: GSMTAP: add definitions for new LTE RRC channels .. GSMTAP: add definitions for new LTE RRC channels Later release o

Change in libosmocore[master]: GSMTAP: add definitions for LTE NAS subtypes

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11262 ) Change subject: GSMTAP: add definitions for LTE NAS subtypes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/112

Change in libosmocore[master]: GSMTAP: fix typos in comments

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11263 ) Change subject: GSMTAP: fix typos in comments .. GSMTAP: fix typos in comments Change-Id: I2e710141ee90ddc8b5336d5f81e99bd918d10106

Change in libosmocore[master]: GSMTAP: fix typos in comments

2018-10-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11263 ) Change subject: GSMTAP: fix typos in comments .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11263 To unsubscri

Change in libosmocore[master]: GSMTAP: add definitions for LTE NAS subtypes

2018-10-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11262 ) Change subject: GSMTAP: add definitions for LTE NAS subtypes .. GSMTAP: add definitions for LTE NAS subtypes Wireshark GSMTAP dissec