Change in osmo-gsm-manuals[master]: msc: update vty reference

2018-11-14 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11587 ) Change subject: msc: update vty reference .. Patch Set 2: > Nevertheless it is common knowledge AFAICT I disagree: if you, the person who've

Change in osmo-gsm-tester[master]: ms_driver: Allow to specify env and binary name/path

2018-11-14 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/11596 ) Change subject: ms_driver: Allow to specify env and binary name/path .. ms_driver: Allow to specify env and binary name/path For

Change in osmo-gsm-tester[master]: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH

2018-11-14 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/11580 ) Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH .. misc: Use RPATH to avoid having tests to set

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mt_sms for MT SMS over GSUP

2018-11-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11777 Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_sms for MT SMS over GSUP .. MSC_Tests.ttcn: introduce TC_gsup_mt_sms for MT SMS over

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP

2018-11-14 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11776 Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP .. MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA

Change in osmo-bsc[master]: bsc: bts_alloc: Use enum value during neigh_list_manual_mode initiali...

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11775 Change subject: bsc: bts_alloc: Use enum value during neigh_list_manual_mode initialization .. bsc: bts_alloc: Use enum value during

Change in osmo-bsc[master]: examples: Remove neighbor-list invalid for default setup

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11774 Change subject: examples: Remove neighbor-list invalid for default setup .. examples: Remove neighbor-list invalid for default setup In

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11742 ) Change subject: coverity: gscon_forget_lchan: squelch forward-null .. coverity: gscon_forget_lchan: squelch forward-null conn->fi

Change in osmo-ttcn3-hacks[master]: bsc: check channel release message presence

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11662 ) Change subject: bsc: check channel release message presence .. bsc: check channel release message presence Instead of vaguely

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11670 ) Change subject: lchan: set cause for 4 instances of release_in_error = true .. lchan: set cause for 4 instances of release_in_error

Change in osmo-bsc[master]: cosmetic: abis_rsl.c: drop uneccesary braces

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11669 ) Change subject: cosmetic: abis_rsl.c: drop uneccesary braces .. cosmetic: abis_rsl.c: drop uneccesary braces Change-Id:

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11668 ) Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* .. cosmetic: lchan: introduce sub-struct lchan->release.*

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11742 ) Change subject: coverity: gscon_forget_lchan: squelch forward-null .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11670 ) Change subject: lchan: set cause for 4 instances of release_in_error = true .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11668 ) Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-14 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11742 to look at the new patch set (#4). Change subject: coverity: gscon_forget_lchan: squelch forward-null .. coverity:

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

2018-11-14 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11670 to look at the new patch set (#3). Change subject: lchan: set cause for 4 instances of release_in_error = true

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-14 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11668 to look at the new patch set (#3). Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* ..

Change in osmo-gsm-manuals[master]: msc: update vty reference

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11587 ) Change subject: msc: update vty reference .. Patch Set 2: related: https://osmocom.org/issues/3695 -- To view, visit

Change in osmo-gsm-manuals[master]: msc: update vty reference

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11587 ) Change subject: msc: update vty reference .. Patch Set 2: http://git.osmocom.org/osmo-gsm-manuals/tree/INSTALL.txt#n22 -- To view, visit

Change in osmo-gsm-manuals[master]: msc: update vty reference

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11587 ) Change subject: msc: update vty reference .. Patch Set 2: > Patch Set 1: > > Which README? Top-level directory of osmo-gsm-manuals doesn't

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-14 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11742 to look at the new patch set (#3). Change subject: coverity: gscon_forget_lchan: squelch forward-null .. coverity:

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11742 ) Change subject: coverity: gscon_forget_lchan: squelch forward-null .. Patch Set 2: (1 comment)

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 4: > > I think you should also update TODO-RELEASE file

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 4: (1 comment)

Change in osmo-ttcn3-hacks[master]: bsc: handle RR Release messages

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11660 ) Change subject: bsc: handle RR Release messages .. bsc: handle RR Release messages Receive RR Release messages if they happen

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11659 ) Change subject: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel .. bsc: TC_chan_act_ack_est_ind_noreply: use

Change in osmo-ttcn3-hacks[master]: bsc: handle Deact SACCH messages

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11661 ) Change subject: bsc: handle Deact SACCH messages .. bsc: handle Deact SACCH messages Allow osmo-bsc sending a Deact SACCH messages

Change in osmo-ttcn3-hacks[master]: bsc: remove flush from f_expect_chan_rel

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11658 ) Change subject: bsc: remove flush from f_expect_chan_rel .. bsc: remove flush from f_expect_chan_rel When we're expecting release,

Change in osmo-bsc[master]: lchan release: always Deact SACCH

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11667 ) Change subject: lchan release: always Deact SACCH .. lchan release: always Deact SACCH If an lchan is being released and had a

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-14 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11742 to look at the new patch set (#2). Change subject: coverity: gscon_forget_lchan: squelch forward-null .. coverity:

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11665 ) Change subject: abis_rsl.c: drop unused enum sacch_deact .. abis_rsl.c: drop unused enum sacch_deact Change-Id:

Change in osmo-bsc[master]: fix: send RR Release (e.g. after BSSMAP Clear Cmd)

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11664 ) Change subject: fix: send RR Release (e.g. after BSSMAP Clear Cmd) .. fix: send RR Release (e.g. after BSSMAP Clear Cmd) After

Change in osmo-bsc[master]: lchan: release in error: fix missing messages / events

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11666 ) Change subject: lchan: release in error: fix missing messages / events .. lchan: release in error: fix missing messages / events

Change in osmo-bsc[master]: lchan release: always Deact SACCH

2018-11-14 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11667 to look at the new patch set (#2). Change subject: lchan release: always Deact SACCH

Change in osmo-bsc[master]: lchan release: always Deact SACCH

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11667 ) Change subject: lchan release: always Deact SACCH .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11667 To

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11668 ) Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11668 ) Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* .. Patch Set 1: (3 comments)

Change in osmo-gsm-tester[master]: tests: iperf3: Support testing parallel iperf3 clients in test

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11773 Change subject: tests: iperf3: Support testing parallel iperf3 clients in test .. tests: iperf3: Support testing parallel iperf3 clients

Change in osmo-gsm-tester[master]: resources.conf.rnd: gobi2k changed by ec20

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11770 Change subject: resources.conf.rnd: gobi2k changed by ec20 .. resources.conf.rnd: gobi2k changed by ec20 Given current bad support of

Change in osmo-gsm-tester[master]: iperf3: Allow changing port of iperf3 server

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11771 Change subject: iperf3: Allow changing port of iperf3 server .. iperf3: Allow changing port of iperf3 server This way several servers

Change in osmo-gsm-tester[master]: iperf3: implement str() method in iperf3 server

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11772 Change subject: iperf3: implement str() method in iperf3 server .. iperf3: implement str() method in iperf3 server This way it can be

Change in osmo-gsm-tester[master]: templates: osmo-pcu-sysmo: Set log level from dbg to info

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11769 ) Change subject: templates: osmo-pcu-sysmo: Set log level from dbg to info .. Patch Set 1: Code-Review+2 -- To view, visit

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #307

2018-11-14 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in osmo-gsm-tester[master]: templates: osmo-pcu-sysmo: Set log level from dbg to info

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11769 Change subject: templates: osmo-pcu-sysmo: Set log level from dbg to info .. templates: osmo-pcu-sysmo: Set log level from dbg to info

Change in osmo-bts[master]: bts-trx: trx_if: Use struct to store CTRL msg parsed responses

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11765 ) Change subject: bts-trx: trx_if: Use struct to store CTRL msg parsed responses .. Patch Set 1: And btw, I tested the changes and

Change in osmo-bts[master]: bts-trx: trx_if: Use struct to store CTRL msg parsed responses

2018-11-14 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11765 ) Change subject: bts-trx: trx_if: Use struct to store CTRL msg parsed responses .. Patch Set 1: (1 comment)

Change in osmo-dev[master]: gits: use @{u} to get upstream branch, not origin/%s

2018-11-14 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11756 ) Change subject: gits: use @{u} to get upstream branch, not origin/%s .. Patch Set 1: Code-Review-1 -- To view, visit

Change in osmo-dev[master]: gits: remove code dup: ask_reset_hard()

2018-11-14 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11757 ) Change subject: gits: remove code dup: ask_reset_hard() .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/11757 To