Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12268 ) Change subject: add to osmo_sock_get_name*() API .. add to osmo_sock_get_name*() API Basically, I am applying code review that I wo

Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-18 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12268 to look at the new patch set (#3). Change subject: add to osmo_sock_get_name*() API ..

Change in osmo-msc[master]: use mgcp-client configured endpoint domain name

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12361 Change subject: use mgcp-client configured endpoint domain name .. use mgcp-client configured endpoint domain name Rationale: reading pcaps

Change in osmo-msc[master]: fix msc_mgcp_fsm_evt_names: two missing events

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12359 Change subject: fix msc_mgcp_fsm_evt_names: two missing events .. fix msc_mgcp_fsm_evt_names: two missing events Change-Id: I66ebaf0a55de1a4

Change in osmo-msc[master]: mgcp log tweak: say RAN, not BTS, like surrounding logging

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12360 Change subject: mgcp log tweak: say RAN, not BTS, like surrounding logging .. mgcp log tweak: say RAN, not BTS, like surrounding logging Cha

Change in osmo-bsc[master]: use mgcp-client configured endpoint domain name

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12358 Change subject: use mgcp-client configured endpoint domain name .. use mgcp-client configured endpoint domain name Rationale: reading pcaps

Change in osmo-mgw[master]: mgcp_client_vty: fix missing talloc_free

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12355 Change subject: mgcp_client_vty: fix missing talloc_free .. mgcp_client_vty: fix missing talloc_free If the vty client enters multiple local

Change in osmo-mgw[master]: mgcp_client: make domain part of endpoint configurable

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12357 Change subject: mgcp_client: make domain part of endpoint configurable .. mgcp_client: make domain part of endpoint configurable So far, bot

Change in osmo-mgw[master]: osmo-mgw: err-log: include expected domain name

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12356 Change subject: osmo-mgw: err-log: include expected domain name .. osmo-mgw: err-log: include expected domain name Add the expected domain n

Change in osmo-mgw[master]: mgcp_client: drop a bunch of dead code

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12354 Change subject: mgcp_client: drop a bunch of dead code .. mgcp_client: drop a bunch of dead code Remove public API that makes no sense anymo

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12345 ) Change subject: msc_vty: display current RAN type .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12345 To un

Change in osmo-bts[master]: sysmobts_mgr: Prepare code for gpsd < 2.96 support

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12339 ) Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support .. sysmobts_mgr: Prepare code for gpsd < 2.96 support API pri

Change in osmo-bts[master]: sysmobts_mgr: Add support for gpsd < 2.96

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12340 ) Change subject: sysmobts_mgr: Add support for gpsd < 2.96 .. sysmobts_mgr: Add support for gpsd < 2.96 This allows running sysmo

Change in osmo-bts[master]: sysmobts_mgr: Prepare code for gpsd < 2.96 support

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12339 ) Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmoc

Change in osmo-bts[master]: sysmobts_mgr: Add support for gpsd < 2.96

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12340 ) Change subject: sysmobts_mgr: Add support for gpsd < 2.96 .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12

Change in osmo-bts[master]: sysmobts_mgr: Prepare code for gpsd < 2.96 support

2018-12-18 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12339 ) Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.

Re: Change in osmo-sip-connector[master]: Fix mncc socket name

2018-12-18 Thread Daniel Willmann
On Fri, 2018-10-05 at 17:55 +, Keith Whyte wrote: > Keith Whyte has posted comments on this change. ( > https://gerrit.osmocom.org/11240 ) > > Change subject: Fix mncc socket name > Hmm.. broken now for anybody who was using osmo-nitb... of course > they can fix it by passing the socket name

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12352 ) Change subject: Store GSN address in libosmocore struct .. Patch Set 2: > That's orthogonal to this patch I think: regardless of the use

Change in osmo-ttcn3-hacks[master]: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12346 ) Change subject: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher .. Patch Set 1: Code-Review+1 Did some tests fail because of this?

Change in osmocom-bb[master]: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12351 ) Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12243 To

Change in osmo-msc[master]: use vty->type instead of local variable

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12353 ) Change subject: use vty->type instead of local variable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12353 To unsubscri

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12352 ) Change subject: Store GSN address in libosmocore struct .. Patch Set 2: > Then please state so in the commit description. Until I see a user for the

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12352 ) Change subject: Store GSN address in libosmocore struct .. Patch Set 2: > > You are breaking the ABI > > That's not a library - what k

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12352 ) Change subject: Store GSN address in libosmocore struct .. Patch Set 2: > You are breaking the ABI That's not a library - what kind of ABI breakage a

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: > Patch Set 1: Code-Review+1 > Simply changing the log level of this message in os

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12266 ) Change subject: vty: show subscriber: put() before printing the use count .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.os

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

2018-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12266 ) Change subject: vty: show subscriber: put() before printing the use count .. vty: show subscriber: put() before printing the use coun

Change in osmo-msc[master]: use vty->type instead of local variable

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12353 Change subject: use vty->type instead of local variable .. use vty->type instead of local variable We can check if we're parsing the confi

Change in osmo-bsc[master]: LCLS: update parameter representation

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11820 ) Change subject: LCLS: update parameter representation .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11820/3/src/osmo-bsc/o

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12352 ) Change subject: Store GSN address in libosmocore struct .. Patch Set 2: Code-Review-1 (1 comment) I see no good reason for this change.

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. VLR: drop unused struct members Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84 --- M

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: Code-Review+2 Since there're 2 votes for it already, let's merge this and nuke entire

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-18 Thread Stefan Sperling
Hello Pau Espin Pedrol, Max, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12243 to look at the new patch set (#4). Change subject: make gsup ipa name configurable in osmo-sgsn.cfg

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12350 ) Change subject: host/layer23: don't init SAP interface by default .. Patch Set 1: > Patch Set 1: > > > There is code which calls sap_open

Change in osmo-bsc[master]: LCLS: update parameter representation

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11820 ) Change subject: LCLS: update parameter representation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11820 To unsubscribe

Change in osmo-bsc[master]: LCLS: update parameter representation

2018-12-18 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11820 ) Change subject: LCLS: update parameter representation .. LCLS: update parameter representation * use osmo_lcls struct from libosmocore * use

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12352 to look at the new patch set (#2). Change subject: Store GSN address in libosmocore struct .. Store GSN address in li

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

2018-12-18 Thread Stefan Sperling
Stefan Sperling has removed a vote on this change. Change subject: MSC: adjust gsup log level to error .. Removed Code-Review+1 by Stefan Sperling -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help w

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: Code-Review+1 > Patch Set 1: > > I am not sure if this is a very good

Change in osmo-bsc[master]: LCLS: update parameter representation

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11820 ) Change subject: LCLS: update parameter representation .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11820 T

Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12268 ) Change subject: add to osmo_sock_get_name*() API .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12268 To unsubs

Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vt

Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12268 ) Change subject: add to osmo_sock_get_name*() API .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12268/2/src/socket.c File sr

Change in osmo-sgsn[master]: gtphub: remove code duplication

2018-12-18 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12230 ) Change subject: gtphub: remove code duplication .. Abandoned -- To view, visit https://gerrit.osmocom.org/12230 To unsubscribe, or for help writing mail filters

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2018-12-18 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12352 Change subject: Store GSN address in libosmocore struct .. Store GSN address in libosmocore struct That's automated code change made using following pr

Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12343 ) Change subject: msc_vty: also show IMEI and IMEISV .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12343/2/src/

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12350 ) Change subject: host/layer23: don't init SAP interface by default .. Patch Set 1: > There is code which calls sap_open() in mobile/app_mo

Change in osmo-msc[master]: msc_vty: display current RAN type

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12345 ) Change subject: msc_vty: display current RAN type .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12345 To un

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12344 ) Change subject: msc_vty: display subscriber flags .. Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/12344 To uns

Change in osmo-msc[master]: msc_vty: display subscriber flags

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12344 ) Change subject: msc_vty: display subscriber flags .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12344/2/src/l

Change in osmo-bts[master]: sysmobts_mgr: Add support for gpsd < 2.96

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12340 ) Change subject: sysmobts_mgr: Add support for gpsd < 2.96 .. Patch Set 4: Code-Review+1 Silly of them to break the API without backwards

Change in osmo-bts[master]: sysmobts_mgr: Prepare code for gpsd < 2.96 support

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12339 ) Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmoco

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12350 ) Change subject: host/layer23: don't init SAP interface by default .. Patch Set 1: Code-Review+1 There is code which calls sap_open() in m

Change in osmocom-bb[master]: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12351 ) Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12335 To unsu

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12330 ) Change subject: Use proper type for tch_rtp_connect() parameter .. Use proper type for tch_rtp_connect() parameter Change-Id: I6e2efcd2e25d6e

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12330 ) Change subject: Use proper type for tch_rtp_connect() parameter .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12330 To u

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

2018-12-18 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12349 to look at the new patch set (#2). Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE .. imp

Change in osmocom-bb[master]: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12351 ) Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/1235

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12350 ) Change subject: host/layer23: don't init SAP interface by default .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmoco

Change in osmocom-bb[master]: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()

2018-12-18 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12351 ) Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmoc

Change in osmocom-bb[master]: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12351 Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() .. host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE() Chang

Change in osmocom-bb[master]: host/layer23: don't init SAP interface by default

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12350 Change subject: host/layer23: don't init SAP interface by default .. host/layer23: don't init SAP interface by default Almost all layer23

Change in osmo-msc[master]: MNCC: use log wrapper for call processing

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12329 ) Change subject: MNCC: use log wrapper for call processing .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12329/3/

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. BSC_ConnectionHandler: introduce ctrl interface There are some up

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11701 ) Change subject: BSC_ConnectionHandler: make VTY interface available .. BSC_ConnectionHandler: make VTY interface available The BSC_C

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11701 ) Change subject: BSC_ConnectionHandler: make VTY interface available .. Patch Set 11: Code-Review+1 I like this change, but the MSC's VTY

Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL_Adapter: Let the OS decide over the local port number

2018-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12348 ) Change subject: Osmocom_CTRL_Adapter: Let the OS decide over the local port number .. Osmocom_CTRL_Adapter: Let the OS decide over t

Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL_Adapter: Let the OS decide over the local port number

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12348 ) Change subject: Osmocom_CTRL_Adapter: Let the OS decide over the local port number .. Patch Set 1: Code-Review+2 -- To view, visit https:/

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. GSUP/SMS: introduce MO-/MT-FORWARD-SM messages According to 3GPP T

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11751 T

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

2018-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11751 ) Change subject: GSUP/SMS: introduce READY-FOR-SM message .. GSUP/SMS: introduce READY-FOR-SM message According to 3GPP TS 29.002, se

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12349 Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE .. improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

2018-12-18 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/11690 ) Change subject: MSC_Tests: remove unused control interface .. Abandoned I have revisited the problem and managed to solve it. Now we have the control inter

Change in osmo-ttcn3-hacks[master]: WIP: MSC_Tests: Add SGs testcases

2018-12-18 Thread dexter
dexter has uploaded a new patch set (#18) to the change originally created by Harald Welte. ( https://gerrit.osmocom.org/11488 ) Change subject: WIP: MSC_Tests: Add SGs testcases .. WIP: MSC_Tests: Add SGs testcases This extens

Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL_Adapter: Let the OS decide over the local port number

2018-12-18 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12348 Change subject: Osmocom_CTRL_Adapter: Let the OS decide over the local port number .. Osmocom_CTRL_Adapter: Let the OS decide over the local port nu

Change in osmo-ttcn3-hacks[master]: WIP: MSC_Tests: Add SGs testcases

2018-12-18 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11488 ) Change subject: WIP: MSC_Tests: Add SGs testcases .. Patch Set 17: (3 comments) > Patch Set 17: Code-Review+2 Note: We must not merge this before

Change in osmo-ttcn3-hacks[master]: add three tests for CIPHER MODE COMPLETE without algo

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12347 Change subject: add three tests for CIPHER MODE COMPLETE without algo .. add three tests for CIPHER MODE COMPLETE without algo Add three t

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 ) Change subject: Use msgb helper instead of local #define for debug print .. Patch Set 2: This change is ready for review. -- To view, visit https://

Change in libosmocore[master]: cleanup: remove unused define

2018-12-18 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12272 ) Change subject: cleanup: remove unused define .. Abandoned Superseded by new revision of parent patch. -- To view, visit https://gerrit.osmocom.org/12272 To un

Change in osmo-ttcn3-hacks[master]: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher

2018-12-18 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12346 Change subject: wait for subscriber conn in TC_cipher_complete_with_invalid_cipher .. wait for subscriber conn in TC_cipher_complete_with_

Change in osmocom-bb[master]: Revert "mobile: use VTY bind addr from config, deprecate cmd line opt...

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12208 ) Change subject: Revert "mobile: use VTY bind addr from config, deprecate cmd line options" .. Patch Set 1: Hi Holger, > Something that

Change in osmocom-bb[master]: Revert "mobile: use VTY bind addr from config, deprecate cmd line opt...

2018-12-18 Thread Holger Freyther
Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/12208 ) Change subject: Revert "mobile: use VTY bind addr from config, deprecate cmd line options" .. Patch Set 1: > Patch Set 1: Code-Review-1

Change in osmo-msc[master]: MNCC: use log wrapper for call processing

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12329 ) Change subject: MNCC: use log wrapper for call processing .. Patch Set 2: > Patch Set 2: > > Yep, looks fine. Feel free to add +1/+2 than :) -- To

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/vlr.h File inc

Change in osmo-msc[master]: VLR: drop unused struct members

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12335 ) Change subject: VLR: drop unused struct members .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12335/3/include/osmocom/msc/v

Change in osmo-msc[master]: Use proper type for tch_rtp_connect() parameter

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12330 ) Change subject: Use proper type for tch_rtp_connect() parameter .. Patch Set 2: Code-Review+1 Yeah ok. -- To view, visit https://gerrit

Change in osmo-msc[master]: MNCC: use log wrapper for call processing

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12329 ) Change subject: MNCC: use log wrapper for call processing .. Patch Set 2: Yep, looks fine. -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: Remove redundancy in LAC processing

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12338 ) Change subject: Remove redundancy in LAC processing .. Patch Set 3: Code-Review+1 Yes makes sense. -- To view, visit https://gerrit.osm

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-18 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.o

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #343

2018-12-18 Thread jenkins
See -- [...truncated 3.69 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu check

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11069 ) Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .. Patch Set 11: (3 comments) https://gerrit.osmocom.org/#/c/11069/11/src

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

2018-12-18 Thread Vadim Yanitskiy
Hello Stefan Sperling, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11069 to look at the new patch set (#12). Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages .

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-12-18 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. chapters/gsup.adoc: document READY-FOR-SM message Change-Id:

Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details

2018-12-18 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. VLR tests: avoid leaking LAC access details Avoid leaking details on accessing

  1   2   >