Change in libosmocore[master]: Add function to combine nibbles into byte

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12573 ) Change subject: Add function to combine nibbles into byte .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. Patch Set 11: Code-Review+1 (1 comment)

Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12572 ) Change subject: Change GSM48_PDISC_* to enum type .. Patch Set 1: (1 comment)

Build failure of network:osmocom:nightly/libosmocore in Debian_9.0/armv7l

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of

Build failure of network:osmocom:nightly/libusrp in xUbuntu_16.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/libusrp failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build

Change in libosmocore[master]: Add function to combine nibbles into byte

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12573 Change subject: Add function to combine nibbles into byte .. Add function to combine nibbles into byte It's a very common patter throughout GSM 04.08

Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12572 Change subject: Change GSM48_PDISC_* to enum type .. Change GSM48_PDISC_* to enum type Prepare for transaction handling revamp in OsmoMSC: an enum is

Change in osmo-msc[master]: MNCC: use explicit struct type in gsm_call

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12563 ) Change subject: MNCC: use explicit struct type in gsm_call .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: Log: don't print CallRef prefix

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12570 ) Change subject: Log: don't print CallRef prefix .. Patch Set 2: Code-Review-2 (1 comment)

Change in osmo-msc[master]: Clarify transaction ID assignment

Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 ) Change subject: Clarify transaction ID assignment .. Patch Set 3: > Patch Set 3: > So, I think we should roll-back to the initial version of this

Change in osmo-msc[master]: Clarify transaction ID assignment

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12519 ) Change subject: Clarify transaction ID assignment .. Patch Set 3: Hi Max, Harald, > I am not sure if we should drop it just because the

Change in osmo-msc[master]: VLR: use msgb_eq_data_print() for comparison

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12571 Change subject: VLR: use msgb_eq_data_print() for comparison .. VLR: use msgb_eq_data_print() for comparison This simplifies tests refactoring by

Change in osmo-msc[master]: Log: don't print CallRef prefix

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12570 to look at the new patch set (#2). Change subject: Log: don't print CallRef prefix .. Log: don't print CallRef

Change in osmo-msc[master]: Log: don't print CallRef prefix

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12570 Change subject: Log: don't print CallRef prefix .. Log: don't print CallRef prefix In a preparation for upcoming CallRef fixes, let's update test

Change in libosmocore[master]: LCLS: add string dump helpers

Max has posted comments on this change. ( https://gerrit.osmocom.org/12492 ) Change subject: LCLS: add string dump helpers .. Patch Set 8: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/12492

Change in libosmocore[master]: LCLS: add allocator function

Max has abandoned this change. ( https://gerrit.osmocom.org/12491 ) Change subject: LCLS: add allocator function .. Abandoned -- To view, visit https://gerrit.osmocom.org/12491 To unsubscribe, or for help writing mail filters,

Change in libosmocore[master]: Prevent GCR encoder/decoder functions from being used directly

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12569 Change subject: Prevent GCR encoder/decoder functions from being used directly .. Prevent GCR encoder/decoder functions from being used directly They

Change in libosmocore[master]: LCLS: make GCR into static member of osmo_lcls

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12568 Change subject: LCLS: make GCR into static member of osmo_lcls .. LCLS: make GCR into static member of osmo_lcls Most of the time we'll have GCR

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12478 To

Change in osmo-hlr[master]: VTY: integrate IMEI

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12527 ) Change subject: VTY: integrate IMEI .. Patch Set 5: Code-Review-1 (1 comment)

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12526 ) Change subject: Optionally store IMEI in subscriber table .. Patch Set 5: Code-Review-1 (2 comments)

Change in osmo-hlr[master]: Add IMEI column to subscriber table

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 4: (1 comment) -1 https://gerrit.osmocom.org/#/c/12525/4/src/db_hlr.c

Change in osmo-hlr[master]: Add IMEI column to subscriber table

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 4: Code-Review-1 (1 comment) -0.0001

Change in osmo-hlr[master]: Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi()

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12566 ) Change subject: Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: gitignore: add tests/hlr_vty_test.db*

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12565 ) Change subject: gitignore: add tests/hlr_vty_test.db* .. Patch Set 1: Code-Review+1 actually the tests should also remove them right away?

Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12567 Change subject: common: extend glossary.adoc .. common: extend glossary.adoc Add EIR, IMEISV, LU, PVLR, SS, TS and VLR, clarify the difference

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12526 ) Change subject: Optionally store IMEI in subscriber table .. Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/12526/4/src/hlr.c File

Change in osmo-hlr[master]: Add IMEI column to subscriber table

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 3: (4 comments) https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG Commit

Change in osmo-hlr[master]: Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi()

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12566 Change subject: Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi() .. Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi() Properly

Change in osmo-hlr[master]: Add IMEI column to subscriber table

Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12525 to look at the new patch set (#4). Change subject: Add IMEI column to subscriber table .. Add IMEI

Change in osmo-hlr[master]: gitignore: add tests/hlr_vty_test.db*

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12565 Change subject: gitignore: add tests/hlr_vty_test.db* .. gitignore: add tests/hlr_vty_test.db* Ignore files generated from the VTY test.

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12526 to look at the new patch set (#5). Change subject: Optionally store IMEI in subscriber table ..

Change in libosmocore[master]: MNCC: move messages into public header and convert to enum

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12564 Change subject: MNCC: move messages into public header and convert to enum .. MNCC: move messages into public header and convert to enum Change-Id:

Change in osmo-msc[master]: MNCC: use explicit struct type in gsm_call

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12563 Change subject: MNCC: use explicit struct type in gsm_call .. MNCC: use explicit struct type in gsm_call There's no need to use 'void *' because we

Change in osmo-msc[master]: Add tests for transaction routines

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 11: Code-Review-1 Keeping my -1 because I am against using same callref

Change in osmo-msc[master]: Add tests for transaction routines

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: (3 comments)

Change in osmo-msc[master]: Clarify transaction ID assignment

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12519 to look at the new patch set (#3). Change subject: Clarify transaction ID assignment .. Clarify

Change in osmo-msc[master]: Add SGs Interface

dexter has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 30: (96 comments) I am now through with the review, I hope nothing slipped through, the scrolling

Change in libosmocore[master]: socket: add define for socket name length

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12554 to look at the new patch set (#2). Change subject: socket: add define for socket name length ..

Change in osmo-msc[master]: Add tests for transaction routines

Hello Vadim Yanitskiy, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12556 to look at the new patch set (#11). Change subject: Add tests for transaction routines

Change in osmo-ttcn3-hacks[master]: MSC_Tests: change default for mp_vlr_name

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12562 Change subject: MSC_Tests: change default for mp_vlr_name .. MSC_Tests: change default for mp_vlr_name osmo-msc now uses *_SGS_SERVER_* instead of

Change in osmo-msc[master]: Clarify transaction ID assignment

Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 ) Change subject: Clarify transaction ID assignment .. Patch Set 2: This change is ready for review. -- To view, visit

Change in osmo-msc[master]: Add tests for transaction routines

Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/12556/9/tests/trans/trans_test.c File

Change in osmo-msc[master]: Add SGs Interface

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11642 to look at the new patch set (#30). Change subject: Add SGs Interface .. Add SGs

Change in osmo-msc[master]: Add tests for transaction routines

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: > (1 comment) Yup, please see: https://osmocom.org/issues/3294 --

Change in osmo-msc[master]: Add tests for transaction routines

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: (4 comments)

Change in osmo-msc[master]: Add tests for transaction routines

Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/12556/9/tests/trans/trans_test.c File

Change in osmo-msc[master]: Add tests for transaction routines

Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12556 to look at the new patch set (#10). Change subject: Add tests for transaction routines

Change in osmo-msc[master]: Add tests for transaction routines

Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 ) Change subject: Add tests for transaction routines .. Patch Set 9: (8 comments) > you could set its level to DEBUG Good point. I'll update it in

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

Hello Stefan Sperling, Vadim Yanitskiy, Pau Espin Pedrol, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12478 to look at the new patch set (#11). Change subject: VLR: send CHECK-IMEI to EIR/HLR