Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation

2019-03-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13196 ) Change subject: Add IPA keep-alive FSM implementation .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13196

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 2: Code-Review-1 I think it makes more sense to have all *.service

Change in osmo-msc[master]: msc_vty: add missing header file

2019-03-19 Thread Daniel Willmann
Daniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13329 ) Change subject: msc_vty: add missing header file .. msc_vty: add missing header file The symbol GSM0808_SPEECH_FULL_BM is used

Change in osmo-msc[master]: msc_vty: add missing header file

2019-03-19 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13329 ) Change subject: msc_vty: add missing header file .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13329 To

Change in osmo-sysmon[master]: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13330 Change subject: Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 .. Bump version: 0.0.1.66-d4c3-dirty → 0.1.0 Change-Id:

Change in osmo-msc[master]: msc_vty: add missing header file

2019-03-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13329 Change subject: msc_vty: add missing header file .. msc_vty: add missing header file The symbol GSM0808_SPEECH_FULL_BM is used in msc_vty.c, but

Change in osmo-sysmon[master]: Add debian packaging content

2019-03-19 Thread Pau Espin Pedrol
Hello lynxis lazus, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13328 to look at the new patch set (#2). Change subject: Add debian packaging content .. Add debian

Change in osmo-msc[master]: debian/control: Fix typo

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13325 ) Change subject: debian/control: Fix typo .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13325 To unsubscribe, or for

Change in osmo-sysmon[master]: Add debian packaging content

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13328 ) Change subject: Add debian packaging content .. Patch Set 1: Why do we need it packaged for Debian? I doubt it would be useful outside of hw BTS.

Change in osmo-bsc[master]: lchan_fsm: add missing header file.

2019-03-19 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13327 ) Change subject: lchan_fsm: add missing header file. .. lchan_fsm: add missing header file. The symbol

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 2: (1 comment)

Change in osmo-sysmon[master]: Add debian packaging content

2019-03-19 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13328 ) Change subject: Add debian packaging content .. Patch Set 1: Code-Review-1 (3 comments)

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 2: (1 comment) It's pretty handy to start entire stack as a single unit instead of

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 2: (1 comment)

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Max
Hello Vadim Yanitskiy, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13326 to look at the new patch set (#2). Change subject: Add example systemd user unit files ..

Change in osmo-bsc[master]: lchan_fsm: add missing header file.

2019-03-19 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13327 ) Change subject: lchan_fsm: add missing header file. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13327 To

Change in osmo-sysmon[master]: Add debian packaging content

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13328 ) Change subject: Add debian packaging content .. Patch Set 1: I'll push tag 0.0.1 for this one once merged. -- To view, visit

Change in osmo-sysmon[master]: Makefile.am: Add missing bits to have make release working

2019-03-19 Thread Pau Espin Pedrol
Hello Max, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13323 to look at the new patch set (#2). Change subject: Makefile.am: Add missing bits to have make release working

Change in osmo-sysmon[master]: Add debian packaging content

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13328 Change subject: Add debian packaging content .. Add debian packaging content Change-Id: I2bcacca040364f77aa6b17edf53acf53c820c17b --- A

Change in osmo-bsc[master]: lchan_fsm: add missing header file.

2019-03-19 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13327 ) Change subject: lchan_fsm: add missing header file. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13327 To

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 8: (1 comment) This change is ready for review.

Change in osmo-bsc[master]: lchan_fsm: add missing header file.

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13327 ) Change subject: lchan_fsm: add missing header file. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13327 To unsubscribe,

Change in osmo-bsc[master]: lchan_fsm: add missing header file.

2019-03-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13327 Change subject: lchan_fsm: add missing header file. .. lchan_fsm: add missing header file. The symbol GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 is

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 1: I'd prefer having them under contrib/systemd/user/ -- To view,

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13326 ) Change subject: Add example systemd user unit files .. Patch Set 1: (1 comment)

Change in osmocom-bb[master]: Add example systemd user unit files

2019-03-19 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13326 Change subject: Add example systemd user unit files .. Add example systemd user unit files Those examples illustrate how fake_trx and trxcon can

Change in osmo-msc[master]: debian/control: Fix typo

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13325 Change subject: debian/control: Fix typo .. debian/control: Fix typo Change-Id: I3392d8e184413203d27fc3d75371de4d66f205b9 --- M

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-03-19 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Support Emergency Calling LCR supports emergency calling by sending the string

Change in osmo-sysmon[master]: Makefile.am: Add missing bits to have make release working

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13323 ) Change subject: Makefile.am: Add missing bits to have make release working .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 4: (1 comment) Not a merge blocker though.

Change in osmo-bsc[master]: test

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13324 ) Change subject: test .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/13324 To unsubscribe, or for help

Change in osmo-bsc[master]: test

2019-03-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13324 Change subject: test .. test Change-Id: I0cf5432aec1f61adc6f6cf74a8d4f89dbaea0863 --- A test.me 1 file changed, 0 insertions(+), 0 deletions(-)

Change in osmo-sysmon[master]: Makefile.am: Add missing bits to have make release working

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13323 Change subject: Makefile.am: Add missing bits to have make release working .. Makefile.am: Add missing bits to have make release working

Change in osmo-pcu[master]: Explicitly clean up BTS singleton

2019-03-19 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13318 ) Change subject: Explicitly clean up BTS singleton .. Explicitly clean up BTS singleton Add method to explicitly cleanup BTS singleton

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12682 ) Change subject: Support Emergency Calling .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12682 To

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13320 to look at the new patch set (#3). Change subject: Write configuration correctly from vty (alert notifications) ..

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13320 to look at the new patch set (#2). Change subject: Write configuration correctly from vty (alert notifications) ..

Change in osmo-pcu[master]: Explicitly clean up BTS singleton

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13318 ) Change subject: Explicitly clean up BTS singleton .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13318 To

Change in osmo-pcu[master]: Explicitly clean up BTS singleton

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13318 ) Change subject: Explicitly clean up BTS singleton .. Patch Set 2: Code-Review+1 It may make more sense to get rid of the main_bts

Change in osmo-msc[master]: vlr_subscr_name(): use OSMO_STRBUF

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13322 ) Change subject: vlr_subscr_name(): use OSMO_STRBUF .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13322 To

Change in libosmo-sccp[master]: add caller-owns-msgb variant osmo_sccp_user_sap_down2()

2019-03-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13277 ) Change subject: add caller-owns-msgb variant osmo_sccp_user_sap_down2() .. Patch Set 1: > what about the proposal with the 'volatile

Change in osmo-sip-connector[master]: Support Emergency Calling

2019-03-19 Thread Keith Whyte
Hello Max, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12682 to look at the new patch set (#12). Change subject: Support Emergency Calling .. Support

Change in osmo-msc[master]: vlr_subscr_name(): use OSMO_STRBUF

2019-03-19 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13322 Change subject: vlr_subscr_name(): use OSMO_STRBUF .. vlr_subscr_name(): use OSMO_STRBUF We now have a nicer way to compose strings in a

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

2019-03-19 Thread Vasil Velichkov
Hello Piotr Krysik, fixeria, Vadim Yanitskiy, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13246 to look at the new patch set (#4). Change subject: Fix the TCH/H decoder and demapper XML definitions

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

2019-03-19 Thread Vasil Velichkov
Vasil Velichkov has posted comments on this change. ( https://gerrit.osmocom.org/13246 ) Change subject: Fix the TCH/H decoder and demapper XML definitions .. Patch Set 3: (1 comment)

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

2019-03-19 Thread Vasil Velichkov
Hello Piotr Krysik, fixeria, Vadim Yanitskiy, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13246 to look at the new patch set (#3). Change subject: Fix the TCH/H decoder and demapper XML definitions

Change in osmo-msc[master]: libvlr: Allow 2G auth tuples to be re-used without going through AUTH

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13248 ) Change subject: libvlr: Allow 2G auth tuples to be re-used without going through AUTH .. libvlr: Allow 2G auth tuples to be re-used

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13319 ) Change subject: a_iface_bssap: add context information to log output .. Patch Set 2: (1 comment)

Change in osmo-pcu[master]: MS store: move test helper to unit test

2019-03-19 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13213 ) Change subject: MS store: move test helper to unit test .. MS store: move test helper to unit test It's confusing to have test-specific

Change in osmo-bsc[master]: osmo_bsc_bssap: check bssmap length field

2019-03-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13306 ) Change subject: osmo_bsc_bssap: check bssmap length field .. Patch Set 1: (3 comments) > Uploaded patch set 2.

Change in osmo-bsc[master]: osmo_bsc_bssap: check bssmap length field

2019-03-19 Thread dexter
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13306 to look at the new patch set (#2). Change subject: osmo_bsc_bssap: check bssmap length field ..

Change in osmo-msc[master]: libvlr: Allow 2G auth tuples to be re-used without going through AUTH

2019-03-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13248 ) Change subject: libvlr: Allow 2G auth tuples to be re-used without going through AUTH .. Patch Set 1: > looks good to me. I'm a bit wondering about

Change in osmo-msc[master]: a_iface_bssap: check bssmap length field

2019-03-19 Thread dexter
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13307 to look at the new patch set (#2). Change subject: a_iface_bssap: check bssmap length field ..

Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

2019-03-19 Thread Max
Max has removed a vote on this change. Change subject: pcu_sock: cast to long unsigned int before printing .. Removed Code-Review+1 by Max -- To view, visit https://gerrit.osmocom.org/13267 To unsubscribe, or for help writing

Change in osmo-msc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13321 Change subject: Write configuration correctly from vty (alert notifications) .. Write configuration correctly from vty (alert notifications)

Change in openbsc[master]: Write configuration correctly from vty (alert notifications)

2019-03-19 Thread Keith Whyte
Keith Whyte has uploaded this change for review. ( https://gerrit.osmocom.org/13320 Change subject: Write configuration correctly from vty (alert notifications) .. Write configuration correctly from vty (alert notifications)

Change in libosmocore[master]: socket: osmo_sock_get_name() Use "const void *" as talloc context

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13309 ) Change subject: socket: osmo_sock_get_name() Use "const void *" as talloc context .. socket: osmo_sock_get_name() Use "const void

Change in libosmo-abis[master]: rtp: Add 'autoconnect' feature to the osmo_rtp_socket

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13203 ) Change subject: rtp: Add 'autoconnect' feature to the osmo_rtp_socket .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13199 ) Change subject: AMR: Signal usage of octet-aligned or bandwith-efficient mode to MSC .. AMR: Signal usage of octet-aligned or

Change in libosmo-abis[master]: rtp: Add 'autoconnect' feature to the osmo_rtp_socket

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13203 ) Change subject: rtp: Add 'autoconnect' feature to the osmo_rtp_socket .. rtp: Add 'autoconnect' feature to the osmo_rtp_socket The

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_mt_sms_and_nothing: also do f_sgsap_bssmap_screening

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13193 ) Change subject: msc: f_tc_sgsap_mt_sms_and_nothing: also do f_sgsap_bssmap_screening .. msc: f_tc_sgsap_mt_sms_and_nothing: also do

Change in osmo-bts[master]: oc2g: l1if: delay trx initialization to avoid race condition

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13208 ) Change subject: oc2g: l1if: delay trx initialization to avoid race condition .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: oc2g: l1if: delay trx initialization to avoid race condition

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13208 ) Change subject: oc2g: l1if: delay trx initialization to avoid race condition .. oc2g: l1if: delay trx initialization to avoid race

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-03-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13319 Change subject: a_iface_bssap: add context information to log output .. a_iface_bssap: add context information to log output At the moment many of

Change in libosmocore[master]: add osmo_ip_port API

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13123 ) Change subject: add osmo_ip_port API .. Patch Set 5: maybe osmith has time to do the rename so we can get this merged? -- To view, visit

Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13196 ) Change subject: Add IPA keep-alive FSM implementation .. Patch Set 2: (2 comments)

Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation

2019-03-19 Thread Harald Welte
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13196 to look at the new patch set (#3). Change subject: Add IPA keep-alive FSM implementation .. Add

Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13168 ) Change subject: msc: f_call_hangup: ignore MDCX .. Patch Set 1: ping? -- To view, visit https://gerrit.osmocom.org/13168 To unsubscribe,

Change in libosmocore[master]: vty/tdef_vty.c: drop redundant comparison

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13019 ) Change subject: vty/tdef_vty.c: drop redundant comparison .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13019

Change in libosmocore[master]: vty/tdef_vty.c: drop redundant comparison

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13019 ) Change subject: vty/tdef_vty.c: drop redundant comparison .. vty/tdef_vty.c: drop redundant comparison The amount of arguments is

Change in osmo-bsc[master]: OML: Fix encoded length value of OML GET ATTRIBUTES

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12890 ) Change subject: OML: Fix encoded length value of OML GET ATTRIBUTES .. OML: Fix encoded length value of OML GET ATTRIBUTES Before

Change in osmo-ci[master]: Add timeout wrapper to regular gerrit verification jobs

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12857 ) Change subject: Add timeout wrapper to regular gerrit verification jobs .. Patch Set 2: would be great to get some answers to the questions

Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10216 ) Change subject: ipa_ccm_idtag_parse*: Fix reported length value .. ipa_ccm_idtag_parse*: Fix reported length value IPA CCM is using

Change in libosmo-netif[master]: Deprecate osmo_stream_cli_open2()

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12845 ) Change subject: Deprecate osmo_stream_cli_open2() .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12845 To

Change in libosmo-netif[master]: Deprecate osmo_stream_cli_open2()

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12845 ) Change subject: Deprecate osmo_stream_cli_open2() .. Deprecate osmo_stream_cli_open2() This supposed to be variant of

Change in osmo-msc[master]: a_iface: OSMO_ASSERT() if we ever want to send BSSAP with invalid length

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12928 ) Change subject: a_iface: OSMO_ASSERT() if we ever want to send BSSAP with invalid length .. a_iface: OSMO_ASSERT() if we ever want

Change in osmo-pcu[master]: Explicitly clean up BTS singleton

2019-03-19 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13318 Change subject: Explicitly clean up BTS singleton .. Explicitly clean up BTS singleton Add method to explicitly cleanup BTS singleton similar to

Change in osmo-mgw[master]: AMR: Add function to convert between bw-effient and octet aligned mode

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13159 ) Change subject: AMR: Add function to convert between bw-effient and octet aligned mode .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add testcases to verify S15-S0 handling

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13237 ) Change subject: BSC_Tests: add testcases to verify S15-S0 handling .. BSC_Tests: add testcases to verify S15-S0 handling The

Change in osmo-bsc[master]: lchan_fsm: do not include 12.2k in active set on HR channels

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13095 ) Change subject: lchan_fsm: do not include 12.2k in active set on HR channels .. lchan_fsm: do not include 12.2k in active set on HR

Change in osmo-ttcn3-hacks[master]: MGCP_Test: allow setting of fmtp parameters

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13160 ) Change subject: MGCP_Test: allow setting of fmtp parameters .. MGCP_Test: allow setting of fmtp parameters When creating an RTP

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_assignment_codec_amr_f/h

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13236 ) Change subject: BSC_Tests: fix TC_assignment_codec_amr_f/h .. BSC_Tests: fix TC_assignment_codec_amr_f/h The testcase

Change in osmo-ttcn3-hacks[master]: MGCP_Test: Test AMR octet-aligned/bandwith-efficient mode conversion

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13161 ) Change subject: MGCP_Test: Test AMR octet-aligned/bandwith-efficient mode conversion .. MGCP_Test: Test AMR

Change in osmo-bsc[master]: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13092 ) Change subject: osmo_bsc_msc: Use meaningful amr rate configuration on BTS level .. osmo_bsc_msc: Use meaningful amr rate

Change in osmo-bsc[master]: codec_pref: fix special handling for AMR rate configuration (S15-S0)

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13093 ) Change subject: codec_pref: fix special handling for AMR rate configuration (S15-S0) .. codec_pref: fix special handling for AMR

Change in osmo-bsc[master]: lchan_fsm: make sure multi rate configuration is valid

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13094 ) Change subject: lchan_fsm: make sure multi rate configuration is valid .. lchan_fsm: make sure multi rate configuration is valid

Change in osmo-bsc[master]: avoid use-after-free: on MGW endpoint dealloc, also forget it in conn...

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13258 ) Change subject: avoid use-after-free: on MGW endpoint dealloc, also forget it in conn->ho.* .. Patch Set 1: Code-Review+2 -- To view,

Change in libosmocore[master]: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13259 ) Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr .. Patch Set 6: I'm sorry, but I don't really understand the

Change in osmo-ci[master]: build_deps: add libulfius-dev and libjansson-dev for osmo-remsim

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13260 ) Change subject: build_deps: add libulfius-dev and libjansson-dev for osmo-remsim .. build_deps: add libulfius-dev and libjansson-dev

Change in osmo-ci[master]: build_deps: add libulfius-dev and libjansson-dev for osmo-remsim

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13260 ) Change subject: build_deps: add libulfius-dev and libjansson-dev for osmo-remsim .. Patch Set 1: Verified+1 Code-Review+2 -- To view,

Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13067 ) Change subject: MCS: move HeaderType enum outside of class definition .. Patch Set 7: Code-Review-1 (1 comment)

Change in osmo-ttcn3-hacks[master]: msc: TC_lu_disconnect: add final delay to fix spurious failure

2019-03-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13194 ) Change subject: msc: TC_lu_disconnect: add final delay to fix spurious failure .. msc: TC_lu_disconnect: add final delay to fix

Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13057 ) Change subject: Use boolean for DL resegmentation parameter .. Patch Set 3: Code-Review-1 > > there is no downlink arq type "true" or

Change in osmo-bts[master]: pcu_sock: cast to long unsigned int before printing

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has removed a vote on this change. Change subject: pcu_sock: cast to long unsigned int before printing .. Removed Code-Review+2 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/13267 To

Change in osmo-hlr[master]: hlr.c: properly terminate the process on SIGTERM

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13313 ) Change subject: hlr.c: properly terminate the process on SIGTERM .. Patch Set 1: Yeah signalfd is nice but cannot be used for all

Change in osmo-pcu[master]: MS store: move test helper to unit test

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13213 ) Change subject: MS store: move test helper to unit test .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13213

Change in osmo-sysmon[master]: Add vty option to print output of shell cmd on every poll step

2019-03-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13304 ) Change subject: Add vty option to print output of shell cmd on every poll step .. Add vty option to print output of shell cmd on

Change in gr-gsm[master]: Fix the TCH/H decoder and demapper XML definitions

2019-03-19 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13246 ) Change subject: Fix the TCH/H decoder and demapper XML definitions .. Patch Set 2: (1 comment)

Change in osmo-pcu[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts

2019-03-19 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/13317 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts .. tests: use -no-install libtool flag to avoid ./lt-* scripts

Change in osmo-ci[master]: Add scripts/osmocom-list-commits.sh

2019-03-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13301 ) Change subject: Add scripts/osmocom-list-commits.sh .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13301 To unsubscribe,

  1   2   >