Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation .. Patch Set 4: Code-Review+1 -- To view, visit htt

Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 ) Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller .. Patch Set 1: Code-Review+1 -- T

Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l

2019-07-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log

Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l

2019-07-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build

Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l

2019-07-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log

Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l

2019-07-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Transceiver: Move soft bits normalization to

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Transceiver: Drop use of GSM::Time from trx_ul_bur

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Transceiver: Get rid of SoftVector in struct

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Transceiver: replace UDPSocket with libosmocore

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Transceiver: Move cal

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 2: +1+1=2 -- To view, visit https://gerrit.os

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 2: Code-Review+2 -- To view, visit https://ger

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 2: Code-Review+2 +1+1=+2 -- To view, vis

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Patch Set 2: Code-Review+2 +

Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector()

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 ) Change subject: Transceiver: Support pulling idle frames in pullRadioVector() .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Move initialization of var to start o...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14663 ) Change subject: Transceiver: pullRadioVector(): Move initialization of var to start of function .. Patch Set 1: Code-Review+1 -- T

Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 ) Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst .. Patch Set 1: Code-Review+1 -- To v

Change in ...osmo-trx[master]: Transceiver: Avoid noise calculation formula in 2 branches in pullRad...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14661 ) Change subject: Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector .. Patch Set 1: Code-Review+1 (1 comm

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 2: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Patch Set 2: Code-Review+1 -- To view, visit https://

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 2: Code-Review+1 (1 comment) Not critica

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 6: Code-Review-1 See my comment from previ

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 6: (1 comment) https://gerrit.osmocom.org

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 2: Code-Review+1 -- To view, visit https://ge

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Patch Set 2: Code-Review+1 -- To view, visit http

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread fixeria
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 to look at the new patch set (#6). Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Patch Set 2: Code-Review+1

Change in ...osmo-trx[master]: Transceiver: Support TRXD v1

2019-07-04 Thread pespin
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 to look at the new patch set (#9). Change subject: Transceiver: Support TRXD v1 .. Transceiver:

Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread pespin
Hello tnt, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to look at the new patch set (#4). Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation .

Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread pespin
Hello tnt, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to look at the new patch set (#3). Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation .

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling .. Patch Set 3: (1 comment) https://gerrit.osmocom.or

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 5: (5 comments) https://gerrit.osmocom.o

Change in ...osmo-trx[master]: Transceiver: Support TRXD v1

2019-07-04 Thread pespin
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 to look at the new patch set (#7). Change subject: Transceiver: Support TRXD v1 .. Transceiver:

Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation

2019-07-04 Thread pespin
Hello tnt, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to look at the new patch set (#2). Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation .

Change in ...osmo-trx[master]: Add C/I computation

2019-07-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: Add C/I computation .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To un

Change in ...osmo-trx[master]: Add C/I computation

2019-07-04 Thread pespin
Hello tnt, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to review the following change. Change subject: Add C/I computation .. Add C/I computation Change-Id: Ib4ceec553f2e5

Change in ...osmo-trx[master]: Transceiver: Support TRXD v1

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 .. Patch Set 6: (2 comments) This change is ready for review. https://gerrit.osmocom.o

Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params

2019-07-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params .. sigProcLib: detectAnyBurst() family: Use s

Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available...

2019-07-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller .. sigProcLib: detectAnyBurst(): make

Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU .. Patch Set 4: Code-Review+1 -- To view, visit https://ger

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers .. Patch Set 4: (2 comments) https://gerrit.osmocom.

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 5: Code-Review-1 (6 comments) https://ger

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs .. Patch Set 1: Code-Review+1 (1 comment) https://ger

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 ) Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support .. Patch Set 7: Code-Review+1 -- To view, visit h

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" .. tests/Makefile.am: Fix "./configure && make cle

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#

Change in ...osmo-pcap[master]: gitignore: fix application names

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14671 ) Change subject: gitignore: fix application names .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-

Change in ...osmo-pcap[master]: gitignore: fix application names

2019-07-04 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14671 Change subject: gitignore: fix application names .. gitignore: fix application names Change-Id: I4ea6b6691a0e6cfb3de0c9d2b1a0c3ed68a1

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" .. Patch Set 2: Verified+1 Code-Review+2 (1 comment) Cod

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling

2019-07-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling .. Patch Set 3: Code-Review+1 (1 comment) https://gerr

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Set Ready For Review -- To view, visit https://ger

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support .. Set Ready For Review -- To view, visit https:

Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU

2019-07-04 Thread fixeria
Hello tnt, pespin, ipse, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 to look at the new patch set (#4). Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU .

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code

2019-07-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code .. osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code This k

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs

2019-07-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs .. osmo-bts-trx/trx_if.c: properly describe TRXD messag

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers

2019-07-04 Thread fixeria
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 to look at the new patch set (#4). Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers .

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make"

2019-07-04 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 to look at the new patch set (#2). Change subject: tests/Makefile.am: Fix "./configure && make clean && make" ..

Change in ...osmo-pcap[master]: tests/Makefile.am: Fix make check

2019-07-04 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix make check .. Patch Set 1: I can not reproduce this error. The patch looks like it influences