Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-09-20 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of bu

Change in ...osmo-iuh[master]: asn1enum.pl: Make compatible with modern perl

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15588 ) Change subject: asn1enum.pl: Make compatible with modern perl .. asn1enum.pl: Make compatible with modern perl This fixes th

Change in ...osmo-iuh[master]: asn1enum.pl: Make compatible with modern perl

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15588 ) Change subject: asn1enum.pl: Make compatible with modern perl .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in ...osmo-trx[master]: Move multi-ARFCN chan amount modification from UHDDevice to parent class

2019-09-20 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15542 ) Change subject: Move multi-ARFCN chan amount modification from UHDDevice to parent class .. Move multi-ARFCN chan amount modi

Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual

2019-09-20 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. radioInterface: Mark setRxGain as virtual Otherwise the parent f

Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

2019-09-20 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15413 ) Change subject: Transceiver: Fixed copying of history into and from channelizer buffer. .. Transceiver: Fixed copying of hist

Change in ...osmo-trx[master]: radioInterface: Atomically fetch and change underrun variable

2019-09-20 Thread pespin
Hello tnt, fixeria, daniel, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/15524 to look at the new patch set (#2). Change subject: radioInterface: Atomically fetch and change underrun variable .

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-09-20 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-09-20 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of bu

Change in ...osmo-iuh[master]: asn1enum.pl: Make compatible with modern perl

2019-09-20 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15588 Change subject: asn1enum.pl: Make compatible with modern perl .. asn1enum.pl: Make compatible with modern perl This fixes the followi

Change in ...osmo-iuh[master]: hnbgw: Add libosmoctrl's VTY CTRL command initialization

2019-09-20 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15587 ) Change subject: hnbgw: Add libosmoctrl's VTY CTRL command initialization .. hnbgw: Add libosmoctrl's VTY CTRL command initiali

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce TC_ta_init_prach to test initial TA

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15410 ) Change subject: PCU_Tests_RAW.ttcn: introduce TC_ta_init_prach to test initial TA .. Patch Set 9: I like the test case, but

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add test case for UL link quality adaptation

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15526 ) Change subject: PCU_Tests_RAW.ttcn: add test case for UL link quality adaptation .. Patch Set 2: Code-Review+1 -- To view,

Change in ...osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types.ttcn: add UL Packet Resource Request

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15525 ) Change subject: library/RLCMAC_CSN1_Types.ttcn: add UL Packet Resource Request .. Patch Set 2: Code-Review+2 -- To view, vi

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_CodecPort.ttcn: strip padding bytes from PCUIF_data

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15571 ) Change subject: library/PCUIF_CodecPort.ttcn: strip padding bytes from PCUIF_data .. Patch Set 1: (1 comment) https://gerr

Change in ...osmo-iuh[master]: hnbgw: Add libosmoctrl's VTY CTRL command initialization

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15587 ) Change subject: hnbgw: Add libosmoctrl's VTY CTRL command initialization .. Patch Set 1: Code-Review+2 -- To view, visit https://ge

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15408 ) Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel closed during WAIT_CC .. Patch Set 4: Code-Revie

Change in ...osmo-iuh[master]: hnbgw: Add libosmoctrl's VTY CTRL command initialization

2019-09-20 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15587 Change subject: hnbgw: Add libosmoctrl's VTY CTRL command initialization .. hnbgw: Add libosmoctrl's VTY CTRL command initialization O

Change in ...libosmocore[master]: logging: Move extern declaration of osmo_log_target_list from logging...

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15559 ) Change subject: logging: Move extern declaration of osmo_log_target_list from logging.h to logging_internal.h .. logging:

Change in ...libosmocore[master]: logging: Move extern declaration of osmo_log_target_list from logging...

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15559 ) Change subject: logging: Move extern declaration of osmo_log_target_list from logging.h to logging_internal.h .. Patch Set 2: Cod

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 ) Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs .. Patch Set 5: Code-Review-1 I believe y

Change in ...osmo-sgsn[master]: sgsn_libgtp.c: Drop use of deprecated libgtp APIs gtp_retrans*()

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15579 ) Change subject: sgsn_libgtp.c: Drop use of deprecated libgtp APIs gtp_retrans*() .. Patch Set 1: Code-Review+1 -- To view, visit h

Change in ...osmo-sgsn[master]: Introduce TODO-RELEASE file

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15578 ) Change subject: Introduce TODO-RELEASE file .. Introduce TODO-RELEASE file It's going to be useful to track new dependency

Change in ...osmo-sgsn[master]: Introduce TODO-RELEASE file

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15578 ) Change subject: Introduce TODO-RELEASE file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn

Change in ...libosmocore[master]: osmo-release.sh: update TODO-RELEASE for non-lib projects too

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15577 ) Change subject: osmo-release.sh: update TODO-RELEASE for non-lib projects too .. Patch Set 1: Code-Review+2 -- To view, visit ht

Change in ...libosmocore[master]: osmo-release.sh: update TODO-RELEASE for non-lib projects too

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15577 ) Change subject: osmo-release.sh: update TODO-RELEASE for non-lib projects too .. osmo-release.sh: update TODO-RELEASE for

Change in ...osmo-mgw[master]: mgcp_test: Correctly release all endpoints allocated

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15580 ) Change subject: mgcp_test: Correctly release all endpoints allocated .. mgcp_test: Correctly release all endpoints allocated

Change in ...osmo-mgw[master]: mgw: Allocate mgcp_conn instance under tcfg->endpoints

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15581 ) Change subject: mgw: Allocate mgcp_conn instance under tcfg->endpoints .. mgw: Allocate mgcp_conn instance under tcfg->endpoi

Change in ...osmo-mgw[master]: mgcp_test: Correctly release all endpoints allocated

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15580 ) Change subject: mgcp_test: Correctly release all endpoints allocated .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit

Change in ...osmo-mgw[master]: mgw: Allocate mgcp_conn instance under tcfg->endpoints

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15581 ) Change subject: mgw: Allocate mgcp_conn instance under tcfg->endpoints .. Patch Set 1: Code-Review+2 -- To view, visit https://gerr

Change in ...osmo-trx[master]: radioInterface: Atomically fetch and change underrun variable

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15524 ) Change subject: radioInterface: Atomically fetch and change underrun variable .. Patch Set 1: see e.g. https://github.com/php/php-sr

Change in ...osmo-trx[master]: Move multi-ARFCN chan amount modification from UHDDevice to parent class

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15542 ) Change subject: Move multi-ARFCN chan amount modification from UHDDevice to parent class .. Patch Set 2: Code-Review+2 -- To view,

Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15413 ) Change subject: Transceiver: Fixed copying of history into and from channelizer buffer. .. Patch Set 2: Code-Review+2 -- To view,

Change in ...libosmocore[master]: vty: logging_vty_add_cmds: Enforce no parameters

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15056 ) Change subject: vty: logging_vty_add_cmds: Enforce no parameters .. Patch Set 1: Code-Review-1 same here. what if somebody wants

Change in ...libosmocore[master]: vty: logging_vty_add_cmds: Enforce no parameters

2019-09-20 Thread laforge
laforge has removed a vote on this change. Change subject: vty: logging_vty_add_cmds: Enforce no parameters .. Removed Code-Review+1 by laforge -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15056 To unsubscribe,

Change in ...libosmocore[master]: vty: osmo_stats_vty_add_cmds: Enforce no parameters

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15055 ) Change subject: vty: osmo_stats_vty_add_cmds: Enforce no parameters .. Patch Set 1: Code-Review-1 Agreeing with osmith here. I do

Change in ...libosmocore[master]: vty: logging_vty_add_cmds: Enforce no parameters

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15056 ) Change subject: vty: logging_vty_add_cmds: Enforce no parameters .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.

Change in ...libosmo-netif[master]: stream_test: Use fake time

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15575 ) Change subject: stream_test: Use fake time .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosm

Change in ...libosmo-netif[master]: stream_test: Log fake time

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15576 ) Change subject: stream_test: Log fake time .. stream_test: Log fake time It allows easy verification that timing is cor

Change in ...libosmo-netif[master]: stream_test: Use fake time

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15575 ) Change subject: stream_test: Use fake time .. stream_test: Use fake time By using fake own-controlled time we get two b

Change in ...osmo-ci[master]: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases

2019-09-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15586 ) Change subject: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases .. Patch Set 1: Verified+1 -- To view, visit htt

Change in ...libosmo-netif[master]: stream_test: Log fake time

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15576 ) Change subject: stream_test: Log fake time .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosm

Change in ...osmo-ci[master]: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases

2019-09-20 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/15586 ) Change subject: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases .. ansible: gsm-tester-rnd: Add nano3g dev

Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15574 ) Change subject: ecu_fr: increase test coverage for FR ECU implementation .. Patch Set 4: Code-Review+2 -- To view, visit https:/

Change in ...osmo-ci[master]: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases

2019-09-20 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15586 ) Change subject: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

2019-09-20 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15574 ) Change subject: ecu_fr: increase test coverage for FR ECU implementation .. ecu_fr: increase test coverage for FR ECU impl

Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

2019-09-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15574 ) Change subject: ecu_fr: increase test coverage for FR ECU implementation .. Patch Set 4: Code-Review+1 -- To view, visit https:/

Change in ...osmo-ci[master]: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases

2019-09-20 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15586 Change subject: ansible: gsm-tester-rnd: Add nano3g device to static IP DHCP leases .. ansible: gsm-tester-rnd: Add nano3g device to st

Change in ...osmo-ci[master]: gerrit, master builds: build everything in docker

2019-09-20 Thread osmith
Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/15584 to look at the new patch set (#3). Change subject: gerrit, master builds: build everything in docker .. gerrit, ma

Change in ...osmo-ci[master]: gerrit, master builds: add docker_{run, img} vars

2019-09-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15582 ) Change subject: gerrit, master builds: add docker_{run,img} vars .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmoc

Change in ...osmo-ci[master]: gerrit, master builds: make all jobs concurrent

2019-09-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15585 ) Change subject: gerrit, master builds: make all jobs concurrent .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmoco

Change in ...osmo-ci[master]: gerrit, master builds: build everything in docker

2019-09-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15584 ) Change subject: gerrit, master builds: build everything in docker .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmo

Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

2019-09-20 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15574 ) Change subject: ecu_fr: increase test coverage for FR ECU implementation .. Patch Set 4: (1 comment) I was not aware that any app

Change in ...osmo-ci[master]: gerrit, master builds: add docker_{run, img} vars

2019-09-20 Thread osmith
Hello pespin, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/15582 to look at the new patch set (#2). Change subject: gerrit, master builds: add docker_{run,img} vars ..

Change in ...osmo-ci[master]: gerrit, master builds: add docker_{run, img} vars

2019-09-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15582 ) Change subject: gerrit, master builds: add docker_{run,img} vars .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmoc

Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

2019-09-20 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15574 ) Change subject: ecu_fr: increase test coverage for FR ECU implementation .. Patch Set 4: Code-Review+1 -- To view, visit https://

Change in ...osmo-ci[master]: gerrit, master builds: add docker_{run, img} vars

2019-09-20 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15582 ) Change subject: gerrit, master builds: add docker_{run,img} vars .. Patch Set 1: Verified+1 * Verified, that all affected projects sti

Change in ...osmo-ci[master]: gerrit, master builds: use stretch, not jessie

2019-09-20 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15583 ) Change subject: gerrit, master builds: use stretch, not jessie .. Patch Set 1: Setting to WIP, because I need to verify/fix up all pro

Change in ...osmo-ci[master]: gerrit, master builds: build everything in docker

2019-09-20 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15584 Change subject: gerrit, master builds: build everything in docker .. gerrit, master builds: build everything in docker Instead of build

Change in ...osmo-ci[master]: gerrit, master builds: make all jobs concurrent

2019-09-20 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15585 Change subject: gerrit, master builds: make all jobs concurrent .. gerrit, master builds: make all jobs concurrent Now that everything

Change in ...osmo-ci[master]: gerrit, master builds: add docker_{run, img} vars

2019-09-20 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15582 Change subject: gerrit, master builds: add docker_{run,img} vars .. gerrit, master builds: add docker_{run,img} vars Move the common "d

Change in ...osmo-ci[master]: gerrit, master builds: use stretch, not jessie

2019-09-20 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15583 Change subject: gerrit, master builds: use stretch, not jessie .. gerrit, master builds: use stretch, not jessie Debian jessie (8) is E

Change in ...libosmocore[master]: ecu_fr: increase test coverage for FR ECU implementation

2019-09-20 Thread dexter
Hello pespin, fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15574 to look at the new patch set (#4). Change subject: ecu_fr: increase test coverage for FR ECU implementation .

Change in ...libosmocore[master]: cosmetic: Add comment on GSM-FR ECU struct

2019-09-20 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15573 ) Change subject: cosmetic: Add comment on GSM-FR ECU struct .. cosmetic: Add comment on GSM-FR ECU struct Change-Id: Ic0a3a

Change in ...libosmocore[master]: cosmetic: Move comment to the right place

2019-09-20 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15572 ) Change subject: cosmetic: Move comment to the right place .. cosmetic: Move comment to the right place Change-Id: I3d548fc