Change in osmo-bsc[master]: Fix some typos

2019-11-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16066 ) Change subject: Fix some typos .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-bsc[master]: Fix some typos

2019-11-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16066 ) Change subject: Fix some typos .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16066 To

Change in osmo-bsc[master]: Fix some typos

2019-11-13 Thread roox
roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16066 ) Change subject: Fix some typos .. Fix some typos Fix typos and common misspellings in code comments and in the manual. Change-Id:

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-13 Thread neels
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 to look at the new patch set (#3). Change subject: msc: overhaul voice call testing ..

Change in docker-playground[master]: ttcn3-stp-tests: laforge/stp has been merged master; use master

2019-11-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16065 ) Change subject: ttcn3-stp-tests: laforge/stp has been merged master; use master .. Patch Set 1: Thanks, good catch! -- To

Change in docker-playground[master]: ttcn3-stp-tests: laforge/stp has been merged master; use master

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16065 ) Change subject: ttcn3-stp-tests: laforge/stp has been merged master; use master .. ttcn3-stp-tests: laforge/stp has been merged

Change in docker-playground[master]: ttcn3-stp-tests: laforge/stp has been merged master; use master

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16065 ) Change subject: ttcn3-stp-tests: laforge/stp has been merged master; use master .. Patch Set 1: Verified+1 Code-Review+2

Change in docker-playground[master]: ttcn3-stp-tests: laforge/stp has been merged master; use master

2019-11-13 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/16065 ) Change subject: ttcn3-stp-tests: laforge/stp has been merged master; use master .. ttcn3-stp-tests: laforge/stp has been

Change in docker-playground[master]: ttcn3-stp/Makefile: Drop defaulting to branch laforge/stp

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16046 ) Change subject: ttcn3-stp/Makefile: Drop defaulting to branch laforge/stp .. ttcn3-stp/Makefile: Drop defaulting to branch

Change in docker-playground[master]: ttcn3-stp/Makefile: Drop defaulting to branch laforge/stp

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16046 ) Change subject: ttcn3-stp/Makefile: Drop defaulting to branch laforge/stp .. Patch Set 1: Verified+1 Code-Review+2 -- To

Change in osmo-ttcn3-hacks[master]: stp: Introduce TC_tmt_override

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16043 ) Change subject: stp: Introduce TC_tmt_override .. stp: Introduce TC_tmt_override Change-Id: Id99ec3eaa431512114817d2a2af77013762ab2b9

Change in osmo-ttcn3-hacks[master]: stp: Introduce traffic mode type tests with unknwon dynamic ASPs

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16045 ) Change subject: stp: Introduce traffic mode type tests with unknwon dynamic ASPs .. stp: Introduce traffic mode type tests with

Change in osmo-ttcn3-hacks[master]: stp: Introduce TC_tmt_override

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16043 ) Change subject: stp: Introduce TC_tmt_override .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: stp: Refactor STP_Tests_IPA tests and introduce new TC_tmt_loadshare

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16042 ) Change subject: stp: Refactor STP_Tests_IPA tests and introduce new TC_tmt_loadshare .. stp: Refactor STP_Tests_IPA tests and

Change in osmo-ttcn3-hacks[master]: stp: Move logic to create unknwon dynamic ASP to f_connect_ipa()

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16044 ) Change subject: stp: Move logic to create unknwon dynamic ASP to f_connect_ipa() .. stp: Move logic to create unknwon dynamic ASP to

Change in osmo-ttcn3-hacks[master]: stp: Refactor STP_Tests_IPA tests and introduce new TC_tmt_loadshare

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16042 ) Change subject: stp: Refactor STP_Tests_IPA tests and introduce new TC_tmt_loadshare .. Patch Set 1: Code-Review+2 -- To

Change in docker-playground[master]: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16064 ) Change subject: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file .. Patch Set 1: Code-Review+1 --

Change in docker-playground[master]: Update osmo-*/Dockerfile to log stdout+stderr of process to log file

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16063 ) Change subject: Update osmo-*/Dockerfile to log stdout+stderr of process to log file .. Patch Set 1: Code-Review+1 -- To

Change in osmo-ttcn3-hacks[master]: HACK: make IPA_Emulation work as IPA client to OsmoSTP

2019-11-13 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15821 ) Change subject: HACK: make IPA_Emulation work as IPA client to OsmoSTP .. Abandoned no longer needed -- To view, visit

Change in osmo-ccid-firmware[master]: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16057 ) Change subject: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files .. Patch Set 2: Verified+1 --

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Proper Makefile targets

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16056 ) Change subject: sysmoOCTSIM: Proper Makefile targets .. sysmoOCTSIM: Proper Makefile targets It's really bad practsie to generate

Change in osmo-ccid-firmware[master]: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16057 ) Change subject: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files .. Makefile: Add 'make mrproper' for

Change in osmo-ccid-firmware[master]: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16057 ) Change subject: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files .. Patch Set 1: Code-Review+2

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Proper Makefile targets

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16056 ) Change subject: sysmoOCTSIM: Proper Makefile targets .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: ccid_device: Fix memory leaks in ccid_handle_out() error paths

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16035 ) Change subject: ccid_device: Fix memory leaks in ccid_handle_out() error paths .. ccid_device: Fix memory leaks in ccid_handle_out()

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Proper Makefile targets

2019-11-13 Thread laforge
Hello Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16056 to look at the new patch set (#2). Change subject: sysmoOCTSIM: Proper Makefile targets

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Create symlinks of last-built .bin and .elf

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16039 ) Change subject: sysmoOCTSIM: Create symlinks of last-built .bin and .elf .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: main: Add missing #include to osmocom/timer.h

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16036 ) Change subject: main: Add missing #include to osmocom/timer.h .. main: Add missing #include to osmocom/timer.h Change-Id:

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Create symlinks of last-built .bin and .elf

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16039 ) Change subject: sysmoOCTSIM: Create symlinks of last-built .bin and .elf .. sysmoOCTSIM: Create symlinks of last-built .bin and .elf

Change in osmo-ccid-firmware[master]: Add 'check_ccid_config.py' to test for USB VID/PID in libccid_Info.plist

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16050 ) Change subject: Add 'check_ccid_config.py' to test for USB VID/PID in libccid_Info.plist .. Add 'check_ccid_config.py' to test for

Change in osmo-ccid-firmware[master]: Avoid endless loop while printing debug uart ringbuffer

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16055 ) Change subject: Avoid endless loop while printing debug uart ringbuffer .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: Avoid endless loop while printing debug uart ringbuffer

2019-11-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16055 ) Change subject: Avoid endless loop while printing debug uart ringbuffer .. Avoid endless loop while printing debug uart ringbuffer

Change in osmo-ccid-firmware[master]: Add 'check_ccid_config.py' to test for USB VID/PID in libccid_Info.plist

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16050 ) Change subject: Add 'check_ccid_config.py' to test for USB VID/PID in libccid_Info.plist .. Patch Set 2: Code-Review+2

Change in osmo-ccid-firmware[master]: ccid_device: Fix memory leaks in ccid_handle_out() error paths

2019-11-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16035 ) Change subject: ccid_device: Fix memory leaks in ccid_handle_out() error paths .. Patch Set 2: Code-Review+2 -- To view,

Change in docker-playground[master]: Update osmo-*/Dockerfile to log stdout+stderr of process to log file

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/16063 ) Change subject: Update osmo-*/Dockerfile to log stdout+stderr of process to log file .. Update osmo-*/Dockerfile to log

Change in osmo-ccid-firmware[master]: Avoid endless loop while printing debug uart ringbuffer

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16055 ) Change subject: Avoid endless loop while printing debug uart ringbuffer .. Patch Set 1: Code-Review+1 -- To view,

Change in osmo-ccid-firmware[master]: main: Add missing #include to osmocom/timer.h

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16036 ) Change subject: main: Add missing #include to osmocom/timer.h .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16057 ) Change subject: Makefile: Add 'make mrproper' for removing all bin/elf/etc output files .. Patch Set 1: Code-Review+1

Change in osmo-ccid-firmware[master]: ccid_device: Fix memory leaks in ccid_handle_out() error paths

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16035 ) Change subject: ccid_device: Fix memory leaks in ccid_handle_out() error paths .. Patch Set 2: Code-Review+1 -- To

Change in osmo-ccid-firmware[master]: Add 'check_ccid_config.py' to test for USB VID/PID in libccid_Info.plist

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16050 ) Change subject: Add 'check_ccid_config.py' to test for USB VID/PID in libccid_Info.plist .. Patch Set 2: Code-Review+1

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Create symlinks of last-built .bin and .elf

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16039 ) Change subject: sysmoOCTSIM: Create symlinks of last-built .bin and .elf .. Patch Set 2: Code-Review+1 -- To view,

Change in docker-playground[master]: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/16064 ) Change subject: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file .. Update ttcn3-*/jenkins.sh to log

Change in osmo-ccid-firmware[master]: sysmoOCTSIM: Proper Makefile targets

2019-11-13 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16056 ) Change subject: sysmoOCTSIM: Proper Makefile targets .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: overhaul voice call testing

2019-11-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 ) Change subject: msc: overhaul voice call testing .. Patch Set 2: (1 comment)

Change in libosmocore[master]: utils.h: add OSMO_NAME_C_IMPL() macro

2019-11-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15957 ) Change subject: utils.h: add OSMO_NAME_C_IMPL() macro .. Patch Set 7: (1 comment)

Change in libosmocore[master]: utils.h: add OSMO_NAME_C_IMPL() macro

2019-11-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15957 ) Change subject: utils.h: add OSMO_NAME_C_IMPL() macro .. Patch Set 7: (1 comment)

Change in libosmocore[master]: osmo_sockaddr_str: fix 32bit addr mixup of host/network byte order

2019-11-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16030 ) Change subject: osmo_sockaddr_str: fix 32bit addr mixup of host/network byte order .. Patch Set 2: (1 comment)

Change in osmo-ttcn3-hacks[master]: stp: Refactor STP_Tests_IPA tests and introduce new TC_tmt_loadshare

2019-11-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16042 ) Change subject: stp: Refactor STP_Tests_IPA tests and introduce new TC_tmt_loadshare .. Patch Set 1: > Patch Set 1:

Change in osmo-bts[master]: Unify common and bts-trx power control loop VTY command

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16058 ) Change subject: Unify common and bts-trx power control loop VTY command .. Unify common and bts-trx power control loop VTY command

Change in osmo-bts[master]: rsl: Remove unneeded duplicate reset on some lchan fields

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16061 ) Change subject: rsl: Remove unneeded duplicate reset on some lchan fields .. rsl: Remove unneeded duplicate reset on some lchan

Change in osmo-bts[master]: Change gsm_bts_trx field to bool and rename it

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16059 ) Change subject: Change gsm_bts_trx field to bool and rename it .. Change gsm_bts_trx field to bool and rename it Thies field is

Change in osmo-bts[master]: Change gsm_lchan field fixed to bool

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16060 ) Change subject: Change gsm_lchan field fixed to bool .. Change gsm_lchan field fixed to bool Change-Id:

Change in osmo-bts[master]: Move and rename gsm_lchan.ms_power field

2019-11-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16062 ) Change subject: Move and rename gsm_lchan.ms_power field .. Move and rename gsm_lchan.ms_power field Make it clear that it contains