Change in osmo-msc[master]: libmsc/gsm_04_08: use DRR in gsm48_rx_rr_pag_resp(), not DMM

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17016 ) Change subject: libmsc/gsm_04_08: use DRR in gsm48_rx_rr_pag_resp(), not DMM .. libmsc/gsm_04_08: use DRR in gsm48_rx_rr_pag_resp(), not DMM

Change in osmo-msc[master]: libmsc/gsm_04_08: make use of msc_a in gsm48_rx_rr_app_info()

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17015 ) Change subject: libmsc/gsm_04_08: make use of msc_a in gsm48_rx_rr_app_info() .. libmsc/gsm_04_08: make use of msc_a in gsm48_rx_rr_app_info()

Change in osmo-msc[master]: vlr_sgs_fsm: add missing break, do not call to_null() twice

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17012 ) Change subject: vlr_sgs_fsm: add missing break, do not call to_null() twice .. vlr_sgs_fsm: add missing break, do not call to_null() twice

Change in osmo-bts[master]: osmo-bts-sysmo/Makefile.am: fix: do not overwrite bin_PROGRAMS

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16974 ) Change subject: osmo-bts-sysmo/Makefile.am: fix: do not overwrite bin_PROGRAMS .. osmo-bts-sysmo/Makefile.am: fix: do not overwrite

Change in osmo-msc[master]: VTY: cosmetic: make struct cmd_node for GSMNET_NODE static

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17014 ) Change subject: VTY: cosmetic: make struct cmd_node for GSMNET_NODE static .. VTY: cosmetic: make struct cmd_node for GSMNET_NODE static We

Change in osmo-msc[master]: msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name()

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17013 ) Change subject: msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name() .. msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name()

Change in osmo-msc[master]: vlr: remove unused parameter 'log_level' of auth_fsm_start()

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17011 ) Change subject: vlr: remove unused parameter 'log_level' of auth_fsm_start() .. vlr: remove unused parameter 'log_level' of auth_fsm_start()

Change in osmo-msc[master]: vlr: remove unused parameter 'log_level' of auth_fsm_start()

2020-01-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17011 ) Change subject: vlr: remove unused parameter 'log_level' of auth_fsm_start() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: tdef_vty: do not enforce enum 'node_type' in osmo_tdef_vty_groups_init()

2020-01-27 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17017 ) Change subject: tdef_vty: do not enforce enum 'node_type' in osmo_tdef_vty_groups_init() .. Patch Set 2: > Patch Set 2: > > is

Change in osmo-msc[master]: libmsc/gsm_04_11.h: remove unused sms_deliver definition

2020-01-27 Thread fixeria
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/17023 to look at the new patch set (#2). Change subject: libmsc/gsm_04_11.h: remove unused sms_deliver definition

Change in osmo-pcu[master]: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame'

2020-01-27 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17007 ) Change subject: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame' .. Patch Set 1: > Patch Set 1: > > What about

Change in osmo-pcu[master]: tests/alloc: fix implicit conversion from 'double' to 'int8_t'

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17009 ) Change subject: tests/alloc: fix implicit conversion from 'double' to 'int8_t' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: encoding: fix log_alert_exit(): do not treat error as format string

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17008 ) Change subject: encoding: fix log_alert_exit(): do not treat error as format string .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-pcu[master]: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame'

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17007 ) Change subject: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame' .. Patch Set 1: What about using

Change in osmo-pcu[master]: gsm_timer: fix comparison of constant LONG_MAX with an integer

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17006 ) Change subject: gsm_timer: fix comparison of constant LONG_MAX with an integer .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc/gsm_04_11.h: remove unused sms_deliver definition

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17023 ) Change subject: libmsc/gsm_04_11.h: remove unused sms_deliver definition .. Patch Set 1: I think clearly that's not aimed at storing

Change in osmo-msc[master]: libmsc/gsm_04_11.h: remove unused sms_deliver definition

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17023 ) Change subject: libmsc/gsm_04_11.h: remove unused sms_deliver definition .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: tdef_vty: do not enforce enum 'node_type' in osmo_tdef_vty_groups_init()

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17017 ) Change subject: tdef_vty: do not enforce enum 'node_type' in osmo_tdef_vty_groups_init() .. Patch Set 2: is that ebcause

Change in osmo-msc[master]: msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name()

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17013 ) Change subject: msc/sccp_ran.h: fix: do not pass -1 to osmo_rat_type_name() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc/gsm_04_08: make use of msc_a in gsm48_rx_rr_app_info()

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17015 ) Change subject: libmsc/gsm_04_08: make use of msc_a in gsm48_rx_rr_app_info() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc/gsm_04_08: use DRR in gsm48_rx_rr_pag_resp(), not DMM

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17016 ) Change subject: libmsc/gsm_04_08: use DRR in gsm48_rx_rr_pag_resp(), not DMM .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: VTY: cosmetic: make struct cmd_node for GSMNET_NODE static

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17014 ) Change subject: VTY: cosmetic: make struct cmd_node for GSMNET_NODE static .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: vlr: remove unused parameter 'log_level' of auth_fsm_start()

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17011 ) Change subject: vlr: remove unused parameter 'log_level' of auth_fsm_start() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: vlr_sgs_fsm: add missing break, do not call to_null() twice

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17012 ) Change subject: vlr_sgs_fsm: add missing break, do not call to_null() twice .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: Merge branch 'dfurt'

2020-01-27 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17028 ) Change subject: Merge branch 'dfurt' .. Merge branch 'dfurt' Change-Id: I96d03994d3990d8ca95be02116070509fe672d9f ---

Change in osmo-ccid-firmware[laforge/dfurt]: support DFU detach to switch from fw to bootloader

2020-01-27 Thread Hoernchen
Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17027 ) Change subject: support DFU detach to switch from fw to bootloader .. support DFU detach to switch from fw to bootloader This

Change in osmo-ccid-firmware[laforge/dfurt]: support DFU detach to switch from fw to bootloader

2020-01-27 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17027 ) Change subject: support DFU detach to switch from fw to bootloader .. support DFU detach to switch from fw to

Change in osmo-asf4-dfu[master]: usb serial number descriptor

2020-01-27 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/17024 ) Change subject: usb serial number descriptor .. usb serial number descriptor Change-Id:

Change in osmo-msc[master]: libmsc/gsm_04_11.h: remove unused sms_deliver definition

2020-01-27 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/17023 ) Change subject: libmsc/gsm_04_11.h: remove unused sms_deliver definition .. libmsc/gsm_04_11.h: remove unused sms_deliver

Change in osmo-msc[master]: libmsc: move subscriber expiration timer T3212 to libvlr

2020-01-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16934 ) Change subject: libmsc: move subscriber expiration timer T3212 to libvlr .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc: move subscriber expiration timer T3212 to libvlr

2020-01-27 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16934 ) Change subject: libmsc: move subscriber expiration timer T3212 to libvlr .. libmsc: move subscriber expiration timer T3212 to libvlr Since

Change in osmo-msc[master]: VTY: add osmo_tdef introspection and configuration commands

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16932 ) Change subject: VTY: add osmo_tdef introspection and configuration commands .. VTY: add osmo_tdef introspection and configuration commands

Change in osmo-msc[master]: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

2020-01-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16933 ) Change subject: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270 .. libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

Change in osmo-ci[master]: Fix ansible playbooks after docker directory was removed here

2020-01-27 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17022 ) Change subject: Fix ansible playbooks after docker directory was removed here .. Fix ansible playbooks after docker directory was removed here

Change in osmo-ci[master]: Fix ansible playbooks after docker directory was removed here

2020-01-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17022 ) Change subject: Fix ansible playbooks after docker directory was removed here .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc: move subscriber expiration timer T3212 to libvlr

2020-01-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16934 ) Change subject: libmsc: move subscriber expiration timer T3212 to libvlr .. Patch Set 5: Code-Review+1 -- To view, visit