Change in osmo-pcu[master]: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame'

2020-01-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17007 ) Change subject: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame' .. gprs_bssgp_pcu: fix invalid use of non-static data

Change in osmo-pcu[master]: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame'

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17007 ) Change subject: gprs_bssgp_pcu: fix invalid use of non-static data member 'frame' .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: fix srcdir to reflect $abs_srcdir

2020-01-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16990 ) Change subject: fix srcdir to reflect $abs_srcdir .. fix srcdir to reflect $abs_srcdir When building .adoc files, we pass a srcdir

Change in osmo-gsm-manuals[master]: fix srcdir to reflect $abs_srcdir

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/16990 ) Change subject: fix srcdir to reflect $abs_srcdir .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: mdns_rfc.c: fix possible access of uninit. mem

2020-01-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16846 ) Change subject: mdns_rfc.c: fix possible access of uninit. mem .. mdns_rfc.c: fix possible access of uninit. mem Fixes: CID#207548 Change-Id:

Change in osmo-hlr[master]: mdns_rfc.c: fix possible access of uninit. mem

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16846 ) Change subject: mdns_rfc.c: fix possible access of uninit. mem .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: Implement serial number string descriptor in CTRL EP callback

2020-01-31 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16521 ) Change subject: Implement serial number string descriptor in CTRL EP callback .. Abandoned -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: add TC_MSLookup_mDNS_service_GSUP_HLR_home

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17073 ) Change subject: hlr: add TC_MSLookup_mDNS_service_GSUP_HLR_home .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: add TC_MSLookup_mDNS_service_other_proxy

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17075 ) Change subject: hlr: add TC_MSLookup_mDNS_service_other_proxy .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: add TC_MSLookup_mDNS_service_GSUP_HLR_proxy

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17074 ) Change subject: hlr: add TC_MSLookup_mDNS_service_GSUP_HLR_proxy .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-tester[master]: contrib: Add scripts to build srsLTE software

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17067 ) Change subject: contrib: Add scripts to build srsLTE software .. Patch Set 1: (1 comment)

Change in osmo-gsm-tester[master]: Introduce RemoteHost and refactor code to use it

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17065 ) Change subject: Introduce RemoteHost and refactor code to use it .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ci[master]: Install srsLTE build dependencies in jenkins buildhosts

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17069 ) Change subject: Install srsLTE build dependencies in jenkins buildhosts .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: jobs: Introduce osmo-gsm-tester_build-srslte

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17068 ) Change subject: jobs: Introduce osmo-gsm-tester_build-srslte .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: ansible: mdbus2 is not nowadays available on Debian10

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17070 ) Change subject: ansible: mdbus2 is not nowadays available on Debian10 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: ansible: gsm-tester: Install srsLTE dependencies

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17066 ) Change subject: ansible: gsm-tester: Install srsLTE dependencies .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: dfu: proper product name for dfu runtime descriptor

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17056 ) Change subject: dfu: proper product name for dfu runtime descriptor .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: usb dfu header cleanup

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17037 ) Change subject: usb dfu header cleanup .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: git version appended to the product usb string descriptor

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17035 ) Change subject: git version appended to the product usb string descriptor .. Patch Set 3: Code-Review+2 (1 comment)

Change in osmo-ccid-firmware[master]: WIP: Add DFU runtime descriptor

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17033 ) Change subject: WIP: Add DFU runtime descriptor .. Patch Set 2: Code-Review+1 Is this still WIP or should it be reviewed

Change in osmo-ccid-firmware[master]: Implement serial number string descriptor in CTRL EP callback

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17055 ) Change subject: Implement serial number string descriptor in CTRL EP callback .. Patch Set 1: Code-Review+2 -- To view,

Change in pysim[master]: Fixed update_hplmn_act method

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16945 ) Change subject: Fixed update_hplmn_act method .. Patch Set 7: Code-Review+1 -- To view, visit

Change in pysim[master]: Support for MSISDN programming

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16946 ) Change subject: Support for MSISDN programming .. Patch Set 6: Code-Review+1 (1 comment)

Change in pysim[master]: Fixed MCC and MCC representation in the output of pySim-read

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16944 ) Change subject: Fixed MCC and MCC representation in the output of pySim-read .. Patch Set 6: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: gsm_rlcmac.cpp: fix another global-buffer-overflow error reported by ...

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17053 ) Change subject: gsm_rlcmac.cpp: fix another global-buffer-overflow error reported by ASAN .. Patch Set 1: Code-Review+2 -- To

Change in osmo-pcu[master]: gsm_rlcmac: Update : PACKET RESOURCE REQUEST to Release 14.0.0

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17051 ) Change subject: gsm_rlcmac: Update : PACKET RESOURCE REQUEST to Release 14.0.0 .. Patch Set 1: Code-Review+1 (2 comments)

Change in osmo-pcu[master]: gsm_rlcmac.cpp: fix global-buffer-overflow error reported by ASAN

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17052 ) Change subject: gsm_rlcmac.cpp: fix global-buffer-overflow error reported by ASAN .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: add TC_MSLookup_GSUP_proxy

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17064 ) Change subject: hlr: add TC_MSLookup_GSUP_proxy .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: library/DNS_Helpers: add f_enc_IPv4

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17063 ) Change subject: library/DNS_Helpers: add f_enc_IPv4 .. Patch Set 2: Code-Review+1 (1 comment)

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types: add dest name to some messages

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17062 ) Change subject: library/GSUP_Types: add dest name to some messages .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: add emulated GSUP server (second HLR)

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17061 ) Change subject: hlr: add emulated GSUP server (second HLR) .. Patch Set 2: Code-Review+1 (1 comment)

Change in pysim[master]: Fix file permission

2020-01-31 Thread herlesupreeth
herlesupreeth has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/16942 ) Change subject: Fix file permission .. Fix file permission Change-Id: I893869329e9547e06386baf4d16a18e545042d62 --- M pySim-read.py 1 file

Change in pysim[master]: Added feature to program SPN into sysmoUSIM-SJS1 SIM cards

2020-01-31 Thread herlesupreeth
herlesupreeth has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/16941 ) Change subject: Added feature to program SPN into sysmoUSIM-SJS1 SIM cards .. Added feature to program SPN into sysmoUSIM-SJS1 SIM cards

Change in osmo-ttcn3-hacks[master]: hlr: add TC_MSLookup_mDNS_service_other_home

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16914 ) Change subject: hlr: add TC_MSLookup_mDNS_service_other_home .. Patch Set 10: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: deps: set titan.TestPorts.UDPasp_commit

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17060 ) Change subject: deps: set titan.TestPorts.UDPasp_commit .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: adoc: add D-GSM chapter to osmohlr-usermanual

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16211 ) Change subject: adoc: add D-GSM chapter to osmohlr-usermanual .. Patch Set 36: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: gsup_server: send routing error back to the correct peer

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16336 ) Change subject: gsup_server: send routing error back to the correct peer .. Patch Set 14: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: db v5: prep for D-GSM: add vlr_via_proxy and sgsn_via_proxy

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16207 ) Change subject: db v5: prep for D-GSM: add vlr_via_proxy and sgsn_via_proxy .. Patch Set 28: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: drop error log for when a subscriber does not exist

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16212 ) Change subject: drop error log for when a subscriber does not exist .. Patch Set 36: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: gsup client: add up_down_cb(), add osmo_gsup_client_create3()

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16206 ) Change subject: gsup client: add up_down_cb(), add osmo_gsup_client_create3() .. Patch Set 28: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: vty: show subscriber: change format of 'last LU seen'

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15359 ) Change subject: vty: show subscriber: change format of 'last LU seen' .. Patch Set 26: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: auc3g: officially wrap IND around IND_bitlen space

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16763 ) Change subject: auc3g: officially wrap IND around IND_bitlen space .. Patch Set 10: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: esme_dgsm.py: add --always-fail option for debugging SMPP

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16793 ) Change subject: esme_dgsm.py: add --always-fail option for debugging SMPP .. Patch Set 7: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: gsup_client.c: fix deprecation for client create func

2020-01-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/17057 ) Change subject: gsup_client.c: fix deprecation for client create func .. gsup_client.c: fix deprecation for client create func Change-Id:

Change in simtrace2[master]: cardem: disable upload for simtrace2

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/17079 ) Change subject: cardem: disable upload for simtrace2 .. Patch Set 1: I also deleted all the existing simtrace-cardem-* on

Change in libosmocore[master]: pcsc: don't leak memory

2020-01-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17058 ) Change subject: pcsc: don't leak memory .. pcsc: don't leak memory Change-Id: I183882ff2eae82754d55189b154863fad9cce4aa --- M

Change in libosmocore[master]: pcsc: don't leak memory

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17058 ) Change subject: pcsc: don't leak memory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: cardem: disable upload for simtrace2

2020-01-31 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/17079 ) Change subject: cardem: disable upload for simtrace2 .. cardem: disable upload for simtrace2 cardem on the st2 has been broken forever and

Change in osmo-sgsn[master]: gprs_gmm_fsm.c: Implement RAT change between 2g and 3g

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 ) Change subject: gprs_gmm_fsm.c: Implement RAT change between 2g and 3g .. Patch Set 12: Code-Review+1 -- To view, visit

Change in simtrace2[master]: cardem: disable upload for simtrace2

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/17079 ) Change subject: cardem: disable upload for simtrace2 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: gprs_gmm: Check for RAT change and ensure this only happens for RAU/ATT

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/17081 ) Change subject: gprs_gmm: Check for RAT change and ensure this only happens for RAU/ATT .. Patch Set 1: Code-Review+1 -- To

Change in pysim[master]: Fix file permission

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16942 ) Change subject: Fix file permission .. Patch Set 4: there may have been a permission problem. if you have time, please re-try if it's

Change in osmo-sgsn[master]: mm_state_gb_fsm: Handle implicit detach from mm_standby

2020-01-31 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/17080 ) Change subject: mm_state_gb_fsm: Handle implicit detach from mm_standby .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: mm_state_gb_fsm: Handle implicit detach from mm_standby

2020-01-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/17080 ) Change subject: mm_state_gb_fsm: Handle implicit detach from mm_standby .. Patch Set 1: > Patch Set 1: > > Can you add a more

Change in libosmocore[master]: pcsc: don't leak memory

2020-01-31 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17058 ) Change subject: pcsc: don't leak memory .. Patch Set 1: > Hoernchen would like fixeria to review this change. Sorry, I am not

Change in pysim[master]: Fixed reading of MSISDN parameter

2020-01-31 Thread herlesupreeth
herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16947 ) Change subject: Fixed reading of MSISDN parameter .. Patch Set 15: (2 comments) I will address those comments in the next patch