Change in osmocom-bb[master]: virt_phy: tweak log levels

2020-05-14 Thread osmith
Hello laforge, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/18266 to review the following change. Change subject: virt_phy: tweak log levels .. virt_phy: tweak log levels Relat

Change in osmo-bts[master]: osmo-bts-virtual/scheduler: log unknown GSMTAP chan

2020-05-14 Thread osmith
Hello laforge, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/18267 to review the following change. Change subject: osmo-bts-virtual/scheduler: log unknown GSMTAP chan .. osmo-bts-v

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18245 ) Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. Patch Set 4: Code-Review+2 -- To view, visit https://gerri

Change in libosmocore[master]: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen()

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18245 ) Change subject: libosmogsm: add Doxygen docs for gsm0502_hop_seq_gen() .. Patch Set 4: (1 comment) This change is ready for revi

Change in libosmocore[master]: libosmogsm: import hopping sequence generation code

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18244 ) Change subject: libosmogsm: import hopping sequence generation code .. Patch Set 4: This change is ready for review. -- To view

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_countdown_procedure

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18260 ) Change subject: pcu: Introduce test TC_countdown_procedure .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.o

Change in osmo-ttcn3-hacks[master]: pcu: f_tx_rlcmac_ul_n_blocks(): Keep BSN state and return all payload...

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18259 ) Change subject: pcu: f_tx_rlcmac_ul_n_blocks(): Keep BSN state and return all payload sent .. Patch Set 1: Code-Review+1 (2

Change in osmo-ttcn3-hacks[master]: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258 ) Change subject: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks .. Patch Set 1: Code-Review+2 -- To view, visit https://gerri

Change in osmo-ttcn3-hacks[master]: Introduce test TC_force_two_phase_access

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18254 ) Change subject: Introduce test TC_force_two_phase_access .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osm

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 4: Code-Review+1 -- To view, visit htt

Change in osmo-ttcn3-hacks[master]: pcu: Support decoding Egprs Pkt Ul Ass on PDCH

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18252 ) Change subject: pcu: Support decoding Egprs Pkt Ul Ass on PDCH .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osm

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18265 ) Change subject: amr: Fix OA<->BWE conversion. .. Patch Set 5: Code-Review+1 I reverted the previous version of this patch because

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread ipse
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/18265 to look at the new patch set (#5). Change subject: amr: Fix OA<->BWE conversion. .. amr: Fix OA<->B

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread ipse
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/18265 to look at the new patch set (#3). Change subject: amr: Fix OA<->BWE conversion. .. amr: Fix OA<->B

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread neels
neels has uploaded a new patch set (#4) to the change originally created by ipse. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18265 ) Change subject: amr: Fix OA<->BWE conversion. .. amr: Fix OA<->BWE conversion. Size of a s

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18265 ) Change subject: amr: Fix OA<->BWE conversion. .. amr: Fix OA<->BWE conversion. Size of a single AMR frame doesn't always shrink b

Change in libosmo-netif[master]: Revert "amr: Fix OA<->BWE conversion."

2020-05-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18264 ) Change subject: Revert "amr: Fix OA<->BWE conversion." .. Patch Set 1: Code-Review+2 self +2 to fix the current master build --

Change in libosmo-netif[master]: Revert "amr: Fix OA<->BWE conversion."

2020-05-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18264 ) Change subject: Revert "amr: Fix OA<->BWE conversion." .. Revert "amr: Fix OA<->BWE conversion." This reverts commit 002a51e2180cf19bf5e11e

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread neels
neels has created a revert of this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/17997 ) Change subject: amr: Fix OA<->BWE conversion. .. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/17997 To unsubscrib

Change in libosmo-netif[master]: Revert "amr: Fix OA<->BWE conversion."

2020-05-14 Thread neels
Hello dexter, pespin, ipse, laforge, Jenkins Builder, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/18264 to review the following change. Change subject: Revert "amr: Fix OA<->BWE conversion." ...

Change in osmo-bsc[master]: bsc_vty: Coding style fix - brackets around a complex if/else

2020-05-14 Thread ipse
ipse has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18263 ) Change subject: bsc_vty: Coding style fix - brackets around a complex if/else .. bsc_vty: Coding style fix - brackets around a complex if/else Ch

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-14 Thread ipse
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18192 to look at the new patch set (#7). Change subject: stats: Add counters and gauges for BORKEN lchans/TS ..

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-14 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc

Change in osmo-bsc[master]: bsc_vty: Coding style fix - brackets around a complex if/else

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18263 ) Change subject: bsc_vty: Coding style fix - brackets around a complex if/else .. Patch Set 2: Code-Review+2 -- To view, visit https:

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/osmo-b

Change in osmocom-bb[master]: trx_toolkit/gsm_shared.py: implement hopping sequence generation

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18261 ) Change subject: trx_toolkit/gsm_shared.py: implement hopping sequence generation .. Patch Set 1: Code-Review+1 -- To view, visit h

Change in libosmocore[master]: struct_endianess.py: also recognise unnamed substructs

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18256 ) Change subject: struct_endianess.py: also recognise unnamed substructs .. Patch Set 1: Code-Review+1 -- To view, visit https://ge

Change in libosmocore[master]: add missing endian.h in gsm_23_041.h

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18255 ) Change subject: add missing endian.h in gsm_23_041.h .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-14 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 ) Change subject: stats: Add counters and gauges for BORKEN lchans/TS .. Patch Set 4: (3 comments) This change is ready for review. htt

Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

2020-05-14 Thread ipse
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18192 to look at the new patch set (#5). Change subject: stats: Add counters and gauges for BORKEN lchans/TS ..

Change in osmo-bsc[master]: bsc_vty: Coding style fix - brackets around a complex if/else

2020-05-14 Thread ipse
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18263 ) Change subject: bsc_vty: Coding style fix - brackets around a complex if/else .. bsc_vty: Coding style fix - brackets around a complex

Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add frequency hopping support

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18262 ) Change subject: trx_toolkit/transceiver.py: add frequency hopping support .. Patch Set 1: Let's keep it WIP for now. I need to cha

Change in osmocom-bb[master]: trx_toolkit/gsm_shared.py: implement hopping sequence generation

2020-05-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18261 ) Change subject: trx_toolkit/gsm_shared.py: implement hopping sequence generation .. trx_toolkit/gsm_shared.py: implement hopping s

Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add frequency hopping support

2020-05-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18262 ) Change subject: trx_toolkit/transceiver.py: add frequency hopping support .. trx_toolkit/transceiver.py: add frequency hopping sup

Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

2020-05-14 Thread ipse
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18231 to look at the new patch set (#2). Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding. ..

Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

2020-05-14 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 ) Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding. .. Patch Set 1: (5 comments) https://ge

Change in osmo-ttcn3-hacks[master]: Move some types from GSM_RR_Types.ttcn to RLCMAC_CSN1_Types.ttcn

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18251 ) Change subject: Move some types from GSM_RR_Types.ttcn to RLCMAC_CSN1_Types.ttcn .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_countdown_procedure

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18260 ) Change subject: pcu: Introduce test TC_countdown_procedure .. pcu: Introduce test TC_countdown_procedure Change-Id: I2b92bf4

Change in osmo-ttcn3-hacks[master]: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258 ) Change subject: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks .. pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks Also incremen

Change in osmo-ttcn3-hacks[master]: pcu: f_tx_rlcmac_ul_n_blocks(): Keep BSN state and return all payload...

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18259 ) Change subject: pcu: f_tx_rlcmac_ul_n_blocks(): Keep BSN state and return all payload sent .. pcu: f_tx_rlcmac_ul_n_blocks()

Change in libosmocore[master]: cosmetic: apply changes to match struct_endianess.py output

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18257 ) Change subject: cosmetic: apply changes to match struct_endianess.py output .. Patch Set 1: Code-Review+1 -- To view, visit https://

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. codec: Add functions for AMR s->d bits and d->s bits These function

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. Patch Set 4: Code-Review+2 -- To view, visit https://ger

Change in osmo-ttcn3-hacks[master]: Introduce test TC_force_two_phase_access

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18254 ) Change subject: Introduce test TC_force_two_phase_access .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osm

Change in osmo-ttcn3-hacks[master]: pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs_only

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18253 ) Change subject: pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs_only .. Patch Set 1: Code-Review+1 -- To view, visit htt

Change in osmo-ttcn3-hacks[master]: Move some types from GSM_RR_Types.ttcn to RLCMAC_CSN1_Types.ttcn

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18251 ) Change subject: Move some types from GSM_RR_Types.ttcn to RLCMAC_CSN1_Types.ttcn .. Patch Set 1: Code-Review+1 -- To view,

Change in osmo-ttcn3-hacks[master]: pcu: Support decoding Egprs Pkt Ul Ass on PDCH

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18252 ) Change subject: pcu: Support decoding Egprs Pkt Ul Ass on PDCH .. Patch Set 1: Code-Review+1 -- To view, visit https://gerr

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 4: Code-Review+1 -- To view, visit htt

Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 ) Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) .. Patch Set 4: Code-Review+2 -- To view, visit htt

Change in libosmo-abis[master]: trau_frame: Fix AMR frame decoding

2020-05-14 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18182 ) Change subject: trau_frame: Fix AMR frame decoding .. trau_frame: Fix AMR frame decoding Change-Id: I9b2dbca05217ee78cade2a47a02857f7cf7e0

Change in libosmo-abis[master]: trau_frame: Add 16k HR + OAM encoding/decoding; add AMR encoding

2020-05-14 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18181 ) Change subject: trau_frame: Add 16k HR + OAM encoding/decoding; add AMR encoding .. Abandoned let's not add thsi to the old code, but to

Change in libosmocore[master]: cosmetic: apply changes to match struct_endianess.py output

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18257 ) Change subject: cosmetic: apply changes to match struct_endianess.py output .. Patch Set 1: Code-Review+1 -- To view, visit http

Change in libosmo-abis[master]: trau_frame: Fix AMR frame decoding

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18182 ) Change subject: trau_frame: Fix AMR frame decoding .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in libosmocore[master]: cosmetic: apply changes to match struct_endianess.py output

2020-05-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18257 ) Change subject: cosmetic: apply changes to match struct_endianess.py output .. cosmetic: apply changes to match struct_endianess.py

Change in libosmocore[master]: add missing endian.h in gsm_23_041.h

2020-05-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18255 ) Change subject: add missing endian.h in gsm_23_041.h .. add missing endian.h in gsm_23_041.h Change-Id: I593cc5e8272469b570559206b

Change in libosmocore[master]: struct_endianess.py: also recognise unnamed substructs

2020-05-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18256 ) Change subject: struct_endianess.py: also recognise unnamed substructs .. struct_endianess.py: also recognise unnamed substructs B

Change in libosmo-abis[master]: trau_frame: Fix AMR frame decoding

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18182 ) Change subject: trau_frame: Fix AMR frame decoding .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/lib

Change in osmo-ttcn3-hacks[master]: Introduce test TC_force_two_phase_access

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18254 ) Change subject: Introduce test TC_force_two_phase_access .. Introduce test TC_force_two_phase_access Change-Id: Icce25b5d113

Change in osmo-ttcn3-hacks[master]: pcu: Support decoding Egprs Pkt Ul Ass on PDCH

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18252 ) Change subject: pcu: Support decoding Egprs Pkt Ul Ass on PDCH .. pcu: Support decoding Egprs Pkt Ul Ass on PDCH Change-Id:

Change in osmo-ttcn3-hacks[master]: pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs_only

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18253 ) Change subject: pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs_only .. pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs

Change in osmo-ttcn3-hacks[master]: Move some types from GSM_RR_Types.ttcn to RLCMAC_CSN1_Types.ttcn

2020-05-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18251 ) Change subject: Move some types from GSM_RR_Types.ttcn to RLCMAC_CSN1_Types.ttcn .. Move some types from GSM_RR_Types.ttcn to

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 4: (1 comment) https://gerrit.osmocom.o

Change in osmo-bsc[master]: manual: fix config example typo 'msc-addr'

2020-05-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18241 ) Change subject: manual: fix config example typo 'msc-addr' .. manual: fix config example typo 'msc-addr' Change-Id: Ifb84d7ceddc772e3e1ae59c8d58

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18246 to look at the new patch set (#4). Change subject: codec: Add functions for AMR s->d bits and d->s bits ..

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18246 to look at the new patch set (#3). Change subject: codec: Add functions for AMR s->d bits and d->s bits ..

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/17997 ) Change subject: amr: Fix OA<->BWE conversion. .. amr: Fix OA<->BWE conversion. Size of a single AMR frame doesn't always shrink by a byte

Change in libosmo-netif[master]: amr: Fix OA<->BWE conversion.

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/17997 ) Change subject: amr: Fix OA<->BWE conversion. .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/lib

Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 ) Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) .. Patch Set 4: Code-Review+1 (1 comment) https://

Change in libosmo-abis[master]: trau_frame: Add 16k HR + OAM encoding/decoding; add AMR encoding

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18181 ) Change subject: trau_frame: Add 16k HR + OAM encoding/decoding; add AMR encoding .. Patch Set 2: Code-Review-1 Actually I'm not

Change in libosmo-abis[master]: WIP: Add new TRAU frame sync code

2020-05-14 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18250 ) Change subject: WIP: Add new TRAU frame sync code .. WIP: Add new TRAU frame sync code This code is able to detect and sync aga

Change in libosmo-abis[master]: WIP: unixsocket: Add support for TRAU frames

2020-05-14 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18248 ) Change subject: WIP: unixsocket: Add support for TRAU frames .. WIP: unixsocket: Add support for TRAU frames Change-Id: I4baa02

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 to look at the new patch set (#4). Change subject: pcu: use correct RA type to properly test 2phase access .

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 to look at the new patch set (#3). Change subject: pcu: use correct RA type to properly test 2phase access .

Change in osmo-pcu[master]: Drop unneeded arg 'ta' in tbf_alloc_ul()

2020-05-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() .. Drop unneeded arg 'ta' in tbf_alloc_ul() The function is simply setting the ta on t

Change in osmo-pcu[master]: bts: Drop specific functions to add values to stats

2020-05-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18228 ) Change subject: bts: Drop specific functions to add values to stats .. bts: Drop specific functions to add values to stats Change-Id: I877a9c9a

Change in osmo-pcu[master]: bts: Drop specific functions to increase counters

2020-05-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18226 ) Change subject: bts: Drop specific functions to increase counters .. bts: Drop specific functions to increase counters It's super annoying seei

Change in osmo-pcu[master]: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used...

2020-05-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18223 ) Change subject: pdch: rcv_resource_request(): Clarify tbf_free only needed if MS used to exist beforehand .. pdch: rcv_resource_request(): Clar

Change in osmo-pcu[master]: bts: Drop specific functions to add values to counters

2020-05-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18227 ) Change subject: bts: Drop specific functions to add values to counters .. bts: Drop specific functions to add values to counters It's super ann

Change in osmo-pcu[master]: Drop unneeded arg 'ta' in tbf_alloc_ul()

2020-05-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/libos

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18246 to look at the new patch set (#2). Change subject: codec: Add functions for AMR s->d bits and d->s bits ..

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-14 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18247 to look at the new patch set (#4). Change subject: Implement ITU-T I.460 multiplex / demultiplex .. I

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-14 Thread laforge
laforge has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Implement ITU-T I.460 multiplex / demultiplex This implements a mu

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-14 Thread laforge
laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Implement ITU-T I.460 multiplex / demultiplex This implements a mu

Change in libosmocore[master]: Implement ITU-T I.460 multiplex / demultiplex

2020-05-14 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18247 ) Change subject: Implement ITU-T I.460 multiplex / demultiplex .. Implement ITU-T I.460 multiplex / demultiplex This implements a

Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

2020-05-14 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 ) Change subject: codec: Add functions for AMR s->d bits and d->s bits .. codec: Add functions for AMR s->d bits and d->s bits The

Change in libosmocore[master]: libosmogsm: cosmetic: add spaces before and after PRIu32

2020-05-14 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18243 ) Change subject: libosmogsm: cosmetic: add spaces before and after PRIu32 .. libosmogsm: cosmetic: add spaces before and after PRIu32 As was

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 2: (1 comment) https://gerrit.osmocom.

Change in libosmocore[master]: libosmogsm: cosmetic: add spaces before and after PRIu32

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18243 ) Change subject: libosmogsm: cosmetic: add spaces before and after PRIu32 .. Patch Set 3: Code-Review+2 -- To view, visit https:/

Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 ) Change subject: pcu: use correct RA type to properly test 2phase access .. Patch Set 2: Code-Review+1 -- To view, visit htt

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-14 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .. gsm0808_utils: Add gsm0808_get_ciph

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-14 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .. Patch Set 3: Code-Review+

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-14 Thread laforge
laforge has uploaded a new patch set (#3) to the change originally created by ipse. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. ..

Change in libosmocore[master]: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a depr...

2020-05-14 Thread laforge
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18242 ) Change subject: gsm0808_utils: Add gsm0808_get_cipher_reject_cause() back with a deprecation notice. .. Removed Code-Review-2 b