Change in osmo-ccid-firmware[master]: add script to generate a inititial osmo-bankd slotconfig sorted by us...

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/25062 ) Change subject: add script to generate a inititial osmo-bankd slotconfig sorted by usb path .. Patch Set 3: Code-Review+1

Change in osmo-ccid-firmware[master]: add script to generate a inititial osmo-bankd slotconfig sorted by us...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/25062 to look at the new patch set (#3). Change subject: add script to generate a inititial osmo-bankd slotconfig sorted by usb path

Change in osmo-ccid-firmware[master]: add script to generate a inititial osmo-bankd slotconfig sorted by us...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/25062 to look at the new patch set (#2). Change subject: add script to generate a inititial osmo-bankd slotconfig sorted by usb path

Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Simplify tbf::set_polling()

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25111 ) Change subject: Simplify tbf::set_polling() .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Simplify tbf::set_polling()

Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25111 to look at the new patch set (#3). Change subject: Simplify tbf::set_polling() .. Simplify

Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25108 to look at the new patch set (#5). Change subject: Move tbf ul_ack_state to osmocom FSM .. Move tbf

Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 4: (2 comments)

Change in simtrace2[master]: contrib: more cardem dissection

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25086 ) Change subject: contrib: more cardem dissection .. Patch Set 7: (1 comment)

Change in simtrace2[master]: firmware: make the ngff beakout blink ..but only if the cardem sim is...

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25083 ) Change subject: firmware: make the ngff beakout blink ..but only if the cardem sim is active .. Patch Set 8: Code-Review+1 (1

Change in simtrace2[master]: introduce support for new ngff_cardem board

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25082 ) Change subject: introduce support for new ngff_cardem board .. Patch Set 7: Code-Review+1 new board is still not mentioned in

Change in osmo-pcu[master]: fix typo 's/dowlink/downlink/g'

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25113 ) Change subject: fix typo 's/dowlink/downlink/g' .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: tbf: Move T3193 to tbf_state FSM

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25112 ) Change subject: tbf: Move T3193 to tbf_state FSM .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Simplify tbf::set_polling()

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25111 ) Change subject: Simplify tbf::set_polling() .. Patch Set 2: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: Move tbf ul_ack_state to osmocom FSM

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25108 ) Change subject: Move tbf ul_ack_state to osmocom FSM .. Patch Set 4: (3 comments)

Change in osmo-pcu[master]: Move timer X2002 to tbf_fsm

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25104 ) Change subject: Move timer X2002 to tbf_fsm .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: tbf_dl: Clarify requirements for DL ACK/NACK

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25105 ) Change subject: tbf_dl: Clarify requirements for DL ACK/NACK .. Patch Set 2: It's true that it could be split into 2 different

Change in osmo-pcu[master]: tbf.h: Improve documentation on several flags

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25106 ) Change subject: tbf.h: Improve documentation on several flags .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move timer X2002 to tbf_fsm

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25104 to look at the new patch set (#2). Change subject: Move timer X2002 to tbf_fsm .. Move timer X2002 to

Change in osmo-pcu[master]: tbf_dl: Clarify requirements for DL ACK/NACK

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25105 ) Change subject: tbf_dl: Clarify requirements for DL ACK/NACK .. Patch Set 1: Code-Review+1 (2 comments) just some nitpicks

Change in osmo-pcu[master]: Move timer X2002 to tbf_fsm

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25104 ) Change subject: Move timer X2002 to tbf_fsm .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: fix typo 's/dowlink/downlink/g'

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25113 ) Change subject: fix typo 's/dowlink/downlink/g' .. fix typo 's/dowlink/downlink/g' Change-Id:

Change in osmo-pcu[master]: Move timer X2002 to tbf_fsm

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25104 ) Change subject: Move timer X2002 to tbf_fsm .. Patch Set 1: Code-Review-1 (3 comments)

Change in osmo-pcu[master]: Move timer X2002 to tbf_fsm

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25104 ) Change subject: Move timer X2002 to tbf_fsm .. Patch Set 1: (3 comments)

Change in osmo-msc[master]: add vlr_subscr_find_by_mi

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25075 ) Change subject: add vlr_subscr_find_by_mi .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: Clarify string name for GSM_CHREQ_REASON_CALL

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25096 ) Change subject: Clarify string name for GSM_CHREQ_REASON_CALL .. Clarify string name for GSM_CHREQ_REASON_CALL The previous naming was

Change in osmo-pcu[master]: tbf: Move T3193 to tbf_state FSM

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25112 ) Change subject: tbf: Move T3193 to tbf_state FSM .. tbf: Move T3193 to tbf_state FSM Related: OS#2709 Change-Id:

Change in simtrace2[master]: firmware: make the ngff beakout blink ..but only if the cardem sim is...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25083 to look at the new patch set (#6). Change subject: firmware: make the ngff beakout blink ..but only if the cardem sim is active

Change in simtrace2[master]: firmware: make the ngff beakout blink ..but only if the cardem sim is...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25083 to look at the new patch set (#5). Change subject: firmware: make the ngff beakout blink ..but only if the cardem sim is active

Change in osmo-bsc[master]: Clarify string name for GSM_CHREQ_REASON_CALL

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25096 ) Change subject: Clarify string name for GSM_CHREQ_REASON_CALL .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: contrib: more cardem dissection

Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25086 to look at the new patch set (#5). Change subject: contrib: more cardem dissection .. contrib:

Change in simtrace2[master]: introduce support for new ngff_cardem board

Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25082 to look at the new patch set (#5). Change subject: introduce support for new ngff_cardem board

Change in simtrace2[master]: Introduce simtrace2-tool

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24574 ) Change subject: Introduce simtrace2-tool .. Patch Set 4: I didn't test it, but I've looked at the function, and it does claim

Change in osmo-pcu[master]: tbf: Use type bool for upgrade_to_multislot

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25102 ) Change subject: tbf: Use type bool for upgrade_to_multislot .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: Clarify string name for GSM_CHREQ_REASON_CALL

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25096 ) Change subject: Clarify string name for GSM_CHREQ_REASON_CALL .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Simplify tbf::set_polling()

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25111 ) Change subject: Simplify tbf::set_polling() .. Simplify tbf::set_polling() When setting a POLL, it will always happen on PACCH, so

Change in simtrace2[master]: gitreview: new file

osmith has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25110 ) Change subject: gitreview: new file .. gitreview: new file Change-Id: I650fe7c930392d24042e65295fa49400478ffab9 --- A .gitreview 1 file

Change in simtrace2[master]: gitreview: new file

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25110 ) Change subject: gitreview: new file .. Patch Set 1: Code-Review+2 trivial, we have this in other repos too -- To view, visit

Change in osmo-msc[master]: implement CM Re-Establish for voice calls

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 ) Change subject: implement CM Re-Establish for voice calls .. Patch Set 5: Code-Review+1 -- To view, visit

Change in simtrace2[master]: gitreview: new file

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25110 ) Change subject: gitreview: new file .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25110

Change in osmo-msc[master]: implement CM Re-Establish for voice calls

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 ) Change subject: implement CM Re-Establish for voice calls .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: allow another reject cause in TC_cm_reest_req_reject

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25109 ) Change subject: msc: allow another reject cause in TC_cm_reest_req_reject .. Patch Set 1: Code-Review+1 -- To view, visit

Change in simtrace2[master]: contrib: more cardem dissection

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25086 ) Change subject: contrib: more cardem dissection .. Patch Set 4: Code-Review+1 (2 comments)

Change in simtrace2[master]: simtrace2-cardem: use local sim on exit

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25084 ) Change subject: simtrace2-cardem: use local sim on exit .. Patch Set 4: Code-Review+1 -- To view, visit

Change in simtrace2[master]: firmware: make the ngff beakout blink

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25083 ) Change subject: firmware: make the ngff beakout blink .. Patch Set 4: (3 comments)

Change in simtrace2[master]: firmware: proper makefile deps

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25081 ) Change subject: firmware: proper makefile deps .. Patch Set 4: Code-Review+1 -- To view, visit

Change in simtrace2[master]: firmware: data sections

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25080 ) Change subject: firmware: data sections .. Patch Set 4: Code-Review+1 -- To view, visit

Change in simtrace2[master]: introduce support for new ngff_cardem board

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25082 ) Change subject: introduce support for new ngff_cardem board .. Patch Set 4: (5 comments) the code is very readable! only found

Change in simtrace2[master]: gitreview: new file

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/25110 ) Change subject: gitreview: new file .. gitreview: new file Change-Id: I650fe7c930392d24042e65295fa49400478ffab9 --- A .gitreview 1

Change in simtrace2[master]: Introduce simtrace2-tool

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24574 ) Change subject: Introduce simtrace2-tool .. Patch Set 4: Code-Review+1 (1 comment)

Change in osmo-ci[master]: lint: ignore LONG_LINE

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25107 ) Change subject: lint: ignore LONG_LINE .. lint: ignore LONG_LINE With recent code reviews I've realized that in Osmocom we do often use more

Change in osmo-ci[master]: lint: exclude kdf, milenage for libosmocore

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24962 ) Change subject: lint: exclude kdf, milenage for libosmocore .. lint: exclude kdf, milenage for libosmocore Imported code that doesn't follow

Change in osmo-ci[master]: lint: checkpatch.pl: no spaces required for tdef

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24961 ) Change subject: lint: checkpatch.pl: no spaces required for tdef .. lint: checkpatch.pl: no spaces required for tdef Don't require spaces

Change in osmo-ci[master]: lint: ignore LONG_LINE

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25107 ) Change subject: lint: ignore LONG_LINE .. Patch Set 2: Verified+1 Code-Review+2 (1 comment)

Change in osmo-ci[master]: lint: ignore LONG_LINE

Hello neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/25107 to look at the new patch set (#2). Change subject: lint: ignore LONG_LINE .. lint: ignore LONG_LINE With

Change in osmo-ci[master]: lint: exclude kdf, milenage for libosmocore

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24962 ) Change subject: lint: exclude kdf, milenage for libosmocore .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit

Change in osmo-ci[master]: lint: checkpatch.pl: no spaces required for tdef

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/24961 ) Change subject: lint: checkpatch.pl: no spaces required for tdef .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit