Change in libosmocore[master]: gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NS...

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25151 to look at the new patch set (#2). Change subject: gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are present

Change in libosmocore[master]: gprs_ns2: improve reselection protection

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25150 to look at the new patch set (#2). Change subject: gprs_ns2: improve reselection protection

Change in libosmocore[master]: gprs_ns2: add correct filename/linenr to sns failed log message

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25149 to look at the new patch set (#2). Change subject: gprs_ns2: add correct filename/linenr to sns failed log message

Change in libosmocore[master]: gprs_ns2: calculate the nse->*_sums before notifing the sns fsm

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25148 to look at the new patch set (#2). Change subject: gprs_ns2: calculate the nse->*_sums before notifing the sns fsm

Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS DEL procedures

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, pespin, daniel, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24591 to look at the new patch set (#6). Change subject: gprs_ns2_sns: implement outbound SNS DEL procedures

Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS ADD procedures

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24123 to look at the new patch set (#9). Change subject: gprs_ns2_sns: implement outbound SNS ADD procedures

Change in libosmocore[master]: gprs_ns2_sns: implement local change weight procedure

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/23187 to look at the new patch set (#12). Change subject: gprs_ns2_sns: implement local change weight procedure

Change in libosmocore[master]: gprs_ns2: dont use llist_for_each when freeing an element

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25147 to look at the new patch set (#2). Change subject: gprs_ns2: dont use llist_for_each when freeing an element

Change in libosmocore[master]: gprs_ns2: use an event to free the nsvscs when using SNS

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25146 to look at the new patch set (#2). Change subject: gprs_ns2: use an event to free the nsvscs when using SNS

Change in libosmocore[master]: gprs_ns2_sns: rework sns clean up

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25145 to look at the new patch set (#2). Change subject: gprs_ns2_sns: rework sns clean up ..

Change in libosmocore[master]: gprs_ns2: move sns_event into internal.h to direct emit events

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25144 to look at the new patch set (#2). Change subject: gprs_ns2: move sns_event into internal.h to direct emit events

Change in libosmocore[master]: gprs_ns2: add recursive anchor to protect against double free

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25143 to look at the new patch set (#2). Change subject: gprs_ns2: add recursive anchor to protect against double free

Change in libosmocore[master]: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24650 to look at the new patch set (#5). Change subject: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid

Change in libosmocore[master]: gprs_ns2_sns: refactor SNS failures into a function

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/24649 to look at the new patch set (#4). Change subject: gprs_ns2_sns: refactor SNS failures into a function

Change in libosmocore[master]: gprs_ns2_udp: don't start the NSVC fsm for SNS

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25142 to look at the new patch set (#2). Change subject: gprs_ns2_udp: don't start the NSVC fsm for SNS

Change in libosmocore[master]: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid

2021-08-11 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24650 ) Change subject: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid .. Patch Set 4: (1 comment)

Change in osmo-ttcn3-hacks[master]: ns2: rename TC_sns_config_success -> TC_sns_bss_config_success

2021-08-11 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25137 ) Change subject: ns2: rename TC_sns_config_success -> TC_sns_bss_config_success .. ns2: rename TC_sns_config_success ->

Change in osmo-ttcn3-hacks[master]: ns2: add a dummy test case TC_idle() for manual test cases

2021-08-11 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25136 ) Change subject: ns2: add a dummy test case TC_idle() for manual test cases .. ns2: add a dummy test case TC_idle() for manual

Change in osmo-ttcn3-hacks[master]: ns2: add test case to call force unconfigured after SNS Size received

2021-08-11 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25135 ) Change subject: ns2: add test case to call force unconfigured after SNS Size received .. ns2: add test case to call force

Change in osmo-ttcn3-hacks[master]: fr/fr-net: use correct DLCI range for test cases

2021-08-11 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25134 ) Change subject: fr/fr-net: use correct DLCI range for test cases .. fr/fr-net: use correct DLCI range for test cases DLCIs are

Change in osmo-ttcn3-hacks[master]: ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN role

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25140 to look at the new patch set (#3). Change subject: ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN role

Change in osmo-ttcn3-hacks[master]: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141 to look at the new patch set (#3). Change subject: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken

Change in osmo-ttcn3-hacks[master]: ns2: introduce module parameter SnsRole

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138 to look at the new patch set (#2). Change subject: ns2: introduce module parameter SnsRole ..

Change in osmo-ttcn3-hacks[master]: ns2: add first sgsn test case TC_sns_sgsn_config_success

2021-08-11 Thread lynxis lazus
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25139 to look at the new patch set (#2). Change subject: ns2: add first sgsn test case TC_sns_sgsn_config_success

Change in osmo-ttcn3-hacks[master]: ns2: introduce module parameter SnsSide

2021-08-11 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138 ) Change subject: ns2: introduce module parameter SnsSide .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25155 ) Change subject: Add counters: pcu.bts.N.pch.requests.timeout .. Add counters: pcu.bts.N.pch.requests.timeout Implement T3113 for paging over

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25155 ) Change subject: Add counters: pcu.bts.N.pch.requests.timeout .. Patch Set 4: Code-Review+2 re-applying 1+1=2 after adding author

Change in osmo-ci[master]: repo-install-test: osmo-pcap-server: !latest

2021-08-11 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25181 ) Change subject: repo-install-test: osmo-pcap-server: !latest .. repo-install-test: osmo-pcap-server: !latest Disable osmo-pcap-server for

Change in osmo-ci[master]: repo-install-test: osmo-pcap-server: !latest

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25181 ) Change subject: repo-install-test: osmo-pcap-server: !latest .. Patch Set 1: Verified+1 Code-Review+2 Trivial, merging now so the

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread osmith
Hello Jenkins Builder, Hoernchen, daniel, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25155 to look at the new patch set (#4). Change subject: Add counters: pcu.bts.N.pch.requests.timeout

Change in simtrace2[master]: contrib: allow manually forcing bulk simtrace dissection

2021-08-11 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25178 ) Change subject: contrib: allow manually forcing bulk simtrace dissection .. Patch Set 1: It was just useless because the pid/vid

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25155 ) Change subject: Add counters: pcu.bts.N.pch.requests.timeout .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 ) Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25120 ) Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling .. Patch Set 12: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

2021-08-11 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25120 ) Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling .. Patch Set 12: (1 comment)

Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

2021-08-11 Thread dexter
Hello osmith, Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25120 to look at the new patch set (#12). Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

2021-08-11 Thread dexter
Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123 to look at the new patch set (#4). Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc

Change in osmo-bsc[master]: error log: improve lchan lookup error msg

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25167 ) Change subject: error log: improve lchan lookup error msg .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: early IMM ASS 3/n: implement 'pre-ts-ack'

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25166 ) Change subject: early IMM ASS 3/n: implement 'pre-ts-ack' .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: early IMM ASS 2/n: implement 'pre-chan-ack'

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25165 ) Change subject: early IMM ASS 2/n: implement 'pre-chan-ack' .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: early IMM ASS 1/n: add vty config option

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25164 ) Change subject: early IMM ASS 1/n: add vty config option .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: introduce gsm48_lchan_and_pchan2chan_desc()

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25163 ) Change subject: introduce gsm48_lchan_and_pchan2chan_desc() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: lchan_fsm_post_activ_ack(): return upon release

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25162 ) Change subject: lchan_fsm_post_activ_ack(): return upon release .. Patch Set 1: Code-Review+1 -- To view, visit

Change in simtrace2[master]: contrib: allow manually forcing bulk simtrace dissection

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25178 ) Change subject: contrib: allow manually forcing bulk simtrace dissection .. Patch Set 1: Code-Review+1 LGTM. Why was it disabled

Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

2021-08-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25182 ) Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf() .. Patch Set 2: Code-Review+1 Patch looks sane to me. Maybe

Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

2021-08-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25182 ) Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf() .. Patch Set 2: Code-Review+1 I'm a bit hesitant to merge