Change in osmo-pcu[master]: coverity: fix null deref from recent UL TBF leak fix

2021-08-19 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25203 ) Change subject: coverity: fix null deref from recent UL TBF leak fix .. coverity: fix null deref from recent UL TBF leak fix Fix a possible NU

Change in osmo-bts[master]: early IMM ASS: add configurable delay for RR IMM ASS

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 ) Change subject: early IMM ASS: add configurable delay for RR IMM ASS .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit

Change in osmo-bts[master]: add osmo_tdef groups, exposing T timers on VTY config

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25200 ) Change subject: add osmo_tdef groups, exposing T timers on VTY config .. Patch Set 3: Code-Review+2 -- To view, visit https://gerri

Change in osmo-bts[master]: add VTY transcript testing

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25198 ) Change subject: add VTY transcript testing .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/

Change in osmo-bsc[master]: doc: Improve ACC ramp documentation

2021-08-19 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25087 ) Change subject: doc: Improve ACC ramp documentation .. doc: Improve ACC ramp documentation Commit below added support for ACC ramping based on

Change in osmo-bsc[master]: doc: Improve ACC ramp documentation

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25087 ) Change subject: doc: Improve ACC ramp documentation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/os

Change in osmo-ttcn3-hacks[master]: MGCP_Test: do not use module parameter mp_test_ip (statsd)

2021-08-19 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 ) Change subject: MGCP_Test: do not use module parameter mp_test_ip (statsd) .. MGCP_Test: do not use module parameter mp_test_ip (statsd

Change in osmo-ttcn3-hacks[master]: MGCP_Test: do not use module parameter mp_test_ip (statsd)

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 ) Change subject: MGCP_Test: do not use module parameter mp_test_ip (statsd) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add control interface to MGW testsuite

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820 ) Change subject: MGCP_Test: add control interface to MGW testsuite .. Patch Set 4: Code-Review+2 -- To view, visit https://g

Change in libosmocore[master]: tests/stats: show how last item sent may be wrong

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25205 ) Change subject: tests/stats: show how last item sent may be wrong .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit

Change in osmo-mgw[master]: mgcp_client_vty: cosmetic: doc string should terminated with \n

2021-08-19 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25210 ) Change subject: mgcp_client_vty: cosmetic: doc string should terminated with \n .. mgcp_client_vty: cosmetic: doc string should terminated with

Change in osmo-mgw[master]: mgcp_client_vty: add OSMO_ASSERT on pool parameter

2021-08-19 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25208 ) Change subject: mgcp_client_vty: add OSMO_ASSERT on pool parameter .. mgcp_client_vty: add OSMO_ASSERT on pool parameter When the function mgc

Change in osmo-mgw[master]: mgcp_client_vty: fix docstrings for mgw-pool

2021-08-19 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25209 ) Change subject: mgcp_client_vty: fix docstrings for mgw-pool .. mgcp_client_vty: fix docstrings for mgw-pool The interactive VTY commands to r

Change in osmo-mgw[master]: mgcp_client_vty: cosmetic: doc string should terminated with \n

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25210 ) Change subject: mgcp_client_vty: cosmetic: doc string should terminated with \n .. Patch Set 1: Code-Review+2 -- To view, visit htt

Change in osmo-mgw[master]: mgcp_client_vty: fix docstrings for mgw-pool

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25209 ) Change subject: mgcp_client_vty: fix docstrings for mgw-pool .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom

Change in osmo-mgw[master]: mgcp_client_vty: add OSMO_ASSERT on pool parameter

2021-08-19 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25208 ) Change subject: mgcp_client_vty: add OSMO_ASSERT on pool parameter .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.o

Change in osmo-mgw[master]: mgcp_client_vty: cosmetic: doc string should terminated with \n

2021-08-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25210 ) Change subject: mgcp_client_vty: cosmetic: doc string should terminated with \n .. mgcp_client_vty: cosmetic: doc string should termi

Change in osmo-mgw[master]: mgcp_client_vty: fix docstrings for mgw-pool

2021-08-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25209 ) Change subject: mgcp_client_vty: fix docstrings for mgw-pool .. mgcp_client_vty: fix docstrings for mgw-pool The interactive VTY com

Change in osmo-mgw[master]: mgcp_client_vty: add OSMO_ASSERT on pool parameter

2021-08-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25208 ) Change subject: mgcp_client_vty: add OSMO_ASSERT on pool parameter .. mgcp_client_vty: add OSMO_ASSERT on pool parameter When the fu

Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

2021-08-19 Thread dexter
Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123 to look at the new patch set (#7). Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc ..

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add control interface to MGW testsuite

2021-08-19 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820 ) Change subject: MGCP_Test: add control interface to MGW testsuite .. Patch Set 4: Code-Review+1 -- To view, visit https://ge

Change in osmo-ttcn3-hacks[master]: MGCP_Test: do not use module parameter mp_test_ip (statsd)

2021-08-19 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 ) Change subject: MGCP_Test: do not use module parameter mp_test_ip (statsd) .. Patch Set 1: Code-Review+1 -- To view, visit h

Change in libosmocore[master]: tests: add 'make update_exp' target

2021-08-19 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25207 ) Change subject: tests: add 'make update_exp' target .. Patch Set 1: > Patch Set 1: Code-Review+1 > > looks like something that is

Change in libosmocore[master]: tests: add 'make update_exp' target

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25207 ) Change subject: tests: add 'make update_exp' target .. Patch Set 1: Code-Review+1 looks like something that is easy to forget to u

Change in osmo-bts[master]: jenkins: enable new flag --enable-external-tests

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25199 ) Change subject: jenkins: enable new flag --enable-external-tests .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmo

Change in libosmocore[master]: tests: add 'make update_exp' target

2021-08-19 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25207 ) Change subject: tests: add 'make update_exp' target .. tests: add 'make update_exp' target Add convenience target to update the t

Change in libosmocore[master]: stats: send real last value if no new values come

2021-08-19 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25206 to look at the new patch set (#2). Change subject: stats: send real last value if no new values come .

Change in libosmocore[master]: tests/stats: show how last item sent may be wrong

2021-08-19 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25205 to look at the new patch set (#2). Change subject: tests/stats: show how last item sent may be wrong .

Change in osmo-bts[master]: add osmo_tdef groups, exposing T timers on VTY config

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25200 ) Change subject: add osmo_tdef groups, exposing T timers on VTY config .. Patch Set 3: Code-Review+1 looks good to me. Reminds me a bi

Change in libosmocore[master]: stats: send real last value if no new values come

2021-08-19 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25206 ) Change subject: stats: send real last value if no new values come .. stats: send real last value if no new values come Fixes: OS#

Change in libosmocore[master]: tests/stats: show how last item sent may be wrong

2021-08-19 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25205 ) Change subject: tests/stats: show how last item sent may be wrong .. tests/stats: show how last item sent may be wrong Extend the

Change in osmo-pcu[master]: coverity: fix null deref from recent UL TBF leak fix

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25203 ) Change subject: coverity: fix null deref from recent UL TBF leak fix .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.

Change in osmo-bts[master]: add VTY transcript testing

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25198 ) Change subject: add VTY transcript testing .. Patch Set 3: Verified+1 Code-Review+1 (1 comment) I think this is a good Idea. Maybe a

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add control interface to MGW testsuite

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820 ) Change subject: MGCP_Test: add control interface to MGW testsuite .. Patch Set 4: Thanks for reviewing this. I have fixed it

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add control interface to MGW testsuite

2021-08-19 Thread dexter
Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24820 to look at the new patch set (#4). Change subject: MGCP_Test: add control interface to MGW testsuite ...

Change in osmo-ttcn3-hacks[master]: MGCP_Test: do not use module parameter mp_test_ip (statsd)

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 ) Change subject: MGCP_Test: do not use module parameter mp_test_ip (statsd) .. Patch Set 1: The reason for the test failure wa

Change in osmo-ttcn3-hacks[master]: MGCP_Test: do not use module parameter mp_test_ip (statsd)

2021-08-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 ) Change subject: MGCP_Test: do not use module parameter mp_test_ip (statsd) .. MGCP_Test: do not use module parameter mp_test_

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

2021-08-19 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of bui

Build failure of network:osmocom:nightly/libgtpnl in Debian_10/x86_64

2021-08-19 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_10/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [

Change in osmo-pcu[master]: coverity: fix null deref from recent UL TBF leak fix

2021-08-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25203 ) Change subject: coverity: fix null deref from recent UL TBF leak fix .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit

Change in osmo-bts[master]: osmo-bts-trx: send dummy FACCH in the absense of RTP frames

2021-08-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24846 ) Change subject: osmo-bts-trx: send dummy FACCH in the absense of RTP frames .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/

Change in osmo-bts[master]: osmo-bts-trx: send dummy FACCH in the absense of RTP frames

2021-08-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24846 ) Change subject: osmo-bts-trx: send dummy FACCH in the absense of RTP frames .. Patch Set 3: > Patch Set 3: Code-Review+1 > > That is

Change in osmo-bts[master]: early IMM ASS: add configurable delay for RR IMM ASS

2021-08-19 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 ) Change subject: early IMM ASS: add configurable delay for RR IMM ASS .. Patch Set 4: (2 comments) Thanks for your explaination. htt