Change in osmo-ttcn3-hacks[master]: bsc: add TC_imm_ass_pre_ts_ack

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25399 ) Change subject: bsc: add TC_imm_ass_pre_ts_ack .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns

2021-09-07 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25375 ) Change subject: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns .. jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns Depends: docker-playground I1

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25375 ) Change subject: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns .. Patch Set 2: Verified+1 Code-Review+2 re-applying +2 -- To view,

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25375 ) Change subject: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ci/+/25

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns

2021-09-07 Thread osmith
Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/25375 to look at the new patch set (#2). Change subject: jobs/ttcn3-testsuites.yml: add ns-test-sgsn-sns .

Change in libosmocore[master]: gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSV...

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25392 ) Change subject: gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSVC BLOCKED .. gprs_ns2: nsvc: react on STATUS PDUs

Change in libosmocore[master]: gprs_ns2: fix NS STATUS validation

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25390 ) Change subject: gprs_ns2: fix NS STATUS validation .. gprs_ns2: fix NS STATUS validation The wrong TLVs were used. Change-Id: I01339d

Change in libosmocore[master]: ns2: nsvc: reject UNITDATA when the remote BLOCK'ed

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25383 ) Change subject: ns2: nsvc: reject UNITDATA when the remote BLOCK'ed .. ns2: nsvc: reject UNITDATA when the remote BLOCK'ed When the

Change in libosmocore[master]: gprs_ns2: fix a white space

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25391 ) Change subject: gprs_ns2: fix a white space .. gprs_ns2: fix a white space Change-Id: I2207d13ae451ce49482625fac43b6ab1c0f215e8 --- M

Change in libosmocore[master]: ns2: fix a crash when receiving a SIZE while configured

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25384 ) Change subject: ns2: fix a crash when receiving a SIZE while configured .. ns2: fix a crash when receiving a SIZE while configured The

Change in osmo-ttcn3-hacks[master]: bsc: add TC_imm_ass_pre_ts_ack

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25399 ) Change subject: bsc: add TC_imm_ass_pre_ts_ack .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-ttcn3-hacks[master]: bsc: properly check TSC and ARFCN in early IA tests

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25398 ) Change subject: bsc: properly check TSC and ARFCN in early IA tests .. Patch Set 2: Code-Review+2 -- To view, visit https:/

Change in osmo-ttcn3-hacks[master]: bsc: properly check TSC and ARFCN in early IA tests

2021-09-07 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25398 ) Change subject: bsc: properly check TSC and ARFCN in early IA tests .. bsc: properly check TSC and ARFCN in early IA tests Tests have

Change in osmo-bsc[master]: fixup for Early IMM ASS: use proper TSC

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25397 ) Change subject: fixup for Early IMM ASS: use proper TSC .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-bsc[master]: doc: power_control.adoc: Add small time graph showcasing P_CON_INTERVAL

2021-09-07 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25356 ) Change subject: doc: power_control.adoc: Add small time graph showcasing P_CON_INTERVAL .. doc: power_control.adoc: Add small time graph showc

Change in osmo-bsc[master]: doc: power_control.adoc: Add small time graph showcasing P_CON_INTERVAL

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25356 ) Change subject: doc: power_control.adoc: Add small time graph showcasing P_CON_INTERVAL .. Patch Set 1: Code-Review+2 -- To view,

Change in libosmocore[master]: gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSV...

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25392 ) Change subject: gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSVC BLOCKED .. Patch Set 1: Code-Review+2 --

Change in libosmocore[master]: gprs_ns2: fix NS STATUS validation

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25390 ) Change subject: gprs_ns2: fix NS STATUS validation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/

Change in libosmocore[master]: ns2: fix a crash when receiving a SIZE while configured

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25384 ) Change subject: ns2: fix a crash when receiving a SIZE while configured .. Patch Set 1: Code-Review+2 -- To view, visit https://

Change in libosmocore[master]: ns2: nsvc: reject UNITDATA when the remote BLOCK'ed

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25383 ) Change subject: ns2: nsvc: reject UNITDATA when the remote BLOCK'ed .. Patch Set 1: Code-Review+2 -- To view, visit https://ger

Change in libosmocore[master]: ns2: nsvc: add a uptime/downtime to track the last state change

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25350 ) Change subject: ns2: nsvc: add a uptime/downtime to track the last state change .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmocore[master]: ns2: nse: add a uptime/downtime to track the last state change

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25349 ) Change subject: ns2: nse: add a uptime/downtime to track the last state change .. Patch Set 3: Code-Review+2 -- To view, visit h

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: add ttcn3-ns-test-fr

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25375 ) Change subject: jobs/ttcn3-testsuites.yml: add ttcn3-ns-test-fr .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ci/+/2

Change in docker-playground[master]: ttcn3-ns-test-sgsn-sns: add test run for ns sgsn role with sns

2021-09-07 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25374 ) Change subject: ttcn3-ns-test-sgsn-sns: add test run for ns sgsn role with sns .. ttcn3-ns-test-sgsn-sns: add test run for ns sgsn rol

Change in docker-playground[master]: ttcn3-ns-test: add second NSVC to allow SNS tests to work

2021-09-07 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25373 ) Change subject: ttcn3-ns-test: add second NSVC to allow SNS tests to work .. ttcn3-ns-test: add second NSVC to allow SNS tests to work

Change in docker-playground[master]: ttcn3-ns-test: add second NSVC to allow SNS tests to work

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25373 ) Change subject: ttcn3-ns-test: add second NSVC to allow SNS tests to work .. Patch Set 1: Verified+1 Code-Review+2 -- To v

Change in docker-playground[master]: ttcn3-ns-test-sgsn-sns: add test run for ns sgsn role with sns

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25374 ) Change subject: ttcn3-ns-test-sgsn-sns: add test run for ns sgsn role with sns .. Patch Set 1: Verified+1 Code-Review+2 --

Change in osmo-bsc[master]: add CTRL bts.N.trx.M.rf_locked (RW)

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25395 ) Change subject: add CTRL bts.N.trx.M.rf_locked (RW) .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/os

Change in osmo-bsc[master]: add CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25387 ) Change subject: add CTRL 'rf_states' and 'bts.N.rf_states' .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.o

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ctrl_trx_rf_locked

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25393 ) Change subject: bsc: add TC_ctrl_trx_rf_locked .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-ttcn3-hacks[master]: bsc: verify new CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25388 ) Change subject: bsc: verify new CTRL 'rf_states' and 'bts.N.rf_states' .. Patch Set 3: Code-Review+1 -- To view, visit http

Change in osmo-ttcn3-hacks[master]: bsc: make TC_stats_conn_fail less fragile

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25396 ) Change subject: bsc: make TC_stats_conn_fail less fragile .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.os

Change in osmo-bsc[master]: fixup for Early IMM ASS: use proper TSC

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25397 ) Change subject: fixup for Early IMM ASS: use proper TSC .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/

Change in libosmocore[master]: revisit some calls of strtol(), stroul(), strtoull()

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25347 ) Change subject: revisit some calls of strtol(), stroul(), strtoull() .. Patch Set 6: Code-Review+1 Once more I'm more agreeing wi

Change in libosmocore[master]: CTRL: expose stat_item groups on CTRL

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25224 ) Change subject: CTRL: expose stat_item groups on CTRL .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in libosmocore[master]: add osmo_stat_item_get_group_by_name_idxname()

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25346 ) Change subject: add osmo_stat_item_get_group_by_name_idxname() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.os

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 2: > Patch Set 2: > > > You could pick a differ

Change in osmo-ttcn3-hacks[master]: fix errmsg in f_ctrl_set() which said "GET"

2021-09-07 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25394 ) Change subject: fix errmsg in f_ctrl_set() which said "GET" .. fix errmsg in f_ctrl_set() which said "GET" Change-Id: I56cd20c3c1b22ac0b

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 2: > You could pick a different error code, like

Change in osmo-ttcn3-hacks[master]: bsc: add TC_imm_ass_pre_ts_ack

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25399 ) Change subject: bsc: add TC_imm_ass_pre_ts_ack .. bsc: add TC_imm_ass_pre_ts_ack Also test the early IA feature for non-dyn T

Change in osmo-ttcn3-hacks[master]: bsc: properly check TSC and ARFCN in early IA tests

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25398 ) Change subject: bsc: properly check TSC and ARFCN in early IA tests .. bsc: properly check TSC and ARFCN in early IA tests Te

Change in osmo-bsc[master]: fixup for Early IMM ASS: use proper TSC

2021-09-07 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/25397 ) Change subject: fixup for Early IMM ASS: use proper TSC .. fixup for Early IMM ASS: use proper TSC Testing has shown that the Training S

Change in osmo-bsc[master]: fixup for Early IMM ASS: use proper TSC

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25397 ) Change subject: fixup for Early IMM ASS: use proper TSC .. fixup for Early IMM ASS: use proper TSC Testing has shown that the Trainin

Change in osmo-ttcn3-hacks[master]: bsc: make TC_stats_conn_fail less fragile

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25396 ) Change subject: bsc: make TC_stats_conn_fail less fragile .. bsc: make TC_stats_conn_fail less fragile Add a delay between se

Change in osmo-bsc[master]: add CTRL bts.N.trx.M.rf_locked (RW)

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25395 ) Change subject: add CTRL bts.N.trx.M.rf_locked (RW) .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osm

Change in libosmocore[master]: CTRL: expose stat_item groups on CTRL

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25224 ) Change subject: CTRL: expose stat_item groups on CTRL .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 2: > Patch Set 2: > You did read my reasoning of

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ctrl_trx_rf_locked

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25393 ) Change subject: bsc: add TC_ctrl_trx_rf_locked .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/

Change in osmo-ttcn3-hacks[master]: fix errmsg in f_ctrl_set() which said "GET"

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25394 ) Change subject: fix errmsg in f_ctrl_set() which said "GET" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.o

Change in docker-playground[master]: ttcn3-ns-test-sgsn-sns: add test run for ns sgsn role with sns

2021-09-07 Thread lynxis lazus
lynxis lazus has removed daniel from this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25374 ) Change subject: ttcn3-ns-test-sgsn-sns: add test run for ns sgsn role with sns .. Removed reviewer daniel. -- To view

Change in docker-playground[master]: ttcn3-ns-test: add second NSVC to allow SNS tests to work

2021-09-07 Thread lynxis lazus
lynxis lazus has removed daniel from this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25373 ) Change subject: ttcn3-ns-test: add second NSVC to allow SNS tests to work .. Removed reviewer daniel. -- To view, vis

Change in osmo-bsc[master]: add CTRL bts.N.trx.M.rf_locked (RW)

2021-09-07 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25395 to look at the new patch set (#2). Change subject: add CTRL bts.N.trx.M.rf_locked (RW) .. add CTRL bts.N

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 2: > TBH I forgot to write about it, but I found

Change in libosmocore[master]: CTRL: expose stat_item groups on CTRL

2021-09-07 Thread neels
Hello Jenkins Builder, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25224 to look at the new patch set (#7). Change subject: CTRL: expose stat_item groups on CTRL .

Change in osmo-bsc[master]: add CTRL bts.N.trx.M.rf_locked (RW)

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25395 ) Change subject: add CTRL bts.N.trx.M.rf_locked (RW) .. add CTRL bts.N.trx.M.rf_locked (RW) Add per-TRX command to lock/unlock single

Change in osmo-ttcn3-hacks[master]: fix errmsg in f_ctrl_set() which said "GET"

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25394 ) Change subject: fix errmsg in f_ctrl_set() which said "GET" .. fix errmsg in f_ctrl_set() which said "GET" Change-Id: I56cd20

Change in osmo-ttcn3-hacks[master]: bsc: add TC_ctrl_trx_rf_locked

2021-09-07 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25393 ) Change subject: bsc: add TC_ctrl_trx_rf_locked .. bsc: add TC_ctrl_trx_rf_locked Related: OS#5542 Depends: Ie46fd730797b64fb1

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: add ttcn3-ns-test-fr

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/25375 ) Change subject: jobs/ttcn3-testsuites.yml: add ttcn3-ns-test-fr .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.

Change in libosmocore[master]: ns2: fix a crash when receiving a SIZE while configured

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25384 ) Change subject: ns2: fix a crash when receiving a SIZE while configured .. Patch Set 1: (1 comment) https://gerrit.osmocom.

Change in osmo-bsc[master]: add CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25387 ) Change subject: add CTRL 'rf_states' and 'bts.N.rf_states' .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.or

Change in osmo-bsc[master]: add CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread neels
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/25387 to look at the new patch set (#4). Change subject: add CTRL 'rf_states' and 'bts.N.rf_states' ..

Change in osmo-ttcn3-hacks[master]: ns2: add tc TC_mirror_unitdata_tx_status_blocked

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25389 ) Change subject: ns2: add tc TC_mirror_unitdata_tx_status_blocked .. ns2: add tc TC_mirror_unitdata_tx_status_blocked Change-Id: I

Change in osmo-ttcn3-hacks[master]: ns: add test case for SIZE after a successful configuration

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25382 ) Change subject: ns: add test case for SIZE after a successful configuration .. ns: add test case for SIZE after a successful confi

Change in osmo-ttcn3-hacks[master]: ns: add test case for UNITDATA transmission

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25355 ) Change subject: ns: add test case for UNITDATA transmission .. ns: add test case for UNITDATA transmission Change-Id: I5f59581d42

Change in osmo-ttcn3-hacks[master]: ns: fix missing f_ prefix for function f_tx_block_by_vty

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25354 ) Change subject: ns: fix missing f_ prefix for function f_tx_block_by_vty .. ns: fix missing f_ prefix for function f_tx_block_by_v

Change in osmo-ttcn3-hacks[master]: ns: always clean up the ns_codec

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353 ) Change subject: ns: always clean up the ns_codec .. ns: always clean up the ns_codec The f_clean_ns_codec() was introduced later

Change in osmo-ttcn3-hacks[master]: ns: add tests to test UNITDATA over a BLOCKED nsvcs

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25352 ) Change subject: ns: add tests to test UNITDATA over a BLOCKED nsvcs .. ns: add tests to test UNITDATA over a BLOCKED nsvcs The UN

Change in osmo-ttcn3-hacks[master]: ns: f_init_vty: only reset SNS configuration when using SNS.

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25342 ) Change subject: ns: f_init_vty: only reset SNS configuration when using SNS. .. ns: f_init_vty: only reset SNS configuration when

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmi...

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25351 ) Change subject: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmitted from the correct port .. ns: add TC_sns

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct wh...

2021-09-07 Thread lynxis lazus
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341 ) Change subject: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct when removing a bind .. ns: add TC_sns_bss_rem

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct wh...

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341 ) Change subject: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct when removing a bind .. Patch Set 2:

Change in osmo-ttcn3-hacks[master]: ns2: add tc TC_mirror_unitdata_tx_status_blocked

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25389 ) Change subject: ns2: add tc TC_mirror_unitdata_tx_status_blocked .. Patch Set 1: Code-Review+2 1 + 1 = 2 -- To view,

Change in osmo-ttcn3-hacks[master]: ns: add test case for SIZE after a successful configuration

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25382 ) Change subject: ns: add test case for SIZE after a successful configuration .. Patch Set 1: Code-Review+2 1 + 1 = 2 -

Change in osmo-ttcn3-hacks[master]: ns: add test case for UNITDATA transmission

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25355 ) Change subject: ns: add test case for UNITDATA transmission .. Patch Set 1: Code-Review+2 1 + 1 = 2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: ns: always clean up the ns_codec

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353 ) Change subject: ns: always clean up the ns_codec .. Patch Set 1: Code-Review+2 1 + 1 = 2 -- To view, visit https://ge

Change in osmo-ttcn3-hacks[master]: ns: add tests to test UNITDATA over a BLOCKED nsvcs

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25352 ) Change subject: ns: add tests to test UNITDATA over a BLOCKED nsvcs .. Patch Set 1: Code-Review+2 1 + 1 = 2 -- To vie

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmi...

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25351 ) Change subject: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmitted from the correct port .. Patc

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmi...

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25351 ) Change subject: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmitted from the correct port .. Patc

Change in osmo-ttcn3-hacks[master]: ns: f_init_vty: only reset SNS configuration when using SNS.

2021-09-07 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25342 ) Change subject: ns: f_init_vty: only reset SNS configuration when using SNS. .. Patch Set 2: Code-Review+2 1 + 1 = 2

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 2: TBH I forgot to write about it, but I found i

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 2: The linter does not like that osmo_str_to_int(

Change in osmo-bsc[master]: add CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25387 ) Change subject: add CTRL 'rf_states' and 'bts.N.rf_states' .. Patch Set 3: I'd prefer having bts_nr out of there if not needed. That

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread neels
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/25345 to look at the new patch set (#2). Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() ..

Change in osmo-bsc[master]: add CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25387 ) Change subject: add CTRL 'rf_states' and 'bts.N.rf_states' .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25387/

Change in libosmocore[master]: revisit some calls of strtol(), stroul(), strtoull()

2021-09-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25347 ) Change subject: revisit some calls of strtol(), stroul(), strtoull() .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libo

Change in libosmocore[master]: utils: add osmo_str_to_int() and osmo_str_to_int64()

2021-09-07 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25345 ) Change subject: utils: add osmo_str_to_int() and osmo_str_to_int64() .. Patch Set 1: > Places where expected ranges are not clear o

Change in osmo-bts[master]: WIP: TA loop: Take into account UL SACCH 'Actual Timing advance' field

2021-09-07 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25386 ) Change subject: WIP: TA loop: Take into account UL SACCH 'Actual Timing advance' field .. Patch Set 1: (2 comments) in general a g

Change in osmo-ttcn3-hacks[master]: bsc: verify new CTRL 'rf_states' and 'bts.N.rf_states'

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25388 ) Change subject: bsc: verify new CTRL 'rf_states' and 'bts.N.rf_states' .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct wh...

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341 ) Change subject: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct when removing a bind .. Patch Set 2: (1 c

Change in osmo-ttcn3-hacks[master]: ns2: add tc TC_mirror_unitdata_tx_status_blocked

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25389 ) Change subject: ns2: add tc TC_mirror_unitdata_tx_status_blocked .. Patch Set 1: Code-Review+1 -- To view, visit https://ger

Change in osmo-ttcn3-hacks[master]: ns: add test case for SIZE after a successful configuration

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25382 ) Change subject: ns: add test case for SIZE after a successful configuration .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: ns: add test case for UNITDATA transmission

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25355 ) Change subject: ns: add test case for UNITDATA transmission .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.o

Change in osmo-ttcn3-hacks[master]: ns: fix missing f_ prefix for function f_tx_block_by_vty

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25354 ) Change subject: ns: fix missing f_ prefix for function f_tx_block_by_vty .. Patch Set 1: Code-Review+2 -- To view, visit htt

Change in osmo-ttcn3-hacks[master]: ns: always clean up the ns_codec

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25353 ) Change subject: ns: always clean up the ns_codec .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/

Change in osmo-ttcn3-hacks[master]: ns: add tests to test UNITDATA over a BLOCKED nsvcs

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25352 ) Change subject: ns: add tests to test UNITDATA over a BLOCKED nsvcs .. Patch Set 1: Code-Review+1 -- To view, visit https://

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmi...

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25351 ) Change subject: ns: add TC_sns_sgsn_size_correct_port to check if SIZE_ACK is transmitted from the correct port .. Patch Set

Change in osmo-ttcn3-hacks[master]: ns: f_init_vty: only reset SNS configuration when using SNS.

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25342 ) Change subject: ns: f_init_vty: only reset SNS configuration when using SNS. .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct wh...

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25341 ) Change subject: ns: add TC_sns_bss_remove_bind_fail_sns to check SNS fails correct when removing a bind .. Patch Set 2: Code-

Change in libosmocore[master]: gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSV...

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25392 ) Change subject: gprs_ns2: nsvc: react on STATUS PDUs with cause code NSVC UNKNOWN/NSVC BLOCKED .. Patch Set 1: Code-Review+1 --

Change in libosmocore[master]: gprs_ns2: fix a white space

2021-09-07 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25391 ) Change subject: gprs_ns2: fix a white space .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmoc

  1   2   >