Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

2023-01-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others .. Patch

Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

2023-01-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others .. Patch

Change in pysim[master]: gsm_r: Fix byte/nibble ordering of predefined_value1

2023-01-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31057 ) Change subject: gsm_r: Fix byte/nibble ordering of predefined_value1 .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.os

Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

2023-01-27 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others .. Patch

Change in pysim[master]: Prepare for decoding/encoding records differently based on record number

2023-01-27 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31055 ) Change subject: Prepare for decoding/encoding records differently based on record number .. Prepare for decoding/encoding records differently bas

Change in pysim[master]: Prepare for decoding/encoding records differently based on record number

2023-01-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31055 ) Change subject: Prepare for decoding/encoding records differently based on record number .. Patch Set 2: Code-Review+2 -- To view, vi

Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

2023-01-27 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others .. Patch

Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

2023-01-27 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31056 to look at the new patch set (#3). Change subject: gsm_r: EF_Predefined: Decode first record different from others ..

Change in libosmo-gprs[master]: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI

2023-01-27 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31098 ) Change subject: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI .. Patch S

Change in osmo-ttcn3-hacks[master]: DIAMETER_Templates: Fix 3GPP Spec number

2023-01-27 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31097 ) Change subject: DIAMETER_Templates: Fix 3GPP Spec number .. Patch Set 1: Code-R

Change in osmo-ttcn3-hacks[master]: DIAMETER_Templates: Fix 3GPP Spec number

2023-01-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31097 ) Change subject: DIAMETER_Templates: Fix 3GPP Spec number .. DIAMETER_Templates: Fix 3GPP Spec number It's 3GPP TS 29.272, n

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

2023-01-27 Thread laforge
Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods .. Patch S

Change in pysim[master]: ts_51_011: Implement Extended BCD Coding

2023-01-27 Thread laforge
Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31066 ) Change subject: ts_51_011: Implement Extended BCD Coding .. Patch Set 2: (1 comm

Change in osmo-pcu[master]: Mark *_fsm_timeouts as static

2023-01-27 Thread pespin
Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31096 to look at the new patch set (#2). Change subject: Mark *_fsm_timeouts as static .

Change in osmo-pcu[master]: cosmetic: Remove unneeded curly braces

2023-01-27 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31095 ) Change subject: cosmetic: Remove unneeded curly braces .. cosmetic: Remove unneeded curly braces Change-Id: I6d87f11ff749d027685bf539a81f43d35f

Change in osmo-pcu[master]: Mark *_fsm_timeouts as static

2023-01-27 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31096 ) Change subject: Mark *_fsm_timeouts as static .. Patch Set 1: Code-Review+1 -- To vie

Change in osmo-pcu[master]: cosmetic: Remove unneeded curly braces

2023-01-27 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31095 ) Change subject: cosmetic: Remove unneeded curly braces .. Patch Set 1: Code-Review+1

Change in osmo-pcu[master]: Mark *_fsm_timeouts as static

2023-01-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31096 ) Change subject: Mark *_fsm_timeouts as static .. Mark *_fsm_timeouts as static After some earlier refactoring, those fields are only

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac

2023-01-27 Thread osmith
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31077 ) Change subject: modem: Initial integration of libosmo-gprs-rlcmac .. Patch Se

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-{llc,sndcp}

2023-01-27 Thread osmith
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31007 ) Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp} .. Pat

Change in osmo-pcu[master]: llc: Refactor code checking if PDU expired while dequeueing

2023-01-27 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31087 ) Change subject: llc: Refactor code checking if PDU expired while dequeueing .. llc: Refactor code checking if PDU expired while dequeueing The

Change in osmo-pcu[master]: llc: remove unused reference to msgb address

2023-01-27 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31090 ) Change subject: llc: remove unused reference to msgb address .. llc: remove unused reference to msgb address This is probably a leftover from a

Change in osmo-pcu[master]: llc: remove unused reference to msgb address

2023-01-27 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31090 ) Change subject: llc: remove unused reference to msgb address .. Patch Set 1: Code-Revie

Change in osmo-pcu[master]: cosmetic: Remove unneeded curly braces

2023-01-27 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31095 ) Change subject: cosmetic: Remove unneeded curly braces .. Patch Set 1: Code-Review+2 -

Change in osmo-pcu[master]: llc: Refactor code checking if PDU expired while dequeueing

2023-01-27 Thread osmith
Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31087 ) Change subject: llc: Refactor code checking if PDU expired while dequeueing .. P

Change in osmo-pcu[master]: cosmetic: Remove unneeded curly braces

2023-01-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31095 ) Change subject: cosmetic: Remove unneeded curly braces .. cosmetic: Remove unneeded curly braces Change-Id: I6d87f11ff749d027685bf53

Change in libosmocore[master]: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF

2023-01-27 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31094 ) Change subject: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF .. Patch Set 1: Code-

Change in libosmocore[master]: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF

2023-01-27 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31094 ) Change subject: gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF .. gsm_08_08.h: fix typo in GSM0808_DATA_FULL_PREF Change-Id: I25

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-rlcmac

2023-01-27 Thread pespin
Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31077 to look at the new patch set (#5). Change subject: modem: Initial integration of libosmo-gprs-rlcmac ..

Change in osmocom-bb[master]: modem: Initial integration of libosmo-gprs-{llc,sndcp}

2023-01-27 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31007 ) Change subject: modem: Initial integration of libosmo-gprs-{llc,sndcp} .. Patch Set 6

Change in libosmocore[master]: SI: add missing header

2023-01-27 Thread pespin
Attention is currently required from: fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 ) Change subject: SI: add missing header .. Patch Set 3: Code-Review+1 -- T

Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

2023-01-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 ) Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ..

Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

2023-01-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 ) Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ..

Change in osmo-pcu[master]: osmo-pcu: Transition to use of 'telnet_init_default'

2023-01-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31092 ) Change subject: osmo-pcu: Transition to use of 'telnet_init_default' .. Patch Set 1:

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

2023-01-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31093 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' .. Patch S

Change in osmo-pcu[master]: osmo-pcu: Transition to use of 'telnet_init_default'

2023-01-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31092 ) Change subject: osmo-pcu: Transition to use of 'telnet_init_default' .. Patch Set 1: