[S] Change in osmo-pcu[master]: pcu_l1_if_phy: support multiple BTS (in theory)

2023-03-06 Thread laforge
Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31649 ) Change subject: pcu_l1_if_phy: support multiple BTS (in theory) .. Patch Set

[S] Change in osmo-bsc[master]: cosmetic: timeslot_fsm.c: move some code to separate function

2023-03-06 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31658 ) Change subject: cosmetic: timeslot_fsm.c: move some code to separate function .. cosmetic: timeslot_fsm.c: move some code to separate function

[S] Change in libosmocore[master]: gsm0502: add burst length definitions from chapter 5.2

2023-03-06 Thread fixeria
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 ) Change subject: gsm0502: add burst length definitions from chapter 5.2 .. Pa

[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect

2023-03-06 Thread dexter
Attention is currently required from: neels, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31497 ) Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect .. Patch Se

[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect

2023-03-06 Thread dexter
Attention is currently required from: neels, fixeria. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 to look at the new patch set (#11). Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnec

[L] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_data: implement

2023-03-06 Thread osmith
Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31547 to look at the new patch set (#5). Change subject: bssmap_handle_ass_req_ct_data: implement .

[M] Change in osmo-bsc[master]: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD

2023-03-06 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31549 ) Change subject: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD .. Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: 1+1=2 aft

[L] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_data: implement

2023-03-06 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 ) Change subject: bssmap_handle_ass_req_ct_data: implement .. Patch Set 5: (1 comment) Patchset: PS5: 1+1=2 after rebase -- To vie

[L] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_data: implement

2023-03-06 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 ) Change subject: bssmap_handle_ass_req_ct_data: implement .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

[M] Change in osmo-bsc[master]: assignment_fsm: chan mode check: support CSD

2023-03-06 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31551 ) Change subject: assignment_fsm: chan mode check: support CSD .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.

[S] Change in osmo-bsc[master]: tests/handover: wrap functions from gsm_08_08.c

2023-03-06 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31621 ) Change subject: tests/handover: wrap functions from gsm_08_08.c .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmoc

[S] Change in osmo-bsc[master]: bssmap_handle_ass_req_tp_codec_list: tweak log msg

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31550 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: bssmap_handle_ass_req_tp_codec_list: tweak log msg

[L] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_data: implement

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 ) Change subject: bssmap_handle_ass_req_ct_data: implement .. bssmap_handle_ass_req_ct_data: implement Handle assignment requests for CSD. In thi

[S] Change in osmo-bsc[master]: abis_rsl: ipacc_payload_type: handle CSD

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31548 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: abis_rsl: ipacc_payload_type: handle CSD ..

[M] Change in osmo-bsc[master]: assignment_fsm: chan mode check: support CSD

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31551 ) Change subject: assignment_fsm: chan mode check: support CSD .. assignment_fsm: chan mode check: support CSD Replace check_requires_voice_strea

[S] Change in osmo-bsc[master]: tests/handover: wrap functions from gsm_08_08.c

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31621 ) Change subject: tests/handover: wrap functions from gsm_08_08.c .. tests/handover: wrap functions from gsm_08_08.c Prepare to include gsm_08_08

[S] Change in libosmocore[master]: gsm0502: add burst length definitions from chapter 5.2

2023-03-06 Thread pespin
Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 ) Change subject: gsm0502: add burst length definitions from chapter 5.2 .. Pa

[M] Change in osmo-bsc[master]: requires_voice_stream -> ch_indctr

2023-03-06 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31622 ) Change subject: requires_voice_stream -> ch_indctr .. Patch Set 4: Code-Review+1 -- T

[S] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

2023-03-06 Thread dexter
Attention is currently required from: neels, pespin, fixeria. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31578 to look at the new patch set (#10). Change subject: pcu_sock: use struct to transfer

[S] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

2023-03-06 Thread dexter
Attention is currently required from: neels, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 ) Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ...

[S] Change in osmo-bsc[master]: pcu_sock: get rid of leaking message buffer

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31673 ) Change subject: pcu_sock: get rid of leaking message buffer .. pcu_sock: get rid of leaking message buffer When a data request is re

[M] Change in osmo-bsc[master]: pcu_sock: improve logging

2023-03-06 Thread dexter
Attention is currently required from: neels. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31579 ) Change subject: pcu_sock: improve logging .. Patch Set 9: (1 comment) File src/osmo-bs

[M] Change in osmo-bsc[master]: pcu_sock: improve logging

2023-03-06 Thread dexter
Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31579 to look at the new patch set (#9). Change subject: pcu_sock: improve logging

[M] Change in osmo-bsc[master]: requires_voice_stream -> ch_indctr

2023-03-06 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31622 ) Change subject: requires_voice_stream -> ch_indctr .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

[S] Change in osmo-bsc[master]: lchan_select: chan_mode_to_chan_type: support CSD

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31552 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: lchan_select: chan_mode_to_chan_type: support CSD .

[M] Change in osmo-bsc[master]: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31549 ) Change subject: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD .. rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD Omit the A-bis/IP specific

[S] Change in osmo-bsc[master]: chan_mode_to_mgcp_codec: support CSD

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31554 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: chan_mode_to_mgcp_codec: support CSD ..

[S] Change in osmo-bsc[master]: Cosmetic: channel_mode_from_lchan: remove fixme

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31555 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Cosmetic: channel_mode_from_lchan: remove fixme ...

[S] Change in libosmocore[master]: gsm0502: add burst length definitions from chapter 5.2

2023-03-06 Thread fixeria
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 ) Change subject: gsm0502: add burst length definitions from chapter 5.2 .. Pa

[S] Change in libosmocore[master]: gsm0502: add burst length definitions from chapter 5.2

2023-03-06 Thread fixeria
Attention is currently required from: neels, pespin. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31669 to look at the new patch set (#2). Change subject: gsm0502: add burst length definitions from chapter 5.2 ...

[S] Change in libosmocore[master]: gsm0502: add burst length definitions from chapter 5.2

2023-03-06 Thread fixeria
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 ) Change subject: gsm0502: add burst length definitions from chapter 5.2 .. Pa

[S] Change in osmo-bts[master]: pcu_sock: rename rc to fd

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31674 ) Change subject: pcu_sock: rename rc to fd .. pcu_sock: rename rc to fd The variable rc holds the return code of accept(), which retu

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove whitespace after type cast

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31675 ) Change subject: pcu_sock: cosmetic: remove whitespace after type cast .. pcu_sock: cosmetic: remove whitespace after type cast Chang

[S] Change in libosmocore[master]: Makefile.am: Make libraries depend on .map files

2023-03-06 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31667 ) Change subject: Makefile.am: Make libraries depend on .map files .. Patch Set 1: C

[S] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout

2023-03-06 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31676 ) Change subject: bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout .. bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout Make th

[S] Change in osmo-bsc[master]: pcu_sock: get rid of leaking message buffer

2023-03-06 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31673 ) Change subject: pcu_sock: get rid of leaking message buffer .. Patch Set 1: Code-Revie

[S] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

2023-03-06 Thread fixeria
Attention is currently required from: neels, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 ) Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ...

[M] Change in osmo-bsc[master]: pcu_sock: improve logging

2023-03-06 Thread pespin
Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31579 ) Change subject: pcu_sock: improve logging .. Patch Set 9: Code-Review+2 -- To

[M] Change in osmo-bsc[master]: pcu_sock: improve logging

2023-03-06 Thread fixeria
Attention is currently required from: neels, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31579 ) Change subject: pcu_sock: improve logging .. Patch Set 9: Code-Review+1 -- To

[S] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout

2023-03-06 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31676 ) Change subject: bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout .. Patch Set

[S] Change in libosmocore[master]: gsm0502: add burst length definitions from chapter 5.2

2023-03-06 Thread pespin
Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 ) Change subject: gsm0502: add burst length definitions from chapter 5.2 .. Pa

[S] Change in osmo-bts[master]: pcu_sock: rename rc to fd

2023-03-06 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31674 ) Change subject: pcu_sock: rename rc to fd .. Patch Set 1: Code-Review+2 -- To view,

[S] Change in osmo-bts[master]: pcu_sock: rename rc to fd

2023-03-06 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31674 ) Change subject: pcu_sock: rename rc to fd .. Patch Set 1: Code-Review+1 -- To view, v

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove whitespace after type cast

2023-03-06 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31675 ) Change subject: pcu_sock: cosmetic: remove whitespace after type cast .. Patch Set 1:

[S] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

2023-03-06 Thread pespin
Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 ) Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ..

[S] Change in osmo-ttcn3-hacks[master]: bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout

2023-03-06 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31676 ) Change subject: bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout .. bsc-sccplite: fix TC_ho_in_fail_mgw_mdcx_timeout Make the test pass

[S] Change in osmo-bts[master]: pcu_sock: do not mess with the osmo fd flags directly

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31679 ) Change subject: pcu_sock: do not mess with the osmo fd flags directly .. pcu_sock: do not mess with the osmo fd flags directly When

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove unnecessary line breaks

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31677 ) Change subject: pcu_sock: cosmetic: remove unnecessary line breaks .. pcu_sock: cosmetic: remove unnecessary line breaks Change-Id:

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior .. pcu_sock: fix PCU socket accept behavior When a new PCU connection is ac

[S] Change in osmo-bts[master]: pcu_sock: rename rc to fd

2023-03-06 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31674 ) Change subject: pcu_sock: rename rc to fd .. pcu_sock: rename rc to fd The variable rc holds the return code of accept(), which returns a file

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove whitespace after type cast

2023-03-06 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31675 ) Change subject: pcu_sock: cosmetic: remove whitespace after type cast .. pcu_sock: cosmetic: remove whitespace after type cast Change-Id: I373b

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: set rc on error in bts_model_l1sap_down()

2023-03-06 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31680 ) Change subject: osmo-bts-{trx,virtual}: set rc on error in bts_model_l1sap_down() .. osmo-bts-{trx,virtual}: set rc on error in bts

[L] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: clean up bts_model_l1sap_down()

2023-03-06 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31670 to look at the new patch set (#2). Change subject: osmo-bts-{trx,virtual}: clean up bts_model_l1sap_down() ...

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_d...

2023-03-06 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31671 to look at the new patch set (#2). Change subject: osmo-bts-{trx,virtual}: check lchan against NULL in bts_mo

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_d...

2023-03-06 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31671 ) Change subject: osmo-bts-{trx,virtual}: check lchan against NULL in bts_model_l1sap_down() .

[S] Change in libosmocore[master]: gsm: gsm_gsmtime2fn(): constify param

2023-03-06 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31681 ) Change subject: gsm: gsm_gsmtime2fn(): constify param .. gsm: gsm_gsmtime2fn(): constify param Change-Id: Ib29d5a8e7dcf50fb086f96

[S] Change in libosmocore[master]: gsm: gsm_gsmtime2fn(): constify param

2023-03-06 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31681 ) Change subject: gsm: gsm_gsmtime2fn(): constify param .. Patch Set 1: Code-Review+2

[S] Change in libosmocore[master]: gsm: gsm_gsmtime2fn(): constify param

2023-03-06 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31681 ) Change subject: gsm: gsm_gsmtime2fn(): constify param .. gsm: gsm_gsmtime2fn(): constify param Change-Id: Ib29d5a8e7dcf50fb086f967857b0afa07

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove unnecessary line breaks

2023-03-06 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31677 ) Change subject: pcu_sock: cosmetic: remove unnecessary line breaks .. Patch Set 1: Cod

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior .. Patch Set 1: (1 comment)

[S] Change in osmo-bts[master]: pcu_sock: do not mess with the osmo fd flags directly

2023-03-06 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31679 ) Change subject: pcu_sock: do not mess with the osmo fd flags directly .. Patch Set 1:

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Drop dummy event GPRS_RLCMAC_TBF_UL_ASS_EV_FO...

2023-03-06 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31682 ) Change subject: rlcmac: tbf_ul_ass_fsm: Drop dummy event GPRS_RLCMAC_TBF_UL_ASS_EV_FOOBAR .. rlcmac: tbf_ul_ass_fsm: Drop dummy

[M] Change in osmo-bsc[master]: abis_rsl: CSD: add RTP_CSD_FMT IE to CRCX/MDCX

2023-03-06 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31683 ) Change subject: abis_rsl: CSD: add RTP_CSD_FMT IE to CRCX/MDCX .. abis_rsl: CSD: add RTP_CSD_FMT IE to CRCX/MDCX Related: OS#4393 Ch

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul_ass_fsm: Drop dummy event GPRS_RLCMAC_TBF_UL_ASS_EV_FO...

2023-03-06 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31682 ) Change subject: rlcmac: tbf_ul_ass_fsm: Drop dummy event GPRS_RLCMAC_TBF_UL_ASS_EV_FOOBAR .

[S] Change in osmocom-bb[master]: mobile: log MCC/MNC of the network while registering

2023-03-06 Thread msuraev
Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31659 ) Change subject: mobile: log MCC/MNC of the network while registering .. Patch Set 2

[S] Change in osmocom-bb[master]: mobile: log MCC/MNC of the network while registering

2023-03-06 Thread msuraev
Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31659 ) Change subject: mobile: log MCC/MNC of the network while registering .. Patch Set 2

[S] Change in osmocom-bb[master]: mobile: log MCC/MNC of the network while registering

2023-03-06 Thread msuraev
msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31659 ) Change subject: mobile: log MCC/MNC of the network while registering .. mobile: log MCC/MNC of the network while registering Change-Id: I114

[S] Change in osmocom-bb[master]: mobile: deprecate --gsmtap-ip option

2023-03-06 Thread msuraev
Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31660 ) Change subject: mobile: deprecate --gsmtap-ip option .. Patch Set 1: Code-Review+2

[S] Change in osmocom-bb[master]: mobile: deprecate --gsmtap-ip option

2023-03-06 Thread msuraev
msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31660 ) Change subject: mobile: deprecate --gsmtap-ip option .. mobile: deprecate --gsmtap-ip option Change-Id: I44b355f9a0bafee16a284537de76662a611

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread dexter
Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior .. Patch Set 1: (1 comment)

[S] Change in osmo-bsc[master]: pcu_sock: get rid of leaking message buffer

2023-03-06 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31673 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: pcu_sock: get rid of leaking message buffer ...

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread msuraev
Attention is currently required from: fixeria, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior .. Patch Set 1: (1

[S] Change in osmo-bts[master]: pcu_sock: do not mess with the osmo fd flags directly

2023-03-06 Thread msuraev
Attention is currently required from: dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31679 ) Change subject: pcu_sock: do not mess with the osmo fd flags directly .. Patch Set 1:

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: support multiple BTS (in theory)

2023-03-06 Thread msuraev
Attention is currently required from: fixeria, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31649 ) Change subject: pcu_l1_if_phy: support multiple BTS (in theory) .. Patch Set

[S] Change in osmo-bts[master]: pcu_sock: cosmetic: remove unnecessary line breaks

2023-03-06 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31677 ) Change subject: pcu_sock: cosmetic: remove unnecessary line breaks .. pcu_sock: cosmetic: remove unnecessary line breaks Change-Id: I8cb2979c62

[S] Change in libosmocore[master]: Makefile.am: Make libraries depend on .map files

2023-03-06 Thread msuraev
Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31667 ) Change subject: Makefile.am: Make libraries depend on .map files .. Patch Set 1: C

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread dexter
Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31678 to look at the new patch set (#2). Change subject: pcu_sock: fix PCU socket accept behavior

[S] Change in osmo-bts[master]: pcu_sock: do not mess with the osmo fd flags directly

2023-03-06 Thread dexter
Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31679 to look at the new patch set (#2). Change subject: pcu_sock: do not mess with the osmo fd flags directly ...

[S] Change in osmo-bts[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread dexter
Attention is currently required from: fixeria, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31678 ) Change subject: pcu_sock: fix PCU socket accept behavior .. Patch Set 2: (1

[M] Change in osmo-bsc[master]: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs

2023-03-06 Thread dexter
Attention is currently required from: neels, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31618 to look at the new patch set (#6). Change subject: pcu_sock: handle multiple BTSs with multip

[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect

2023-03-06 Thread dexter
Attention is currently required from: neels, fixeria. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 to look at the new patch set (#12). Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnec

[S] Change in osmo-bsc[master]: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH

2023-03-06 Thread dexter
Attention is currently required from: neels, dexter. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31578 to look at the new patch set (#11). Change subject: pcu_sock: use struct to transfer IMMEDIAT

[M] Change in osmo-bsc[master]: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs

2023-03-06 Thread dexter
Attention is currently required from: neels, laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31618 ) Change subject: pcu_sock: handle multiple BTSs with multiple BSC co-located PCUs

[S] Change in osmo-bsc[master]: pcuif_proto: increment version number

2023-03-06 Thread dexter
Attention is currently required from: neels, laforge. Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31597 to look at the new patch set (#7). Change subject: pcuif_proto: increment version number .

[S] Change in osmo-bsc[master]: pcuif_proto: increment version number

2023-03-06 Thread dexter
Attention is currently required from: neels, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31597 ) Change subject: pcuif_proto: increment version number .. Patch Set 7: (2 comme

[S] Change in osmo-bsc[master]: pcu_sock: fix PCU socket accept behavior

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31686 ) Change subject: pcu_sock: fix PCU socket accept behavior .. pcu_sock: fix PCU socket accept behavior When a new PCU connection is ac

[S] Change in osmo-bsc[master]: pcu_sock: cosmetic: remove whitespace after type cast

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31685 ) Change subject: pcu_sock: cosmetic: remove whitespace after type cast .. pcu_sock: cosmetic: remove whitespace after type cast Chang

[S] Change in osmo-bsc[master]: pcu_sock: rename rc to fd

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31684 ) Change subject: pcu_sock: rename rc to fd .. pcu_sock: rename rc to fd The variable rc holds the return code of accept(), which retu

[S] Change in osmo-bsc[master]: pcu_sock: only allow Ericsson RBS to connect to external PCU

2023-03-06 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31687 ) Change subject: pcu_sock: only allow Ericsson RBS to connect to external PCU .. pcu_sock: only allow Ericsson RBS to connect to exter

[M] Change in osmocom-bb[master]: layer23: get rid of lapdm_channel_init() warning

2023-03-06 Thread msuraev
Attention is currently required from: msuraev. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31664 to look at the new patch set (#2). Change subject: layer23: get rid of lapdm_channel_init() warni

[S] Change in osmo-gsm-manuals[master]: Change upload path to project/master/

2023-03-06 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 ) Change subject: Change upload path to project/master/ .. Change upload path to project/master/ Don't upload the manuals for

[S] Change in osmo-gsm-manuals[master]: editorconfig: new file

2023-03-06 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31689 ) Change subject: editorconfig: new file .. editorconfig: new file Add an editorconfig file so editors can figure out that the

[S] Change in osmocom-bb[master]: mobile: allow configuring local GSMTAP address

2023-03-06 Thread msuraev
Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31661 ) Change subject: mobile: allow configuring local GSMTAP address .. Patch Set 2: (1

[S] Change in osmo-gsm-manuals[master]: Change upload path to project/master/

2023-03-06 Thread osmith
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31688 to look at the new patch set (#2). Change subject: Change upload path to project/master/ .. Chan

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

2023-03-06 Thread dexter
Attention is currently required from: neels, pespin, fixeria, dexter. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#23). Change subject: bts: add IMMEDIATE ASSIG

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

2023-03-06 Thread dexter
Attention is currently required from: neels, pespin, fixeria, dexter. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 to look at the new patch set (#24). Change subject: bts: add IMMEDIATE ASSIG

[S] Change in libosmocore[master]: Makefile.am: Make libraries depend on .map files

2023-03-06 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31667 ) Change subject: Makefile.am: Make libraries depend on .map files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.

[S] Change in libosmocore[master]: Makefile.am: Make libraries depend on .map files

2023-03-06 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31667 ) Change subject: Makefile.am: Make libraries depend on .map files .. Makefile.am: Make libraries depend on .map files Without this, an updat

[S] Change in libosmocore[master]: gsm_08_58: Document IPAC RTP CSD modes in at least a few words

2023-03-06 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31690 ) Change subject: gsm_08_58: Document IPAC RTP CSD modes in at least a few words .. gsm_08_58: Document IPAC RTP CSD modes in at le

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: support multiple BTS (in theory)

2023-03-06 Thread laforge
Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31649 ) Change subject: pcu_l1_if_phy: support multiple BTS (in theory) .. Patch Set

  1   2   >