[S] Change in osmo-bts[2023q1]: oml: reset BCCH carrier power reduction mode (if enabled)

2023-05-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32598 ) Change subject: oml: reset BCCH carrier power reduction mode (if enabled) .. Patch Set 1: Code-Review+2 -- To view, visit https://g

[S] Change in osmo-bts[2023q1]: oml: reset BCCH carrier power reduction mode (if enabled)

2023-05-04 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32598 ) Change subject: oml: reset BCCH carrier power reduction mode (if enabled) .. oml: reset BCCH carrier power reduction mode (if enabled) We shou

[S] Change in osmocom-bb[master]: layer23: modem: sndcp: Properly inform SNDCP layer of ownership transfer

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32593 ) Change subject: layer23: modem: sndcp: Properly inform SNDCP layer of ownership transfer .. layer23: modem: sndcp: Properly inform SNDCP laye

[M] Change in osmocom-bb[master]: layer23: modem: Delay GPRS attach at startup until modem is ready

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32567 ) Change subject: layer23: modem: Delay GPRS attach at startup until modem is ready .. layer23: modem: Delay GPRS attach at startup until modem

[M] Change in libosmo-gprs[master]: gmm: Rework sess_id to identify one GMME

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32580 ) Change subject: gmm: Rework sess_id to identify one GMME .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.

[M] Change in libosmo-gprs[master]: gmm: Implement GMMSM-UNITDATA.ind

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32581 ) Change subject: gmm: Implement GMMSM-UNITDATA.ind .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/l

[M] Change in libosmo-gprs[master]: sm: Fix encoding of dynamic IP address in PDPActCtxReq

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32582 ) Change subject: sm: Fix encoding of dynamic IP address in PDPActCtxReq .. Patch Set 1: Code-Review+2 -- To view, visit https://g

[M] Change in libosmo-gprs[master]: sm: Implement rx Act PDP Ctx Rej

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32583 ) Change subject: sm: Implement rx Act PDP Ctx Rej .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/li

[S] Change in libosmo-gprs[master]: sm: Avoid freeing the SME object too quickly

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32584 ) Change subject: sm: Avoid freeing the SME object too quickly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmo

[S] Change in libosmo-gprs[master]: llc: use GRR instead of BSSGP to tx XID.req in MS mode

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32585 ) Change subject: llc: use GRR instead of BSSGP to tx XID.req in MS mode .. Patch Set 1: Code-Review+2 -- To view, visit https://g

[S] Change in libosmo-gprs[master]: sndcp: Allow cb users taking ownership of primitives

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32586 ) Change subject: sndcp: Allow cb users taking ownership of primitives .. Patch Set 2: Code-Review+2 -- To view, visit https://ger

[S] Change in libosmo-gprs[master]: sndcp: Initiate LL-XID.req only if we have something to send at L3

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32591 ) Change subject: sndcp: Initiate LL-XID.req only if we have something to send at L3 .. Patch Set 2: Code-Review+2 -- To view, vi

[S] Change in libosmo-gprs[master]: sm: Fix pdp_act_cnf.accepted flag value swapped

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32592 ) Change subject: sm: Fix pdp_act_cnf.accepted flag value swapped .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.o

[M] Change in libosmo-gprs[master]: sm: Fix encoding of dynamic IP address in PDPActCtxReq

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32582 ) Change subject: sm: Fix encoding of dynamic IP address in PDPActCtxReq .. sm: Fix encoding of dynamic IP address in PDPActCtxReq Change-Id:

[M] Change in libosmo-gprs[master]: gmm: Rework sess_id to identify one GMME

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32580 ) Change subject: gmm: Rework sess_id to identify one GMME .. gmm: Rework sess_id to identify one GMME The GMM layer doesn't really have to d

[M] Change in libosmo-gprs[master]: gmm: Implement GMMSM-UNITDATA.ind

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32581 ) Change subject: gmm: Implement GMMSM-UNITDATA.ind .. gmm: Implement GMMSM-UNITDATA.ind Change-Id: Ib1ac220292c61419a65f27fa88a731357728459d

[M] Change in libosmo-gprs[master]: sm: Implement rx Act PDP Ctx Rej

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32583 ) Change subject: sm: Implement rx Act PDP Ctx Rej .. sm: Implement rx Act PDP Ctx Rej Change-Id: Ib534ebc2a3a0674675621da2f8bd0de218a08ef0 -

[S] Change in libosmo-gprs[master]: sm: Avoid freeing the SME object too quickly

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32584 ) Change subject: sm: Avoid freeing the SME object too quickly .. sm: Avoid freeing the SME object too quickly At that point in time we may s

[S] Change in libosmo-gprs[master]: llc: use GRR instead of BSSGP to tx XID.req in MS mode

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32585 ) Change subject: llc: use GRR instead of BSSGP to tx XID.req in MS mode .. llc: use GRR instead of BSSGP to tx XID.req in MS mode Change-Id:

[S] Change in libosmo-gprs[master]: sndcp: Allow cb users taking ownership of primitives

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32586 ) Change subject: sndcp: Allow cb users taking ownership of primitives .. sndcp: Allow cb users taking ownership of primitives Change-Id: Ie3

[S] Change in libosmo-gprs[master]: sndcp: Initiate LL-XID.req only if we have something to send at L3

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32591 ) Change subject: sndcp: Initiate LL-XID.req only if we have something to send at L3 .. sndcp: Initiate LL-XID.req only if we have something

[S] Change in libosmo-gprs[master]: sm: Fix pdp_act_cnf.accepted flag value swapped

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32592 ) Change subject: sm: Fix pdp_act_cnf.accepted flag value swapped .. sm: Fix pdp_act_cnf.accepted flag value swapped Change-Id: Ieb7b4ce7121b

[L] Change in osmo-ttcn3-hacks[master]: MGCP_Test: support multiple codecs

2023-05-04 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 ) Change subject: MGCP_Test: support multiple codecs .. MGCP_Test: support multiple codecs At the moment The RTP emulation and MGCP_Test

[S] Change in osmo-bsc[master]: cosmetic: Clarify language ip.access nanoBTS vs. all IPA Abis/IP

2023-05-04 Thread pespin
Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32180 ) Change subject: cosmetic: Clarify language ip.access nanoBTS vs. all IPA Abis/IP ..

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

2023-05-04 Thread pespin
Attention is currently required from: pespin, fixeria. Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32589 to look at the new patch set (#5). Change subject: layer23: modem: grr: Log ignored CCCH ImmAss ..

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

2023-05-04 Thread osmith
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss .. Patch Set 4:

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

2023-05-04 Thread osmith
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss .. Patch Set 5:

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

2023-05-04 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss .. Patch Set 5: Code-Re

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Activate PDP Context of APN after GPRS attach

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32590 ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: layer23: modem: gmm: Activate PDP Context of APN after GPRS attach .

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss .. layer23: modem: grr: Log ignored CCCH ImmAss There seems to be some bug when

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: add fmtp to template t_RtpFlow

2023-05-04 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32177 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: MGCP_Test: add fmtp to template t_RtpFlow .

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased mas...

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 ) Change subject: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference .. deps/Makefile: Update

[M] Change in osmo-ttcn3-hacks[master]: MGCP_Test: move template RtpFlowData up

2023-05-04 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32178 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: MGCP_Test: move template RtpFlowData up ...

[L] Change in osmocom-bb[master]: layer23: Introduce apn_fsm

2023-05-04 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32596 ) Change subject: layer23: Introduce apn_fsm .. Patch Set 2: (2 comments) File src/ho

[S] Change in osmocom-bb[master]: layer23: Store and use SAPI & NSAPI in apn->pdp

2023-05-04 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32597 ) Change subject: layer23: Store and use SAPI & NSAPI in apn->pdp .. Patch Set 2: Code-

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased mas...

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 ) Change subject: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference .. Patch Set 2: Code-Revie

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased mas...

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 ) Change subject: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference .. deps/Makefile: Update titan.Proto

[L] Change in osmocom-bb[master]: layer23: Introduce apn_fsm

2023-05-04 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32596 ) Change subject: layer23: Introduce apn_fsm .. Patch Set 2: (2 comments) File src/ho

[L] Change in osmocom-bb[master]: layer23: Introduce apn_fsm

2023-05-04 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32596 ) Change subject: layer23: Introduce apn_fsm .. Patch Set 2: Code-Review+1 (1 comment)

[S] Change in osmo-ttcn3-hacks[master]: Makefile: workaround Eclipse Gitlab rate limiting

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600 ) Change subject: Makefile: workaround Eclipse Gitlab rate limiting .. Makefile: workaround Eclipse Gitlab rate limiting Got t

[S] Change in osmo-ttcn3-hacks[master]: Makefile: workaround Eclipse Gitlab rate limiting

2023-05-04 Thread fixeria
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600 ) Change subject: Makefile: workaround Eclipse Gitlab rate limiting .. P

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Change remote gerrit->gitea for titan.ProtocolModules....

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32601 ) Change subject: deps/Makefile: Change remote gerrit->gitea for titan.ProtocolModules.BSSMAP .. deps/Makefile: Change remote

[S] Change in osmo-bts[master]: octphy: Fix clearly wrong noop assignment

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32602 ) Change subject: octphy: Fix clearly wrong noop assignment .. octphy: Fix clearly wrong noop assignment This code has been there sinc

[S] Change in osmo-bts[master]: bbtransc/rcarrier: Fix statechg done twice upon NM_EV_RX_OPSTART

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32603 ) Change subject: bbtransc/rcarrier: Fix statechg done twice upon NM_EV_RX_OPSTART .. bbtransc/rcarrier: Fix statechg done twice upon N

[S] Change in osmo-bts[master]: octphy: Fix clearly wrong noop assignment

2023-05-04 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32602 ) Change subject: octphy: Fix clearly wrong noop assignment .. Patch Set 1: Code-Review+

[S] Change in osmo-bts[master]: bbtransc/rcarrier: Fix statechg done twice upon NM_EV_RX_OPSTART

2023-05-04 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32603 ) Change subject: bbtransc/rcarrier: Fix statechg done twice upon NM_EV_RX_OPSTART .. Pa

[S] Change in osmo-ttcn3-hacks[master]: Makefile: workaround Eclipse Gitlab rate limiting

2023-05-04 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600 ) Change subject: Makefile: workaround Eclipse Gitlab rate limiting .. Patch Set

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Change remote gerrit->gitea for titan.ProtocolModules....

2023-05-04 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32601 ) Change subject: deps/Makefile: Change remote gerrit->gitea for titan.ProtocolModules.BSSMAP

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT

2023-05-04 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32604 ) Change subject: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT .. PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to P

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND

2023-05-04 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605 ) Change subject: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND .. PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND E

[M] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add templates for PCU_IF_MSG_DATA_CNF_DT message types

2023-05-04 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32607 ) Change subject: PCUIF_Types: add templates for PCU_IF_MSG_DATA_CNF_DT message types .. PCUIF_Types: add templates for PCU_IF

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add record PCUIF_pch_dt

2023-05-04 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 ) Change subject: PCUIF_Types: add record PCUIF_pch_dt .. PCUIF_Types: add record PCUIF_pch_dt The record PCUIF_pch_dt, coresp

[S] Change in osmo-ttcn3-hacks[master]: Makefile: workaround Eclipse Gitlab rate limiting

2023-05-04 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600 ) Change subject: Makefile: workaround Eclipse Gitlab rate limiting .. Patch Set 1: Code-Review+2 -- To view, visit https://ge

[S] Change in osmo-ttcn3-hacks[master]: Makefile: workaround Eclipse Gitlab rate limiting

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600 ) Change subject: Makefile: workaround Eclipse Gitlab rate limiting .. Makefile: workaround Eclipse Gitlab rate limiting Got this while p

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT

2023-05-04 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32604 ) Change subject: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT ..

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND

2023-05-04 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605 ) Change subject: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND .. Patch Se

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add record PCUIF_pch_dt

2023-05-04 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 ) Change subject: PCUIF_Types: add record PCUIF_pch_dt .. Patch Set 1: (1 commen

[M] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add templates for PCU_IF_MSG_DATA_CNF_DT message types

2023-05-04 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32607 ) Change subject: PCUIF_Types: add templates for PCU_IF_MSG_DATA_CNF_DT message types

[S] Change in osmo-bts[master]: octphy: Fix clearly wrong noop assignment

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32602 ) Change subject: octphy: Fix clearly wrong noop assignment .. octphy: Fix clearly wrong noop assignment This code has been there since first oct

[S] Change in libosmo-gprs[master]: gmm: Fix false positive compilation error with gcc 13.1.1

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32608 ) Change subject: gmm: Fix false positive compilation error with gcc 13.1.1 .. gmm: Fix false positive compilation error with gcc 1

[S] Change in osmo-iuh[master]: Move testdir src/tests/ -> tests/

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/32609 ) Change subject: Move testdir src/tests/ -> tests/ .. Move testdir src/tests/ -> tests/ Move tests to usual directory in most project

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

2023-05-04 Thread dexter
Attention is currently required from: jolly, laforge, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

[S] Change in osmo-bts[master]: l1sap: fix wording in comment

2023-05-04 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32610 ) Change subject: l1sap: fix wording in comment .. l1sap: fix wording in comment The function rtppayload_is_valid() is called from the

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

2023-05-04 Thread dexter
Attention is currently required from: jolly, laforge, pespin, fixeria. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31417 to look at the new patch set (#8). Change subject: l1sap: Accept RFC5993 and

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

2023-05-04 Thread pespin
Attention is currently required from: jolly, laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

2023-05-04 Thread pespin
Attention is currently required from: jolly, laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

[S] Change in osmo-bts[master]: l1sap: fix wording in comment

2023-05-04 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32610 ) Change subject: l1sap: fix wording in comment .. Patch Set 1: Code-Review+1 -- To vie

[M] Change in libosmocore[master]: vty: show bug in implicit go_parent_node

2023-05-04 Thread neels
Attention is currently required from: laforge, pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32561 ) Change subject: vty: show bug in implicit go_parent_node .. Patch S

[S] Change in libosmocore[master]: vty: fix vty->index for implicit go_parent_node

2023-05-04 Thread neels
Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32562 ) Change subject: vty: fix vty->index for implicit go_parent_node .. Patch Set

[S] Change in osmo-bts[master]: l1sap: fix wording in comment

2023-05-04 Thread neels
Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32610 ) Change subject: l1sap: fix wording in comment .. Patch Set 1: Code-Review+2 (1 comment)

[S] Change in libasn1c[master]: Disable _ASN_STACK_OVERFLOW_CHECK if building with Asan enabled

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/32612 ) Change subject: Disable _ASN_STACK_OVERFLOW_CHECK if building with Asan enabled .. Disable _ASN_STACK_OVERFLOW_CHECK if building with

[S] Change in libasn1c[master]: .gitignore: Add configure~

2023-05-04 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/32611 ) Change subject: .gitignore: Add configure~ .. .gitignore: Add configure~ Change-Id: Ie46723fe3ad5b27813c102e068f433215692271f --- M

[S] Change in libasn1c[master]: Disable _ASN_STACK_OVERFLOW_CHECK if building with Asan enabled

2023-05-04 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libasn1c/+/32612 to look at the new patch set (#2). Change subject: Disable _ASN_STACK_OVERFLOW_CHECK if building with Asan enabled ..

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

2023-05-04 Thread neels
Attention is currently required from: jolly, laforge, pespin, fixeria, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload .

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT

2023-05-04 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32604 ) Change subject: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT ..

[S] Change in libosmo-gprs[master]: gmm: Fix false positive compilation error with gcc 13.1.1

2023-05-04 Thread daniel
Attention is currently required from: osmith, pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32608 ) Change subject: gmm: Fix false positive compilation error with gcc 13.1.1 ..

[M] Change in libosmocore[master]: gsm: add osmo_mobile_identity_decode_from_l3_buf()

2023-05-04 Thread daniel
Attention is currently required from: neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32577 ) Change subject: gsm: add osmo_mobile_identity_decode_from_l3_buf() .. Patch Set 1: Co

[M] Change in libosmocore[master]: vty: show bug in implicit go_parent_node

2023-05-04 Thread daniel
Attention is currently required from: neels, laforge, pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32561 ) Change subject: vty: show bug in implicit go_parent_node ..

[S] Change in libosmocore[master]: vty: move struct vty_parent_node to private API

2023-05-04 Thread daniel
Attention is currently required from: neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32576 ) Change subject: vty: move struct vty_parent_node to private API .. Patch Set 2: Code-

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload

2023-05-04 Thread pespin
Attention is currently required from: jolly, neels, laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload .

[S] Change in osmo-sgsn[master]: gprs_sm.c: Fix load of misaligned ptr address

2023-05-04 Thread daniel
Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32578 ) Change subject: gprs_sm.c: Fix load of misaligned ptr address .. Patch Set 1: Code-Rev

[S] Change in libosmo-gprs[master]: gmm: Fix false positive compilation error with gcc 13.1.1

2023-05-04 Thread fixeria
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32608 ) Change subject: gmm: Fix false positive compilation error with gcc 13.1.1 ..

[S] Change in libosmo-gprs[master]: gmm: Fix false positive compilation error with gcc 13.1.1

2023-05-04 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32608 ) Change subject: gmm: Fix false positive compilation error with gcc 13.1.1 .. gmm: Fix false positive compilation error with gcc 13.1.1 Newe

[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs...

2023-05-04 Thread lynxis lazus
Attention is currently required from: laforge, pespin, msuraev. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 ) Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...

[L] Change in osmo-hlr[master]: Add support for multiple APN profiles for subscriber data

2023-05-04 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data .. Patch Set 5: This change is ready for review. --

[S] Change in osmo-sgsn[master]: gprs_sm.c: Fix load of misaligned ptr address

2023-05-04 Thread lynxis lazus
Attention is currently required from: neels, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32578 ) Change subject: gprs_sm.c: Fix load of misaligned ptr address .. Patch Se

[S] Change in osmo-ttcn3-hacks[master]: gbproxy: Reduce timeout to fix flaky test

2023-05-04 Thread lynxis lazus
Attention is currently required from: daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32570 ) Change subject: gbproxy: Reduce timeout to fix flaky test .. Patch Set 1:

[M] Change in libosmocore[master]: ns2: Count transmitted/dropped in each layer implementation

2023-05-04 Thread lynxis lazus
Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32535 ) Change subject: ns2: Count transmitted/dropped in each layer implementation ..

[S] Change in osmo-iuh[master]: fix leak in ranap_new_transp_layer_addr()

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/32613 ) Change subject: fix leak in ranap_new_transp_layer_addr() .. fix leak in ranap_new_transp_layer_addr() Like BIT_STRING_fromBuf(), fre

[S] Change in osmo-hnbgw[master]: rab_ass_fsm.c: fix asn1 memleak when replacing GTP address

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32614 ) Change subject: rab_ass_fsm.c: fix asn1 memleak when replacing GTP address .. rab_ass_fsm.c: fix asn1 memleak when replacing GTP add

[S] Change in osmo-hnbgw[master]: ps_rab_ass_fsm.h: fix dup of FSM event enum

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32615 ) Change subject: ps_rab_ass_fsm.h: fix dup of FSM event enum .. ps_rab_ass_fsm.h: fix dup of FSM event enum Change-Id: I20d5fc6d52d0

[S] Change in osmo-hnbgw[master]: drop empty hnbgw_rua_init()

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32616 ) Change subject: drop empty hnbgw_rua_init() .. drop empty hnbgw_rua_init() Change-Id: I8e3ff452242d8baa527c2a61d182bbe9786341e3 ---

[S] Change in osmo-hnbgw[master]: eliminate function hnb_contexts()

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32617 ) Change subject: eliminate function hnb_contexts() .. eliminate function hnb_contexts() It's really just a bloated llist_count() wra

[L] Change in osmo-hnbgw[master]: move main() to separate file

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620 ) Change subject: move main() to separate file .. move main() to separate file Conform to recent osmocom practice by having an osmo_h

[S] Change in osmo-hnbgw[master]: ranap_rab_ass_test.c: clarify talloc contexts

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32619 ) Change subject: ranap_rab_ass_test.c: clarify talloc contexts .. ranap_rab_ass_test.c: clarify talloc contexts Change-Id: I4256e0d9

[M] Change in osmo-hnbgw[master]: add non-installed libhnbgw.la for test linkage

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621 ) Change subject: add non-installed libhnbgw.la for test linkage .. add non-installed libhnbgw.la for test linkage To ease linking C

[L] Change in osmo-hnbgw[master]: simplify: one g_hnbgw as global state and root ctx

2023-05-04 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 ) Change subject: simplify: one g_hnbgw as global state and root ctx .. Patch Set 1: (1 comment) File src/osmo-hnbgw/hnbgw_

[L] Change in osmo-hnbgw[master]: move main() to separate file

2023-05-04 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620 ) Change subject: move main() to separate file .. Patch Set 1: (2 comments) File src/osmo-hnbgw/osmo_hnbgw_main.c: Robot C

[S] Change in osmo-smlc[master]: ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)'

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/32622 ) Change subject: ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)' .. ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)' That is a copy-paste

[S] Change in osmo-hnbgw[master]: actually run vty-tests: osmotestconfig.py

2023-05-04 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32625 ) Change subject: actually run vty-tests: osmotestconfig.py .. actually run vty-tests: osmotestconfig.py Change-Id: Id60e5dfb22b7cea3

  1   2   >