[S] Change in pysim[master]: fileystem/tlv: remove unused imports

2024-01-02 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35479?usp=email ) Change subject: fileystem/tlv: remove unused imports .. fileystem/tlv: remove unused imports Change-Id:

[S] Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: Increase file Code splitting to decrease mem use

2024-01-02 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35478?usp=email ) Change subject: regen-makefile.sh: Increase file Code splitting to decrease mem use

[S] Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: Increase file Code splitting to decrease mem use

2024-01-02 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35478?usp=email ) Change subject: regen-makefile.sh: Increase file Code splitting to decrease mem use

[S] Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: Increase file Code splitting to decrease mem use

2024-01-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35478?usp=email ) Change subject: regen-makefile.sh: Increase file Code splitting to decrease mem use .. regen-makefile.sh:

[S] Change in osmo-ttcn3-hacks[master]: GTP_Emulation: SGSN_ContextRequest: Fix unconditional access to optio...

2024-01-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35477?usp=email ) Change subject: GTP_Emulation: SGSN_ContextRequest: Fix unconditional access to optional field IMSI ..

[S] Change in osmo-bsc[master]: ctrl: Add rach expiry timeout

2024-01-02 Thread matanp
matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35476?usp=email ) Change subject: ctrl: Add rach expiry timeout .. ctrl: Add rach expiry timeout Change-Id: I74a402a3800d245e4bc3052ccb53d8d2660e9f52

[S] Change in osmo-bsc[master]: ctrl: Add rach expiry timeout

2024-01-02 Thread matanp
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35476?usp=email ) Change subject: ctrl: Add rach expiry timeout .. Patch Set 1: Code-Review+2 -- To view, visit

[S] Change in osmo-bsc[master]: ctrl: Add rach expiry timeout

2024-01-02 Thread pespin
Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35476?usp=email ) Change subject: ctrl: Add rach expiry timeout .. Patch Set 1: Code-Review+1

[S] Change in osmo-bsc[master]: ctrl: Add rach expiry timeout

2024-01-02 Thread matanp
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35476?usp=email ) Change subject: ctrl: Add rach expiry timeout .. Set Ready For Review -- To view, visit

[S] Change in osmo-bsc[master]: ctrl: Add rach expiry timeout

2024-01-02 Thread matanp
matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35476?usp=email ) Change subject: ctrl: Add rach expiry timeout .. ctrl: Add rach expiry timeout Change-Id:

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2024-01-02 Thread pespin
Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2024-01-02 Thread pespin
Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2024-01-02 Thread Jenkins Builder
Attention is currently required from: laforge, neels, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2024-01-02 Thread dexter
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email to look at the new patch set (#6). The following approvals got outdated

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2024-01-02 Thread dexter
Attention is currently required from: laforge, neels, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in docker-playground[master]: ttcn3-mme: Set log level of open5gs-mmed to debug

2024-01-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35431?usp=email ) Change subject: ttcn3-mme: Set log level of open5gs-mmed to debug .. ttcn3-mme: Set log level of open5gs-mmed to debug INFO

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: Add missing template tr_NAS_EMMInformation

2024-01-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35408?usp=email ) Change subject: NAS_Templates: Add missing template tr_NAS_EMMInformation .. NAS_Templates: Add missing template

[S] Change in osmo-ttcn3-hacks[master]: DIAMETER_Templates: Add missing ts_AVP_DestinationHost

2024-01-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35406?usp=email ) Change subject: DIAMETER_Templates: Add missing ts_AVP_DestinationHost .. DIAMETER_Templates: Add missing

[M] Change in osmo-ttcn3-hacks[master]: DIAMETER_ts29_272_Templates: Add missing templates for CLR and CLA me...

2024-01-02 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35407?usp=email ) Change subject: DIAMETER_ts29_272_Templates: Add missing templates for CLR and CLA messages .. DIAMETER_ts29_272_Templates:

[S] Change in osmo-bsc[master]: abis_rsl: Add rach expiry timeout

2024-01-02 Thread matanp
matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email ) Change subject: abis_rsl: Add rach expiry timeout .. abis_rsl: Add rach expiry timeout This allows controlling the RACH DoS attack

[S] Change in osmo-bsc[master]: abis_rsl: Add rach expiry timeout

2024-01-02 Thread matanp
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email ) Change subject: abis_rsl: Add rach expiry timeout .. Patch Set 4: Code-Review+2 -- To view, visit

[S] Change in osmo-bsc[master]: abis_rsl: Add rach expiry timeout

2024-01-02 Thread pespin
Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email ) Change subject: abis_rsl: Add rach expiry timeout .. Patch Set 4:

[S] Change in libosmocore[master]: utils: osmo_bcd2str(): fix applying non-zero offset to null pointer

2024-01-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35470?usp=email ) Change subject: utils: osmo_bcd2str(): fix applying non-zero offset to null pointer

[S] Change in libosmocore[master]: tests/utils: do not test strbuf_example2() with buf=NULL

2024-01-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35471?usp=email ) Change subject: tests/utils: do not test strbuf_example2() with buf=NULL

[S] Change in libosmocore[master]: bitvec: bitvec_to_string_r(): drop unused variable

2024-01-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35472?usp=email ) Change subject: bitvec: bitvec_to_string_r(): drop unused variable ..

[S] Change in libosmocore[master]: {gsm,vty}: suppress warnings about [total_]len being set but not used

2024-01-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35473?usp=email ) Change subject: {gsm,vty}: suppress warnings about [total_]len being set but not used

[M] Change in pysim[master]: tlv: improve flatten_dict_lists for multiple keys

2024-01-02 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/35254?usp=email ) Change subject: tlv: improve flatten_dict_lists for multiple keys .. Abandoned There are problems with this (see last post from

[S] Change in osmo-bts[master]: l1sap: fix logic error in gsmtap_csd_rlp_process()

2024-01-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35468?usp=email ) Change subject: l1sap: fix logic error in gsmtap_csd_rlp_process() .. Patch

[S] Change in libosmocore[master]: pseudotalloc: add talloc_memdup(), use it in talloc_strdup()

2024-01-02 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email ) Change subject: pseudotalloc: add talloc_memdup(), use it in talloc_strdup()

[M] Change in libosmocore[master]: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision

2024-01-02 Thread pespin
Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email ) Change subject: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision

[M] Change in libosmocore[master]: tests/tdef: also test OSMO_TDEF_US and negative T values

2024-01-02 Thread fixeria
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email ) Change subject: tests/tdef: also test OSMO_TDEF_US and negative T values

[S] Change in libosmocore[master]: tests/tdef: tune logging, also match stderr

2024-01-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35469?usp=email ) Change subject: tests/tdef: tune logging, also match stderr .. Patch Set

[M] Change in libosmocore[master]: tests/tdef: also test OSMO_TDEF_US and negative T values

2024-01-02 Thread pespin
Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email ) Change subject: tests/tdef: also test OSMO_TDEF_US and negative T values

[L] Change in libosmocore[master]: tests/{gb,iuup}: also match stderr

2024-01-02 Thread pespin
Attention is currently required from: daniel, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35464?usp=email ) Change subject: tests/{gb,iuup}: also match stderr .. Patch Set

[M] Change in osmo-mgw[master]: drop cfg 'sdp audio fmtp-extra'

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35437?usp=email ) Change subject: drop cfg 'sdp audio fmtp-extra' .. Patch Set 5: Code-Review+2

[S] Change in osmo-mgw[master]: drop get_net_downlink_format_cb

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35436?usp=email ) Change subject: drop get_net_downlink_format_cb .. Patch Set 4: Code-Review+2

[S] Change in osmo-mgw[master]: tests/mgcp: add update_exp target

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35435?usp=email ) Change subject: tests/mgcp: add update_exp target .. Patch Set 4:

[S] Change in osmo-mgw[master]: mgcp_codec_decide: remove redundant lookup

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35301?usp=email ) Change subject: mgcp_codec_decide: remove redundant lookup .. Patch Set 5:

[S] Change in osmo-mgw[master]: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically

2024-01-02 Thread pespin
Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email ) Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically

[S] Change in osmo-mgw[master]: mgw: do not fail MGCP on codec mismatch

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email ) Change subject: mgw: do not fail MGCP on codec mismatch .. Patch Set 5: (1

[M] Change in osmo-mgw[master]: add fmtp.h

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35434?usp=email ) Change subject: add fmtp.h .. Patch Set 4: (6 comments) Commit Message:

[S] Change in osmo-mgw[master]: build: move mgcp/*.h to noinst_HEADERS, drop RPM libosmo-mgcp-devel

2024-01-02 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35433?usp=email ) Change subject: build: move mgcp/*.h to noinst_HEADERS, drop RPM libosmo-mgcp-devel

[S] Change in osmo-bsc[master]: abis_rsl: Add rach expiry timeout

2024-01-02 Thread fixeria
Attention is currently required from: matanp. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35475?usp=email ) Change subject: abis_rsl: Add rach expiry timeout .. Patch Set 4: