[S] Change in osmocom-bb[master]: l1gprs: minor changes to l1gprs_handle_rts_ind()

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35776?usp=email ) Change subject: l1gprs: minor changes to l1gprs_handle_rts_ind() .. Patch

[M] Change in osmocom-bb[master]: l1gprs: implement UL BLOCK.cnf (L1CTL_GPRS_UL_BLOCK_CNF)

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35777?usp=email ) Change subject: l1gprs: implement UL BLOCK.cnf (L1CTL_GPRS_UL_BLOCK_CNF) ..

[S] Change in osmocom-bb[master]: trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35778?usp=email ) Change subject: trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH ..

[S] Change in osmocom-bb[master]: trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35778?usp=email ) Change subject: trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH ..

[S] Change in osmocom-bb[master]: layer23: cosmetic: clarify GPRS related L1CTL logging

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35779?usp=email ) Change subject: layer23: cosmetic: clarify GPRS related L1CTL logging .. P

[M] Change in osmo-sgsn[master]: ctrl: Add ctrl trap on PDP Context changes

2024-02-02 Thread matanp
matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35781?usp=email ) Change subject: ctrl: Add ctrl trap on PDP Context changes .. ctrl: Add ctrl trap on PDP Context changes This change allo

[M] Change in osmo-sgsn[master]: ctrl: Add ctrl trap on PDP Context changes

2024-02-02 Thread matanp
matanp has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35781?usp=email ) Change subject: ctrl: Add ctrl trap on PDP Context changes .. Abandoned To similar to CDR CTRL -- To view, visit https://gerrit.osm

[M] Change in libosmo-gprs[master]: rlcmac: Add new structure to allow passing FN+TN to TBF handling func...

2024-02-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email ) Change subject: rlcmac: Add new structure to allow passing FN+TN to TBF handling functions .. rlcmac: Add new structur

[M] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM

2024-02-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35783?usp=email ) Change subject: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM .. rlcmac: ul_tbf: Register UL ACK/NACK poll insid

[S] Change in libosmo-gprs[master]: rlcmac: add definition for OSMO_GPRS_RLCMAC_L1CTL_PDCH_DATA | Cnf

2024-02-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35774?usp=email ) Change subject: rlcmac: add definition for OSMO_GPRS_RLCMAC_L1CTL_PDCH_DATA | Cnf .. Patch Set 3: This change is ready

[M] Change in libosmo-gprs[master]: Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted

2024-02-02 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35775?usp=email ) Change subject: Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted .. Patch Set 3: This change is read

[M] Change in osmocom-bb[master]: layer23/modem: handle and forward L1CTL UL BLOCK.cnf

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35780?usp=email ) Change subject: layer23/modem: handle and forward L1CTL UL BLOCK.cnf .. Pa

[S] Change in osmocom-bb[master]: apn_fsm: Set default timeout for APN activation to 65s

2024-02-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35784?usp=email ) Change subject: apn_fsm: Set default timeout for APN activation to 65s .. apn_fsm: Set default timeout for APN activation

[S] Change in osmocom-bb[master]: modem: Improve logging when forwarding data to GRR

2024-02-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35785?usp=email ) Change subject: modem: Improve logging when forwarding data to GRR .. modem: Improve logging when forwarding data to GRR

[S] Change in libosmo-gprs[master]: rlcmac: Implement RLC_OCTET_COUNT in DL ACK/NACK

2024-02-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35786?usp=email ) Change subject: rlcmac: Implement RLC_OCTET_COUNT in DL ACK/NACK .. rlcmac: Implement RLC_OCTET_COUNT in DL ACK/NACK T

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong parenthesis around macro

2024-02-02 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35787?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong parenthesis around macro .. rlcmac: tbf_ul: Fix wrong parenthesis around macr

[S] Change in libosmo-gprs[master]: rlcmac: Implement RLC_OCTET_COUNT in DL ACK/NACK

2024-02-02 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35786?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: rlcmac: Implement RLC

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35788?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1() .. mobile: fix -Wmaybe-uninitialized in t

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong parenthesis around macro

2024-02-02 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35787?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong parenthesis around macro .. Pa

[M] Change in libosmo-gprs[master]: rlcmac: Add new structure to allow passing FN+TN to TBF handling func...

2024-02-02 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email ) Change subject: rlcmac: Add new structure to allow passing FN+TN to TBF handling functions ..

[M] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM

2024-02-02 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35783?usp=email ) Change subject: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM ..

[S] Change in osmo-bsc[master]: abis_nm: fix -Wunused-but-set-variable (bug)

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35791?usp=email ) Change subject: abis_nm: fix -Wunused-but-set-variable (bug) .. abis_nm: fix -Wunused-but-set-variable (bug) clang warns

[S] Change in osmo-bsc[master]: lchan_fsm: fix -Wgnu-designator warnings printed by clang

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35790?usp=email ) Change subject: lchan_fsm: fix -Wgnu-designator warnings printed by clang .. lchan_fsm: fix -Wgnu-designator warnings prin

[S] Change in osmo-bsc[master]: bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_install()

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35789?usp=email ) Change subject: bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_install() .. bsc_ctrl: do not overwrite rc in bsc_base

[S] Change in osmo-bsc[master]: Add support for M3UA-over-TCP, clarify default SCTP

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35792?usp=email ) Change subject: Add support for M3UA-over-TCP, clarify default SCTP .. Add support for M3UA-over-TCP, clarify default SCTP

[L] Change in pysim[master]: Introduce GlobalPlatform SCP02 implementation

2024-02-02 Thread laforge
Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35462?usp=email to look at the new patch set (#7). The following approvals got outdated and were rem

[S] Change in pysim[master]: global_platform: Add install_for_personalization command

2024-02-02 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35771?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builde

[M] Change in pysim[master]: SCP02: Only C-MAC/C-ENCRYPT APDUs whose CLA byte indicates GlobalPlat...

2024-02-02 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35769?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builde

[M] Change in pysim[master]: global_platform: add set_status command

2024-02-02 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35772?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builde

[L] Change in pysim[master]: WIP: Implement Global Platform SCP03

2024-02-02 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35793?usp=email ) Change subject: WIP: Implement Global Platform SCP03 .. WIP: Implement Global Platform SCP03 Change-Id: Ibc35af5474923aed2e3

[M] Change in pysim[master]: global_platform: implement GET STATUS command

2024-02-02 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35756?usp=email ) Change subject: global_platform: implement GET STATUS command .. Patch

[M] Change in pysim[master]: commands.py: Wrap the transport send_apdu* methods

2024-02-02 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35762?usp=email ) Change subject: commands.py: Wrap the transport send_apdu* methods ..

[S] Change in pysim[master]: move global_platform.py to global_platform/__init__.py

2024-02-02 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35763?usp=email ) Change subject: move global_platform.py to global_platform/__init__.py .

[M] Change in pysim[master]: commands.py: Wrap the transport send_apdu* methods

2024-02-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35762?usp=email ) Change subject: commands.py: Wrap the transport send_apdu* methods .. commands.py: Wrap the transport send_apdu* methods Let's not have

[M] Change in pysim[master]: global_platform: implement GET STATUS command

2024-02-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35756?usp=email ) Change subject: global_platform: implement GET STATUS command .. global_platform: implement GET STATUS command The GlobalPlatform GET S

[S] Change in pysim[master]: move global_platform.py to global_platform/__init__.py

2024-02-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35763?usp=email ) Change subject: move global_platform.py to global_platform/__init__.py .. move global_platform.py to global_platform/__init__.py This w

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()

2024-02-02 Thread laforge
Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35788?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()

[S] Change in osmocom-bb[master]: l1gprs: minor changes to l1gprs_handle_rts_ind()

2024-02-02 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35776?usp=email ) Change subject: l1gprs: minor changes to l1gprs_handle_rts_ind() .. Patch

[S] Change in osmocom-bb[master]: layer23: cosmetic: clarify GPRS related L1CTL logging

2024-02-02 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35779?usp=email ) Change subject: layer23: cosmetic: clarify GPRS related L1CTL logging ..

[S] Change in osmo-bsc[master]: bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_install()

2024-02-02 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35789?usp=email ) Change subject: bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_install() ...

[S] Change in osmo-bsc[master]: lchan_fsm: fix -Wgnu-designator warnings printed by clang

2024-02-02 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35790?usp=email ) Change subject: lchan_fsm: fix -Wgnu-designator warnings printed by clang ..

[S] Change in osmo-bsc[master]: abis_nm: fix -Wunused-but-set-variable (bug)

2024-02-02 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35791?usp=email ) Change subject: abis_nm: fix -Wunused-but-set-variable (bug) .. Patch Set 1

[S] Change in osmo-bsc[master]: bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_install()

2024-02-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35789?usp=email ) Change subject: bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_install() .. bsc_ctrl: do not overwrite rc in bsc_base_ctrl_cmds_

[S] Change in osmo-bsc[master]: lchan_fsm: fix -Wgnu-designator warnings printed by clang

2024-02-02 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35790?usp=email ) Change subject: lchan_fsm: fix -Wgnu-designator warnings printed by clang .. lchan_fsm: fix -Wgnu-designator warnings printed by clan

[S] Change in osmo-bsc[master]: Add support for M3UA-over-TCP, clarify default SCTP

2024-02-02 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35792?usp=email ) Change subject: Add support for M3UA-over-TCP, clarify default SCTP .. Patc

[S] Change in osmo-bsc[master]: Add support for M3UA-over-TCP, clarify default SCTP

2024-02-02 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35792?usp=email ) Change subject: Add support for M3UA-over-TCP, clarify default SCTP .. Patc

[M] Change in libosmo-gprs[master]: rlcmac: Add new structure to allow passing FN+TN to TBF handling func...

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email ) Change subject: rlcmac: Add new structure to allow passing FN+TN to TBF handling functions ..

[M] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35783?usp=email ) Change subject: rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM ..

[S] Change in osmocom-bb[master]: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35788?usp=email ) Change subject: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1() .

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong parenthesis around macro

2024-02-02 Thread pespin
Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35787?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by

[M] Change in libosmo-gprs[master]: rlcmac: Add new structure to allow passing FN+TN to TBF handling func...

2024-02-02 Thread pespin
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins

[S] Change in osmo-bsc[master]: abis_nm: fix -Wunused-but-set-variable (bug)

2024-02-02 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/35791?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Bui

[S] Change in osmo-bsc[master]: abis_nm: misc/cosmetic changes to abis_nm_sw_act_req_ack()

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35794?usp=email ) Change subject: abis_nm: misc/cosmetic changes to abis_nm_sw_act_req_ack() .. abis_nm: misc/cosmetic changes to abis_nm_sw

[S] Change in osmo-bsc[master]: abis_nm: fix -Wunused-but-set-variable (bug)

2024-02-02 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35791?usp=email ) Change subject: abis_nm: fix -Wunused-but-set-variable (bug) .. Patch Set 1

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) .. Implement M3UA-over-TCP (in addition to SCTP) RFC 46

[M] Change in libosmo-sccp[master]: cosmetic: rename OSMO_SS7_ASP_PROT_M3UA[_SCTP]

2024-02-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35795?usp=email ) Change subject: cosmetic: rename OSMO_SS7_ASP_PROT_M3UA[_SCTP] .. cosmetic: rename OSMO_SS7_ASP_PROT_M3UA[_SCTP] This

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)

2024-02-02 Thread fixeria
Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ..

[S] Change in osmo-bsc[master]: abis_nm: misc/cosmetic changes to abis_nm_sw_act_req_ack()

2024-02-02 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35794?usp=email ) Change subject: abis_nm: misc/cosmetic changes to abis_nm_sw_act_req_ack() ..

[S] Change in osmo-bsc[master]: abis_nm: fix -Wunused-but-set-variable (bug)

2024-02-02 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35791?usp=email ) Change subject: abis_nm: fix -Wunused-but-set-variable (bug) .. Pat

[M] Change in libosmo-sccp[master]: cosmetic: rename OSMO_SS7_ASP_PROT_M3UA[_SCTP]

2024-02-02 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35795?usp=email ) Change subject: cosmetic: rename OSMO_SS7_ASP_PROT_M3UA[_SCTP] ..

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)

2024-02-02 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ..