Re: Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

2020-01-19 Thread Harald Welte
owed in this PLMN" > in the vty configuration? I would prefer "GMM_CAUSE_NO_GPRS_PLMN". I would prefer something like "no-gprs-plmn" or NO_GPRS_PLMN. The first would be the most natural from the vty perspective. -- -

Change in ...osmo-msc[master]: db_sms_test: Remove libdbi expected driver load errors

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14362 ) Change subject: db_sms_test: Remove libdbi expected driver load errors .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: debian/control: add missing libdbd-sqlite3 to Build-Depends

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14380 ) Change subject: debian/control: add missing libdbd-sqlite3 to Build-Depends .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-bts[master]: Use #define RSL_CHAN_RACH for RSL Channel Number of RACH

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14381 ) Change subject: Use #define RSL_CHAN_RACH for RSL Channel Number of RACH .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-msc[master]: debian/control: add missing libdbd-sqlite3 to Build-Depends

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14380 ) Change subject: debian/control: add missing libdbd-sqlite3 to Build-Depends .. debian/control: add missing libdbd

Change in ...osmo-bts[master]: Use #define RSL_CHAN_RACH for RSL Channel Number of RACH

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14381 ) Change subject: Use #define RSL_CHAN_RACH for RSL Channel Number of RACH .. Use #define RSL_CHAN_RACH for RSL Channel

Change in ...libosmocore[master]: fsm: Reduce amount of copy+pasted LOGPFSMSRC() statements

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14363 ) Change subject: fsm: Reduce amount of copy+pasted LOGPFSMSRC() statements .. fsm: Reduce amount of copy+pasted

Change in ...libosmocore[master]: lapdm: Allow user to specify T200 values; Use correct N200 values

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14339 ) Change subject: lapdm: Allow user to specify T200 values; Use correct N200 values .. lapdm: Allow user to specify

Change in ...libosmocore[master]: fsm: Allow millisecond granularity in osmo_fsm built-in timer

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14200 ) Change subject: fsm: Allow millisecond granularity in osmo_fsm built-in timer .. Patch Set 7: Code-Review+2 -- To view

Change in ...libosmocore[master]: fsm: Reduce amount of copy+pasted LOGPFSMSRC() statements

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14363 ) Change subject: fsm: Reduce amount of copy+pasted LOGPFSMSRC() statements .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: fsm: Allow millisecond granularity in osmo_fsm built-in timer

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14200 ) Change subject: fsm: Allow millisecond granularity in osmo_fsm built-in timer .. fsm: Allow millisecond granularity

Change in ...libosmocore[master]: lapd_core: Perform N200 retransmissions, not N200-1

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14347 ) Change subject: lapd_core: Perform N200 retransmissions, not N200-1 .. lapd_core: Perform N200 retransmissions, not

Change in ...libosmocore[master]: lapdm: Allow user to specify T200 values; Use correct N200 values

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14339 ) Change subject: lapdm: Allow user to specify T200 values; Use correct N200 values .. Patch Set 4: Code-Review+2 -- To

Change in ...libosmocore[master]: lapd_core: Perform N200 retransmissions, not N200-1

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14347 ) Change subject: lapd_core: Perform N200 retransmissions, not N200-1 .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: bts: Check if BTS_TRXC port is mapped before attempting UDP socket co...

2019-06-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14379 ) Change subject: bts: Check if BTS_TRXC port is mapped before attempting UDP socket connect .. bts: Check if

Change in ...osmo-ttcn3-hacks[master]: bts: Check if BTS_TRXC port is mapped before attempting UDP socket co...

2019-06-05 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14379 ) Change subject: bts: Check if BTS_TRXC port is mapped before attempting UDP socket connect .. Patch Set 1: Code-Review

Change in ...osmo-ttcn3-hacks[master]: bts: Check if BTS_TRXC port is mapped before attempting UDP socket co...

2019-06-05 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14379 Change subject: bts: Check if BTS_TRXC port is mapped before attempting UDP socket connect .. bts: Check if BTS_TRXC

Change in ...libosmocore[master]: lapdm: Allow user to specify T200 values; Use correct N200 values

2019-06-04 Thread Harald Welte
-Branch: master Gerrit-Change-Id: I90fdc4dd4720d4e02213197c894eb0a55a39158c Gerrit-Change-Number: 14339 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: libmsc/db.c: get rid of hard-coded SMS expiry threshold

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13631 ) Change subject: libmsc/db.c: get rid of hard-coded SMS expiry threshold .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: libmsc/db.c: introduce and use parse_sm_ud_from_result()

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13488 ) Change subject: libmsc/db.c: introduce and use parse_sm_ud_from_result() .. Patch Set 7: Code-Review+1 -- To view, visit

Change in ...osmo-msc[master]: libmsc/db.c: warn user about SMS text truncation

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13489 ) Change subject: libmsc/db.c: warn user about SMS text truncation .. Patch Set 7: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: libmsc/db.c: fix potential integer overflow

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13470 ) Change subject: libmsc/db.c: fix potential integer overflow .. Patch Set 9: Code-Review+2 -- To view, visit https

Change in ...osmo-sgsn[master]: osmo-sgsn: add VTY parameter to toggle authentication

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14194 ) Change subject: osmo-sgsn: add VTY parameter to toggle authentication .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-sgsn[master]: doc/manuals/vty: regenerate sgsn_vty_reference.xml

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14377 ) Change subject: doc/manuals/vty: regenerate sgsn_vty_reference.xml .. doc/manuals/vty: regenerate

Change in ...osmo-sgsn[master]: doc/manuals/vty: regenerate sgsn_vty_reference.xml

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14377 ) Change subject: doc/manuals/vty: regenerate sgsn_vty_reference.xml .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 ) Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler .. Patch Set 2: Code-Review+1 -- To v

Change in ...osmo-ttcn3-hacks[master]: bts: Add LAPDm test for SABM with wrong C/R bit

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14378 ) Change subject: bts: Add LAPDm test for SABM with wrong C/R bit .. bts: Add LAPDm test for SABM with wrong C/R

Change in ...osmo-ttcn3-hacks[master]: bts: Add test csse for I frame with wrong C/R value

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14350 ) Change subject: bts: Add test csse for I frame with wrong C/R value .. bts: Add test csse for I frame with

Change in ...osmo-ttcn3-hacks[master]: bts: Add LAPDm test for SABM with wrong C/R bit

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14378 ) Change subject: bts: Add LAPDm test for SABM with wrong C/R bit .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: bts: Add test csse for I frame with wrong C/R value

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14350 ) Change subject: bts: Add test csse for I frame with wrong C/R value .. Patch Set 4: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bts: Add LAPDm test for SABM with wrong C/R bit

2019-06-04 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14378 Change subject: bts: Add LAPDm test for SABM with wrong C/R bit .. bts: Add LAPDm test for SABM with wrong C/R bit Test

Change in ...osmo-ttcn3-hacks[master]: bts: Add test csse for I frame with wrong C/R value

2019-06-04 Thread Harald Welte
ge-Id: I19e50049625bd31662a1e22b1394b69b2d249104 Gerrit-Change-Number: 14350 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-ggsn[master]: ggsn: vty: Require ggsn param in cmd

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14298 ) Change subject: ggsn: vty: Require ggsn param in cmd .. ggsn: vty: Require ggsn param in cmd Other similar commands

Change in ...osmo-ggsn[master]: sgsnemu: Replace use of deprecated libgtp API pdp_newpdp with new one

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14299 ) Change subject: sgsnemu: Replace use of deprecated libgtp API pdp_newpdp with new one .. sgsnemu: Replace use of

Change in ...osmo-ggsn[master]: ggsn_vty_reference.xml: Update from last code changes

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14358 ) Change subject: ggsn_vty_reference.xml: Update from last code changes .. ggsn_vty_reference.xml: Update from last code

Change in ...osmo-ggsn[master]: gtp: Make use of new libgtp APIs with multi-gsn support

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14297 ) Change subject: gtp: Make use of new libgtp APIs with multi-gsn support .. gtp: Make use of new libgtp APIs with multi

Change in ...osmo-ggsn[master]: gtp: Introduce new pdp APIs (and deprecate old ones) to support multi...

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14296 ) Change subject: gtp: Introduce new pdp APIs (and deprecate old ones) to support multiple GSN .. Patch Set 3: Code-Review+2

Change in ...osmo-ggsn[master]: gtp: Make use of new libgtp APIs with multi-gsn support

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14297 ) Change subject: gtp: Make use of new libgtp APIs with multi-gsn support .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-ggsn[master]: sgsnemu: Replace use of deprecated libgtp API pdp_newpdp with new one

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14299 ) Change subject: sgsnemu: Replace use of deprecated libgtp API pdp_newpdp with new one .. Patch Set 4: Code-Review+2 -- To

Change in ...osmo-ggsn[master]: ggsn: vty: Require ggsn param in cmd

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14298 ) Change subject: ggsn: vty: Require ggsn param in cmd .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in ...osmo-ggsn[master]: gtp: Introduce new pdp APIs (and deprecate old ones) to support multi...

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14296 ) Change subject: gtp: Introduce new pdp APIs (and deprecate old ones) to support multiple GSN .. gtp: Introduce new

Change in ...osmo-ggsn[master]: ggsn_vty_reference.xml: Update from last code changes

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14358 ) Change subject: ggsn_vty_reference.xml: Update from last code changes .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix name of f_trx_fake_toffs256()

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14371 ) Change subject: BTS_Tests.ttcn: fix name of f_trx_fake_toffs256() .. BTS_Tests.ttcn: fix name of

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: correct error messages about TRXC connection

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14369 ) Change subject: BTS_Tests.ttcn: correct error messages about TRXC connection .. BTS_Tests.ttcn: correct error

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14370 ) Change subject: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr .. BTS_Tests.ttcn: fix TRXC

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14375 ) Change subject: BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX .. BTS_Tests.ttcn: indicate default RSSI

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14370 ) Change subject: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr .. Patch Set 2: Code-Review+2

Change in ...docker-playground[master]: ttcn3-bts-tests: Add BTS_Tests_LAPDm.control to config file

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14376 ) Change subject: ttcn3-bts-tests: Add BTS_Tests_LAPDm.control to config file .. Patch Set 1: Verified+1 Code-Review+2

Change in ...docker-playground[master]: ttcn3-bts-tests: Add BTS_Tests_LAPDm.control to config file

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14376 ) Change subject: ttcn3-bts-tests: Add BTS_Tests_LAPDm.control to config file .. ttcn3-bts-tests: Add

Change in ...osmo-bts[master]: bts-trx: trx_if.c: Introduce logging macro LOGPPHI

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14373 ) Change subject: bts-trx: trx_if.c: Introduce logging macro LOGPPHI .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: bts-trx: trx_if.c: Introduce logging macro LOGPPHI

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14373 ) Change subject: bts-trx: trx_if.c: Introduce logging macro LOGPPHI .. bts-trx: trx_if.c: Introduce logging macro

Change in ...osmo-ggsn[master]: gtp: Make use of new libgtp APIs with multi-gsn support

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14297 ) Change subject: gtp: Make use of new libgtp APIs with multi-gsn support .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...docker-playground[master]: ttcn3-bts-tests: Add BTS_Tests_LAPDm.control to config file

2019-06-04 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14376 Change subject: ttcn3-bts-tests: Add BTS_Tests_LAPDm.control to config file .. ttcn3-bts-tests: Add

Change in ...osmo-bts[master]: l1sap: Compute statistics on FN advance in PH-RTS.ind

2019-06-04 Thread Harald Welte
ng mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f739fdb808a614f080afbc4654641ec3df19eb2 Gerrit-Change-Number: 14336 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: common/scheduler.c: refactor description of TRXC_* lchans

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14322 ) Change subject: common/scheduler.c: refactor description of TRXC_* lchans .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: gsm0808_utils: Add gsm0808_decode_cell_id_u()

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/13888 ) Change subject: gsm0808_utils: Add gsm0808_decode_cell_id_u() .. gsm0808_utils: Add gsm0808_decode_cell_id_u() This

Change in ...libosmocore[master]: gsm0808_utils: Add gsm0808_decode_cell_id_u()

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13888 ) Change subject: gsm0808_utils: Add gsm0808_decode_cell_id_u() .. Patch Set 5: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14375 ) Change subject: BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-trx[master]: lms: Fix stream_stats checks with overrun/underrun

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14368 ) Change subject: lms: Fix stream_stats checks with overrun/underrun .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-trx[master]: lms: Drop unusued variable masterClockRate

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14367 ) Change subject: lms: Drop unusued variable masterClockRate .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-trx[master]: Rename and move STOP signal from Transceiver to main

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14366 ) Change subject: Rename and move STOP signal from Transceiver to main .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-trx[master]: Add rate_ctr support to store/retrieve SDR errors through VTY

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14167 ) Change subject: Add rate_ctr support to store/retrieve SDR errors through VTY .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 ) Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages .. Patch Set 2: (1 comment

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix name of f_trx_fake_toffs256()

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14371 ) Change subject: BTS_Tests.ttcn: fix name of f_trx_fake_toffs256() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: correct error messages about TRXC connection

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14369 ) Change subject: BTS_Tests.ttcn: correct error messages about TRXC connection .. Patch Set 1: Code-Review+2 -- To view

Change in ...osmo-bts[master]: bts-trx: trx_if.c: Introduce logging macro LOGPL1H

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14373 ) Change subject: bts-trx: trx_if.c: Introduce logging macro LOGPL1H .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: do not override LD_LIBRARY_PATH

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14374 ) Change subject: start-testsuite.sh: do not override LD_LIBRARY_PATH .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ggsn[master]: gtp: Replace old pdp APIs with new ones with multi-gsn support

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14297 ) Change subject: gtp: Replace old pdp APIs with new ones with multi-gsn support .. Patch Set 2: > > Patch

Change in ...libosmocore[master]: fsm: Allow millisecond granularity in osmo_fsm built-in timer

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14200 ) Change subject: fsm: Allow millisecond granularity in osmo_fsm built-in timer .. Set Ready For Review -- To view, visit

Change in ...libosmocore[master]: fsm: Reduce amount of copy+pasted LOGPFSMSRC() statements

2019-06-04 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14363 Change subject: fsm: Reduce amount of copy+pasted LOGPFSMSRC() statements .. fsm: Reduce amount of copy+pasted LOGPFSMSRC

Change in ...osmo-msc[master]: db_sms_test: Do not print exact memcmp result

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14357 ) Change subject: db_sms_test: Do not print exact memcmp result .. db_sms_test: Do not print exact memcmp result man

Change in ...osmo-msc[master]: db_sms_test: Do not print exact memcmp result

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14357 ) Change subject: db_sms_test: Do not print exact memcmp result .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: bts: Extend LAPDm test suite with a number of new tests

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14341 ) Change subject: bts: Extend LAPDm test suite with a number of new tests .. Patch Set 4: Code-Review+2 -- To view

Change in ...osmo-ttcn3-hacks[master]: bts: Factor out mobile-originated LAPDm establishment

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14348 ) Change subject: bts: Factor out mobile-originated LAPDm establishment .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bts: Implement testcase for RR response frame loss

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14349 ) Change subject: bts: Implement testcase for RR response frame loss .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bts: Implement testcase for RR response frame loss

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14349 ) Change subject: bts: Implement testcase for RR response frame loss .. bts: Implement testcase for RR response

Change in ...osmo-ttcn3-hacks[master]: bts: Add test for expiring T200 N200+1 times

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14346 ) Change subject: bts: Add test for expiring T200 N200+1 times .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: RSL_Types: Fix definition of RLL ERROR INDICATION

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14345 ) Change subject: RSL_Types: Fix definition of RLL ERROR INDICATION .. RSL_Types: Fix definition of RLL ERROR

Change in ...osmo-ttcn3-hacks[master]: bts: Add test for expiring T200 N200+1 times

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14346 ) Change subject: bts: Add test for expiring T200 N200+1 times .. bts: Add test for expiring T200 N200+1 times

Change in ...osmo-ttcn3-hacks[master]: bts: Add TC_segm_concat to test segmentation+concatenation

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14342 ) Change subject: bts: Add TC_segm_concat to test segmentation+concatenation .. bts: Add TC_segm_concat to test

Change in ...osmo-msc[master]: db_sms_test: Remove libdbi expected driver load errors

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14356 ) Change subject: db_sms_test: Remove libdbi expected driver load errors .. Patch Set 1: the problem with mixing stderr and

Change in ...osmo-ttcn3-hacks[master]: bts: Also test SACCH in TC_segm_concat

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14343 ) Change subject: bts: Also test SACCH in TC_segm_concat .. bts: Also test SACCH in TC_segm_concat Change-Id

Change in ...osmo-ttcn3-hacks[master]: bts: Add TC_segm_concat to test segmentation+concatenation

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14342 ) Change subject: bts: Add TC_segm_concat to test segmentation+concatenation .. Patch Set 4: Code-Review+2 -- To view

Change in ...osmo-ttcn3-hacks[master]: bts: Extend LAPDm test suite with a number of new tests

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14341 ) Change subject: bts: Extend LAPDm test suite with a number of new tests .. bts: Extend LAPDm test suite with a

Change in ...osmo-ttcn3-hacks[master]: bts: Factor out mobile-originated LAPDm establishment

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14348 ) Change subject: bts: Factor out mobile-originated LAPDm establishment .. bts: Factor out mobile-originated

Change in ...osmo-ttcn3-hacks[master]: bts: Also test SACCH in TC_segm_concat

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14343 ) Change subject: bts: Also test SACCH in TC_segm_concat .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: db_sms_test: Remove libdbi expected driver load errors

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14356 ) Change subject: db_sms_test: Remove libdbi expected driver load errors .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-ggsn[master]: gtp: Replace old pdp APIs with new ones with multi-gsn support

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14297 ) Change subject: gtp: Replace old pdp APIs with new ones with multi-gsn support .. Patch Set 2: this is about replacing API

Change in ...libosmocore[master]: gsm0808_utils: Add gsm0808_decode_cell_id_u()

2019-06-04 Thread Harald Welte
lp writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I08b33881667aa32f01e53ccb70d44d5b79c7c986 Gerrit-Change-Number: 13888 Gerrit-PatchSet: 5 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-CC:

Change in ...libosmocore[master]: make use of OTC_GLOBAL when allocating library-internal contexts

2019-06-04 Thread Harald Welte
ter Gerrit-Change-Id: I48f475efd3ee0d5120b8fc30861e852d1a6920b1 Gerrit-Change-Number: 13338 Gerrit-PatchSet: 9 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset

Change in ...libosmocore[master]: make all library-internal static buffers thread-local

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/13436 ) Change subject: make all library-internal static buffers thread-local .. make all library-internal static buffers

Change in ...libosmocore[master]: make all library-internal static buffers thread-local

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13436 ) Change subject: make all library-internal static buffers thread-local .. Patch Set 9: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: make all library-internal static buffers thread-local

2019-06-04 Thread Harald Welte
ilters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50eb2436a7c1261d79a9d2955584dce92780ca07 Gerrit-Change-Number: 13436 Gerrit-PatchSet: 9 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: Max

Change in ...libosmocore[master]: fsm.c: Print error message for FSM with allstate_action but no events

2019-06-04 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14361 Change subject: fsm.c: Print error message for FSM with allstate_action but no events .. fsm.c: Print error message for FSM

Change in ...libosmocore[master]: make all library-internal static buffers thread-local

2019-06-04 Thread Harald Welte
ilters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50eb2436a7c1261d79a9d2955584dce92780ca07 Gerrit-Change-Number: 13436 Gerrit-PatchSet: 8 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: Max

Change in ...osmo-ggsn[master]: ggsn: Fix undefined behaviour shifting beyond sign bit

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14287 ) Change subject: ggsn: Fix undefined behaviour shifting beyond sign bit .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-ggsn[master]: ggsn: Fix undefined behaviour shifting beyond sign bit

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14287 ) Change subject: ggsn: Fix undefined behaviour shifting beyond sign bit .. ggsn: Fix undefined behaviour shifting

Change in ...osmo-ttcn3-hacks[master]: sgsn: Add tests to check GTP retransmit queue

2019-06-04 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14262 ) Change subject: sgsn: Add tests to check GTP retransmit queue .. sgsn: Add tests to check GTP retransmit queue

Change in ...osmo-ggsn[master]: ggsn_vty_reference.xml: Update from last code changes

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14358 ) Change subject: ggsn_vty_reference.xml: Update from last code changes .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: sgsn: Add tests to check GTP retransmit queue

2019-06-04 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14262 ) Change subject: sgsn: Add tests to check GTP retransmit queue .. Patch Set 1: Code-Review+2 -- To view, visit https

  1   2   3   4   5   6   7   8   9   10   >