[PATCH] osmo-msc[master]: VLR tests: add simple LU generator

2018-02-15 Thread Max
ac); + + /* classmark 1 */ + gsm48_encode_classmark1(&nlu->classmark1, rev_lv, es_ind, a5_1, pwr_lv); + + /* MI */ + if (imsi) + gsm48_generate_mid(buf, imsi, GSM_MI_TYPE_IMSI); + else + gsm48_generate_mid_from_tmsi(buf, tmsi); + +

[PATCH] osmo-msc[master]: VLR tests: add simple LU generator

2018-02-15 Thread Max
8 LU"); + struct gsm48_hdr *ngh; + struct gsm48_loc_upd_req *nlu; /* NOTE: mi_len is part of struct */ + uint8_t buf[11]; + + ngh = (struct gsm48_hdr *)msgb_put(nmsg, sizeof(*ngh)); + nlu = (struct gsm48_loc_upd_req *)msgb_put(nmsg, sizeof(*nlu)); + + ngh->proto_discr = GSM48_PDISC_MM; + ngh->msg_type = GSM48_MT_MM_LOC_UPD_REQUEST; + + /* location updating type */ + nlu->type = lu_type; + + /* cipering key */ + nlu->key_seq = key_seq; + + gsm48_generate_lai(&nlu->lai, mcc, mnc, lac); + + /* classmark 1 */ + gsm48_encode_classmark1(&nlu->classmark1, rev_lv, es_ind, a5_1, pwr_lv); + + /* MI */ + gsm48_generate_mid(buf, imsi, GSM_MI_TYPE_IMSI); + + msgb_put(nmsg, buf[1]); /* length is part of nlu */ + memcpy(&nlu->mi_len, buf + 1, 1 + buf[1]); + + ms_sends_msg(msgb_hexdump(nmsg)); + + msgb_free(nmsg); +} + const struct timeval fake_time_start_time = { 123, 456 }; void fake_time_start() diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index a59b5d9..2ac20ce 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -135,6 +135,8 @@ void paging_expect_imsi(const char *imsi); void paging_expect_tmsi(uint32_t tmsi); void tx_identity_resp(const char *imsi, uint8_t mi_type, uint8_t seq); +void tx_loc_upd_req(const char *imsi, uint8_t lu_type, uint8_t rev_lv, + bool a5_1, bool es_ind, uint8_t pwr_lv, uint16_t mcc, uint16_t mnc, uint8_t lac, uint8_t key_seq); void ms_sends_msg(const char *hex); void ms_sends_security_mode_complete(); void gsup_rx(const char *rx_hex, const char *expect_tx_hex); -- To view, visit https://gerrit.osmocom.org/6484 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab8b07b3276b6f6ac0387df14abb98355ea0e99a Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[MERGED] libosmocore[master]: Add function to encode classmark

2018-02-15 Thread Max
Max has submitted this change and it was merged. Change subject: Add function to encode classmark .. Add function to encode classmark The code is based on Osmocom-BB implementation. Change-Id

[PATCH] libosmocore[master]: Add function to encode classmark

2018-02-15 Thread Max
ect: libosmocore Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmocore[master]: Add function to encode classmark

2018-02-15 Thread Max
m.org/6481 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I78f6968edaa3ed535673411fb2a80060a472290f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max

libosmocore[master]: contrib/jenkins_arch.sh: Fix script comparison and arm support

2018-02-15 Thread Max
Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

[PATCH] osmo-msc[master]: VLR tests: expand ID RESP generator

2018-02-15 Thread Max
r *imsi, uint8_t seq); +void tx_identity_resp(const char *imsi, uint8_t mi_type, uint8_t seq); void ms_sends_msg(const char *hex); void ms_sends_security_mode_complete(); void gsup_rx(const char *rx_hex, const char *expect_tx_hex); -- To view, visit https://gerrit.osmocom.org/6475 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibb6cdf652ff48a5b74a89925fd67f147cedf30b7 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-msc[master]: VLR tests: expand ID RESP generator

2018-02-15 Thread Max
y_mode_complete(); void gsup_rx(const char *rx_hex, const char *expect_tx_hex); -- To view, visit https://gerrit.osmocom.org/6475 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb6cdf652ff48a5b74a89925fd67f147cedf30b7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[MERGED] libosmocore[master]: Add test for gsm48_generate_mid_from_imsi()

2018-02-15 Thread Max
Max has submitted this change and it was merged. Change subject: Add test for gsm48_generate_mid_from_imsi() .. Add test for gsm48_generate_mid_from_imsi() Change-Id: Ibe5c0831268c788ceecd10fd7b22ece6480da817 --- M tests

[MERGED] libosmocore[master]: Add generic Mobile Identity encoder

2018-02-15 Thread Max
Max has submitted this change and it was merged. Change subject: Add generic Mobile Identity encoder .. Add generic Mobile Identity encoder Add generic function which allows caller to set Mobile Identity explicitly. This

[PATCH] libosmo-sccp[master]: SS7: clarify handling of stream opening error

2018-02-15 Thread Max
osmocom.org/6407 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Re

[PATCH] osmo-msc[master]: Fix VLR test macro

2018-02-15 Thread Max
= conn) return true; } + return false; } @@ -210,7 +215,7 @@ ran_type_name(rx_from_ran), gh_type_name(gh)); - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; if (!g_conn) { @@ -232,7 +237,7 @@ msc_dtap(g_conn, 23, msg); } - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index d00eb9f..9d7632a 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -128,7 +128,7 @@ struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex); void clear_vlr(); -bool conn_exists(struct gsm_subscriber_connection *conn); +bool conn_exists(const struct gsm_subscriber_connection *conn); void dtap_expect_tx(const char *hex); void dtap_expect_tx_ussd(char *ussd_text); @@ -144,14 +144,14 @@ void thwart_rx_non_initial_requests(); -#define EXPECT_ACCEPTED(expect_accepted) do { \ - if (g_conn) \ - OSMO_ASSERT(conn_exists(g_conn)); \ - bool accepted = msc_subscr_conn_is_accepted(g_conn); \ +#define EXPECT_ACCEPTED(expect_accepted, x_conn) do { \ + if (x_conn) \ + OSMO_ASSERT(conn_exists(x_conn)); \ + bool accepted = msc_subscr_conn_is_accepted(x_conn); \ fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \ accepted ? "true" : "false"); \ OSMO_ASSERT(accepted == expect_accepted); \ - } while (false) + } while (0) #define VERBOSE_ASSERT(val, expect_op, fmt) \ do { \ -- To view, visit https://gerrit.osmocom.org/6296 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213 Gerrit-PatchSet: 6 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: daniel

[PATCH] osmo-msc[master]: VLR tests: add function to generate ID RESP

2018-02-15 Thread Max
-MessageType: newchange Gerrit-Change-Id: Ifc43b4b9b1595e14c353771edbcdd1ad46974895 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] libosmocore[master]: Add test for gsm48_generate_mid_from_imsi()

2018-02-15 Thread Max
, MCC=77, LAC=666, RAC=5 RA: MNC=121, MCC=77, LAC=666, RAC=5 -- To view, visit https://gerrit.osmocom.org/6458 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibe5c0831268c788ceecd10fd7b22ece6480da817 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] libosmocore[master]: Add generic Mobile Identity encoder

2018-02-15 Thread Max
e, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id79be7abfff75ecd0d248bbeed93e605abeec9b3 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max

osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

2018-02-14 Thread Max
: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox Gerrit-HasComments: No

[PATCH] gapk[master]: Ignore build products

2018-02-14 Thread Max
https://gerrit.osmocom.org/6383 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 Gerrit-PatchSet: 3 Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer

[PATCH] gapk[master]: Ignore build products

2018-02-14 Thread Max
83 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 Gerrit-PatchSet: 2 Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Rev

[MERGED] gapk[master]: Add basic CI integration

2018-02-14 Thread Max
Max has submitted this change and it was merged. Change subject: Add basic CI integration .. Add basic CI integration Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5 --- A contrib/jenkins.sh 1 file changed, 42 insertions

gapk[master]: Add basic CI integration

2018-02-14 Thread Max
: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: tnt Gerrit-HasComments: No

osmo-bts[master]: LC15: Fix missing fill frame and GSM 05.08 mandatory frame

2018-02-13 Thread Max
: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No

[PATCH] libosmo-abis[master]: IPA: log remote address

2018-02-13 Thread Max
goto err; } @@ -485,7 +487,7 @@ goto err; break; default: - LOGP(DLINP, LOGL_ERROR, "Unknown IPA message type\n"); + LOGIPA(conn, LOGL_ERROR, "Unknown IPA message type\n"); break; } return 0; -- To view, visit https://gerrit.osmocom.org/6408 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I19ebaea45812aad6b3d3480cac0f1f833daf428d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Owner: Max

libosmo-sccp[master]: SS7: return error on stream opening error

2018-02-13 Thread Max
isit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

[PATCH] libosmo-sccp[master]: SS7: return error on stream opening error

2018-02-13 Thread Max
role = XUA_ASPFSM_ROLE_ASP; -- To view, visit https://gerrit.osmocom.org/6407 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-pcu[master]: emu: use libosmocore definitions

2018-02-13 Thread Max
-MessageType: newchange Gerrit-Change-Id: I4eade528faeb3841549ad7a6c78e8c1357909614 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max

osmo-sgsn[master]: .gitignore: Add m4 files

2018-02-13 Thread Max
Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: Yes

[PATCH] osmo-msc[master]: VLR: fix potential NULL dereference

2018-02-12 Thread Max
-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

gapk[master]: Add basic CI integration

2018-02-12 Thread Max
tps://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: tnt Ger

gapk[master]: Ignore build products

2018-02-12 Thread Max
Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: tnt Gerrit-HasComments: Yes

[PATCH] gapk[master]: Add basic CI integration

2018-02-12 Thread Max
="" $MAKE distcheck || cat-testlogs.sh + +osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/6384 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] gapk[master]: Ignore build products

2018-02-12 Thread Max
: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] gapk[master]: Add --enable-sanitize configure option

2018-02-12 Thread Max
core (codec module) PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.3.2) -- To view, visit https://gerrit.osmocom.org/6382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb26e5fc73843f3951dbc534653ee7d88e4c80e7 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Owner: Max

osmo-ttcn3-hacks[master]: Ignore symlinks and build byproducts

2018-02-12 Thread Max
smocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Re

[PATCH] osmo-ttcn3-hacks[master]: Ignore symlinks and build byproducts

2018-02-12 Thread Max
ge-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: dexter

osmo-bts[master]: Add 11-bit RACH support to osmo-bts-trx

2018-02-09 Thread Max
ent Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No

libosmocore[master]: osmo_msgbdump_{l2,l3}(): Proper typecast

2018-02-09 Thread Max
Gerrit-Owner: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

[PATCH] osmo-bts[master]: osmo-bts-trx: init nbits to know value

2018-02-08 Thread Max
ocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-bts[master]: osmo-bts-trx: ignore frame offset error on startup

2018-02-08 Thread Max
the current GSM time */ -- To view, visit https://gerrit.osmocom.org/6322 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4f7cf285e437db0e980e1a2a3ab48a7255945448 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max

osmocom-bb[master]: layer23/cell_log: set default logfile to /dev/null

2018-02-08 Thread Max
Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No

osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts

2018-02-08 Thread Max
rit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: dexter Gerrit-HasComments: No

[MERGED] osmo-pcu[master]: RACH: improve single block detection

2018-02-08 Thread Max
Max has submitted this change and it was merged. Change subject: RACH: improve single block detection .. RACH: improve single block detection Replace unreadable if-else ladder in is_single_block() with regular switch-case

[PATCH] osmo-bts[master]: Add helper to get BCC from BSIC

2018-02-07 Thread Max
gs Gerrit-MessageType: newchange Gerrit-Change-Id: Ib539a8739d53ab60d8fadffcef38152b82a28498 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-bts[master]: Add 11-bit RACH support to osmo-bts-trx

2018-02-07 Thread Max
l1sap_up(l1t->trx, &l1sap); -- To view, visit https://gerrit.osmocom.org/6315 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerri

osmo-bts[master]: Add 11-bit RACH support to osmo-bts-trx

2018-02-07 Thread Max
errit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

[PATCH] osmo-bts[master]: Add 11-bit RACH support to osmo-bts-trx

2018-02-07 Thread Max
visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-pcu[master]: RACH: improve single block detection

2018-02-07 Thread Max
LOGP(DRLCMAC, LOGL_ERROR, "PCU has not received burst type from BTS\n"); + break; + default: + LOGP(DRLCMAC, LOGL_ERROR, "Unexpected RACH burst type %u for %s-bit RACH\n", +burst_type, is_11bit ? "11" : "8"); } return sb; -- To view, visit https://gerrit.osmocom.org/6312 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9180478152f9341f11bb3dffe61671da683f24d8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: GSUP: check osmo_gsup_encode() result

2018-02-07 Thread Max
SMO_ASSERT(event == UPD_HLR_VLR_E_START); /* Send UpdateLocation to HLR */ - vlr_subscr_req_lu(vsub, vsub->vlr->cfg.is_ps); + rc = vlr_subscr_req_lu(vsub, vsub->vlr->cfg.is_ps); + if (rc < 0) + LOGPFSML(fi, LOGL_ERROR, "Failed to send Up

[PATCH] osmo-msc[master]: VLR tests: move network init into function

2018-02-07 Thread Max
ode_cmd; + msc_subscr_conn_init(); clear_vlr(); -- To view, visit https://gerrit.osmocom.org/6311 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I68a2e94cf79fcb83286eef981a8d88bdbe10ef69 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: Fix VLR test macro

2018-02-07 Thread Max
rrit-PatchSet: 5 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: daniel

[PATCH] osmo-msc[master]: Move IMSI into test parameters

2018-02-07 Thread Max
truct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex); -- To view, visit https://gerrit.osmocom.org/6288 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I74d46fdb7e87dc04c6b82a0b6f3ce6bef60bde58 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel

[PATCH] osmo-msc[master]: GSUP: check osmo_gsup_encode() result

2018-02-07 Thread Max
r->cfg.is_ps); + rc = vlr_subscr_req_lu(vsub, vsub->vlr->cfg.is_ps); + if (rc < 0) + LOGPFSML(fi, LOGL_ERROR, "Failed to send UpdateLocation to HLR\n"); osmo_fsm_inst_state_chg(fi, UPD_HLR_VLR_S_WAIT_FOR_DATA,

[PATCH] osmo-msc[master]: Fix whitespace issues

2018-02-06 Thread Max
rg/6308 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5962431ad16c97e412939dc1b8949f6361a5c26e Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

osmo-msc[master]: Fix VLR test macro

2018-02-06 Thread Max
o belong here Indeed. -- To view, visit https://gerrit.osmocom.org/6296 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner

[PATCH] osmo-msc[master]: Fix VLR test macro

2018-02-06 Thread Max
if (!conn_exists(conn)) + fprintf(stderr, "ERROR: expecting %s on unknown connection\n", + exp ? "true" : "false"); + + accepted = msc_subscr_conn_is_accepted(conn); + fprintf(stderr,

[PATCH] osmo-msc[master]: VLR tests: always print test parameters

2018-02-06 Thread Max
Review at https://gerrit.osmocom.org/6307 VLR tests: always print test parameters For each test print: * the test number * IMSI Unfortunately tests are organized in such a way that we don't know the number of particular test in advance. Nevertheless, it make sense to always print it regardless

[PATCH] osmo-msc[master]: VLR tests: don't fail via assert

2018-02-06 Thread Max
2ed2b3738bfbcc63 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-msc[master]: VLR tests: remove weird code

2018-02-06 Thread Max
com.org/6305 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f571ec319ff3231fd9acd4066e470476c3b1f78 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins

[PATCH] osmo-msc[master]: Fix VLR test macro

2018-02-06 Thread Max
quot;); + + accepted = msc_subscr_conn_is_accepted(conn); + fprintf(stderr, "msc_subscr_conn_is_accepted() == %s%s\n", + accepted ? "true" : "false", accepted != exp ? " EXP. FAILED!" : ""); } enum ran_type rx_from_ran = RAN_GERAN_A; @@ -210,7 +228,7 @@ ran_type_name(rx_from_ran), gh_type_name(gh)); - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; if (!g_conn) { @@ -232,7 +250,7 @@ msc_dtap(g_conn, 23, msg); } - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index 2ea3f29..0d48e00 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -128,7 +128,8 @@ struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex); void clear_vlr(); -bool conn_exists(struct gsm_subscriber_connection *conn); + +void exp_accept_con(bool exp, const struct gsm_subscriber_connection *conn); void dtap_expect_tx(const char *hex); void dtap_expect_tx_ussd(char *ussd_text); @@ -143,15 +144,6 @@ char *str); void thwart_rx_non_initial_requests(); - -#define EXPECT_ACCEPTED(expect_accepted) do { \ - if (g_conn) \ - OSMO_ASSERT(conn_exists(g_conn)); \ - bool accepted = msc_subscr_conn_is_accepted(g_conn); \ - fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \ - accepted ? "true" : "false"); \ - OSMO_ASSERT(accepted == expect_accepted); \ - } while (false) #define VERBOSE_ASSERT(val, expect_op, fmt) \ do { \ -- To view, visit https://gerrit.osmocom.org/6296 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel

[PATCH] osmo-msc[master]: Expand VLR tests

2018-02-06 Thread Max
+ run_tests(nr, "90170004620"); } } -- To view, visit https://gerrit.osmocom.org/6297 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3 Gerrit-PatchSet: 3 Gerrit-P

[PATCH] osmo-msc[master]: VLR tests: don't fail via assert

2018-02-06 Thread Max
2ed2b3738bfbcc63 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-msc[master]: VLR tests: mark static test functions as such

2018-02-06 Thread Max
Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel

[PATCH] osmo-msc[master]: Expand VLR tests

2018-02-06 Thread Max
+ run_tests(nr, "90170004620"); } } -- To view, visit https://gerrit.osmocom.org/6297 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3 Gerrit-PatchSet: 2 Gerrit-P

[PATCH] osmo-msc[master]: Constify msc_subscr_conn_is_accepted() parameter

2018-02-06 Thread Max
!conn) return false; -- To view, visit https://gerrit.osmocom.org/6295 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner

[PATCH] osmo-msc[master]: Fix VLR test macro

2018-02-06 Thread Max
quot;); + + accepted = msc_subscr_conn_is_accepted(conn); + fprintf(stderr, "msc_subscr_conn_is_accepted() == %s%s\n", + accepted ? "true" : "false", accepted != exp ? " EXP. FAILED!" : ""); } enum ran_type rx_from_ran = RAN_GERAN_A; @@ -210,7 +228,7 @@ ran_type_name(rx_from_ran), gh_type_name(gh)); - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; if (!g_conn) { @@ -232,7 +250,7 @@ msc_dtap(g_conn, 23, msg); } - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index 2ea3f29..0d48e00 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -128,7 +128,8 @@ struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex); void clear_vlr(); -bool conn_exists(struct gsm_subscriber_connection *conn); + +void exp_accept_con(bool exp, const struct gsm_subscriber_connection *conn); void dtap_expect_tx(const char *hex); void dtap_expect_tx_ussd(char *ussd_text); @@ -143,15 +144,6 @@ char *str); void thwart_rx_non_initial_requests(); - -#define EXPECT_ACCEPTED(expect_accepted) do { \ - if (g_conn) \ - OSMO_ASSERT(conn_exists(g_conn)); \ - bool accepted = msc_subscr_conn_is_accepted(g_conn); \ - fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \ - accepted ? "true" : "false"); \ - OSMO_ASSERT(accepted == expect_accepted); \ - } while (false) #define VERBOSE_ASSERT(val, expect_op, fmt) \ do { \ -- To view, visit https://gerrit.osmocom.org/6296 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel

[PATCH] osmo-msc[master]: VLR tests: remove weird code

2018-02-06 Thread Max
v) -- To view, visit https://gerrit.osmocom.org/6305 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f571ec319ff3231fd9acd4066e470476c3b1f78 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: MSC tests: don't fail via assert

2018-02-06 Thread Max
*receiver, -- To view, visit https://gerrit.osmocom.org/6304 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2607cb1ac60941dbc22fca532ed2b3738bfbcc63 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

osmo-bsc[master]: abis_rsl: permit first EstablishInd only on SAPI=0

2018-02-06 Thread Max
com.org/6303 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf4fca0bd42dfe5bc63e8b08754ebbe0a5e252c3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer:

osmo-ci[master]: jobs: add Coverity Upload Job

2018-02-06 Thread Max
-Owner: lynxis lazus Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Max Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-HasComments: No

[PATCH] osmo-msc[master]: Constify msc_subscr_conn_is_accepted() parameter

2018-02-06 Thread Max
/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: Mark static test functions as such

2018-02-06 Thread Max
.osmocom.org/6294 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5eac4c24257fd38068ba629d3c21848181703220 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: Expand MSC tests

2018-02-06 Thread Max
m.org/6297 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: Fix MSC test macro

2018-02-06 Thread Max
if (!conn_exists(conn)) + fprintf(stderr, "ERROR: expecting %s on unknown connection\n", + exp ? "true" : "false"); + + accepted = msc_subscr_conn_is_accepted(conn); + fprintf(stderr, "msc_subscr_conn_is_accepted() == %s%s\n", + accepted ? "true" : "false", accepted != exp ? " EXP. FAILED!" : ""); } enum ran_type rx_from_ran = RAN_GERAN_A; @@ -210,7 +228,7 @@ ran_type_name(rx_from_ran), gh_type_name(gh)); - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; if (!g_conn) { @@ -232,7 +250,7 @@ msc_dtap(g_conn, 23, msg); } - if (g_conn && !conn_exists(g_conn)) + if (!conn_exists(g_conn)) g_conn = NULL; } diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h index 2ea3f29..0d48e00 100644 --- a/tests/msc_vlr/msc_vlr_tests.h +++ b/tests/msc_vlr/msc_vlr_tests.h @@ -128,7 +128,8 @@ struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex); void clear_vlr(); -bool conn_exists(struct gsm_subscriber_connection *conn); + +void exp_accept_con(bool exp, const struct gsm_subscriber_connection *conn); void dtap_expect_tx(const char *hex); void dtap_expect_tx_ussd(char *ussd_text); @@ -143,15 +144,6 @@ char *str); void thwart_rx_non_initial_requests(); - -#define EXPECT_ACCEPTED(expect_accepted) do { \ - if (g_conn) \ - OSMO_ASSERT(conn_exists(g_conn)); \ - bool accepted = msc_subscr_conn_is_accepted(g_conn); \ - fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \ - accepted ? "true" : "false"); \ - OSMO_ASSERT(accepted == expect_accepted); \ - } while (false) #define VERBOSE_ASSERT(val, expect_op, fmt) \ do { \ -- To view, visit https://gerrit.osmocom.org/6296 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-msc[master]: Move IMSI into test parameters

2018-02-06 Thread Max
-122,7 +122,7 @@ int run_test_nr; }; -typedef void (* msc_vlr_test_func_t )(void); +typedef void (* msc_vlr_test_func_t )(const char *); extern msc_vlr_test_func_t msc_vlr_tests[]; struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex); -- To view, visit https://gerrit.osmocom.org/6288 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I74d46fdb7e87dc04c6b82a0b6f3ce6bef60bde58 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max

libosmocore[master]: Add macros for all ACC bit flags in the rach control IE.

2018-02-06 Thread Max
tefan Sperling Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: Yes

osmo-bts[master]: Name systemd service after the software

2018-02-06 Thread Max
-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-HasComments: No

[PATCH] osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts

2018-02-06 Thread Max
ge-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter

[PATCH] osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts

2018-02-06 Thread Max
unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max

[ABANDON] osmo-ttcn3-hacks[master]: Fix regen_makefile warning

2018-02-05 Thread Max
Max has abandoned this change. Change subject: Fix regen_makefile warning .. Abandoned -- To view, visit https://gerrit.osmocom.org/6276 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon

osmo-msc[master]: a_iface: correct data type for a.conn_id in gsm_subscriber_c...

2018-02-05 Thread Max
7df46 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

osmocom-bb[master]: Import gprsdecode utility from SRLabs

2018-02-05 Thread Max
ssageType: comment Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856 Gerrit-PatchSet: 6 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-HasComments: No

[PATCH] osmo-ttcn3-hacks[master]: Fix regen_makefile warning

2018-02-05 Thread Max
: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol

[PATCH] osmo-ttcn3-hacks[master]: Fix regen_makefile warning

2018-02-05 Thread Max
To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib94dbe65fa2ae53d95b3f0524af77b1303e33ce3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-ttcn3-hacks[master]: Don't symlink non-existent file

2018-02-05 Thread Max
DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src -- To view, visit https://gerrit.osmocom.org/6275 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10309f07fb207c027703f0b43a478c152a029b6d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max

[PATCH] osmo-pcu[master]: Simplify TS alloc: move slot check into functions

2018-02-05 Thread Max
* \param[in] trx Pointer to TRX object @@ -467,16 +511,12 @@ int find_multi_slots(struct gprs_rlcmac_trx *trx, uint8_t mslot_class, uint8_t *ul_slots, uint8_t *dl_slots) { uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx slots */ - Sum = mslot_

[PATCH] osmo-pcu[master]: Simplify TS alloc: split off RX mask computation

2018-02-05 Thread Max
, Sum;/* Maximum Number of Slots: RX, Tx, Sum Rx+Tx */ - uint8_t Tta, Ttb, Tra, Trb; /* Minimum Number of Slots */ - uint8_t Type; /* Type of Mobile */ + uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx slots */ + Sum = mslot_class_get_sum(mslot_

[PATCH] osmo-pcu[master]: Simplify TS alloc: don't use PDCH for free TFI

2018-02-05 Thread Max
b9a30911b451525a1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-pcu[master]: Simplify TS alloc: replace debug printer

2018-02-05 Thread Max
29 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb Gerrit-PatchSet: 13 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max

[MERGED] libosmocore[master]: GSUP: change osmo_gsup_encode() return type

2018-02-05 Thread Max
Max has submitted this change and it was merged. Change subject: GSUP: change osmo_gsup_encode() return type .. GSUP: change osmo_gsup_encode() return type * match return type of osmo_gsup_encode() with osmo_gsup_decode() to

[PATCH] osmo-msc[master]: Wrap osmo_strlcpy() calls

2018-02-05 Thread Max
vsub->imsi, vsub->imeisv); } @@ -397,7 +397,7 @@ { if (!vsub) return; - osmo_strlcpy(vsub->msisdn, msisdn, sizeof(vsub->msisdn)); + OSMO_STRLCPY_ARRAY(vsub->msisdn, msisdn); DEBUGP(DVLR, "set MSISDN on subscriber; IMSI=%s MSISDN=%s\n", vsub->imsi, vsub->msisdn); } @@ -566,7 +566,7 @@ struct osmo_gsup_message gsup_msg = {0}; gsup_msg.message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT; - osmo_strlcpy(gsup_msg.imsi, vsub->imsi, sizeof(gsup_msg.imsi)); + OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi); return vlr_tx_gsup_message(vsub->vlr, &gsup_msg); } -- To view, visit https://gerrit.osmocom.org/6198 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I67b482dedfa11237ac21894fc5930039e12434ab Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder

[MERGED] libosmocore[master]: utils: add helper wrapper for osmo_strlcpy()

2018-02-05 Thread Max
Max has submitted this change and it was merged. Change subject: utils: add helper wrapper for osmo_strlcpy() .. utils: add helper wrapper for osmo_strlcpy() Add wrapper for osmo_strlcpy() which uses sizeof() to automatically

[PATCH] libosmocore[master]: utils: add helper wrapper for osmo_strlcpy()

2018-02-05 Thread Max
estamp in the message, irrespective -- To view, visit https://gerrit.osmocom.org/6197 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder

osmo-pcu[master]: vty: add commands to show TBF of a certain kind

2018-02-05 Thread Max
To view, visit https://gerrit.osmocom.org/6239 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Hara

osmo-pcu[master]: Simplify TS alloc: improve readability

2018-02-04 Thread Max
keep this one in gerrit till than as a reminder. -- To view, visit https://gerrit.osmocom.org/4086 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31600462e48d945bc8b7abf86a3718ac83e1dcbb Gerrit-PatchSet: 7 Gerrit-Project: osmo-pcu Ger

[PATCH] osmo-mgw[master]: Turn libosmo-mgcp into local, non-installed library

2018-02-04 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6270 to look at the new patch set (#2). Turn libosmo-mgcp into local, non-installed library This is an internal library simmilar to 'libmsc' in osmo-msc, which we don't expect to be used by

osmocom-bb[master]: firmware/l23_api.c: increase the L3_MSG_SIZE

2018-02-02 Thread Max
://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I237c6898cb7bbccb891e23ebab08498768a01574 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: tnt Gerrit

osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

2018-02-02 Thread Max
ge-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No

osmocom-bb[master]: layer23/cell_log: set default logfile to /dev/null

2018-02-02 Thread Max
Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

libosmocore[master]: tests: utils_test: Fix test failure when compiling with -O0

2018-02-02 Thread Max
errit-Change-Id: I736c1e4d625f647d3bb794fa717256e9dbf36e87 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No

osmo-bts[master]: gsm_pchan2chan_nr: move warning to pragma message and track ...

2018-02-02 Thread Max
Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No

osmocom-bb[master]: layer23/cell_log: set default logfile to /dev/null

2018-02-02 Thread Max
visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasCom

<    11   12   13   14   15   16   17   18   19   20   >