Max has posted comments on this change. ( https://gerrit.osmocom.org/12907 )
Change subject: Don't install pcuif_proto.h header
..
Patch Set 1:
> Why not to move it to libosmocore?
In general I agree (provided we move enco
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12906 )
Change subject: Log lchan kind on PCU-related error
..
Log lchan kind on PCU-related error
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12916 )
Change subject: Enable remote SIM protocol log level
..
Enable remote SIM protocol log level
It's defined in logging.h for quite some time
Max has posted comments on this change. ( https://gerrit.osmocom.org/6315 )
Change subject: osmo-bts-trx: add extended (11-bit) RACH support
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6315
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/6315 )
Change subject: osmo-bts-trx: add extended (11-bit) RACH support
..
osmo-bts-trx: add extended (11-bit) RACH support
Attempt to decode
Max has posted comments on this change. ( https://gerrit.osmocom.org/12916 )
Change subject: Enable remote SIM protocol log level
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12905 )
Change subject: gsm_08_08.h: Add constants for Channel Type in signalling mode
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12913 )
Change subject: MSC_Tests: Make sure only sgsap related tests use the SGs
interface
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12907 )
Change subject: Don't install pcuif_proto.h header
..
Patch Set 1:
> What's the problem with installing it? How does this patch simpl
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12916
Change subject: Enable remote SIM protocol log level
..
Enable remote SIM protocol log level
It's defined in logging.h for quite some time
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12915
Change subject: Add git-review config
..
Add git-review config
Change-Id: Iceb58eba5922687aefae7e086a64ea9ae0d225c3
---
A .gitreview
1 file changed, 3
Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: transaction: drop meaningless ti_flag of trans_assign_trans_id()
..
Patch Set 5: Code-Review-1
Just to get my earlier comment more
Max has posted comments on this change. ( https://gerrit.osmocom.org/12901 )
Change subject: transaction: clarify magic 0xff transaction ID
..
Patch Set 3: Code-Review+1
(1 comment)
Anyway, just a food for thought
Max has posted comments on this change. ( https://gerrit.osmocom.org/6315 )
Change subject: osmo-bts-trx: add extended (11-bit) RACH support
..
Patch Set 7:
Tested both gprs and egprs (without 11bit_rach_support_for_egprs
Max has posted comments on this change. ( https://gerrit.osmocom.org/12908 )
Change subject: Fix compilation on eclipse-titan 6.5.1
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12908
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12907
Change subject: Don't install pcuif_proto.h header
..
Don't install pcuif_proto.h header
Both OsmoBTS and OsmoBSC use their own copies of this header
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12906
Change subject: Log lchan kind on PCU-related error
..
Log lchan kind on PCU-related error
Change-Id: Iadb464e7040dd11e4a8cabfc96d6d90f32594109
---
M
Max has posted comments on this change. ( https://gerrit.osmocom.org/12901 )
Change subject: transaction: clarify magic 0xff transaction ID
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12901
Max has posted comments on this change. ( https://gerrit.osmocom.org/12882 )
Change subject: firmware/board/pirelli_dpl10: fix ASIC_CONF_REG setting
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12893 )
Change subject: OML: Store merged attributes of IPA OML Managed Objects
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12893/1/src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12897 )
Change subject: Add multipatch capability to osmo-config-merge
..
Patch Set 3:
(1 comment)
Fixed in updated patch, thanks!
https
: 3
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: daniel
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12895 )
Change subject: GMM: permit VLR_ANSWERED event in attach FSM
..
GMM: permit VLR_ANSWERED event in attach FSM
This fixes following error:
DMM
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12904 )
Change subject: Log ip:port when adding GSUP routes
..
Log ip:port when adding GSUP routes
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12890 )
Change subject: OML: Fix encoded length value of OML GET ATTRIBUTES
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12890/1/src/osmo-bsc
Max has posted comments on this change. ( https://gerrit.osmocom.org/12903 )
Change subject: transaction.h: use #pragma once as include guard
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12903
Max has posted comments on this change. ( https://gerrit.osmocom.org/12901 )
Change subject: transaction: clarify late transaction ID assignment
..
Patch Set 1:
What about gsm_04_11.c and transaction.c? I think both used 0xff
Max has posted comments on this change. ( https://gerrit.osmocom.org/12902 )
Change subject: transaction: fix description of trans_assign_trans_id()
..
Patch Set 1:
Sounds somewhat odd. Someone with less Russian English than
Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: transaction: drop meaningless ti_flag of trans_assign_trans_id()
..
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/12519/5
: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
Gerrit-Change-Number: 12895
Gerrit-PatchSet: 3
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12904
Change subject: Log ip:port when adding GSUP routes
..
Log ip:port when adding GSUP routes
Change-Id: I7202fdf59e763dbca26150868b324ac7e4c0
---
M
Max has posted comments on this change. ( https://gerrit.osmocom.org/12889 )
Change subject: osmo_ss7.c: fix typo
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12889/1/src/osmo_ss7.c
File src/osmo_ss7.c:
https
: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: daniel
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12894 )
Change subject: Improve 'show subscriber cache' vty command
..
Improve 'show subscriber cache' vty command
* don't use spaces when printing
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12897
Change subject: Add multipatch capability to osmo-config-merge
..
Add multipatch capability to osmo-config-merge
That's pretty straightforward
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I14d234632224e20faf865d2273c83cfff31abf61
Gerrit-Change-Number: 12895
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12895
Change subject: GMM: permit VLR_ANSWERED event in attach FSM
..
GMM: permit VLR_ANSWERED event in attach FSM
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12894
Change subject: Improve 'show subscriber cache' vty command
..
Improve 'show subscriber cache' vty command
* don't use spaces when printing hex data
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12889 )
Change subject: osmo_ss7.c: fix typo
..
osmo_ss7.c: fix typo
Change-Id: Idd0945ef7fa5cc0caf2f35919f97e2e11691f3a3
---
M src/osmo_ss7.c
1
Max has posted comments on this change. ( https://gerrit.osmocom.org/12883 )
Change subject: firmware/board/gta0x: fix GPIO and ASIC_CONF_REG configuration
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12888 )
Change subject: firmware/board: introduce the new FCDEV3B target
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/12888/1
Max has posted comments on this change. ( https://gerrit.osmocom.org/12885 )
Change subject: firmware/lib: introduce TIFFS filesystem support
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12885
Max has posted comments on this change. ( https://gerrit.osmocom.org/12845 )
Change subject: Deprecate osmo_stream_cli_open2()
..
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/12845/6/tests/stream/stream_test.c
File
-Number: 12845
Gerrit-PatchSet: 7
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12889
Change subject: osmo_ss7.c: fix typo
..
osmo_ss7.c: fix typo
Change-Id: Idd0945ef7fa5cc0caf2f35919f97e2e11691f3a3
---
M src/osmo_ss7.c
1 file changed
Max has posted comments on this change. ( https://gerrit.osmocom.org/12861 )
Change subject: install: keep existing / modified etc/osmocom/*.cfg files
..
Patch Set 1: Code-Review-2
I strongly disagree: we should not try
Max has posted comments on this change. ( https://gerrit.osmocom.org/12868 )
Change subject: OML: Reduce code duplication in down_mom/down_fom
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12868
Max has posted comments on this change. ( https://gerrit.osmocom.org/12869 )
Change subject: OML: Report short messages even for invalid TRX numbers in
down_fom()
..
Patch Set 1: Code-Review+2
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12870 )
Change subject: OML: Use 'const struct abis_oml_mo *' whenever users only read
..
Patch Set 1: Code-Review+2
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12871 )
Change subject: OML: Reject segmented OML messages
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12871
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/12872 )
Change subject: OML: Send Failure Event Report on short OML messages
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12876 )
Change subject: IPA_Emulation: Integrate OML decoding/encoding; add OML port
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12875 )
Change subject: Add TTCN-3 definition of GSM Abis OML protocol (TS 12.21)
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12875/1/library
Max has posted comments on this change. ( https://gerrit.osmocom.org/12867 )
Change subject: WIP: send proper OML alert in case of errors
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12867/1/src/common/oml.c
Max has posted comments on this change. ( https://gerrit.osmocom.org/12873 )
Change subject: OML: Properly reject short messages and truncate over-long
messages
..
Patch Set 1: Code-Review+1
I think this can be moved earlier
Max has posted comments on this change. ( https://gerrit.osmocom.org/12879 )
Change subject: get_value_string(): guard against NULL
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12879
Max has posted comments on this change. ( https://gerrit.osmocom.org/12880 )
Change subject: add OSMO_STRBUF_PRINTF()
..
Patch Set 2:
(1 comment)
Please clarify.
https://gerrit.osmocom.org/#/c/12880/2/tests/utils
Max has posted comments on this change. ( https://gerrit.osmocom.org/12857 )
Change subject: Add timeout wrapper to regular gerrit verification jobs
..
Patch Set 2: Verified+1
Nevermind, actually I can.
--
To view, visit
Max has posted comments on this change. ( https://gerrit.osmocom.org/12881 )
Change subject: cosmetic: remove excess space at line end
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12881
Max has posted comments on this change. ( https://gerrit.osmocom.org/12857 )
Change subject: Add timeout wrapper to regular gerrit verification jobs
..
Patch Set 2:
Odd, seems like I can't put verified+1 to my own patch
Max has posted comments on this change. ( https://gerrit.osmocom.org/12763 )
Change subject: Add OpenVPN probe
..
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/12763/5/src/osysmon_openvpn.c
File src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12763 )
Change subject: Add OpenVPN probe
..
Patch Set 7:
(1 comment)
So far there's only one probe which uses osmocom event loop. That's why I've
opted
Max has posted comments on this change. ( https://gerrit.osmocom.org/12761 )
Change subject: Introduce generic host config and related helpers
..
Patch Set 6:
(1 comment)
I can change the macro the way you propose
Max has posted comments on this change. ( https://gerrit.osmocom.org/12857 )
Change subject: Add timeout wrapper to regular gerrit verification jobs
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/12857/1/jobs
/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d0eb6b9eddf3e17120e74d7570d42291c0750ae
Gerrit-Change-Number: 12857
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin
Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test
..
Patch Set 18: Code-Review+2
> I don't really understand why you need the -no-install f
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test
..
Add stream client/server test
Previously stream client and server code were only used
Max has posted comments on this change. ( https://gerrit.osmocom.org/12763 )
Change subject: Add OpenVPN probe
..
Patch Set 7:
(13 comments)
This change is ready for review.
https://gerrit.osmocom.org/#/c/12763/5/src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12761 )
Change subject: Introduce generic host config and related helpers
..
Patch Set 6:
(6 comments)
This change is ready for review.
https
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12854 )
Change subject: Stream client: report reconnection event as INFO
..
Stream client: report reconnection event as INFO
This helps to avoid
Max has posted comments on this change. ( https://gerrit.osmocom.org/12853 )
Change subject: Avoid compiler warning 'dynamic exception specifications are
deprecated in C++11 [-Wdeprecated]'
..
Patch Set 1: Code-Review+1
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12857
Change subject: Add timeout wrapper to regular gerrit verification jobs
..
Add timeout wrapper to regular gerrit verification jobs
Use 'timeout
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12852 )
Change subject: Don't use deprecated osmo_stream_cli_open2()
..
Don't use deprecated osmo_stream_cli_open2()
Using osmo_stream_cli_open
Max has posted comments on this change. ( https://gerrit.osmocom.org/12852 )
Change subject: Don't use deprecated osmo_stream_cli_open2()
..
Patch Set 1:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12845 )
Change subject: Deprecate osmo_stream_cli_open2()
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test
..
Patch Set 18:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12837
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors
..
ctrl: log host/port on errors
In case of multiple ctrl-client entries in .cfg file it's
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12854
Change subject: Stream client: report reconnection event as INFO
..
Stream client: report reconnection event as INFO
This helps to avoid unnecessary
Max has posted comments on this change. ( https://gerrit.osmocom.org/12851 )
Change subject: Use timeout in jenkins job
..
Patch Set 1:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12851
Max has posted comments on this change. ( https://gerrit.osmocom.org/12851 )
Change subject: Use timeout in jenkins job
..
Patch Set 1:
> did we see problems here? has this happened before? should we also do this in
>
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12852
Change subject: Don't use deprecated osmo_stream_cli_open2()
..
Don't use deprecated osmo_stream_cli_open2()
Using osmo_stream_cli_open
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12851
Change subject: Use timeout in jenkins job
..
Use timeout in jenkins job
Automatically terminate 'make distcheck' jenkins build job after 5
minutes
Max has posted comments on this change. ( https://gerrit.osmocom.org/12840 )
Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12843 )
Change subject: libmsc/gsm_04_80.c: add msc_send_ussd_release_complete_cause()
..
Patch Set 2: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12850 )
Change subject: protocol/gsm_04_14: Fix the OPEN LOOP message type
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12850
Max has posted comments on this change. ( https://gerrit.osmocom.org/12849 )
Change subject: usrp2: firmware: ignore .lk build artifacts
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12849
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12845
Change subject: Deprecate osmo_stream_cli_open2()
..
Deprecate osmo_stream_cli_open2()
This supposed to be variant of osmo_stream_cli_open
Max has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
..
Patch Set 8: Code-Review-1
Same comments as before.
--
To view
Max has posted comments on this change. ( https://gerrit.osmocom.org/12840 )
Change subject: libmsc/gsm_04_80.c: use gsm0480_create_release_complete()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 8
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: daniel
Gerrit-Reviewer: osmith
Max has posted comments on this change. ( https://gerrit.osmocom.org/12730 )
Change subject: Inactive connection cleanup (disabled by default)
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12730
Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test
..
Patch Set 7:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12837
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12760 )
Change subject: Stream client: fix disconnection logic
..
Stream client: fix disconnection logic
Previously closing the client did not alter
Max has posted comments on this change. ( https://gerrit.osmocom.org/12760 )
Change subject: Stream client: fix disconnection logic
..
Patch Set 4:
This change is ready for review.
--
To view, visit https
: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 5
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: daniel
Gerrit-Reviewer: osmith
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12827 )
Change subject: Add socket name functions to stream client/server
..
Add socket name functions to stream client/server
Add functions to get
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12571 )
Change subject: VLR tests: use msgb_eq_data_print() for comparison
..
VLR tests: use msgb_eq_data_print() for comparison
This simplifies
: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e
Gerrit-Change-Number: 12837
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: daniel
Gerrit-Reviewer: osmith
Max has posted comments on this change. ( https://gerrit.osmocom.org/12836 )
Change subject: Stream client: update logging
..
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/12836/1/src/stream.c
File src/stream.c
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12654 )
Change subject: Log peer's port in accept callback
..
Log peer's port in accept callback
* log port from which we accept() the connection
401 - 500 of 3542 matches
Mail list logo
