Max has posted comments on this change. ( https://gerrit.osmocom.org/11157 )
Change subject: trxcon/scheduler: fix RSSI -> RX level conversion
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/11157/2/src/host/trx
Max has posted comments on this change. ( https://gerrit.osmocom.org/12382 )
Change subject: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12382/1
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12447
Change subject: Constify trans_assign_trans_id() parameters
..
Constify trans_assign_trans_id() parameters
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/10185/8/src
Max has posted comments on this change. ( https://gerrit.osmocom.org/10189 )
Change subject: port rest octets encoding code from osmo-bsc
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/10189/6/src
Max has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc
..
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/#/c/10185/8/src/gsm
Max has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc
..
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/#/c/10185/8/include/osmocom/gsm
Max has posted comments on this change. ( https://gerrit.osmocom.org/10189 )
Change subject: port rest octets encoding code from osmo-bsc
..
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/10189/6/include/osmocom/gprs
Max has posted comments on this change. ( https://gerrit.osmocom.org/11720 )
Change subject: Automatically disable GnuTLS fallback
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/11720
Max has posted comments on this change. ( https://gerrit.osmocom.org/11720 )
Change subject: Automatically disable GnuTLS fallback
..
Patch Set 9:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/11719 )
Change subject: Streamline glibc version check
..
Patch Set 9:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/11719
Max has posted comments on this change. ( https://gerrit.osmocom.org/12224 )
Change subject: Use libosmocore constant for IMSI length in ACL entry
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/12224/2/include
Max has posted comments on this change. ( https://gerrit.osmocom.org/12377 )
Change subject: LCLS: don't send invalid status in HO messages
..
Patch Set 5:
> lcls_bss_status_present is a field in a public structure, so i
Max has posted comments on this change. ( https://gerrit.osmocom.org/5629 )
Change subject: BSSGP: use monotonic clock
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/5629
Max has posted comments on this change. ( https://gerrit.osmocom.org/5631 )
Change subject: Remove unused timeval parameters
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/5631
Max has posted comments on this change. ( https://gerrit.osmocom.org/5103 )
Change subject: Add function to estimate elapsed time
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/5104 )
Change subject: NS: use monotonic clock
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/5104
Max has abandoned this change. ( https://gerrit.osmocom.org/3750 )
Change subject: abis: fix unaligned memory access
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3750
To unsubscribe, or for help writing mail
Max has posted comments on this change. ( https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12318
Max has posted comments on this change. ( https://gerrit.osmocom.org/12316 )
Change subject: ctrl: separate config structure
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12316
Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c
File
Max has posted comments on this change. ( https://gerrit.osmocom.org/12377 )
Change subject: LCLS: don't send invalid status in HO messages
..
Patch Set 5:
> provide information on when was this API added
Which API are
Max has posted comments on this change. ( https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 2:
Just a cosmetic addition to make sure that format and the MI-type are coherent
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12421 )
Change subject: ctrl2cgi: explicitly ignore unrelated TRAPs
..
ctrl2cgi: explicitly ignore unrelated TRAPs
Previously we've tried
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12271 )
Change subject: tests/gsm0808: use new msgb comparison API
..
tests/gsm0808: use new msgb comparison API
Since
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12423
Change subject: ctrl2cgi: update comments
..
ctrl2cgi: update comments
* remove obsolete comments
* add missing function comments
Change-Id
: I42b715cb82eb309950ff387649726504b6c7cf61
Gerrit-Change-Number: 12421
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12421
Change subject: ctrl2cgi: explicitly ignore unrelated TRAPs
..
ctrl2cgi: explicitly ignore unrelated TRAPs
Previously we've tried to determine
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12412 )
Change subject: ctrl2cgi: account wait and http times separately
..
ctrl2cgi: account wait and http times separately
Save and propagate
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12412
Change subject: ctrl2cgi: account wait and http times separately
..
ctrl2cgi: account wait and http times separately
Save and propagate separate
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: tests/gsm0808: use new msgb comparison API
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12271
Max has posted comments on this change. ( https://gerrit.osmocom.org/12364 )
Change subject: fix ipa_asp_fsm down state transition
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12364
Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12243
Max has posted comments on this change. ( https://gerrit.osmocom.org/12297 )
Change subject: mgw: Tear down all RTP flows to avoid race condition on tear
down
..
Patch Set 1:
(1 comment)
Maybe move it to separate func
Max has posted comments on this change. ( https://gerrit.osmocom.org/12316 )
Change subject: ctrl: separate config structure
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12316
Max has posted comments on this change. ( https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12318
Max has abandoned this change. ( https://gerrit.osmocom.org/12317 )
Change subject: ctrl: pass config struct to all simple_ctrl_*()
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12317
To unsubscribe, or for help
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12393
Change subject: Move shared libs into common LDADD
..
Move shared libs into common LDADD
Change-Id: I8b2f2cd60426cf3b52dd463959a48fd7619cfcce
---
M
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12392
Change subject: utils: drop redundant _SOURCES entries
..
utils: drop redundant _SOURCES entries
Automake use the .c file corresponding to the program
Max has posted comments on this change. ( https://gerrit.osmocom.org/12364 )
Change subject: fix ipa_asp_fsm down state transition
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c
File src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12366 )
Change subject: LCLS: log config/control update
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12366
To unsubscribe
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12366 )
Change subject: LCLS: log config/control update
..
LCLS: log config/control update
Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
Max has posted comments on this change. ( https://gerrit.osmocom.org/12364 )
Change subject: fix ipa_asp_fsm down state transition
..
Patch Set 1: Code-Review-1
(3 comments)
Being unfamiliar with the code helps to highlight
Max has posted comments on this change. ( https://gerrit.osmocom.org/12377 )
Change subject: LCLS: don't send invalid status in HO messages
..
Patch Set 4:
This change is ready for review.
--
To view, visit https
, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer
Max has posted comments on this change. ( https://gerrit.osmocom.org/12369 )
Change subject: LCLS: don't send invalid status in HO messages
..
Patch Set 6:
Ok, I've split API-change into separate patch from behavior fix
Max has posted comments on this change. ( https://gerrit.osmocom.org/11918 )
Change subject: libmsc/VTY: introduce kill-switch for routing SMS over GSUP
..
Patch Set 8: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12357 )
Change subject: mgcp_client: make domain part of endpoint configurable
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12357/3/src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12371 )
Change subject: LCLS: enc/dec entire parameter set instead of GCR
..
Patch Set 5:
This change is ready for review.
--
To view, visit https
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12372 )
Change subject: TLV: fix doc copy-paste error
..
TLV: fix doc copy-paste error
Change-Id: I8aa79cab7505585de00ee2aaae125462108906e8
---
M
Max has posted comments on this change. ( https://gerrit.osmocom.org/12373 )
Change subject: TLV: add convenience function for 1-byte values
..
Patch Set 3: Code-Review+2
> Patch Set 2: Code-Review-1
>
> (1 commen
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12373 )
Change subject: TLV: add convenience function for 1-byte values
..
TLV: add convenience function for 1-byte values
Similar to existing 16
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12381 )
Change subject: Use define for key buffers
..
Use define for key buffers
Add corresponding spec. references and comments where appropriate
-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0a148bd04b8860e321f509fdcd913f688c8e920
Gerrit-Change-Number: 12373
Gerrit-PatchSet: 3
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12381
Change subject: Use define for key buffers
..
Use define for key buffers
Add corresponding spec. references and comments where appropriate.
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12369 )
Change subject: LCLS: don't send invalid status in HO messages
..
Patch Set 4:
This change is ready for review.
--
To view, visit https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12378
Change subject: LCLS: use enum values instead of magic numbers
..
LCLS: use enum values instead of magic numbers
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12379
Change subject: LCLS: use Status for HO-COMPLETE message
..
LCLS: use Status for HO-COMPLETE message
This requires
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12377
Change subject: LCLS: drop boolean status_present from HO structs
..
LCLS: drop boolean status_present from HO structs
The validity of lcls_bss_status
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12375
Change subject: LCLS: don't encode incorrect values
..
LCLS: don't encode incorrect values
Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
---
M
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12376
Change subject: LCLS: fix LCLS-CONNECT-CONTROL encoder
..
LCLS: fix LCLS-CONNECT-CONTROL encoder
Previously it could encode both incorrect values
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12370 )
Change subject: LCLC: fix doc to match type signature
..
LCLC: fix doc to match type signature
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12373
Change subject: TLV: add convenience function for 1-byte values
..
TLV: add convenience function for 1-byte values
Similar to existing 16 and 32 bit
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12371
Change subject: LCLS: enc/dec entire parameter set instead of GCR
..
LCLS: enc/dec entire parameter set instead of GCR
In 3GPP TS 48.008 the Global
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12372
Change subject: TLV: fix doc copy-paste error
..
TLV: fix doc copy-paste error
Change-Id: I8aa79cab7505585de00ee2aaae125462108906e8
---
M include
Max has posted comments on this change. ( https://gerrit.osmocom.org/12369 )
Change subject: LCLS: don't send invalid status in HO messages
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12369/1/include/osmocom
Max has posted comments on this change. ( https://gerrit.osmocom.org/12354 )
Change subject: mgcp_client: drop a bunch of dead code
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12354
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12370
Change subject: LCLC: fix doc to match type signature
..
LCLC: fix doc to match type signature
Change-Id: I8f7b3dca080ef0e632d47a907154f8404b0ec523
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12369
Change subject: LCLS: don't send invalid status in HO messages
..
LCLS: don't send invalid status in HO messages
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12365
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12367
Change subject: LCLS: use proper types for value_string wrappers
..
LCLS: use proper types for value_string wrappers
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12366
Change subject: LCLS: log config/control update
..
LCLS: log config/control update
Change-Id: Iac493014144ca0e5e1a83081e6e01ea7910deac2
---
M src/osmo
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12365
Change subject: Log MI type on request failure
..
Log MI type on request failure
Change-Id: I842a7471ea19a2c13ca1134c56991c0ed63cfb29
---
M src/libmsc
Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: Use msgb helper instead of local #define for debug print
..
Patch Set 2:
> Patch Set 2: Code-Review-1
> I can update this
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12363 )
Change subject: Fix typos in SS opcode names
..
Fix typos in SS opcode names
Change-Id: I8fa1961c85b3fd714bc8df56fe4af6be4060c208
---
M src
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12363
Change subject: Fix typos in SS opcode names
..
Fix typos in SS opcode names
Change-Id: I8fa1961c85b3fd714bc8df56fe4af6be4060c208
---
M src/gsm
Max has posted comments on this change. ( https://gerrit.osmocom.org/12357 )
Change subject: mgcp_client: make domain part of endpoint configurable
..
Patch Set 1: Code-Review-1
(1 comment)
Please clarify.
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12354 )
Change subject: mgcp_client: drop a bunch of dead code
..
Patch Set 1: Code-Review-1
Since you're breaking API please update TODO-RELEASE to make
Max has posted comments on this change. ( https://gerrit.osmocom.org/12349 )
Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE
..
Patch Set 3: Code-Review+1
--
To view, visit https
Gerrit-Change-Id: I5c44d7bb28f1ff895dd4f839d75840495503c916
Gerrit-Change-Number: 12329
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Stefan Sperling
Gerrit
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12338 )
Change subject: Remove redundancy in LAC processing
..
Remove redundancy in LAC processing
Always use LAC which is part of Cell Global ID
Max has posted comments on this change. ( https://gerrit.osmocom.org/12338 )
Change subject: Remove redundancy in LAC processing
..
Patch Set 4:
This already got 2 +1 before, new revision just fixes trivial merge conflict
Max has posted comments on this change. ( https://gerrit.osmocom.org/12338 )
Change subject: Remove redundancy in LAC processing
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12338
To unsubscribe
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I993ebc3e14f25e83124b6d3f8461a4b18f971f8e
Gerrit-Change-Number: 12338
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12349 )
Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE
..
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12350 )
Change subject: host/layer23: don't init SAP interface by default
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12350
Max has posted comments on this change. ( https://gerrit.osmocom.org/12360 )
Change subject: mgcp log tweak: say RAN, not BTS, like surrounding logging
..
Patch Set 1: Code-Review+2
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12346 )
Change subject: wait for subscriber conn in
TC_cipher_complete_with_invalid_cipher
..
Patch Set 1: Code-Review+1
Did some tests fail because
Max has posted comments on this change. ( https://gerrit.osmocom.org/12351 )
Change subject: host/layer23/sap_interface.c: cosmetic: use ARRAY_SIZE()
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12243
Max has posted comments on this change. ( https://gerrit.osmocom.org/12353 )
Change subject: use vty->type instead of local variable
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12
Max has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct
..
Patch Set 2:
> Then please state so in the commit description. Until I see a u
Max has posted comments on this change. ( https://gerrit.osmocom.org/12352 )
Change subject: Store GSN address in libosmocore struct
..
Patch Set 2:
> You are breaking the ABI
That's not a library - what kind of ABI break
Max has posted comments on this change. ( https://gerrit.osmocom.org/12298 )
Change subject: MSC: adjust gsup log level to error
..
Patch Set 1:
> Patch Set 1: Code-Review+1
> Simply changing the log level of this m
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12335 )
Change subject: VLR: drop unused struct members
..
VLR: drop unused struct members
Change-Id: I322072653b41cf250aa2c1e346e00bae884feb84
Max has posted comments on this change. ( https://gerrit.osmocom.org/12335 )
Change subject: VLR: drop unused struct members
..
Patch Set 3: Code-Review+2
Since there're 2 votes for it already, let's merge this and nuke entire
Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12243/3/src/gprs
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11820 )
Change subject: LCLS: update parameter representation
..
LCLS: update parameter representation
* use osmo_lcls struct from libosmocore
* use
Max has posted comments on this change. ( https://gerrit.osmocom.org/11820 )
Change subject: LCLS: update parameter representation
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/11820
://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
801 - 900 of 3542 matches
Mail list logo
