Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Move common Trap-related code into separate file The ctrl2cgi.py is heavi

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: Code-Review+2 Ah sorry I thought the trap_helper.py was

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: We might want to bump the .deb version to match the python one - not

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-27 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: > Did you try actually the script can be imported if installed in /us

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 3: > > is it installed in a correct place so that it can b

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11936 To unsubs

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11936 ) Change subject: Move common Trap-related code into separate file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in python/osmo-python-tests[master]: Move common Trap-related code into separate file

2018-11-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11936 Change subject: Move common Trap-related code into separate file .. Move common Trap-related code into separate file The ctrl2cgi.py is heavily based u