Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmux: Check batch_factor overflow in osmux_batch_enqueue
..
osmux: Check batch_factor overflow in osmux_batch_enqueue
This commit should fix a bug p
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2403
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d643810949aeca4762f0cad05eed534d35087f7
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
G
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2403
to look at the new patch set (#2).
osmux: Check batch_factor overflow in osmux_batch_enqueue
This commit should fix a bug present if for instance batch_factor < 8
and osmux_batch_enqueu
Patch Set 1:
I don't see how your answer is related to my question. Could you be more
specific?
--
To view, visit https://gerrit.osmocom.org/2403
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d643810949aeca4762f0cad05eed534d35087f7
G
Patch Set 1:
While preparing other tests I am adding to osmux + rtp marker support I saw
that if this patch is missing, the situation seems to be even worse than I
expected. I cannot for instance set h_input.batch_actor=4 and try to push more
than 8 consecutive packets to 4 ccids, it will segf
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2403/1/src/osmux.c
File src/osmux.c:
Line 210: int batch_factor)
Can batch_factor really be negative? If not, than why not use unsigned type to
make it obvious?
--
To view, visit https://gerrit.osmocom.org
Review at https://gerrit.osmocom.org/2403
osmux: Check batch_factor overflow in osmux_batch_enqueue
This commit should fix a bug present if for instance batch_factor < 8
and osmux_batch_enqueue is called from osmux_replay_lost_packets and
enough packets were lost from last received packet.
Cha
