Max has submitted this change and it was merged.
Change subject: Add doxygen docs
..
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
Change-Id: I2bf7438bcdde19dc
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4234
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bf7438bcdde19dc88b9bc14c8ad9c8f49099f8a
Gerrit-PatchSet: 5
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Ge
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4234
to look at the new patch set (#5).
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
Change-
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4234
to look at the new patch set (#4).
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
Change-
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4234
to look at the new patch set (#3).
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
Change-
Patch Set 2:
@Max: The point of Neels is that he wants *The same* setup for all osmocom
(cellular communications) git repositories. Not for all libraries or all
applications, but for *all*. I agree with the latter, as it is very confusing
otherwise.
Also, as the project evolves, it could ver
Patch Set 2:
> currently that is mostly doc/examples, right?
Wrong: it's mostly neither. Moreover, I don't know any other library in Osmocom
with doc/examples.
> some wiki pages etc may point to examples by git.osmocom.org/ URLs
Which wiki? Let me know the URL and I'll fix it.
> for some rep
Patch Set 2: -Code-Review
> No, only for repositories where:
> - we need to add doxygen docs
> - doc/examples are used
> - such move would not cause any complications (.deb packaging does
> not rely on it etc)
My intention is to generally have matching structures in all of our git
repositor
Patch Set 2:
> What is the direction then, will we move all other repositories' doc/examples
> to examples/ to follow the same structure everywhere?
No, only for repositories where:
- we need to add doxygen docs
- doc/examples are used
- such move would not cause any complications (.deb packagi
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4234/2//COMMIT_MSG
Commit Message:
Line 18: same structure and simplifies further maintenance.
what about the same structure across git repositories to keep examples in
doc/examples? What's the intention / a reply to my earl
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4234
to look at the new patch set (#2).
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
To avoi
Patch Set 1:
> The makefile snippet to use doxygen is taken from libosmo-netif. It
> assumes empty doc/ which is cleared on every invocation.
ok, I understand now; would be great to mention this in the commit log instead
of just "to avoid complicating". What is the direction then, will we move
Patch Set 1:
The makefile snippet to use doxygen is taken from libosmo-netif. It assumes
empty doc/ which is cleared on every invocation. In case of libosmo-netif
examples are in the separate directory. So ether we have to move examples or
change the Makefile.am. I prefer the former as it make
Patch Set 1: Code-Review-1
> doxygen simply ignores example configs.
Please clarify, why exactly are you moving the example file around? What
happens if you don't, and are there alternatives to moving?
--
To view, visit https://gerrit.osmocom.org/4234
To unsubscribe, visit https://gerrit.osmo
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4234
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bf7438bcdde19dc88b9bc14c8ad9c8f49099f8a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Ge
Patch Set 1:
> if we could instead tell doxygen where to find the example
What do you mean? I thought doxygen simply ignores example configs.
--
To view, visit https://gerrit.osmocom.org/4234
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-I
Patch Set 1: Code-Review+1
(1 comment)
looks good, except...
https://gerrit.osmocom.org/#/c/4234/1//COMMIT_MSG
Commit Message:
Line 13: config was moved to separate directory.
we have the doc/examples path elements in place in most other osmocom.git, and
I'd prefer if we could instead tell do
Review at https://gerrit.osmocom.org/4234
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
To avoid complicating doxygen setup compared to other libraries example
config was moved to separate directory.
Change-Id: I2bf7438bcdde19
18 matches
Mail list logo
