Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Fix warnings: tolower() and similar require uchar
..
Fix warnings: tolower() and similar require uchar
utils.c: In function 'osmo_str2lower':
utils.c
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2963
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fed2ab6a4efba9f8a21fcf84a5b3a91e8df084f
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Hello Max, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2963
to look at the new patch set (#2).
Fix warnings: tolower() and similar require uchar
utils.c: In function 'osmo_str2lower':
utils.c:277:3: warning: array subscript h
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2963/1/src/logging.c
File src/logging.c:
Line 850: name[j] = tolower((unsigned char)
info->cat[i].name[j]);
(usually no space in-between cast and casted value, in several places)
--
To view,
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2963
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fed2ab6a4efba9f8a21fcf84a5b3a91e8df084f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/2963
Fix warnings: tolower() and similar require uchar
utils.c: In function 'osmo_str2lower':
utils.c:277:3: warning: array subscript has type 'char' [-Wchar-subscripts]
out[i] = tolower(in[i]);
And according to man:
If c is neither an unsigned char
